René's URL Explorer Experiment


Title: chore(doctor): replace grunt with npm scripts and build to dist by edusperoni · Pull Request #6093 · NativeScript/nativescript-cli · GitHub

Open Graph Title: chore(doctor): replace grunt with npm scripts and build to dist by edusperoni · Pull Request #6093 · NativeScript/nativescript-cli

X Title: chore(doctor): replace grunt with npm scripts and build to dist by edusperoni · Pull Request #6093 · NativeScript/nativescript-cli

Description: PR Checklist The PR title follows our guidelines. There is an issue for the bug/feature this PR is for. (no tracking issue — happy to open one) You have signed the CLA. All existing tests are passing (82 passing, unchanged). Tests for the changes are included. (build change; verified by packing, installing and calling the package — see below) Companion to #6092, which does the same for the root package. packages/nativescript-envinfo already had this shape and is untouched. What is the current behavior? packages/doctor is still on Grunt, and npm install in it fails outright: grunt-tslint@5.0.2 peer-requires tslint@^5 against the tslint@6.1.3 devDependency. That was papered over in 2022 by committing a .npmrc containing legacy-peer-deps=true (356630a88). tsc also emits next to the sources — main is src/index.js — so source and output share a directory, with the same consequences #6092 describes. What is the new behavior? Grunt is gone; output goes to dist/ with declarations. Grunt task Replacement ts:devsrc (default, build) tsc → dist/ ts:devall (build.all) tsc -p tsconfig.test.json + scripts/copy-test-fixtures.js → dist-test/ ts:release_build tsc -p tsconfig.release.json clean scripts/clean.js watch:* tsc --watch pack (prepack) clean.build && npm test && tsc -p tsconfig.release.json tslint:build (lint) dropped lint was load-bearing in name only: it currently fails with 6 errors, is wired into nothing (not build, test, prepack or CI), and tslint is deprecated — the repo lints via the root prettier/lint-staged hook. Dropping it is what removes the peer conflict, so the committed .npmrc goes too. The release workflow writes its own .npmrc with the auth token after npm pack, so it is unaffected. istanbul dropped: coverage ran but nothing consumed it — no CI step, no coverage service config, no thresholds, coverage/ gitignored. The release compile now runs after the tests rather than before, the same ordering fix #6088 made at the root. types deliberately still points at the hand-written typings types remains ./typings/nativescript-doctor.d.ts, and generated declarations do not replace it. That file is not a normal module .d.ts — it is an ambient declare module "@nativescript/doctor" whose /// reference pulls in typings/interfaces.ts, declaring the global NativeScriptDoctor namespace. The CLI depends on that global in roughly 15 places with no import of the package at all (lib/declarations.d.ts, lib/common/doctor.d.ts, lib/common/declarations.d.ts, lib/services/doctor-service.ts, lib/sys-info.ts). Repointing types at dist/index.d.ts would silently delete the global and break the CLI's own typecheck. Generated .d.ts are still emitted and shipped alongside, so deep imports get types they never had. One rename: typings/interfaces.ts → typings/interfaces.d.ts. It contains only ambient declarations, so as a .ts it emitted a pointless empty JS file — and, more importantly, counted as a non-declaration input, dragging tsc's inferred rootDir up to the package root and producing dist/src/.... That would have broken path.join(__dirname, "..", "resources", ...) in sys-info.ts, since dist/src/../resources is not /resources. Grunt was never applying the repo's compiler options Worth knowing, because it explains the small source changes here. Gruntfile.js did options: grunt.file.readJSON("tsconfig.json").compilerOptions, and readJSON does not resolve extends. Grunt therefore passed only { skipLibCheck: true } and compiled with grunt-ts defaults, ignoring target, noImplicitAny, noUnusedLocals and isolatedModules from the root config. Running real tsc surfaced pre-existing dead code, removed here: src/android-tools-info.ts — getMaxSupportedCompileVersion, a private method with no callers anywhere in the repo src/doctor.ts — an unused private helpers constructor parameter, plus its import and the argument at the single call site. Doctor is not reachable from the package's public exports, so this is not an API change test/sys-info.ts — spawnFromEventCommand (written, never read) and an implicit-any[] return; test/wrappers/file-system.ts — an unused rimraf import Published output moves from ES5 to ES2018 as a consequence of the tsconfig now actually applying. That matches the root package and nativescript-envinfo, and the package declares no engines, but it is a genuine change to the shipped artifact and worth a reviewer's attention. Verification npm install succeeds with no .npmrc and no --legacy-peer-deps (521 → 197 packages) 82 passing before, 82 passing after npm pack → 32 files; main (dist/index.js), types (typings/nativescript-doctor.d.ts) and its referenced typings/interfaces.d.ts, and resources/cocoapods-verification/cocoapods.zip all present; no .js.map Full CI sequence from a wiped node_modules (npm install then npm pack) passes end to end Tarball installed into a scratch directory and exercised: module loads, all five exports present, cocoapods.zip resolves from the installed dist/, and live calls work (getNodeVersion(), getGitVersion(), doctor.getWarnings()) A consumer typecheck against the packed tarball compiles clean, importing all five exports and using NativeScriptDoctor.ISysInfoConfig / .ISysInfoData / .IInfo / .IWarning bare Summary by CodeRabbit New Features Added comprehensive TypeScript declarations for NativeScript Doctor APIs and diagnostic data. Published compiled JavaScript and type declaration files from the distribution build. Improvements Updated Android diagnostics to account for the configured runtime version. Simplified build, test, cleanup, and packaging workflows. Bug Fixes Corrected TypeScript type-definition references for improved integration.

Open Graph Description: PR Checklist The PR title follows our guidelines. There is an issue for the bug/feature this PR is for. (no tracking issue — happy to open one) You have signed the CLA. All existing tests are ...

X Description: PR Checklist The PR title follows our guidelines. There is an issue for the bug/feature this PR is for. (no tracking issue — happy to open one) You have signed the CLA. All existing tests are ...

Opengraph URL: https://github.com/NativeScript/nativescript-cli/pull/6093

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:201ffea4-e291-66e7-04cf-e504155b8075
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD2C:1F68:52BFA4:732035:6B01C304
html-safe-nonced1908985b3829aadf98498b22aea22a28b9763f70ad122f226c18b7836075373
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDJDOjFGNjg6NTJCRkE0OjczMjAzNTo2QjAxQzMwNCIsInZpc2l0b3JfaWQiOiI4MDA3OTY2ODgxNjY5NTYzMTQwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfd5b2c11fc9b15774347ffdf8e2ef17edfc763c6327163f3d87bc68961902577
hovercard-subject-tagpull_request:4154954344
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/nativescript-cli/pull/6093/files
twitter:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
og:image:altPR Checklist The PR title follows our guidelines. There is an issue for the bug/feature this PR is for. (no tracking issue — happy to open one) You have signed the CLA. All existing tests are ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/nativescript-cli git https://github.com/NativeScript/nativescript-cli.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id21347346
octolytics-dimension-repository_nwoNativeScript/nativescript-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21347346
octolytics-dimension-repository_network_root_nwoNativeScript/nativescript-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/nativescript-cli/pull/6093/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F6093%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F6093%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fnativescript-cli
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/6093/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/6093/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/6093/files
NativeScripthttps://github.com/NativeScript
nativescript-clihttps://github.com/NativeScript/nativescript-cli
Codehttps://github.com/NativeScript/nativescript-cli
Issues357 (357)https://github.com/NativeScript/nativescript-cli/issues
Pull requests38 (38)https://github.com/NativeScript/nativescript-cli/pulls
Actionshttps://github.com/NativeScript/nativescript-cli/actions
Projectshttps://github.com/NativeScript/nativescript-cli/projects
Security and qualityhttps://github.com/NativeScript/nativescript-cli/security
Insightshttps://github.com/NativeScript/nativescript-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
NathanWalkerhttps://github.com/NathanWalker
NativeScript:mainhttps://github.com/NativeScript/nativescript-cli/tree/main
edusperoni:chore/doctor-build-to-disthttps://github.com/edusperoni/nativescript-cli/tree/chore/doctor-build-to-dist
Conversation 7 https://github.com/NativeScript/nativescript-cli/pull/6093
Commits 1 https://github.com/NativeScript/nativescript-cli/pull/6093/commits
Checks 6 https://github.com/NativeScript/nativescript-cli/pull/6093/checks
Files changed https://github.com/NativeScript/nativescript-cli/pull/6093/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/6093/files
chore(doctor): replace grunt with npm scripts and build to dist https://github.com/NativeScript/nativescript-cli/pull/6093/files#top
Show all changes 1 commit https://github.com/NativeScript/nativescript-cli/pull/6093/files
b7bdc72 chore(doctor): replace grunt with npm scripts and build to dist edusperoni Jul 28, 2026 https://github.com/NativeScript/nativescript-cli/pull/6093/commits/b7bdc7256c53978e56b335af0ac93ad4ff56f2a4
Clear filters https://github.com/NativeScript/nativescript-cli/pull/6093/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/6093/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/6093/files
.gitignore https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-7e41ca7fef3d0507e4ad99007673d03a4a47959e7fc75be83a5fec9d502b702e
.npmrc https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-030da5196ca883c1c6374733c3a63a42c7e02711753a30cf1a4f695f33e40026
Gruntfile.js https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-f6ca62b623bc50a3c15edf86b34d2511f65134bb6579274dcf0308ab37cd60cb
package.json https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-70ce829cb4fba59d9c62c3c4e109a7f66ee43d883deb9a8818d1d5503970dfa6
clean.js https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-997ef284a0a9e0d17ea41202cfa41481cf58c98a26159a526eddf1fff242d13f
copy-test-fixtures.js https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-37ddb570ab6823fd363002c29d70e9577a5bae89e9c89ac582fe289212f030dd
android-tools-info.ts https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-a106f8564e4daaf5e9dc068271ac169aa7f763f57ca28306bcb9d8113524459e
doctor.ts https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-f80b74d8229de03dabdce5076756909ff0a1f2c67233b24582a2b08566537142
index.ts https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-a35c7452d7ca72d653e546323d0bd92bc22350d325ab08de4acf5c0b184c1ca9
sys-info.ts https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-b6d44d840134ded1c69f97272735df46356f3c7c7a8c5119d3bc85b5c9c19eee
file-system.ts https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-6fb72e5005acff97134e4f7ea1742be566c427f9de57ec2ee8546fcc3869242c
tsconfig.json https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-1a9e3dab62e8747a5f8d1fd8765c208d777e26442ead506d52ce4ab23b728b31
tsconfig.release.json https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-8d286b89a1ad01e8e4d24175987680d6d5d03775ac0503b3a2a5e695cea88a70
tsconfig.test.json https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-5d0e974aad09a4a0101e718d5224e7c7ff11ebf753cb2830db80b467e5a27ab9
tslint.json https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-0b7e7cef32661fc6c4162fbe34b10ff29bb3fb72eaea1f1fec46f97bb61cea2d
interfaces.d.ts https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-53b87607cffd3a7da9ebcda703c7f9f8015faa0754cb09a90ef3d6a4bc3dda5d
nativescript-doctor.d.ts https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-1a7bd238d09cf762b1350b95f73ad2630fd5af60bcca359031fbccf03517e32c
packages/doctor/.gitignorehttps://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-7e41ca7fef3d0507e4ad99007673d03a4a47959e7fc75be83a5fec9d502b702e
View file https://github.com/edusperoni/nativescript-cli/blob/b7bdc7256c53978e56b335af0ac93ad4ff56f2a4/packages/doctor/.gitignore
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/6093/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-7e41ca7fef3d0507e4ad99007673d03a4a47959e7fc75be83a5fec9d502b702e
https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-7e41ca7fef3d0507e4ad99007673d03a4a47959e7fc75be83a5fec9d502b702e
https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-7e41ca7fef3d0507e4ad99007673d03a4a47959e7fc75be83a5fec9d502b702e
packages/doctor/.npmrchttps://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-030da5196ca883c1c6374733c3a63a42c7e02711753a30cf1a4f695f33e40026
View file https://github.com/NativeScript/nativescript-cli/blob/513415a513476552e0810ce14655f5abc3c76e7e/packages/doctor/.npmrc
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/6093/files
packages/doctor/Gruntfile.jshttps://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-f6ca62b623bc50a3c15edf86b34d2511f65134bb6579274dcf0308ab37cd60cb
View file https://github.com/NativeScript/nativescript-cli/blob/513415a513476552e0810ce14655f5abc3c76e7e/packages/doctor/Gruntfile.js
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/6093/files
packages/doctor/package.jsonhttps://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-70ce829cb4fba59d9c62c3c4e109a7f66ee43d883deb9a8818d1d5503970dfa6
View file https://github.com/edusperoni/nativescript-cli/blob/b7bdc7256c53978e56b335af0ac93ad4ff56f2a4/packages/doctor/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/6093/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-70ce829cb4fba59d9c62c3c4e109a7f66ee43d883deb9a8818d1d5503970dfa6
https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-70ce829cb4fba59d9c62c3c4e109a7f66ee43d883deb9a8818d1d5503970dfa6
https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-70ce829cb4fba59d9c62c3c4e109a7f66ee43d883deb9a8818d1d5503970dfa6
https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-70ce829cb4fba59d9c62c3c4e109a7f66ee43d883deb9a8818d1d5503970dfa6
packages/doctor/scripts/clean.jshttps://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-997ef284a0a9e0d17ea41202cfa41481cf58c98a26159a526eddf1fff242d13f
View file https://github.com/edusperoni/nativescript-cli/blob/b7bdc7256c53978e56b335af0ac93ad4ff56f2a4/packages/doctor/scripts/clean.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/6093/{{ revealButtonHref }}
packages/doctor/scripts/copy-test-fixtures.jshttps://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-37ddb570ab6823fd363002c29d70e9577a5bae89e9c89ac582fe289212f030dd
View file https://github.com/edusperoni/nativescript-cli/blob/b7bdc7256c53978e56b335af0ac93ad4ff56f2a4/packages/doctor/scripts/copy-test-fixtures.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/6093/{{ revealButtonHref }}
packages/doctor/src/android-tools-info.tshttps://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-a106f8564e4daaf5e9dc068271ac169aa7f763f57ca28306bcb9d8113524459e
View file https://github.com/edusperoni/nativescript-cli/blob/b7bdc7256c53978e56b335af0ac93ad4ff56f2a4/packages/doctor/src/android-tools-info.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/6093/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/6093/files#diff-a106f8564e4daaf5e9dc068271ac169aa7f763f57ca28306bcb9d8113524459e
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/6093/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.