René's URL Explorer Experiment


Title: fix(ios): let the app's xcconfig win over a plugin's, and warn on discarded settings by edusperoni · Pull Request #6091 · NativeScript/nativescript-cli · GitHub

Open Graph Title: fix(ios): let the app's xcconfig win over a plugin's, and warn on discarded settings by edusperoni · Pull Request #6091 · NativeScript/nativescript-cli

X Title: fix(ios): let the app's xcconfig win over a plugin's, and warn on discarded settings by edusperoni · Pull Request #6091 · NativeScript/nativescript-cli

Description: An app currently has no way to override a build setting that a plugin declares, and no way to find out that it failed to. The app's xcconfig never wins XcconfigService.mergeFiles keeps whichever value is already in the destination and deletes the incoming one: userConfig.attributes.each do |key,| existingConfig.attributes.delete(key) if (userConfig.attributes.key?(key) && existingConfig.attributes.key?(key)) end userConfig.merge(existingConfig) First writer wins — and mergeProjectXcconfigFiles merged every plugin's platforms/ios/build.xcconfig before the app's App_Resources/iOS/build.xcconfig. So for any key a plugin set, the app's value was discarded outright. Not "sometimes lost": never applied. Among plugins the winner was whichever came first in dependency-resolution order, which nobody controls. This PR merges the app's file first. Plugins still supply every key the app says nothing about; they just stop overriding the ones it does. Where this bites today: V8 14.9 (NativeScript iOS 9) made v8config.h reject C++17 outright — #if __cplusplus <= 201703L #error "C++20 or later required." #endif — while several plugins pin CLANG_CXX_LANGUAGE_STANDARD = c++17, which sat exactly on the old floor. One stale transitive plugin holds the whole app below the floor, and the app cannot lift it. The resulting error points at the runtime's headers rather than at the plugin that pinned the standard. Discarded settings are now reported The merge dropped keys in silence, so a discarded setting was indistinguishable from one that was never written. That's the reason the case above is hard to diagnose: nothing tells you which plugin pinned the value, and the failure surfaces somewhere else entirely. mergeFiles now reports what it dropped: Ignoring CLANG_CXX_LANGUAGE_STANDARD = c++17 from node_modules/some-plugin/platforms/ios/build.xcconfig: already set to c++20 by a higher precedence xcconfig. The app's App_Resources xcconfig wins over any plugin's. Only conflicts whose values genuinely differ are reported — two files agreeing on a key is not worth a warning, and that keeps this quiet on normal projects. Reporting is also fully isolated from the merge: an unparseable result is traced and ignored, never thrown. Compatibility The precedence change is behavioural. An app that sets a key a plugin also sets now gets its own value where it previously got the plugin's. That is the intent, but it can surface a latent misconfiguration — a value set long ago that silently never applied and now does. The new warning makes those visible rather than mysterious. Conflicts between plugins are unchanged: still resolved by dependency order, still arbitrary. xcconfig can't express "highest wins" for an ordered value like a language standard, so warning is the practical ceiling; this PR at least makes them audible. Tests npm test — 1514 passing, 9 pending, 0 failures. Added The app's build.xcconfig wins over a plugin's, which sets CLANG_CXX_LANGUAGE_STANDARD in both an app and a plugin xcconfig and asserts the app's value survives while a plugin-only key still lands. It runs the real xcodeproj merge rather than a stub, so it also covers the modified Ruby. test/xcconfig-service.ts gains a logger registration for the new dependency. Summary by CodeRabbit Bug Fixes Updated iOS xcconfig merging so app App_Resources settings are authoritative over plugin-provided values when conflicts occur. Added warnings for detected xcconfig key conflicts, while continuing to preserve the higher-priority (app) values. Tests Added a merge test covering precedence for conflicting CLANG_CXX_LANGUAGE_STANDARD, ensuring app-pinned values win while unrelated plugin settings (e.g., GCC_C_LANGUAGE_STANDARD) are retained.

Open Graph Description: An app currently has no way to override a build setting that a plugin declares, and no way to find out that it failed to. The app's xcconfig never wins XcconfigService.mergeFiles keeps whicheve...

X Description: An app currently has no way to override a build setting that a plugin declares, and no way to find out that it failed to. The app&#39;s xcconfig never wins XcconfigService.mergeFiles keeps whic...

Opengraph URL: https://github.com/NativeScript/nativescript-cli/pull/6091

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c979ec53-ef21-c7c6-802f-b56b6a172598
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8B20:38C5CF:34CC466:42F4AF9:6B01C1A9
html-safe-nonceda06535eef31e97bf4dbc95d66b75762e76bb850327d9ae3b0114723fb08b00b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjIwOjM4QzVDRjozNENDNDY2OjQyRjRBRjk6NkIwMUMxQTkiLCJ2aXNpdG9yX2lkIjoiMjYxNTA1NjMyOTYyNjIwNjYzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0b5918eb6da6f589c7fcb2e57156b240fe1f8b582a8d5279b46e9a0986ce374d
hovercard-subject-tagpull_request:4154633061
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/nativescript-cli/pull/6091/files
twitter:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
og:image:altAn app currently has no way to override a build setting that a plugin declares, and no way to find out that it failed to. The app's xcconfig never wins XcconfigService.mergeFiles keeps whicheve...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/nativescript-cli git https://github.com/NativeScript/nativescript-cli.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id21347346
octolytics-dimension-repository_nwoNativeScript/nativescript-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21347346
octolytics-dimension-repository_network_root_nwoNativeScript/nativescript-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/nativescript-cli/pull/6091/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F6091%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F6091%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fnativescript-cli
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/6091/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/6091/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/6091/files
NativeScripthttps://github.com/NativeScript
nativescript-clihttps://github.com/NativeScript/nativescript-cli
Codehttps://github.com/NativeScript/nativescript-cli
Issues357 (357)https://github.com/NativeScript/nativescript-cli/issues
Pull requests38 (38)https://github.com/NativeScript/nativescript-cli/pulls
Actionshttps://github.com/NativeScript/nativescript-cli/actions
Projectshttps://github.com/NativeScript/nativescript-cli/projects
Security and qualityhttps://github.com/NativeScript/nativescript-cli/security
Insightshttps://github.com/NativeScript/nativescript-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
NathanWalkerhttps://github.com/NathanWalker
NativeScript:mainhttps://github.com/NativeScript/nativescript-cli/tree/main
edusperoni:fix/xcconfig-app-precedencehttps://github.com/edusperoni/nativescript-cli/tree/fix/xcconfig-app-precedence
Conversation 4 https://github.com/NativeScript/nativescript-cli/pull/6091
Commits 4 https://github.com/NativeScript/nativescript-cli/pull/6091/commits
Checks 6 https://github.com/NativeScript/nativescript-cli/pull/6091/checks
Files changed https://github.com/NativeScript/nativescript-cli/pull/6091/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/6091/files
fix(ios): let the app's xcconfig win over a plugin's, and warn on discarded settings https://github.com/NativeScript/nativescript-cli/pull/6091/files#top
Show all changes 4 commits https://github.com/NativeScript/nativescript-cli/pull/6091/files
e8296ed fix(ios): let the app's xcconfig win over a plugin's edusperoni Jul 28, 2026 https://github.com/NativeScript/nativescript-cli/pull/6091/commits/e8296ed590633263d172b236e736ad5631a71753
f219cd5 feat(ios): warn when an xcconfig setting is discarded edusperoni Jul 28, 2026 https://github.com/NativeScript/nativescript-cli/pull/6091/commits/f219cd57a84ab1a3042ab88d7dc32ce024880c1a
972f43f Merge branch 'main' into fix/xcconfig-app-precedence NathanWalker Jul 28, 2026 https://github.com/NativeScript/nativescript-cli/pull/6091/commits/972f43f55e8c3f3e5ffcbf7df710fc730ddece8a
8b839a2 fix(ios): pass xcconfig paths to ruby as argv edusperoni Jul 28, 2026 https://github.com/NativeScript/nativescript-cli/pull/6091/commits/8b839a2620906be93a54a7c5e5d5417781175876
Clear filters https://github.com/NativeScript/nativescript-cli/pull/6091/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/6091/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/6091/files
ios-project-service.ts https://github.com/NativeScript/nativescript-cli/pull/6091/files#diff-f7622a4b889e37ebc0eba2bf40ac06b97262f18f3e2bb9b71375a083af8a3259
xcconfig-service.ts https://github.com/NativeScript/nativescript-cli/pull/6091/files#diff-639e7fcd442f4fb8bf151d84aba3baca22c1ec091f2f9e829adfa82af88e54b1
ios-project-service.ts https://github.com/NativeScript/nativescript-cli/pull/6091/files#diff-a5edc6541d103b52c9672665221f3d6c5834b85f8da71456c709c79c2b0e47e1
xcconfig-service.ts https://github.com/NativeScript/nativescript-cli/pull/6091/files#diff-57465ed7f6c86ffd40a61b8ac6ae910daefff7ef521973c82800f2b946d644c1
lib/services/ios-project-service.tshttps://github.com/NativeScript/nativescript-cli/pull/6091/files#diff-f7622a4b889e37ebc0eba2bf40ac06b97262f18f3e2bb9b71375a083af8a3259
View file https://github.com/edusperoni/nativescript-cli/blob/8b839a2620906be93a54a7c5e5d5417781175876/lib/services/ios-project-service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/6091/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/6091/files#diff-f7622a4b889e37ebc0eba2bf40ac06b97262f18f3e2bb9b71375a083af8a3259
https://github.com/NativeScript/nativescript-cli/pull/6091/files#diff-f7622a4b889e37ebc0eba2bf40ac06b97262f18f3e2bb9b71375a083af8a3259
https://github.com/NativeScript/nativescript-cli/pull/6091/files#diff-f7622a4b889e37ebc0eba2bf40ac06b97262f18f3e2bb9b71375a083af8a3259
lib/services/xcconfig-service.tshttps://github.com/NativeScript/nativescript-cli/pull/6091/files#diff-639e7fcd442f4fb8bf151d84aba3baca22c1ec091f2f9e829adfa82af88e54b1
View file https://github.com/edusperoni/nativescript-cli/blob/8b839a2620906be93a54a7c5e5d5417781175876/lib/services/xcconfig-service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/6091/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/6091/files#diff-639e7fcd442f4fb8bf151d84aba3baca22c1ec091f2f9e829adfa82af88e54b1
https://github.com/NativeScript/nativescript-cli/pull/6091/files#diff-639e7fcd442f4fb8bf151d84aba3baca22c1ec091f2f9e829adfa82af88e54b1
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/6091/files
https://github.com/NativeScript/nativescript-cli/pull/6091/files#diff-639e7fcd442f4fb8bf151d84aba3baca22c1ec091f2f9e829adfa82af88e54b1
test/ios-project-service.tshttps://github.com/NativeScript/nativescript-cli/pull/6091/files#diff-a5edc6541d103b52c9672665221f3d6c5834b85f8da71456c709c79c2b0e47e1
View file https://github.com/edusperoni/nativescript-cli/blob/8b839a2620906be93a54a7c5e5d5417781175876/test/ios-project-service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/6091/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/6091/files#diff-a5edc6541d103b52c9672665221f3d6c5834b85f8da71456c709c79c2b0e47e1
https://github.com/NativeScript/nativescript-cli/pull/6091/files#diff-a5edc6541d103b52c9672665221f3d6c5834b85f8da71456c709c79c2b0e47e1
test/xcconfig-service.tshttps://github.com/NativeScript/nativescript-cli/pull/6091/files#diff-57465ed7f6c86ffd40a61b8ac6ae910daefff7ef521973c82800f2b946d644c1
View file https://github.com/edusperoni/nativescript-cli/blob/8b839a2620906be93a54a7c5e5d5417781175876/test/xcconfig-service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/6091/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/6091/files#diff-57465ed7f6c86ffd40a61b8ac6ae910daefff7ef521973c82800f2b946d644c1
https://github.com/NativeScript/nativescript-cli/pull/6091/files#diff-57465ed7f6c86ffd40a61b8ac6ae910daefff7ef521973c82800f2b946d644c1
https://github.com/NativeScript/nativescript-cli/pull/6091/files#diff-57465ed7f6c86ffd40a61b8ac6ae910daefff7ef521973c82800f2b946d644c1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.