Title: feat(doctor): support asdf-managed Ruby in the CocoaPods check by NathanWalker · Pull Request #6086 · NativeScript/nativescript-cli · GitHub
Open Graph Title: feat(doctor): support asdf-managed Ruby in the CocoaPods check by NathanWalker · Pull Request #6086 · NativeScript/nativescript-cli
X Title: feat(doctor): support asdf-managed Ruby in the CocoaPods check by NathanWalker · Pull Request #6086 · NativeScript/nativescript-cli
Description: What is the current behavior? When Ruby is managed by asdf, the ns doctor CocoaPods verification runs in a fresh temp directory that has no .tool-versions. asdf then fails to resolve a Ruby version for that directory, so pod install fails and the check reports a broken environment even on healthy machines. Related: #6061 What is the new behavior? Detect the active Ruby version via asdf current ruby and write it into a .tool-versions file in the temporary CocoaPods project so the check runs with the same Ruby the project uses: The probe uses ignoreError: true, so a missing or misconfigured asdf no longer makes the check throw and report a broken environment. The version is resolved with an explicit cwd (process.cwd()), so it reflects the project even when ns doctor is invoked outside of the project directory. The .tool-versions entry is newline-terminated so it does not merge with existing content. Adds unit tests around asdf-present / asdf-absent behavior in the doctor package. Note: supersedes the approach in #6062, incorporating the review feedback on that PR (explicit cwd, trailing newline, and unit tests). PR Checklist The PR title follows the commit message guidelines. There is an issue for the bug/feature this PR is for (#6061). All existing tests are passing (doctor package: 82 passing). Tests for the changes are included. Summary by CodeRabbit Bug Fixes Improved CocoaPods diagnostics on macOS when Ruby is managed through asdf. CocoaPods checks now continue successfully when asdf is unavailable. Added clearer error reporting when CocoaPods verification fails. Tests Added coverage for Ruby version detection, configuration handling, and missing asdf scenarios.
Open Graph Description: What is the current behavior? When Ruby is managed by asdf, the ns doctor CocoaPods verification runs in a fresh temp directory that has no .tool-versions. asdf then fails to resolve a Ruby version...
X Description: What is the current behavior? When Ruby is managed by asdf, the ns doctor CocoaPods verification runs in a fresh temp directory that has no .tool-versions. asdf then fails to resolve a Ruby version...
Opengraph URL: https://github.com/NativeScript/nativescript-cli/pull/6086
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ca2de9b1-c690-4463-577b-f0fe6d376174 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ED3A:17500B:271FAB:390AF4:6A6368B5 |
| html-safe-nonce | 787d908c546267f5563b061a02960f2b8ec64cc9602439fcf1480979df8b1b50 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDNBOjE3NTAwQjoyNzFGQUI6MzkwQUY0OjZBNjM2OEI1IiwidmlzaXRvcl9pZCI6IjEwMTYzNzY2MDE5MDIwMTY2OTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 34653f4e89c3211407f1e73184a70bbf0876e7699ebda0541e3b395b2a9c5b7f |
| hovercard-subject-tag | pull_request:4119700883 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/nativescript-cli/pull/6086/files |
| twitter:image | https://avatars.githubusercontent.com/u/457187?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/457187?s=400&v=4 |
| og:image:alt | What is the current behavior? When Ruby is managed by asdf, the ns doctor CocoaPods verification runs in a fresh temp directory that has no .tool-versions. asdf then fails to resolve a Ruby version... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 669d3fcd704a169521d2b6431762f95a6878a9e8ccaf0fd5f2d0802fc5b971f9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/NativeScript/nativescript-cli git https://github.com/NativeScript/nativescript-cli.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 21347346 |
| octolytics-dimension-repository_nwo | NativeScript/nativescript-cli |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 21347346 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/nativescript-cli |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 20da292f132ff51328be50073854259f417052c1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width