René's URL Explorer Experiment


Title: Fix assets generation by ivanovit · Pull Request #3638 · NativeScript/nativescript-cli · GitHub

Open Graph Title: Fix assets generation by ivanovit · Pull Request #3638 · NativeScript/nativescript-cli

X Title: Fix assets generation by ivanovit · Pull Request #3638 · NativeScript/nativescript-cli

Description: What is the current behavior? When we don't find an asset in the default image definitions(image-definitions.json) we skip width and height parsing. Then the image generation fails because width and height are undefined. What is the new behavior? Now we set the correct size even we don't find default asset properties. Fixes ProgressNS/sidekick-feedback#199. PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/nativescript-cli/blob/master/CONTRIBUTING.md#contribute-to-the-code-base Tests for the changes are included.

Open Graph Description: What is the current behavior? When we don't find an asset in the default image definitions(image-definitions.json) we skip width and height parsing. Then the image generation fails because widt...

X Description: What is the current behavior? When we don't find an asset in the default image definitions(image-definitions.json) we skip width and height parsing. Then the image generation fails because ...

Opengraph URL: https://github.com/NativeScript/nativescript-cli/pull/3638

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:417e4817-60f2-fcbd-6257-8b8709237938
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA56E:38EE04:91E2D0:C10EA2:6B01B3A7
html-safe-nonce68f4707ad671e297e756eaac1c931a6b584af2847e9f5bedbf191f1df35ba326
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTZFOjM4RUUwNDo5MUUyRDA6QzEwRUEyOjZCMDFCM0E3IiwidmlzaXRvcl9pZCI6IjcwODU1MDQ4NjUzNzU0NjY0MDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6376f8333895b2d5c062ee826d1e5add4891b27724cd3508dd80a91d8846d6a3
hovercard-subject-tagpull_request:191144350
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/nativescript-cli/pull/3638/files
twitter:imagehttps://avatars.githubusercontent.com/u/1859234?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1859234?s=400&v=4
og:image:altWhat is the current behavior? When we don't find an asset in the default image definitions(image-definitions.json) we skip width and height parsing. Then the image generation fails because widt...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/nativescript-cli git https://github.com/NativeScript/nativescript-cli.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id21347346
octolytics-dimension-repository_nwoNativeScript/nativescript-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21347346
octolytics-dimension-repository_network_root_nwoNativeScript/nativescript-cli
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/nativescript-cli/pull/3638/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F3638%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F3638%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fnativescript-cli
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3638/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3638/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3638/files
NativeScripthttps://github.com/NativeScript
nativescript-clihttps://github.com/NativeScript/nativescript-cli
Codehttps://github.com/NativeScript/nativescript-cli
Issues357 (357)https://github.com/NativeScript/nativescript-cli/issues
Pull requests38 (38)https://github.com/NativeScript/nativescript-cli/pulls
Actionshttps://github.com/NativeScript/nativescript-cli/actions
Projectshttps://github.com/NativeScript/nativescript-cli/projects
Security and qualityhttps://github.com/NativeScript/nativescript-cli/security
Insightshttps://github.com/NativeScript/nativescript-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
ivanovithttps://github.com/ivanovit
releasehttps://github.com/NativeScript/nativescript-cli/tree/release
IIIvanov/fix-assets-generation-2https://github.com/NativeScript/nativescript-cli/tree/IIIvanov/fix-assets-generation-2
Conversation 4 https://github.com/NativeScript/nativescript-cli/pull/3638
Commits 1 https://github.com/NativeScript/nativescript-cli/pull/3638/commits
Checks 0 https://github.com/NativeScript/nativescript-cli/pull/3638/checks
Files changed https://github.com/NativeScript/nativescript-cli/pull/3638/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3638/files
Fix assets generation https://github.com/NativeScript/nativescript-cli/pull/3638/files#top
Show all changes 1 commit https://github.com/NativeScript/nativescript-cli/pull/3638/files
91f998c Fix assets generation ivanovit May 29, 2018 https://github.com/NativeScript/nativescript-cli/pull/3638/commits/91f998c4fc09dab7bea21e47a4cf86367bb8c873
Clear filters https://github.com/NativeScript/nativescript-cli/pull/3638/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3638/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3638/files
lib/services/project-data-service.tshttps://github.com/NativeScript/nativescript-cli/pull/3638/files#diff-5870a601dc7862fa0f6996db6ef94b7216256ae5900d6d09254783d67a8fe654
View file https://github.com/NativeScript/nativescript-cli/blob/91f998c4fc09dab7bea21e47a4cf86367bb8c873/lib/services/project-data-service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/3638/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/3638/files#diff-5870a601dc7862fa0f6996db6ef94b7216256ae5900d6d09254783d67a8fe654
https://github.com/NativeScript/nativescript-cli/pull/3638/files#diff-5870a601dc7862fa0f6996db6ef94b7216256ae5900d6d09254783d67a8fe654
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.