René's URL Explorer Experiment


Title: Fix assets generation by ivanovit · Pull Request #3638 · NativeScript/nativescript-cli · GitHub

Open Graph Title: Fix assets generation by ivanovit · Pull Request #3638 · NativeScript/nativescript-cli

X Title: Fix assets generation by ivanovit · Pull Request #3638 · NativeScript/nativescript-cli

Description: NativeScript CLI - command-line tools . Contribute to NativeScript/nativescript-cli development by creating an account on GitHub.

Open Graph Description: What is the current behavior? When we don't find an asset in the default image definitions(image-definitions.json) we skip width and height parsing. Then the image generation fails because widt...

X Description: What is the current behavior? When we don't find an asset in the default image definitions(image-definitions.json) we skip width and height parsing. Then the image generation fails because ...

Opengraph URL: https://github.com/NativeScript/nativescript-cli/pull/3638

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:41e4bb0e-1d4e-3beb-7066-bd8b0800526d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCE76:16AB79:296CEEF:34AD227:6B01A543
html-safe-nonce0d77fe803b3a6ed360bf51bd68f06e7566c9f8aa07293ed013f97f6cbe4d932f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTc2OjE2QUI3OToyOTZDRUVGOjM0QUQyMjc6NkIwMUE1NDMiLCJ2aXNpdG9yX2lkIjoiMjY4ODYwMjg5NDMzNjM2OTk4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2b585671761893130456b671f952e7c4e835c62d1ad5e92827f95418c07714b0
hovercard-subject-tagpull_request:191144350
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/NativeScript/nativescript-cli/3638/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8a5f862fa0d4ebdcacb39b765683bc7af4a23d63428b48cdcea6c7dc38daecb2/NativeScript/nativescript-cli/pull/3638
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8a5f862fa0d4ebdcacb39b765683bc7af4a23d63428b48cdcea6c7dc38daecb2/NativeScript/nativescript-cli/pull/3638
og:image:altWhat is the current behavior? When we don't find an asset in the default image definitions(image-definitions.json) we skip width and height parsing. Then the image generation fails because widt...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameivanovit
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/NativeScript/nativescript-cli git https://github.com/NativeScript/nativescript-cli.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id21347346
octolytics-dimension-repository_nwoNativeScript/nativescript-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21347346
octolytics-dimension-repository_network_root_nwoNativeScript/nativescript-cli
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/NativeScript/nativescript-cli/pull/3638#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F3638
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F3638
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=NativeScript%2Fnativescript-cli
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3638
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3638
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3638
NativeScripthttps://github.com/NativeScript
nativescript-clihttps://github.com/NativeScript/nativescript-cli
Codehttps://github.com/NativeScript/nativescript-cli
Issues357 (357)https://github.com/NativeScript/nativescript-cli/issues
Pull requests38 (38)https://github.com/NativeScript/nativescript-cli/pulls
Actionshttps://github.com/NativeScript/nativescript-cli/actions
Projectshttps://github.com/NativeScript/nativescript-cli/projects
Security and qualityhttps://github.com/NativeScript/nativescript-cli/security
Insightshttps://github.com/NativeScript/nativescript-cli/insights
https://github.com/NativeScript/nativescript-cli
ivanovithttps://github.com/ivanovit
releasehttps://github.com/NativeScript/nativescript-cli/tree/release
IIIvanov/fix-assets-generation-2https://github.com/NativeScript/nativescript-cli/tree/IIIvanov/fix-assets-generation-2
Conversationhttps://github.com/NativeScript/nativescript-cli/pull/3638
Commits1 (1)https://github.com/NativeScript/nativescript-cli/pull/3638/commits
Checkshttps://github.com/NativeScript/nativescript-cli/pull/3638/checks
Files changedhttps://github.com/NativeScript/nativescript-cli/pull/3638/files
Fix assets generationhttps://github.com/NativeScript/nativescript-cli/pull/3638#top
ivanovithttps://github.com/ivanovit
releasehttps://github.com/NativeScript/nativescript-cli/tree/release
IIIvanov/fix-assets-generation-2https://github.com/NativeScript/nativescript-cli/tree/IIIvanov/fix-assets-generation-2
https://github.com/ivanovit
ivanovithttps://github.com/ivanovit
May 29, 2018https://github.com/NativeScript/nativescript-cli/pull/3638#issue-327318155
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3638
ProgressNS/sidekick-feedback#199https://github.com/ProgressNS/sidekick-feedback/issues/199
https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messageshttps://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages
CLAhttp://www.nativescript.org/cla
https://github.com/NativeScript/nativescript-cli/blob/master/CONTRIBUTING.md#contribute-to-the-code-basehttps://github.com/NativeScript/nativescript-cli/blob/master/CONTRIBUTING.md#contribute-to-the-code-base
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3638
https://github.com/rosen-vladimirov
rosen-vladimirovhttps://github.com/rosen-vladimirov
May 29, 2018 14:02https://github.com/NativeScript/nativescript-cli/pull/3638#event-1651177499
https://github.com/dtopuzov
dtopuzovhttps://github.com/dtopuzov
May 29, 2018https://github.com/NativeScript/nativescript-cli/pull/3638#issuecomment-392793026
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3638
https://github.com/rosen-vladimirov
rosen-vladimirovhttps://github.com/rosen-vladimirov
Jun 1, 2018 https://github.com/NativeScript/nativescript-cli/pull/3638#pullrequestreview-125053241
View reviewed changes https://github.com/NativeScript/nativescript-cli/pull/3638/files
rosen-vladimirovhttps://github.com/rosen-vladimirov
https://github.com/NativeScript/nativescript-cli/pull/3638#pullrequestreview-125053241
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3638
https://github.com/ivanovit
ivanovithttps://github.com/ivanovit
June 1, 2018 10:05https://github.com/NativeScript/nativescript-cli/pull/3638#event-1657959119
https://github.com/ivanovit
Fix assets generationhttps://github.com/NativeScript/nativescript-cli/pull/3638/commits/91f998c4fc09dab7bea21e47a4cf86367bb8c873
91f998chttps://github.com/NativeScript/nativescript-cli/pull/3638/commits/91f998c4fc09dab7bea21e47a4cf86367bb8c873
ProgressNS/sidekick-feedback#199https://github.com/ProgressNS/sidekick-feedback/issues/199
https://github.com/ivanovit
ivanovithttps://github.com/ivanovit
force-pushedhttps://github.com/NativeScript/nativescript-cli/compare/0894a2f8952eab62bbcc183a48e217a42657b1bf..91f998c4fc09dab7bea21e47a4cf86367bb8c873
0894a2fhttps://github.com/NativeScript/nativescript-cli/commit/0894a2f8952eab62bbcc183a48e217a42657b1bf
91f998chttps://github.com/NativeScript/nativescript-cli/commit/91f998c4fc09dab7bea21e47a4cf86367bb8c873
Compare https://github.com/NativeScript/nativescript-cli/compare/0894a2f8952eab62bbcc183a48e217a42657b1bf..91f998c4fc09dab7bea21e47a4cf86367bb8c873
June 1, 2018 10:10https://github.com/NativeScript/nativescript-cli/pull/3638#event-1657968699
https://github.com/ivanovit
ivanovithttps://github.com/ivanovit
Jun 1, 2018https://github.com/NativeScript/nativescript-cli/pull/3638#issuecomment-393837030
@rosen-vladimirovhttps://github.com/rosen-vladimirov
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3638
https://github.com/rosen-vladimirov
rosen-vladimirovhttps://github.com/rosen-vladimirov
Jun 1, 2018 https://github.com/NativeScript/nativescript-cli/pull/3638#pullrequestreview-125121860
View reviewed changes https://github.com/NativeScript/nativescript-cli/pull/3638/files/91f998c4fc09dab7bea21e47a4cf86367bb8c873
rosen-vladimirovhttps://github.com/rosen-vladimirov
https://github.com/NativeScript/nativescript-cli/pull/3638#pullrequestreview-125121860
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3638
https://github.com/rosen-vladimirov
rosen-vladimirovhttps://github.com/rosen-vladimirov
4.1.1https://github.com/NativeScript/nativescript-cli/milestone/72
Jun 4, 2018https://github.com/NativeScript/nativescript-cli/pull/3638#event-1660551503
https://github.com/rosen-vladimirov
rosen-vladimirovhttps://github.com/rosen-vladimirov
bug https://github.com/NativeScript/nativescript-cli/issues?q=state%3Aopen%20label%3Abug
Jun 4, 2018https://github.com/NativeScript/nativescript-cli/pull/3638#event-1660551575
https://github.com/rosen-vladimirov
rosen-vladimirovhttps://github.com/rosen-vladimirov
ivanovithttps://github.com/ivanovit
Jun 4, 2018https://github.com/NativeScript/nativescript-cli/pull/3638#event-1660551760
https://github.com/ivanovit
ivanovithttps://github.com/ivanovit
fdd81c2https://github.com/NativeScript/nativescript-cli/commit/fdd81c222306ee03044fe8d8ffa306be0e956113
Jun 5, 2018https://github.com/NativeScript/nativescript-cli/pull/3638#event-1662989477
https://github.com/ivanovit
ivanovithttps://github.com/ivanovit
June 5, 2018 07:37https://github.com/NativeScript/nativescript-cli/pull/3638#event-1662989574
https://github.com/dtopuzov
dtopuzovhttps://github.com/dtopuzov
ready for test https://github.com/NativeScript/nativescript-cli/issues?q=state%3Aopen%20label%3A%22ready%20for%20test%22
Jun 5, 2018https://github.com/NativeScript/nativescript-cli/pull/3638#event-1662990026
https://github.com/rosen-vladimirov
rosen-vladimirovhttps://github.com/rosen-vladimirov
Jun 5, 2018 https://github.com/NativeScript/nativescript-cli/pull/3638#ref-issue-329510359
Unable to generate icons when the Contents.json is not generated by Xcode #3666 https://github.com/NativeScript/nativescript-cli/issues/3666
https://github.com/miroslavaivanova
miroslavaivanovahttps://github.com/miroslavaivanova
ready for test https://github.com/NativeScript/nativescript-cli/issues?q=state%3Aopen%20label%3A%22ready%20for%20test%22
Jun 7, 2018https://github.com/NativeScript/nativescript-cli/pull/3638#event-1667665066
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F3638
https://github.com/rosen-vladimirov
rosen-vladimirov https://github.com/rosen-vladimirov
https://github.com/NativeScript/nativescript-cli/pull/3638/files/91f998c4fc09dab7bea21e47a4cf86367bb8c873
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3638
https://github.com/ivanovit
ivanovit https://github.com/ivanovit
bug https://github.com/NativeScript/nativescript-cli/issues?q=state%3Aopen%20label%3Abug
4.1.1 https://github.com/NativeScript/nativescript-cli/milestone/72
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3638
https://github.com/ivanovit
https://github.com/dtopuzov
https://github.com/rosen-vladimirov
https://github.com/miroslavaivanova
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.