René's URL Explorer Experiment


Title: fix: Tracking for used Debug tool is incorrect by rosen-vladimirov · Pull Request #3589 · NativeScript/nativescript-cli · GitHub

Open Graph Title: fix: Tracking for used Debug tool is incorrect by rosen-vladimirov · Pull Request #3589 · NativeScript/nativescript-cli

X Title: fix: Tracking for used Debug tool is incorrect by rosen-vladimirov · Pull Request #3589 · NativeScript/nativescript-cli

Description: The tracking if Inspector or Chrome is used as a debug tool is incorrect - currently it sends "Inspector" when --inspector is not specified. Chrome is sent only when --chrome is passed. Fix the tracking and add tests. PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/nativescript-cli/blob/master/CONTRIBUTING.md#contribute-to-the-code-base Tests for the changes are included. What is the current behavior? Tracking for used debug tools is not correct - "Chrome" is the default option, but it is tracked only when --chrome is passed. What is the new behavior? Tracking sends correct information when Inspector is used and when Chrome is used. Fixes #3593

Open Graph Description: The tracking if Inspector or Chrome is used as a debug tool is incorrect - currently it sends "Inspector" when --inspector is not specified. Chrome is sent only when --chrome is passed. F...

X Description: The tracking if Inspector or Chrome is used as a debug tool is incorrect - currently it sends "Inspector" when --inspector is not specified. Chrome is sent only when --chrome is p...

Opengraph URL: https://github.com/NativeScript/nativescript-cli/pull/3589

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:24122ba1-890f-46af-586a-f0b7452b91bc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9ED6:33444D:255AB89:31B0142:6B01A0FF
html-safe-nonce734a017735e30e701466e122bc0d80c143047aabc7d94a6b786167ec8f7d81df
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUQ2OjMzNDQ0RDoyNTVBQjg5OjMxQjAxNDI6NkIwMUEwRkYiLCJ2aXNpdG9yX2lkIjoiMTY0MTA4NzQ4NDk3MDUwODU0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccefa1a0b684fd6a2ed275d3885d68f639f778a4a1986327005c089d2fcecf497
hovercard-subject-tagpull_request:188251362
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/nativescript-cli/pull/3589/files
twitter:imagehttps://avatars.githubusercontent.com/u/8351653?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8351653?s=400&v=4
og:image:altThe tracking if Inspector or Chrome is used as a debug tool is incorrect - currently it sends "Inspector" when --inspector is not specified. Chrome is sent only when --chrome is passed. F...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/nativescript-cli git https://github.com/NativeScript/nativescript-cli.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id21347346
octolytics-dimension-repository_nwoNativeScript/nativescript-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21347346
octolytics-dimension-repository_network_root_nwoNativeScript/nativescript-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/nativescript-cli/pull/3589/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F3589%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F3589%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fnativescript-cli
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3589/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3589/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3589/files
NativeScripthttps://github.com/NativeScript
nativescript-clihttps://github.com/NativeScript/nativescript-cli
Codehttps://github.com/NativeScript/nativescript-cli
Issues357 (357)https://github.com/NativeScript/nativescript-cli/issues
Pull requests38 (38)https://github.com/NativeScript/nativescript-cli/pulls
Actionshttps://github.com/NativeScript/nativescript-cli/actions
Projectshttps://github.com/NativeScript/nativescript-cli/projects
Security and qualityhttps://github.com/NativeScript/nativescript-cli/security
Insightshttps://github.com/NativeScript/nativescript-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
rosen-vladimirovhttps://github.com/rosen-vladimirov
masterhttps://github.com/NativeScript/nativescript-cli/tree/master
vladimirov/fix-inspector-trackinghttps://github.com/NativeScript/nativescript-cli/tree/vladimirov/fix-inspector-tracking
Conversation 0 https://github.com/NativeScript/nativescript-cli/pull/3589
Commits 1 https://github.com/NativeScript/nativescript-cli/pull/3589/commits
Checks 0 https://github.com/NativeScript/nativescript-cli/pull/3589/checks
Files changed https://github.com/NativeScript/nativescript-cli/pull/3589/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3589/files
fix: Tracking for used Debug tool is incorrect https://github.com/NativeScript/nativescript-cli/pull/3589/files#top
Show all changes 1 commit https://github.com/NativeScript/nativescript-cli/pull/3589/files
001aa7e fix: Tracking for used Debug tool is incorrect rosen-vladimirov May 15, 2018 https://github.com/NativeScript/nativescript-cli/pull/3589/commits/001aa7e1d959ca1cd177332ca0d272155dae6edb
Clear filters https://github.com/NativeScript/nativescript-cli/pull/3589/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3589/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3589/files
debug-service.ts https://github.com/NativeScript/nativescript-cli/pull/3589/files#diff-0a9dfc02ca6909d109e8824613cd1a46f9fec08a1d7ed3495eb3331c115a5e17
debug-service.ts https://github.com/NativeScript/nativescript-cli/pull/3589/files#diff-f835510e5e5650607263dc102d58274d5a4b8218a36189b46e40b9c430a9db5e
lib/services/debug-service.tshttps://github.com/NativeScript/nativescript-cli/pull/3589/files#diff-0a9dfc02ca6909d109e8824613cd1a46f9fec08a1d7ed3495eb3331c115a5e17
View file https://github.com/NativeScript/nativescript-cli/blob/001aa7e1d959ca1cd177332ca0d272155dae6edb/lib/services/debug-service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/3589/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/3589/files#diff-0a9dfc02ca6909d109e8824613cd1a46f9fec08a1d7ed3495eb3331c115a5e17
https://github.com/NativeScript/nativescript-cli/pull/3589/files#diff-0a9dfc02ca6909d109e8824613cd1a46f9fec08a1d7ed3495eb3331c115a5e17
test/services/debug-service.tshttps://github.com/NativeScript/nativescript-cli/pull/3589/files#diff-f835510e5e5650607263dc102d58274d5a4b8218a36189b46e40b9c430a9db5e
View file https://github.com/NativeScript/nativescript-cli/blob/001aa7e1d959ca1cd177332ca0d272155dae6edb/test/services/debug-service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/3589/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/3589/files#diff-f835510e5e5650607263dc102d58274d5a4b8218a36189b46e40b9c430a9db5e
https://github.com/NativeScript/nativescript-cli/pull/3589/files#diff-f835510e5e5650607263dc102d58274d5a4b8218a36189b46e40b9c430a9db5e
https://github.com/NativeScript/nativescript-cli/pull/3589/files#diff-f835510e5e5650607263dc102d58274d5a4b8218a36189b46e40b9c430a9db5e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.