René's URL Explorer Experiment


Title: parse npm install results correctly by dnadoba · Pull Request #3213 · NativeScript/nativescript-cli · GitHub

Open Graph Title: parse npm install results correctly by dnadoba · Pull Request #3213 · NativeScript/nativescript-cli

X Title: parse npm install results correctly by dnadoba · Pull Request #3213 · NativeScript/nativescript-cli

Description: Solves Issue #3217 This pull request changes the implementation to search for the correct object by name. It does no longer depend on the position and should be more reliable especially as the --json flag is experimental as described in the npm documentation: https://docs.npmjs.com/misc/config#json As described in the comment of the current implementation of parseNpmInstallResults we just use the first object of the updated array. nativescript-cli/lib/node-package-manager.ts Lines 158 to 160 in e181f03 // Npm 5 return different object after performing `npm install --dry-run`. // Considering that the dependency is already installed we should // find it in the `updated` key as a first element of the array. But when I execute the following command: npm install tns-ios --json --dry-run tns-ios is not the first element in the updated array. The output looks something like this: { "added": [], "removed": [], "updated": [ { "action": "update", "name": "colors", "version": "https://registry.npmjs.org/colors/-/colors-1.1.2.tgz", "path": "/node_modules/colors", "previousVersion": "" }, { "action": "update", "name": "inherits", "version": "https://registry.npmjs.org/inherits/-/inherits-2.0.3.tgz", "path": "/node_modules/inherits", "previousVersion": "" }, { "action": "update", "name": "tns-ios", "version": "3.3.0", "path": "/node_modules/tns-ios", "previousVersion": "3.3.0" } ], "moved": [], "failed": [], "elapsed": 3113 } Instead of the first element, tns-ios is the last element. I had an issue with the following command: tns platform add ios It always failed with the following error: cp: no such file or directory: /node_modules//framework/* Now it works like a charm.

Open Graph Description: Solves Issue #3217 This pull request changes the implementation to search for the correct object by name. It does no longer depend on the position and should be more reliable especially as the --js...

X Description: Solves Issue #3217 This pull request changes the implementation to search for the correct object by name. It does no longer depend on the position and should be more reliable especially as the --js...

Opengraph URL: https://github.com/NativeScript/nativescript-cli/pull/3213

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d07c2c08-2ca1-714f-f058-1dcf5a28b16b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB064:26ECEB:2845F8E:33320CD:6B01890B
html-safe-nonce76ef3b24c5627de15bdbeb2e80bf1111f42a6679e2068f2c09c07d6516f058c5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDY0OjI2RUNFQjoyODQ1RjhFOjMzMzIwQ0Q6NkIwMTg5MEIiLCJ2aXNpdG9yX2lkIjoiNDA0OTUyMTE0Mjg1MDg2OTg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca764441b95b207ea44d1294f67e388dff613de94d0ca0dc0b925eacb218757ca
hovercard-subject-tagpull_request:151973174
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/nativescript-cli/pull/3213/files
twitter:imagehttps://avatars.githubusercontent.com/u/5688874?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5688874?s=400&v=4
og:image:altSolves Issue #3217 This pull request changes the implementation to search for the correct object by name. It does no longer depend on the position and should be more reliable especially as the --js...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/nativescript-cli git https://github.com/NativeScript/nativescript-cli.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id21347346
octolytics-dimension-repository_nwoNativeScript/nativescript-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21347346
octolytics-dimension-repository_network_root_nwoNativeScript/nativescript-cli
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/nativescript-cli/pull/3213/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F3213%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F3213%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fnativescript-cli
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3213/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3213/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3213/files
NativeScripthttps://github.com/NativeScript
nativescript-clihttps://github.com/NativeScript/nativescript-cli
Codehttps://github.com/NativeScript/nativescript-cli
Issues357 (357)https://github.com/NativeScript/nativescript-cli/issues
Pull requests38 (38)https://github.com/NativeScript/nativescript-cli/pulls
Actionshttps://github.com/NativeScript/nativescript-cli/actions
Projectshttps://github.com/NativeScript/nativescript-cli/projects
Security and qualityhttps://github.com/NativeScript/nativescript-cli/security
Insightshttps://github.com/NativeScript/nativescript-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
rosen-vladimirovhttps://github.com/rosen-vladimirov
NativeScript:masterhttps://github.com/NativeScript/nativescript-cli/tree/master
dnadoba:masterhttps://github.com/dnadoba/nativescript-cli/tree/master
Conversation 13 https://github.com/NativeScript/nativescript-cli/pull/3213
Commits 1 https://github.com/NativeScript/nativescript-cli/pull/3213/commits
Checks 0 https://github.com/NativeScript/nativescript-cli/pull/3213/checks
Files changed https://github.com/NativeScript/nativescript-cli/pull/3213/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3213/files
parse npm install results correctly https://github.com/NativeScript/nativescript-cli/pull/3213/files#top
Show all changes 1 commit https://github.com/NativeScript/nativescript-cli/pull/3213/files
2518648 find the correct dependency by searching for the `userSpecifiedPackag… dnadoba Nov 10, 2017 https://github.com/NativeScript/nativescript-cli/pull/3213/commits/251864897e262afa39df3c0c44f77fe2b6939c2c
Clear filters https://github.com/NativeScript/nativescript-cli/pull/3213/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3213/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3213/files
lib/node-package-manager.tshttps://github.com/NativeScript/nativescript-cli/pull/3213/files#diff-850ae620ca20e0d8ed5ccf4acd69fe6b8092192300a09eab8259316dd9f136c5
View file https://github.com/dnadoba/nativescript-cli/blob/251864897e262afa39df3c0c44f77fe2b6939c2c/lib/node-package-manager.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/3213/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/3213/files#diff-850ae620ca20e0d8ed5ccf4acd69fe6b8092192300a09eab8259316dd9f136c5
https://github.com/NativeScript/nativescript-cli/pull/3213/files#diff-850ae620ca20e0d8ed5ccf4acd69fe6b8092192300a09eab8259316dd9f136c5
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.