René's URL Explorer Experiment


Title: Fix hanging commands when webpack and unit tests are used by rosen-vladimirov · Pull Request #3212 · NativeScript/nativescript-cli · GitHub

Open Graph Title: Fix hanging commands when webpack and unit tests are used by rosen-vladimirov · Pull Request #3212 · NativeScript/nativescript-cli

X Title: Fix hanging commands when webpack and unit tests are used by rosen-vladimirov · Pull Request #3212 · NativeScript/nativescript-cli

Description: In case you try using npm scripts that come with nativescript-dev-webpack and you also have nativescript-unit-test-runner in your project, the scripts hang. The problem is that nativescript-unit-test-runner has a hook that resolves testExecutionService. In its constructor it sets that analytics broker should not be disposed. However, this is incorrect - it should not be disposed only in case we execute tests with livesync enabled. In order to fix this, move the logic in the commands. This way the hook will not change the disposing of the analytics broker, so once CLI process finishes, analytics broker process will be disconnected and CLI's process will die gracefully. Fixes: #3164 Also update submodule, where the following change is applied: Fix execution of hooks outside of process In case you need a hook to be executed outside of process, you should place correct shebang at the beginning of the file and CLI should spawn it. However, this is not working at the moment, as when CLI detects that the hook should be spawned, it just does nothing. The code is incorrectly placed inside the if for in process execution. This causes another issue - in case a hook returns a function, which returns falsey value, we decide the hook should be executed outside of process and spawn a new Node.js process to execute the hook. So we execute it twice. Fix the if-else logic, so the hooks will work correctly.

Open Graph Description: In case you try using npm scripts that come with nativescript-dev-webpack and you also have nativescript-unit-test-runner in your project, the scripts hang. The problem is that nativescript-unit-te...

X Description: In case you try using npm scripts that come with nativescript-dev-webpack and you also have nativescript-unit-test-runner in your project, the scripts hang. The problem is that nativescript-unit-te...

Opengraph URL: https://github.com/NativeScript/nativescript-cli/pull/3212

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:39354acd-0939-32fc-1ed8-3aab1771e707
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC2D8:76F02:25CA168:3054AF7:6B018994
html-safe-nonce67eca3756d9f9a6c898d757d875d194febf8412e54467477e0f44e4b5a2f5d14
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkQ4Ojc2RjAyOjI1Q0ExNjg6MzA1NEFGNzo2QjAxODk5NCIsInZpc2l0b3JfaWQiOiI3Mjg4NDU0MDM1ODkwMzQyMjkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb787d05802b02767ea8abf5350b0d95df3c9e9f02398208faf0277e460579ae5
hovercard-subject-tagpull_request:151943682
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/nativescript-cli/pull/3212/files
twitter:imagehttps://avatars.githubusercontent.com/u/8351653?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8351653?s=400&v=4
og:image:altIn case you try using npm scripts that come with nativescript-dev-webpack and you also have nativescript-unit-test-runner in your project, the scripts hang. The problem is that nativescript-unit-te...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/nativescript-cli git https://github.com/NativeScript/nativescript-cli.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id21347346
octolytics-dimension-repository_nwoNativeScript/nativescript-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21347346
octolytics-dimension-repository_network_root_nwoNativeScript/nativescript-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/nativescript-cli/pull/3212/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F3212%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F3212%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fnativescript-cli
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3212/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3212/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3212/files
NativeScripthttps://github.com/NativeScript
nativescript-clihttps://github.com/NativeScript/nativescript-cli
Codehttps://github.com/NativeScript/nativescript-cli
Issues357 (357)https://github.com/NativeScript/nativescript-cli/issues
Pull requests38 (38)https://github.com/NativeScript/nativescript-cli/pulls
Actionshttps://github.com/NativeScript/nativescript-cli/actions
Projectshttps://github.com/NativeScript/nativescript-cli/projects
Security and qualityhttps://github.com/NativeScript/nativescript-cli/security
Insightshttps://github.com/NativeScript/nativescript-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
rosen-vladimirovhttps://github.com/rosen-vladimirov
masterhttps://github.com/NativeScript/nativescript-cli/tree/master
vladimirov/fix-hanging-webpackhttps://github.com/NativeScript/nativescript-cli/tree/vladimirov/fix-hanging-webpack
Conversation 4 https://github.com/NativeScript/nativescript-cli/pull/3212
Commits 1 https://github.com/NativeScript/nativescript-cli/pull/3212/commits
Checks 0 https://github.com/NativeScript/nativescript-cli/pull/3212/checks
Files changed https://github.com/NativeScript/nativescript-cli/pull/3212/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3212/files
Fix hanging commands when webpack and unit tests are used https://github.com/NativeScript/nativescript-cli/pull/3212/files#top
Show all changes 1 commit https://github.com/NativeScript/nativescript-cli/pull/3212/files
4b260d7 Fix hanging commands when webpack and unit tests are used rosen-vladimirov Nov 10, 2017 https://github.com/NativeScript/nativescript-cli/pull/3212/commits/4b260d7d1479e0705f0d1a09abd07e6b986182a6
Clear filters https://github.com/NativeScript/nativescript-cli/pull/3212/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3212/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3212/files
test.ts https://github.com/NativeScript/nativescript-cli/pull/3212/files#diff-92f4ee17ee2d230cbaf07d94d17877cacb924e3858d4fce49fe4ec4c652d63c6
common https://github.com/NativeScript/nativescript-cli/pull/3212/files#diff-3d47a30a80ed97a9879c39c7aa0f13fd8840649148364e47f61d77844ed101bb
test-execution-service.ts https://github.com/NativeScript/nativescript-cli/pull/3212/files#diff-62ec58df046f2cefa83be8d0793b1a618d11270eed6b45a6538577d319cd2ba4
lib/commands/test.tshttps://github.com/NativeScript/nativescript-cli/pull/3212/files#diff-92f4ee17ee2d230cbaf07d94d17877cacb924e3858d4fce49fe4ec4c652d63c6
View file https://github.com/NativeScript/nativescript-cli/blob/4b260d7d1479e0705f0d1a09abd07e6b986182a6/lib/commands/test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/3212/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/3212/files#diff-92f4ee17ee2d230cbaf07d94d17877cacb924e3858d4fce49fe4ec4c652d63c6
https://github.com/NativeScript/nativescript-cli/pull/3212/files#diff-92f4ee17ee2d230cbaf07d94d17877cacb924e3858d4fce49fe4ec4c652d63c6
https://github.com/NativeScript/nativescript-cli/pull/3212/files#diff-92f4ee17ee2d230cbaf07d94d17877cacb924e3858d4fce49fe4ec4c652d63c6
lib/commonhttps://github.com/NativeScript/nativescript-cli/pull/3212/files#diff-3d47a30a80ed97a9879c39c7aa0f13fd8840649148364e47f61d77844ed101bb
Open in desktop https://desktop.github.com
commonhttps://github.com/telerik/mobile-cli-lib
1 files https://github.com/telerik/mobile-cli-lib/compare/df4b878e824694391313552b49a7a7490e65138e...517a9383a7060ff127bd6937688dbd05aaff4aae
services/hooks-service.ts https://github.com/telerik/mobile-cli-lib/compare/df4b878e824694391313552b49a7a7490e65138e...517a9383a7060ff127bd6937688dbd05aaff4aae#diff-c1fb8b5834ad7e2e37ee80b7bbdcf8688cd436952858aab5603c582c55353c7b
lib/services/test-execution-service.tshttps://github.com/NativeScript/nativescript-cli/pull/3212/files#diff-62ec58df046f2cefa83be8d0793b1a618d11270eed6b45a6538577d319cd2ba4
View file https://github.com/NativeScript/nativescript-cli/blob/4b260d7d1479e0705f0d1a09abd07e6b986182a6/lib/services/test-execution-service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/3212/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/3212/files#diff-62ec58df046f2cefa83be8d0793b1a618d11270eed6b45a6538577d319cd2ba4
https://github.com/NativeScript/nativescript-cli/pull/3212/files#diff-62ec58df046f2cefa83be8d0793b1a618d11270eed6b45a6538577d319cd2ba4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.