René's URL Explorer Experiment


Title: Fix missing console.logs on Android when CLI is used as library by rosen-vladimirov · Pull Request #3198 · NativeScript/nativescript-cli · GitHub

Open Graph Title: Fix missing console.logs on Android when CLI is used as library by rosen-vladimirov · Pull Request #3198 · NativeScript/nativescript-cli

X Title: Fix missing console.logs on Android when CLI is used as library by rosen-vladimirov · Pull Request #3198 · NativeScript/nativescript-cli

Description: In case CLI is used as a library, the device logs are no longer captured after application is restarted. The problem is the newly added logic for Android devices that stops the logcat process when CLI calls stopApplication and starts it when startApplication is called. However, in startApplication there's a check if $options.justlaunch is false - only then the device log operation is started again. When CLI is used as a library, we have hardcoded the justlaunch option to true in order to prevent duplicate logs for iOS devices. So the solution to resolve Android logs issues is to remove the setting of justlaunch option. However, this caused the duplicate logs issue for iOS devices. Investigating it further, it turned out to be a memory leak when iOS device is detached. It's fixed in the submodule: Fix leaking handlers for iOS device logs In case iOS Device is detached, the IOSDevice instance is kept alive. The reason is the handler for device logs, that IOSDevice passes to iOSDeviceOperations. As iOSDeviceOperations is still alive, the IOSDevice instance is also alive. Reattaching the same device will cause duplicate logs. Detaching and attaching it again will lead to additional logs. In order to fix the issue, convert iOSDeviceOpertations to event emitter and emit event when there's data for logging. Each IOSDevice will add handler for the event and will do its logic. In case device is detached (i.e. DeviceLost event is fired in DevicesService), call a newly added method to the specific IDevice instance. It's purpose is to clean the used resource. For iOS device, this method will remove the handler for devceLogData event of iOSDeviceOperations.

Open Graph Description: In case CLI is used as a library, the device logs are no longer captured after application is restarted. The problem is the newly added logic for Android devices that stops the logcat process when ...

X Description: In case CLI is used as a library, the device logs are no longer captured after application is restarted. The problem is the newly added logic for Android devices that stops the logcat process when ...

Opengraph URL: https://github.com/NativeScript/nativescript-cli/pull/3198

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6867a7e5-b6ea-e769-d6f5-2124bf52149f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9E94:1F927B:1E84D7:28A907:6B0188F7
html-safe-nonce13aa4505bc1186a01c27a6039cbf1c3495f63eb7529397d111f1280eddb5e3ec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTk0OjFGOTI3QjoxRTg0RDc6MjhBOTA3OjZCMDE4OEY3IiwidmlzaXRvcl9pZCI6Ijg5ODI1NjI5NDE4NzQzMDkzNjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9b685aed980f63e0a12cbfdbc52e0b2634b735c4595557ebf1096d42fd9a83b1
hovercard-subject-tagpull_request:150839076
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/nativescript-cli/pull/3198/files
twitter:imagehttps://avatars.githubusercontent.com/u/8351653?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8351653?s=400&v=4
og:image:altIn case CLI is used as a library, the device logs are no longer captured after application is restarted. The problem is the newly added logic for Android devices that stops the logcat process when ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/nativescript-cli git https://github.com/NativeScript/nativescript-cli.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id21347346
octolytics-dimension-repository_nwoNativeScript/nativescript-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21347346
octolytics-dimension-repository_network_root_nwoNativeScript/nativescript-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/nativescript-cli/pull/3198/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F3198%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F3198%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fnativescript-cli
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3198/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3198/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3198/files
NativeScripthttps://github.com/NativeScript
nativescript-clihttps://github.com/NativeScript/nativescript-cli
Codehttps://github.com/NativeScript/nativescript-cli
Issues357 (357)https://github.com/NativeScript/nativescript-cli/issues
Pull requests38 (38)https://github.com/NativeScript/nativescript-cli/pulls
Actionshttps://github.com/NativeScript/nativescript-cli/actions
Projectshttps://github.com/NativeScript/nativescript-cli/projects
Security and qualityhttps://github.com/NativeScript/nativescript-cli/security
Insightshttps://github.com/NativeScript/nativescript-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
rosen-vladimirovhttps://github.com/rosen-vladimirov
masterhttps://github.com/NativeScript/nativescript-cli/tree/master
vladimirov/fix-sidekick-justlaunchhttps://github.com/NativeScript/nativescript-cli/tree/vladimirov/fix-sidekick-justlaunch
Conversation 3 https://github.com/NativeScript/nativescript-cli/pull/3198
Commits 1 https://github.com/NativeScript/nativescript-cli/pull/3198/commits
Checks 0 https://github.com/NativeScript/nativescript-cli/pull/3198/checks
Files changed https://github.com/NativeScript/nativescript-cli/pull/3198/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3198/files
Fix missing console.logs on Android when CLI is used as library https://github.com/NativeScript/nativescript-cli/pull/3198/files#top
Show all changes 1 commit https://github.com/NativeScript/nativescript-cli/pull/3198/files
980637e Fix missing console.logs on Android when CLI is used as library rosen-vladimirov Nov 6, 2017 https://github.com/NativeScript/nativescript-cli/pull/3198/commits/980637edef02e6c2401fe9c8cbbcf330c762d909
Clear filters https://github.com/NativeScript/nativescript-cli/pull/3198/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3198/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3198/files
common https://github.com/NativeScript/nativescript-cli/pull/3198/files#diff-3d47a30a80ed97a9879c39c7aa0f13fd8840649148364e47f61d77844ed101bb
nativescript-cli-lib-bootstrap.ts https://github.com/NativeScript/nativescript-cli/pull/3198/files#diff-d13b6ec80c106ad8a55390accdd7bb71b2a8a558e53a3d972f7e641da1281037
lib/commonhttps://github.com/NativeScript/nativescript-cli/pull/3198/files#diff-3d47a30a80ed97a9879c39c7aa0f13fd8840649148364e47f61d77844ed101bb
Open in desktop https://desktop.github.com
commonhttps://github.com/telerik/mobile-cli-lib
7 files https://github.com/telerik/mobile-cli-lib/compare/eac6e6bec934f92edae1bbb8b12e845ba8aa4bb0...0812ce953f66e3f749f541b1e93af2794e40e866
appbuilder/device-emitter.ts https://github.com/telerik/mobile-cli-lib/compare/eac6e6bec934f92edae1bbb8b12e845ba8aa4bb0...0812ce953f66e3f749f541b1e93af2794e40e866#diff-3baee75c1fba6631b30649ac338954b3ec11c329a504a6720cb2e992c3a07244
constants.ts https://github.com/telerik/mobile-cli-lib/compare/eac6e6bec934f92edae1bbb8b12e845ba8aa4bb0...0812ce953f66e3f749f541b1e93af2794e40e866#diff-22b7ddb3fe827e6367c5214dd94c93733405fad09f72d932b88d033e7bcd0e10
definitions/mobile.d.ts https://github.com/telerik/mobile-cli-lib/compare/eac6e6bec934f92edae1bbb8b12e845ba8aa4bb0...0812ce953f66e3f749f541b1e93af2794e40e866#diff-b71146b974b36e1a06c2c6d0318dbdf1b152a135f115242a5cf1da294c81c9b7
mobile/ios/device/ios-device-operations.ts https://github.com/telerik/mobile-cli-lib/compare/eac6e6bec934f92edae1bbb8b12e845ba8aa4bb0...0812ce953f66e3f749f541b1e93af2794e40e866#diff-7a1c0e5b7f436bf07b6f2943f39572079ef7fc5e2adb336f744076eb9893896b
mobile/ios/device/ios-device.ts https://github.com/telerik/mobile-cli-lib/compare/eac6e6bec934f92edae1bbb8b12e845ba8aa4bb0...0812ce953f66e3f749f541b1e93af2794e40e866#diff-fca70aea442ced90fcf2a12c05bea39e7df4ee0318ff4542c4a5d0420059fb52
mobile/mobile-core/devices-service.ts https://github.com/telerik/mobile-cli-lib/compare/eac6e6bec934f92edae1bbb8b12e845ba8aa4bb0...0812ce953f66e3f749f541b1e93af2794e40e866#diff-908242d42c1c47c1811733fbefe534e7cdcaff4e529f40342b4ae1a79e91b1cc
test/unit-tests/appbuilder/device-emitter.ts https://github.com/telerik/mobile-cli-lib/compare/eac6e6bec934f92edae1bbb8b12e845ba8aa4bb0...0812ce953f66e3f749f541b1e93af2794e40e866#diff-767bd47167e28c999399f9ac54c5c644c40ee60f623495802ce416d0ed69b9d2
lib/nativescript-cli-lib-bootstrap.tshttps://github.com/NativeScript/nativescript-cli/pull/3198/files#diff-d13b6ec80c106ad8a55390accdd7bb71b2a8a558e53a3d972f7e641da1281037
View file https://github.com/NativeScript/nativescript-cli/blob/980637edef02e6c2401fe9c8cbbcf330c762d909/lib/nativescript-cli-lib-bootstrap.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/3198/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/3198/files#diff-d13b6ec80c106ad8a55390accdd7bb71b2a8a558e53a3d972f7e641da1281037
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.