René's URL Explorer Experiment


Title: Do not track help command when other command fails by rosen-vladimirov · Pull Request #3196 · NativeScript/nativescript-cli · GitHub

Open Graph Title: Do not track help command when other command fails by rosen-vladimirov · Pull Request #3196 · NativeScript/nativescript-cli

X Title: Do not track help command when other command fails by rosen-vladimirov · Pull Request #3196 · NativeScript/nativescript-cli

Description: In case any command fails, we execute help command in order to show the help content. This leads to multiple trackings, i.e. - user executes only one command, but in Analytics we see two commands. Instead of executing help command, introduce new method in htmlHelpService, that prints the help to the terminal and call it instead. Use the same method in the help command itself. Rename htmlHelpService to helpService - it has been incorrectly named from the beginning. Remove helpTextPath from staticConfig interface - this property is not used for more than 2 years. Introduce tests for helpService - get the tests from AppBuilder CLI. Submodule PR: telerik/mobile-cli-lib#1021

Open Graph Description: In case any command fails, we execute help command in order to show the help content. This leads to multiple trackings, i.e. - user executes only one command, but in Analytics we see two commands. ...

X Description: In case any command fails, we execute help command in order to show the help content. This leads to multiple trackings, i.e. - user executes only one command, but in Analytics we see two commands. ...

Opengraph URL: https://github.com/NativeScript/nativescript-cli/pull/3196

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5d1a1471-523c-aecb-b312-8ecfea873015
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id833E:22DB35:277B4AF:3261DE0:6B0188FA
html-safe-nonce2d9759a6a6801cea8a9f80843ffb5d37ef5c0f440abf5fb7ba01a708d23af09e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzNFOjIyREIzNToyNzdCNEFGOjMyNjFERTA6NkIwMTg4RkEiLCJ2aXNpdG9yX2lkIjoiNzUwOTU4NzAyNDE5NDY2ODc5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd9ea04bbc24fb7b324e581a8a94c3cc8801d85855477d6adba82691b662cb75c
hovercard-subject-tagpull_request:150420625
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/nativescript-cli/pull/3196/files
twitter:imagehttps://avatars.githubusercontent.com/u/8351653?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8351653?s=400&v=4
og:image:altIn case any command fails, we execute help command in order to show the help content. This leads to multiple trackings, i.e. - user executes only one command, but in Analytics we see two commands. ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/nativescript-cli git https://github.com/NativeScript/nativescript-cli.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id21347346
octolytics-dimension-repository_nwoNativeScript/nativescript-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21347346
octolytics-dimension-repository_network_root_nwoNativeScript/nativescript-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/nativescript-cli/pull/3196/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F3196%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F3196%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fnativescript-cli
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3196/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3196/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3196/files
NativeScripthttps://github.com/NativeScript
nativescript-clihttps://github.com/NativeScript/nativescript-cli
Codehttps://github.com/NativeScript/nativescript-cli
Issues357 (357)https://github.com/NativeScript/nativescript-cli/issues
Pull requests38 (38)https://github.com/NativeScript/nativescript-cli/pulls
Actionshttps://github.com/NativeScript/nativescript-cli/actions
Projectshttps://github.com/NativeScript/nativescript-cli/projects
Security and qualityhttps://github.com/NativeScript/nativescript-cli/security
Insightshttps://github.com/NativeScript/nativescript-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
rosen-vladimirovhttps://github.com/rosen-vladimirov
masterhttps://github.com/NativeScript/nativescript-cli/tree/master
vladimirov/help-servicehttps://github.com/NativeScript/nativescript-cli/tree/vladimirov/help-service
Conversation 0 https://github.com/NativeScript/nativescript-cli/pull/3196
Commits 1 https://github.com/NativeScript/nativescript-cli/pull/3196/commits
Checks 0 https://github.com/NativeScript/nativescript-cli/pull/3196/checks
Files changed https://github.com/NativeScript/nativescript-cli/pull/3196/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3196/files
Do not track help command when other command fails https://github.com/NativeScript/nativescript-cli/pull/3196/files#top
Show all changes 1 commit https://github.com/NativeScript/nativescript-cli/pull/3196/files
8c0b8cd Do not track help command when other command fails rosen-vladimirov Nov 2, 2017 https://github.com/NativeScript/nativescript-cli/pull/3196/commits/8c0b8cda0afd8988812792206afcff7523ecf165
Clear filters https://github.com/NativeScript/nativescript-cli/pull/3196/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3196/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3196/files
generate-help.ts https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-92d3eb0c6ff5ff9ee170d1b015752fea620017654c3eb16c9724ba890b76f7bf
post-install.ts https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-7fe1fd75a91a988917421113b5a3823b9dc1b6a2993b89eaab3f8bbab943577c
common https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-3d47a30a80ed97a9879c39c7aa0f13fd8840649148364e47f61d77844ed101bb
config.ts https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-e53d9a775fe43c0fed7503b2e2fd8d73b283b72dadc8707d3cdfc00f5e5ff732
post-install.ts https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-213dae35f3b3001f90bda6dce525f34aaaf03c078ead804c43a42e888e1fc1e6
platform-commands.ts https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-8affcae7f654d23e0ee05bec61919c206bbeca64fc04c98a0c5bfb04109e3bcf
platform-service.ts https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-33050b907522742c821509ea3f830b693828787baa3d6094575790ae21f644e6
plugins-service.ts https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-5fc99fab5ffa580e26122b73c4599ad0f7ab50433ecbf6568b8ccc3ee1c0452a
stubs.ts https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-dd112d38ea758f19d5a841e5979dd2153713b9f19f0790124b4b8169a60709d9
lib/commands/generate-help.tshttps://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-92d3eb0c6ff5ff9ee170d1b015752fea620017654c3eb16c9724ba890b76f7bf
View file https://github.com/NativeScript/nativescript-cli/blob/8c0b8cda0afd8988812792206afcff7523ecf165/lib/commands/generate-help.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/3196/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-92d3eb0c6ff5ff9ee170d1b015752fea620017654c3eb16c9724ba890b76f7bf
lib/commands/post-install.tshttps://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-7fe1fd75a91a988917421113b5a3823b9dc1b6a2993b89eaab3f8bbab943577c
View file https://github.com/NativeScript/nativescript-cli/blob/8c0b8cda0afd8988812792206afcff7523ecf165/lib/commands/post-install.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/3196/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-7fe1fd75a91a988917421113b5a3823b9dc1b6a2993b89eaab3f8bbab943577c
https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-7fe1fd75a91a988917421113b5a3823b9dc1b6a2993b89eaab3f8bbab943577c
lib/commonhttps://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-3d47a30a80ed97a9879c39c7aa0f13fd8840649148364e47f61d77844ed101bb
Open in desktop https://desktop.github.com
commonhttps://github.com/telerik/mobile-cli-lib
12 files https://github.com/telerik/mobile-cli-lib/compare/0812ce953f66e3f749f541b1e93af2794e40e866...06d4f680523cf79ecc7df47feeb61cf6acc7a2a7
bootstrap.ts https://github.com/telerik/mobile-cli-lib/compare/0812ce953f66e3f749f541b1e93af2794e40e866...06d4f680523cf79ecc7df47feeb61cf6acc7a2a7#diff-05f38fa762f93c1fd3b764ac98b0be8aa1ae247a58e436b5d507b1bd8132abe9
commands/help.ts https://github.com/telerik/mobile-cli-lib/compare/0812ce953f66e3f749f541b1e93af2794e40e866...06d4f680523cf79ecc7df47feeb61cf6acc7a2a7#diff-1a10ded8cdab2c357c3c5299a0aedc33c92c84b2271fde386843368204bc482f
commands/post-install.ts https://github.com/telerik/mobile-cli-lib/compare/0812ce953f66e3f749f541b1e93af2794e40e866...06d4f680523cf79ecc7df47feeb61cf6acc7a2a7#diff-1bf74f9facd7a60d4297686281cdb88df7f66604c5368c1c2250bedc8408a16d
declarations.d.ts https://github.com/telerik/mobile-cli-lib/compare/0812ce953f66e3f749f541b1e93af2794e40e866...06d4f680523cf79ecc7df47feeb61cf6acc7a2a7#diff-8cdfbd695c6c52376c005a5092ea78b549d4d38989bec624f5e294493410deb4
definitions/config.d.ts https://github.com/telerik/mobile-cli-lib/compare/0812ce953f66e3f749f541b1e93af2794e40e866...06d4f680523cf79ecc7df47feeb61cf6acc7a2a7#diff-4745a3c36a03e93db48792fea914434aa9d6c6f52cdf1ee596bfb5caf12d7b0e
errors.ts https://github.com/telerik/mobile-cli-lib/compare/0812ce953f66e3f749f541b1e93af2794e40e866...06d4f680523cf79ecc7df47feeb61cf6acc7a2a7#diff-41c0f08411a59bde50cb1c1750f321326c0c2f2f4f21ae1e981fb2cd04963058
services/commands-service.ts https://github.com/telerik/mobile-cli-lib/compare/0812ce953f66e3f749f541b1e93af2794e40e866...06d4f680523cf79ecc7df47feeb61cf6acc7a2a7#diff-aa413c7985491ee9ed6fc9eef37b9b47811d46b871dd6b524f4a33417aa60645
services/dynamic-help-service.ts https://github.com/telerik/mobile-cli-lib/compare/0812ce953f66e3f749f541b1e93af2794e40e866...06d4f680523cf79ecc7df47feeb61cf6acc7a2a7#diff-a999dfb5b2f083082c998122155abc8fc963d20652b1805a6ad878344a9fa7de
services/help-service.ts https://github.com/telerik/mobile-cli-lib/compare/0812ce953f66e3f749f541b1e93af2794e40e866...06d4f680523cf79ecc7df47feeb61cf6acc7a2a7#diff-cdf31a7939d762918264d89ce19255651e19c436b5573e91b34bc63dc0d90414
static-config-base.ts https://github.com/telerik/mobile-cli-lib/compare/0812ce953f66e3f749f541b1e93af2794e40e866...06d4f680523cf79ecc7df47feeb61cf6acc7a2a7#diff-4528720bbf9c8dadf9157258577bb333c052f27adc50260bd7861456f38b3096
test/unit-tests/services/help-service.ts https://github.com/telerik/mobile-cli-lib/compare/0812ce953f66e3f749f541b1e93af2794e40e866...06d4f680523cf79ecc7df47feeb61cf6acc7a2a7#diff-3ce466592e1cdb3ad835b8fa9b08503c46e7fcdbc9748f70e3adf3cc0d3fee5f
test/unit-tests/stubs.ts https://github.com/telerik/mobile-cli-lib/compare/0812ce953f66e3f749f541b1e93af2794e40e866...06d4f680523cf79ecc7df47feeb61cf6acc7a2a7#diff-e118ec2330279c9258a76eca41aa7942e065a59ec3452eab5451a3b4abc0a216
lib/config.tshttps://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-e53d9a775fe43c0fed7503b2e2fd8d73b283b72dadc8707d3cdfc00f5e5ff732
View file https://github.com/NativeScript/nativescript-cli/blob/8c0b8cda0afd8988812792206afcff7523ecf165/lib/config.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/3196/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-e53d9a775fe43c0fed7503b2e2fd8d73b283b72dadc8707d3cdfc00f5e5ff732
https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-e53d9a775fe43c0fed7503b2e2fd8d73b283b72dadc8707d3cdfc00f5e5ff732
test/commands/post-install.tshttps://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-213dae35f3b3001f90bda6dce525f34aaaf03c078ead804c43a42e888e1fc1e6
View file https://github.com/NativeScript/nativescript-cli/blob/8c0b8cda0afd8988812792206afcff7523ecf165/test/commands/post-install.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/3196/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-213dae35f3b3001f90bda6dce525f34aaaf03c078ead804c43a42e888e1fc1e6
https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-213dae35f3b3001f90bda6dce525f34aaaf03c078ead804c43a42e888e1fc1e6
test/platform-commands.tshttps://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-8affcae7f654d23e0ee05bec61919c206bbeca64fc04c98a0c5bfb04109e3bcf
View file https://github.com/NativeScript/nativescript-cli/blob/8c0b8cda0afd8988812792206afcff7523ecf165/test/platform-commands.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/3196/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-8affcae7f654d23e0ee05bec61919c206bbeca64fc04c98a0c5bfb04109e3bcf
https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-8affcae7f654d23e0ee05bec61919c206bbeca64fc04c98a0c5bfb04109e3bcf
https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-8affcae7f654d23e0ee05bec61919c206bbeca64fc04c98a0c5bfb04109e3bcf
https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-8affcae7f654d23e0ee05bec61919c206bbeca64fc04c98a0c5bfb04109e3bcf
test/platform-service.tshttps://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-33050b907522742c821509ea3f830b693828787baa3d6094575790ae21f644e6
View file https://github.com/NativeScript/nativescript-cli/blob/8c0b8cda0afd8988812792206afcff7523ecf165/test/platform-service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/3196/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-33050b907522742c821509ea3f830b693828787baa3d6094575790ae21f644e6
https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-33050b907522742c821509ea3f830b693828787baa3d6094575790ae21f644e6
test/plugins-service.tshttps://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-5fc99fab5ffa580e26122b73c4599ad0f7ab50433ecbf6568b8ccc3ee1c0452a
View file https://github.com/NativeScript/nativescript-cli/blob/8c0b8cda0afd8988812792206afcff7523ecf165/test/plugins-service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/3196/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-5fc99fab5ffa580e26122b73c4599ad0f7ab50433ecbf6568b8ccc3ee1c0452a
https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-5fc99fab5ffa580e26122b73c4599ad0f7ab50433ecbf6568b8ccc3ee1c0452a
test/stubs.tshttps://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-dd112d38ea758f19d5a841e5979dd2153713b9f19f0790124b4b8169a60709d9
View file https://github.com/NativeScript/nativescript-cli/blob/8c0b8cda0afd8988812792206afcff7523ecf165/test/stubs.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/3196/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-dd112d38ea758f19d5a841e5979dd2153713b9f19f0790124b4b8169a60709d9
https://github.com/NativeScript/nativescript-cli/pull/3196/files#diff-dd112d38ea758f19d5a841e5979dd2153713b9f19f0790124b4b8169a60709d9
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.