René's URL Explorer Experiment


Title: Fix stopLiveSync method by rosen-vladimirov · Pull Request #3077 · NativeScript/nativescript-cli · GitHub

Open Graph Title: Fix stopLiveSync method by rosen-vladimirov · Pull Request #3077 · NativeScript/nativescript-cli

X Title: Fix stopLiveSync method by rosen-vladimirov · Pull Request #3077 · NativeScript/nativescript-cli

Description: Fix stopLiveSync method Currently stopLiveSync method does not emit correct events in some cases. For example, when there's only one attached device and its identifier is passed to stopLiveSync method, we do not emit liveSyncStopped event. Fix the code and add unit tests to assure liveSyncStopped event is raised correctly. Expose getLiveSyncDeviceDescriptors method Add new public method getLiveSyncDeviceDescriptors to liveSyncService - its purpose is to get information for current LiveSync operation.

Open Graph Description: Fix stopLiveSync method Currently stopLiveSync method does not emit correct events in some cases. For example, when there's only one attached device and its identifier is passed to stopLiveSync...

X Description: Fix stopLiveSync method Currently stopLiveSync method does not emit correct events in some cases. For example, when there's only one attached device and its identifier is passed to stopLive...

Opengraph URL: https://github.com/NativeScript/nativescript-cli/pull/3077

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:45ea795e-05ac-6fe2-e101-e9067e0d0d55
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD3D4:27E5CD:2B07C5F:370C5F7:6B01A19D
html-safe-nonceb0c85b750c645399048c38f0bc00c20bbeddd9aebd23b0c0bcd78c5f36f3c09b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEM0Q0OjI3RTVDRDoyQjA3QzVGOjM3MEM1Rjc6NkIwMUExOUQiLCJ2aXNpdG9yX2lkIjoiMjQ4NTE4MDI5ODE2NjM3ODkwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5ff0ac8723b7d5bfc6694ae5851d7104b9319f5f2a9630705adbc3308324392b
hovercard-subject-tagpull_request:136941852
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/nativescript-cli/pull/3077/files
twitter:imagehttps://avatars.githubusercontent.com/u/8351653?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8351653?s=400&v=4
og:image:altFix stopLiveSync method Currently stopLiveSync method does not emit correct events in some cases. For example, when there's only one attached device and its identifier is passed to stopLiveSync...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/nativescript-cli git https://github.com/NativeScript/nativescript-cli.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id21347346
octolytics-dimension-repository_nwoNativeScript/nativescript-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21347346
octolytics-dimension-repository_network_root_nwoNativeScript/nativescript-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/nativescript-cli/pull/3077/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F3077%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F3077%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fnativescript-cli
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3077/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3077/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/3077/files
NativeScripthttps://github.com/NativeScript
nativescript-clihttps://github.com/NativeScript/nativescript-cli
Codehttps://github.com/NativeScript/nativescript-cli
Issues357 (357)https://github.com/NativeScript/nativescript-cli/issues
Pull requests38 (38)https://github.com/NativeScript/nativescript-cli/pulls
Actionshttps://github.com/NativeScript/nativescript-cli/actions
Projectshttps://github.com/NativeScript/nativescript-cli/projects
Security and qualityhttps://github.com/NativeScript/nativescript-cli/security
Insightshttps://github.com/NativeScript/nativescript-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
rosen-vladimirovhttps://github.com/rosen-vladimirov
masterhttps://github.com/NativeScript/nativescript-cli/tree/master
vladimirov/fix-stop-livesynchttps://github.com/NativeScript/nativescript-cli/tree/vladimirov/fix-stop-livesync
Conversation 2 https://github.com/NativeScript/nativescript-cli/pull/3077
Commits 2 https://github.com/NativeScript/nativescript-cli/pull/3077/commits
Checks 0 https://github.com/NativeScript/nativescript-cli/pull/3077/checks
Files changed https://github.com/NativeScript/nativescript-cli/pull/3077/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3077/files
Fix stopLiveSync method https://github.com/NativeScript/nativescript-cli/pull/3077/files#top
Show all changes 2 commits https://github.com/NativeScript/nativescript-cli/pull/3077/files
b72bdbc Fix stopLiveSync method rosen-vladimirov Aug 22, 2017 https://github.com/NativeScript/nativescript-cli/pull/3077/commits/b72bdbc52ae02eface14cbf5ef12ba5a883fb5d0
8b71556 Expose getLiveSyncDeviceDescriptors method rosen-vladimirov Aug 22, 2017 https://github.com/NativeScript/nativescript-cli/pull/3077/commits/8b7155668b346baefa345bd4cc445c59d55cc8b3
Clear filters https://github.com/NativeScript/nativescript-cli/pull/3077/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3077/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/3077/files
PublicAPI.md https://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-454e9068acb5154f222c4a99860091d7c4a6f9953776d0aa95aa48723110d091
livesync.d.ts https://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-3d0efe15b0b9d1f1839b17d65770cf34e784337db1e0257fdae7912bc770e0af
livesync-service.ts https://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-8e0297d83df10101fca70d03d5625c7722dd4615aa5ad1fdf6317c1100d96e1b
livesync-service.ts https://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-702eb866ce14d0454ad35a2a7382c72f568eae932cd91945dd2e49aee16278bd
stubs.ts https://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-dd112d38ea758f19d5a841e5979dd2153713b9f19f0790124b4b8169a60709d9
PublicAPI.mdhttps://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-454e9068acb5154f222c4a99860091d7c4a6f9953776d0aa95aa48723110d091
View file https://github.com/NativeScript/nativescript-cli/blob/8b7155668b346baefa345bd4cc445c59d55cc8b3/PublicAPI.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/3077/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-454e9068acb5154f222c4a99860091d7c4a6f9953776d0aa95aa48723110d091
https://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-454e9068acb5154f222c4a99860091d7c4a6f9953776d0aa95aa48723110d091
lib/definitions/livesync.d.tshttps://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-3d0efe15b0b9d1f1839b17d65770cf34e784337db1e0257fdae7912bc770e0af
View file https://github.com/NativeScript/nativescript-cli/blob/8b7155668b346baefa345bd4cc445c59d55cc8b3/lib/definitions/livesync.d.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/3077/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-3d0efe15b0b9d1f1839b17d65770cf34e784337db1e0257fdae7912bc770e0af
https://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-3d0efe15b0b9d1f1839b17d65770cf34e784337db1e0257fdae7912bc770e0af
lib/services/livesync/livesync-service.tshttps://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-8e0297d83df10101fca70d03d5625c7722dd4615aa5ad1fdf6317c1100d96e1b
View file https://github.com/NativeScript/nativescript-cli/blob/8b7155668b346baefa345bd4cc445c59d55cc8b3/lib/services/livesync/livesync-service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/3077/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-8e0297d83df10101fca70d03d5625c7722dd4615aa5ad1fdf6317c1100d96e1b
https://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-8e0297d83df10101fca70d03d5625c7722dd4615aa5ad1fdf6317c1100d96e1b
https://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-8e0297d83df10101fca70d03d5625c7722dd4615aa5ad1fdf6317c1100d96e1b
https://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-8e0297d83df10101fca70d03d5625c7722dd4615aa5ad1fdf6317c1100d96e1b
https://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-8e0297d83df10101fca70d03d5625c7722dd4615aa5ad1fdf6317c1100d96e1b
https://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-8e0297d83df10101fca70d03d5625c7722dd4615aa5ad1fdf6317c1100d96e1b
https://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-8e0297d83df10101fca70d03d5625c7722dd4615aa5ad1fdf6317c1100d96e1b
https://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-8e0297d83df10101fca70d03d5625c7722dd4615aa5ad1fdf6317c1100d96e1b
https://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-8e0297d83df10101fca70d03d5625c7722dd4615aa5ad1fdf6317c1100d96e1b
test/services/livesync-service.tshttps://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-702eb866ce14d0454ad35a2a7382c72f568eae932cd91945dd2e49aee16278bd
View file https://github.com/NativeScript/nativescript-cli/blob/8b7155668b346baefa345bd4cc445c59d55cc8b3/test/services/livesync-service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/3077/{{ revealButtonHref }}
test/stubs.tshttps://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-dd112d38ea758f19d5a841e5979dd2153713b9f19f0790124b4b8169a60709d9
View file https://github.com/NativeScript/nativescript-cli/blob/8b7155668b346baefa345bd4cc445c59d55cc8b3/test/stubs.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-cli/pull/3077/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-dd112d38ea758f19d5a841e5979dd2153713b9f19f0790124b4b8169a60709d9
https://github.com/NativeScript/nativescript-cli/pull/3077/files#diff-dd112d38ea758f19d5a841e5979dd2153713b9f19f0790124b4b8169a60709d9
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.