René's URL Explorer Experiment


Title: Fix analytics by rosen-vladimirov · Pull Request #2869 · NativeScript/nativescript-cli · GitHub

Open Graph Title: Fix analytics by rosen-vladimirov · Pull Request #2869 · NativeScript/nativescript-cli

X Title: Fix analytics by rosen-vladimirov · Pull Request #2869 · NativeScript/nativescript-cli

Description: Fix analytics, so we'll no longer track information for users, who have not allowed us to do so. There are several problems: Whenever the terminal is not interactive and we do not know if user allows us to track them, we set the value of TrackExceptions to true. Also we immediately send information to Analytics that we've set the value to true. So all CI builds are tracked as new users, as we start a session for them and send the value of TrackExceptions (enabled). setStatus method almost always sends data to Analytics. This method should not send information. It does not care if we have allowed to be tracked - it always sends data. Remove this logic. tns usage-reporting and tns error-reporting always send information to Analytics - in fact the commands are calling "setStatus", that's why they send information. In order to track them, use the "trackFeature" method which will track information ONLY when user had allowed this. Fix getStatus method which had incorrect behavior - the if has been using the values of the enum (0,1,2) and we were getting in the body of the if statement in a very inaccurate cases. Remove unit tests for setStatus and add new ones for checkConsent logic. PR in mobile-cli-lib: telerik/mobile-cli-lib#972

Open Graph Description: Fix analytics, so we'll no longer track information for users, who have not allowed us to do so. There are several problems: Whenever the terminal is not interactive and we do not know if user...

X Description: Fix analytics, so we'll no longer track information for users, who have not allowed us to do so. There are several problems: Whenever the terminal is not interactive and we do not know if ...

Opengraph URL: https://github.com/NativeScript/nativescript-cli/pull/2869

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:47e15d1f-2c1d-262f-b2d8-c3181f9e4134
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC54C:842EC:20EE251:2BDFC47:6B018617
html-safe-nonce2113f85f06819500d54c48bd8d09cdd89c24621a5b32c418002039fb7c786286
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTRDOjg0MkVDOjIwRUUyNTE6MkJERkM0Nzo2QjAxODYxNyIsInZpc2l0b3JfaWQiOiI0NjUwOTE5MDQ3NTI4MDIzNTc1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf65ff3398617d2e003ccd7820fd5539ed4e287b33ff0a12e4a9c18d7aa836717
hovercard-subject-tagpull_request:123607940
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/nativescript-cli/pull/2869/files
twitter:imagehttps://avatars.githubusercontent.com/u/8351653?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8351653?s=400&v=4
og:image:altFix analytics, so we'll no longer track information for users, who have not allowed us to do so. There are several problems: Whenever the terminal is not interactive and we do not know if user...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/nativescript-cli git https://github.com/NativeScript/nativescript-cli.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id21347346
octolytics-dimension-repository_nwoNativeScript/nativescript-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21347346
octolytics-dimension-repository_network_root_nwoNativeScript/nativescript-cli
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/nativescript-cli/pull/2869/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F2869%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-cli%2Fpull%2F2869%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fnativescript-cli
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/2869/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/2869/files
Reloadhttps://github.com/NativeScript/nativescript-cli/pull/2869/files
NativeScripthttps://github.com/NativeScript
nativescript-clihttps://github.com/NativeScript/nativescript-cli
Codehttps://github.com/NativeScript/nativescript-cli
Issues357 (357)https://github.com/NativeScript/nativescript-cli/issues
Pull requests38 (38)https://github.com/NativeScript/nativescript-cli/pulls
Actionshttps://github.com/NativeScript/nativescript-cli/actions
Projectshttps://github.com/NativeScript/nativescript-cli/projects
Security and qualityhttps://github.com/NativeScript/nativescript-cli/security
Insightshttps://github.com/NativeScript/nativescript-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fnativescript-cli%2Fissues%2Fnew%2Fchoose
rosen-vladimirovhttps://github.com/rosen-vladimirov
releasehttps://github.com/NativeScript/nativescript-cli/tree/release
vladimirov/fix-analyticshttps://github.com/NativeScript/nativescript-cli/tree/vladimirov/fix-analytics
Conversation 0 https://github.com/NativeScript/nativescript-cli/pull/2869
Commits 1 https://github.com/NativeScript/nativescript-cli/pull/2869/commits
Checks 0 https://github.com/NativeScript/nativescript-cli/pull/2869/checks
Files changed https://github.com/NativeScript/nativescript-cli/pull/2869/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/2869/files
Fix analytics https://github.com/NativeScript/nativescript-cli/pull/2869/files#top
Show all changes 1 commit https://github.com/NativeScript/nativescript-cli/pull/2869/files
85b018c Fix analytics rosen-vladimirov Jun 1, 2017 https://github.com/NativeScript/nativescript-cli/pull/2869/commits/85b018cb9bf97d34e4ad6d8631db629d3e98cf88
Clear filters https://github.com/NativeScript/nativescript-cli/pull/2869/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/2869/files
Please reload this pagehttps://github.com/NativeScript/nativescript-cli/pull/2869/files
lib/commonhttps://github.com/NativeScript/nativescript-cli/pull/2869/files#diff-3d47a30a80ed97a9879c39c7aa0f13fd8840649148364e47f61d77844ed101bb
Open in desktop https://desktop.github.com
commonhttps://github.com/telerik/mobile-cli-lib
4 files https://github.com/telerik/mobile-cli-lib/compare/ebfdf06c656604551bfd4d261185f10cb7c566af...2ef1887fffc2895959a82bb130867353ef8828e9
commands/analytics.ts https://github.com/telerik/mobile-cli-lib/compare/ebfdf06c656604551bfd4d261185f10cb7c566af...2ef1887fffc2895959a82bb130867353ef8828e9#diff-5e42494001e012a0ed82ea51c44186b5ef8281f520061e96edeaa9e459c05bf5
declarations.d.ts https://github.com/telerik/mobile-cli-lib/compare/ebfdf06c656604551bfd4d261185f10cb7c566af...2ef1887fffc2895959a82bb130867353ef8828e9#diff-8cdfbd695c6c52376c005a5092ea78b549d4d38989bec624f5e294493410deb4
services/analytics-service-base.ts https://github.com/telerik/mobile-cli-lib/compare/ebfdf06c656604551bfd4d261185f10cb7c566af...2ef1887fffc2895959a82bb130867353ef8828e9#diff-aa6cf9b6e7f5a98034fecec1a101206ec7f55038867abf448724a1323ccb8065
test/unit-tests/analytics-service.ts https://github.com/telerik/mobile-cli-lib/compare/ebfdf06c656604551bfd4d261185f10cb7c566af...2ef1887fffc2895959a82bb130867353ef8828e9#diff-a00b0ca440bc15f69f0e899a011f04f680c0a8709b5652b88250acd1c7f278de
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.