Title: Fix cleanup request removal presence check logging · Issue #6090 · NativeScript/nativescript-cli · GitHub
Open Graph Title: Fix cleanup request removal presence check logging · Issue #6090 · NativeScript/nativescript-cli
X Title: Fix cleanup request removal presence check logging · Issue #6090 · NativeScript/nativescript-cli
Description: Summary removeRequest in lib/detached-processes/cleanup-process.ts uses a self-comparison in its existence check: The predicate compares currentRequestInfo with itself, so it evaluates to true whenever the request queue is non-empty. The...
Open Graph Description: Summary removeRequest in lib/detached-processes/cleanup-process.ts uses a self-comparison in its existence check: The predicate compares currentRequestInfo with itself, so it evaluates to true when...
X Description: Summary removeRequest in lib/detached-processes/cleanup-process.ts uses a self-comparison in its existence check: The predicate compares currentRequestInfo with itself, so it evaluates to true when...
Opengraph URL: https://github.com/NativeScript/nativescript-cli/issues/6090
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Fix cleanup request removal presence check logging","articleBody":"## Summary\n`removeRequest` in `lib/detached-processes/cleanup-process.ts` uses a self-comparison in its existence check:\n\n- The predicate compares `currentRequestInfo` with itself, so it evaluates to true whenever the request queue is non-empty.\n- The subsequent `_.remove` call already correctly compares each queued request against the supplied `requestInfo`.\n\nAs a result, removing a request that was never queued can log that it was removed when there are other queued requests. The request list itself is not incorrectly modified; the impact is limited to the success-versus-absent-request log branch.\n\n## Required change\nUpdate the `removeRequest` existence predicate to compare `currentRequestInfo` with the incoming `requestInfo`, matching the predicate used by `_.remove`.\n\n## Affected area\n- `lib/detached-processes/cleanup-process.ts` — `removeRequest`\n\n## Acceptance criteria\n- `removeRequest` selects the successful-removal branch only when an equal queued request exists.\n- Removing an absent request logs the existing “cannot remove … has not been added before” message.\n- Removing an existing request continues to remove it and log the existing successful-removal message.\n\n## Context\n- Reported during PR #6089: https://github.com/NativeScript/nativescript-cli/pull/6089\n- Original review discussion: https://github.com/NativeScript/nativescript-cli/pull/6089#discussion_r3650504137\n- Requested by @edusperoni.","author":{"url":"https://github.com/apps/coderabbitai","@type":"Person","name":"coderabbitai"},"datePublished":"2026-07-25T16:48:13Z","url":"https://github.com/NativeScript/nativescript-cli/issues/6090"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:75e22459-ac2f-250e-ab11-cb3cd3e49cc1 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9016:291B58:247FD29:2E4F432:6B01C193 |
| html-safe-nonce | c558b5c44bb59421ca7331e5a05caf186763900652aba04c11995d3c0a56473b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDE2OjI5MUI1ODoyNDdGRDI5OjJFNEY0MzI6NkIwMUMxOTMiLCJ2aXNpdG9yX2lkIjoiMTY5NjE0MTgxMDI4OTcyMTc0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ede0a340b665d9f7a5b299f17f45b67f0a60c7bb62aa2ef0e1ca99b27b2dd283 |
| hovercard-subject-tag | issue:4976690332 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/NativeScript/nativescript-cli/6090/issue_layout |
| twitter:image | https://opengraph.githubassets.com/844019952c0d3a86ea8cc465e4db0952eb57f7f4c8f0ad4e4c317028e2ad1b96/NativeScript/nativescript-cli/issues/6090 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/844019952c0d3a86ea8cc465e4db0952eb57f7f4c8f0ad4e4c317028e2ad1b96/NativeScript/nativescript-cli/issues/6090 |
| og:image:alt | Summary removeRequest in lib/detached-processes/cleanup-process.ts uses a self-comparison in its existence check: The predicate compares currentRequestInfo with itself, so it evaluates to true when... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | coderabbitai[bot] |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/NativeScript/nativescript-cli git https://github.com/NativeScript/nativescript-cli.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 21347346 |
| octolytics-dimension-repository_nwo | NativeScript/nativescript-cli |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 21347346 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/nativescript-cli |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width