René's URL Explorer Experiment


Title: fix(renderer): dynamic views can't be prepended by edusperoni · Pull Request #2262 · NativeScript/nativescript-angular · GitHub

Open Graph Title: fix(renderer): dynamic views can't be prepended by edusperoni · Pull Request #2262 · NativeScript/nativescript-angular

X Title: fix(renderer): dynamic views can't be prepended by edusperoni · Pull Request #2262 · NativeScript/nativescript-angular

Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/nativescript-angular/blob/master/DevelopmentWorkflow.md#running-the-tests Tests for the changes are included. What is the current behavior? The angular renderer doesn't support adding views to the first position: Result: I come second I come first This is because the renderer treats not having a previous element as needing to append. ViewContainer at position 0. StackLayout is empty, StackLayout now contains ViewContainer at 0 add ng-container before ViewContainer (no previous element). StackLayout now contains [VC,ng-container] (should be the other way around). Doubly linked list references are now broken. add "I come first" before ng-container. [VC, "I come first", ng-container] add "I come second" before ng-container. [VC, "I come second", "I came first", ng-container] (linked list is broken, so it wraps around from ng-container until "I came first") What is the new behavior? ViewContainer at position 0. StackLayout is empty, StackLayout now contains ViewContainer at 0 add ng-container before ViewContainer (no previous element). StackLayout now contains [ng-container,VC] add "I come first" before ng-container. ["I come first", ng-container, VC] add "I come second" before ng-container. ["I come first", "I came second", ng-container, VC] Fixes/Implements/Closes #[Issue Number].

Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...

X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...

Opengraph URL: https://github.com/NativeScript/nativescript-angular/pull/2262

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:113741c6-1a94-9fe6-a5f3-1bb4a0c47c04
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8128:A39F5:23E473D:30A4D4C:696AD43B
html-safe-nonced36816349d92eaed21519831a669a9fc7090da57e4c59fd4d662b4cd98f39c79
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTI4OkEzOUY1OjIzRTQ3M0Q6MzBBNEQ0Qzo2OTZBRDQzQiIsInZpc2l0b3JfaWQiOiI4NTY1OTU0NTQ1ODE0NTI0OTg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacedc5d50f09549b1112f6e338650c3433d191079fec689028d55f619fd07f3f0b
hovercard-subject-tagpull_request:490570744
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/nativescript-angular/pull/2262/files
twitter:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
og:image:altPR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec785f4ce187e9e7331257791b36ddee01625bb8e292a9b4fe2c16d4c006abf5d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/nativescript-angular git https://github.com/NativeScript/nativescript-angular.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id35951404
octolytics-dimension-repository_nwoNativeScript/nativescript-angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id35951404
octolytics-dimension-repository_network_root_nwoNativeScript/nativescript-angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec718a376fcf780eb22089171adb84a543f660bf7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/nativescript-angular/pull/2262/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-angular%2Fpull%2F2262%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-angular%2Fpull%2F2262%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fnativescript-angular
Reloadhttps://github.com/NativeScript/nativescript-angular/pull/2262/files
Reloadhttps://github.com/NativeScript/nativescript-angular/pull/2262/files
Reloadhttps://github.com/NativeScript/nativescript-angular/pull/2262/files
NativeScript https://github.com/NativeScript
nativescript-angularhttps://github.com/NativeScript/nativescript-angular
Please reload this pagehttps://github.com/NativeScript/nativescript-angular/pull/2262/files
Notifications https://github.com/login?return_to=%2FNativeScript%2Fnativescript-angular
Fork 240 https://github.com/login?return_to=%2FNativeScript%2Fnativescript-angular
Star 1.2k https://github.com/login?return_to=%2FNativeScript%2Fnativescript-angular
Code https://github.com/NativeScript/nativescript-angular
Issues 294 https://github.com/NativeScript/nativescript-angular/issues
Pull requests 2 https://github.com/NativeScript/nativescript-angular/pulls
Actions https://github.com/NativeScript/nativescript-angular/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/NativeScript/nativescript-angular/security
Please reload this pagehttps://github.com/NativeScript/nativescript-angular/pull/2262/files
Insights https://github.com/NativeScript/nativescript-angular/pulse
Code https://github.com/NativeScript/nativescript-angular
Issues https://github.com/NativeScript/nativescript-angular/issues
Pull requests https://github.com/NativeScript/nativescript-angular/pulls
Actions https://github.com/NativeScript/nativescript-angular/actions
Security https://github.com/NativeScript/nativescript-angular/security
Insights https://github.com/NativeScript/nativescript-angular/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fnativescript-angular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fnativescript-angular%2Fissues%2Fnew%2Fchoose
NathanWalkerhttps://github.com/NathanWalker
NativeScript:masterhttps://github.com/NativeScript/nativescript-angular/tree/master
edusperoni:renderer-order-fixhttps://github.com/edusperoni/nativescript-angular/tree/renderer-order-fix
Conversation 0 https://github.com/NativeScript/nativescript-angular/pull/2262
Commits 1 https://github.com/NativeScript/nativescript-angular/pull/2262/commits
Checks 0 https://github.com/NativeScript/nativescript-angular/pull/2262/checks
Files changed https://github.com/NativeScript/nativescript-angular/pull/2262/files
Please reload this pagehttps://github.com/NativeScript/nativescript-angular/pull/2262/files
fix(renderer): dynamic views can't be prepended https://github.com/NativeScript/nativescript-angular/pull/2262/files#top
Show all changes 1 commit https://github.com/NativeScript/nativescript-angular/pull/2262/files
02fa2bb fix(renderer): dynamic views can't be prepended edusperoni Sep 21, 2020 https://github.com/NativeScript/nativescript-angular/pull/2262/commits/02fa2bb88b0ef19dcaccb14de3dc270303dbe1c8
Clear filters https://github.com/NativeScript/nativescript-angular/pull/2262/files
Please reload this pagehttps://github.com/NativeScript/nativescript-angular/pull/2262/files
Please reload this pagehttps://github.com/NativeScript/nativescript-angular/pull/2262/files
nativescript-angular/view-util.tshttps://github.com/NativeScript/nativescript-angular/pull/2262/files#diff-ed419a948822acebb39f187d73adc46bcd1cbe3693fb5235d9d84a94f787fe3a
View file https://github.com/edusperoni/nativescript-angular/blob/02fa2bb88b0ef19dcaccb14de3dc270303dbe1c8/nativescript-angular/view-util.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-angular/pull/2262/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-angular/pull/2262/files#diff-ed419a948822acebb39f187d73adc46bcd1cbe3693fb5235d9d84a94f787fe3a
https://github.com/NativeScript/nativescript-angular/pull/2262/files#diff-ed419a948822acebb39f187d73adc46bcd1cbe3693fb5235d9d84a94f787fe3a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.