René's URL Explorer Experiment


Title: fix(list-view): fix crash when used with ngFor by edusperoni · Pull Request #2121 · NativeScript/nativescript-angular · GitHub

Open Graph Title: fix(list-view): fix crash when used with ngFor by edusperoni · Pull Request #2121 · NativeScript/nativescript-angular

X Title: fix(list-view): fix crash when used with ngFor by edusperoni · Pull Request #2121 · NativeScript/nativescript-angular

Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/nativescript-angular/blob/master/DevelopmentWorkflow.md#running-the-tests Tests for the changes are included. What is the current behavior? #1221 (comment) What is the new behavior? ListView now runs CD inside the ngzone, so no more conflicts with NS events occur. Additional information This is a workaround over a possibly more complicated issue: #1221 (comment) Fixes #1221 .

Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...

X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...

Opengraph URL: https://github.com/NativeScript/nativescript-angular/pull/2121

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:01708fac-5f29-3503-3da7-23ad734253e8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF32:3A35C6:10563F4:15CC609:696ACEA3
html-safe-nonce478ced7db19331963819880ffec9f94c0971fe5dc325df688931262868e270de
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjMyOjNBMzVDNjoxMDU2M0Y0OjE1Q0M2MDk6Njk2QUNFQTMiLCJ2aXNpdG9yX2lkIjoiNjA1NTQzMDAyMTA5MTg3MjQxOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac144ca4897b8bfd6967c49bfd0d51129b8e836a1d64409ac83a7f69fd973cf511
hovercard-subject-tagpull_request:374482999
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/nativescript-angular/pull/2121/files
twitter:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
og:image:altPR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec785f4ce187e9e7331257791b36ddee01625bb8e292a9b4fe2c16d4c006abf5d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/nativescript-angular git https://github.com/NativeScript/nativescript-angular.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id35951404
octolytics-dimension-repository_nwoNativeScript/nativescript-angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id35951404
octolytics-dimension-repository_network_root_nwoNativeScript/nativescript-angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec718a376fcf780eb22089171adb84a543f660bf7
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/nativescript-angular/pull/2121/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-angular%2Fpull%2F2121%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-angular%2Fpull%2F2121%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fnativescript-angular
Reloadhttps://github.com/NativeScript/nativescript-angular/pull/2121/files
Reloadhttps://github.com/NativeScript/nativescript-angular/pull/2121/files
Reloadhttps://github.com/NativeScript/nativescript-angular/pull/2121/files
NativeScript https://github.com/NativeScript
nativescript-angularhttps://github.com/NativeScript/nativescript-angular
Please reload this pagehttps://github.com/NativeScript/nativescript-angular/pull/2121/files
Notifications https://github.com/login?return_to=%2FNativeScript%2Fnativescript-angular
Fork 240 https://github.com/login?return_to=%2FNativeScript%2Fnativescript-angular
Star 1.2k https://github.com/login?return_to=%2FNativeScript%2Fnativescript-angular
Code https://github.com/NativeScript/nativescript-angular
Issues 294 https://github.com/NativeScript/nativescript-angular/issues
Pull requests 2 https://github.com/NativeScript/nativescript-angular/pulls
Actions https://github.com/NativeScript/nativescript-angular/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/NativeScript/nativescript-angular/security
Please reload this pagehttps://github.com/NativeScript/nativescript-angular/pull/2121/files
Insights https://github.com/NativeScript/nativescript-angular/pulse
Code https://github.com/NativeScript/nativescript-angular
Issues https://github.com/NativeScript/nativescript-angular/issues
Pull requests https://github.com/NativeScript/nativescript-angular/pulls
Actions https://github.com/NativeScript/nativescript-angular/actions
Security https://github.com/NativeScript/nativescript-angular/security
Insights https://github.com/NativeScript/nativescript-angular/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fnativescript-angular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fnativescript-angular%2Fissues%2Fnew%2Fchoose
NathanWalkerhttps://github.com/NathanWalker
NativeScript:masterhttps://github.com/NativeScript/nativescript-angular/tree/master
edusperoni:zone-fixeshttps://github.com/edusperoni/nativescript-angular/tree/zone-fixes
Conversation 4 https://github.com/NativeScript/nativescript-angular/pull/2121
Commits 10 https://github.com/NativeScript/nativescript-angular/pull/2121/commits
Checks 0 https://github.com/NativeScript/nativescript-angular/pull/2121/checks
Files changed https://github.com/NativeScript/nativescript-angular/pull/2121/files
Please reload this pagehttps://github.com/NativeScript/nativescript-angular/pull/2121/files
fix(list-view): fix crash when used with ngFor https://github.com/NativeScript/nativescript-angular/pull/2121/files#top
Show all changes 10 commits https://github.com/NativeScript/nativescript-angular/pull/2121/files
496c46d fix(list-view): wrap ChangeDetection in ng zone edusperoni Feb 12, 2020 https://github.com/NativeScript/nativescript-angular/pull/2121/commits/496c46d784a742beb527b72cf72f8459a93fcad4
a1caad5 fix(zone): patch AnimationFrame edusperoni Feb 12, 2020 https://github.com/NativeScript/nativescript-angular/pull/2121/commits/a1caad598b21f089149e05f5ee266275066938e9
29c3e8c fix(dialogs): wrap angular calls in ng zone edusperoni Feb 12, 2020 https://github.com/NativeScript/nativescript-angular/pull/2121/commits/29c3e8cdb87c33f5bb4d0008834765d1b44e005e
308dd97 fix missing zone injection edusperoni Feb 12, 2020 https://github.com/NativeScript/nativescript-angular/pull/2121/commits/308dd978cb4b03aed1540e3f673080143ff1e4af
040d93d Merge branch 'master' into zone-fixes NathanWalker Jun 3, 2020 https://github.com/NativeScript/nativescript-angular/pull/2121/commits/040d93db708a9d2edfcc2a74c05bbcebaf7ad17f
7d49a4d chore: bump NathanWalker Sep 3, 2020 https://github.com/NativeScript/nativescript-angular/pull/2121/commits/7d49a4dd2db08309b52119f497e1eb5db11a60e5
9feea4b chore: ng 10.1 and ns 7 NathanWalker Sep 3, 2020 https://github.com/NativeScript/nativescript-angular/pull/2121/commits/9feea4b65672e23b8168b32225193be7ef6dda47
7595d30 Merge branch 'feat/angular-10-1' of https://github.com/NativeScript/n… edusperoni Sep 3, 2020 https://github.com/NativeScript/nativescript-angular/pull/2121/commits/7595d30cbc46152e8a73a39269e44c824d2307de
e7d3faf chore: fix linting edusperoni Sep 3, 2020 https://github.com/NativeScript/nativescript-angular/pull/2121/commits/e7d3faf99e033815897824bce8f713daf81c3b2c
79ce7ce Merge branch 'master' into zone-fixes NathanWalker Sep 4, 2020 https://github.com/NativeScript/nativescript-angular/pull/2121/commits/79ce7cef21c90d4a40c43d299759a2d68728da19
Clear filters https://github.com/NativeScript/nativescript-angular/pull/2121/files
Please reload this pagehttps://github.com/NativeScript/nativescript-angular/pull/2121/files
Please reload this pagehttps://github.com/NativeScript/nativescript-angular/pull/2121/files
dialogs.ts https://github.com/NativeScript/nativescript-angular/pull/2121/files#diff-e2a82b66619a39c346843e7500b4db4eef0ba8d8efd8959a3cad895620512051
list-view-comp.ts https://github.com/NativeScript/nativescript-angular/pull/2121/files#diff-119a80e2c20603a0f24b534a745d184482a6b9437a2160157077d317fa910395
templated-items-comp.ts https://github.com/NativeScript/nativescript-angular/pull/2121/files#diff-a9a6eac16b42fdf75830cb3859f906a97856e8322b0bdf70ea323979000aa6b6
nativescript-angular/directives/dialogs.tshttps://github.com/NativeScript/nativescript-angular/pull/2121/files#diff-e2a82b66619a39c346843e7500b4db4eef0ba8d8efd8959a3cad895620512051
View file https://github.com/edusperoni/nativescript-angular/blob/79ce7cef21c90d4a40c43d299759a2d68728da19/nativescript-angular/directives/dialogs.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-angular/pull/2121/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-angular/pull/2121/files#diff-e2a82b66619a39c346843e7500b4db4eef0ba8d8efd8959a3cad895620512051
https://github.com/NativeScript/nativescript-angular/pull/2121/files#diff-e2a82b66619a39c346843e7500b4db4eef0ba8d8efd8959a3cad895620512051
https://github.com/NativeScript/nativescript-angular/pull/2121/files#diff-e2a82b66619a39c346843e7500b4db4eef0ba8d8efd8959a3cad895620512051
https://github.com/NativeScript/nativescript-angular/pull/2121/files#diff-e2a82b66619a39c346843e7500b4db4eef0ba8d8efd8959a3cad895620512051
https://github.com/NativeScript/nativescript-angular/pull/2121/files#diff-e2a82b66619a39c346843e7500b4db4eef0ba8d8efd8959a3cad895620512051
nativescript-angular/directives/list-view-comp.tshttps://github.com/NativeScript/nativescript-angular/pull/2121/files#diff-119a80e2c20603a0f24b534a745d184482a6b9437a2160157077d317fa910395
View file https://github.com/edusperoni/nativescript-angular/blob/79ce7cef21c90d4a40c43d299759a2d68728da19/nativescript-angular/directives/list-view-comp.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-angular/pull/2121/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-angular/pull/2121/files#diff-119a80e2c20603a0f24b534a745d184482a6b9437a2160157077d317fa910395
nativescript-angular/directives/templated-items-comp.tshttps://github.com/NativeScript/nativescript-angular/pull/2121/files#diff-a9a6eac16b42fdf75830cb3859f906a97856e8322b0bdf70ea323979000aa6b6
View file https://github.com/edusperoni/nativescript-angular/blob/79ce7cef21c90d4a40c43d299759a2d68728da19/nativescript-angular/directives/templated-items-comp.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/nativescript-angular/pull/2121/{{ revealButtonHref }}
https://github.com/NativeScript/nativescript-angular/pull/2121/files#diff-a9a6eac16b42fdf75830cb3859f906a97856e8322b0bdf70ea323979000aa6b6
https://github.com/NativeScript/nativescript-angular/pull/2121/files#diff-a9a6eac16b42fdf75830cb3859f906a97856e8322b0bdf70ea323979000aa6b6
https://github.com/NativeScript/nativescript-angular/pull/2121/files#diff-a9a6eac16b42fdf75830cb3859f906a97856e8322b0bdf70ea323979000aa6b6
https://github.com/NativeScript/nativescript-angular/pull/2121/files#diff-a9a6eac16b42fdf75830cb3859f906a97856e8322b0bdf70ea323979000aa6b6
https://github.com/NativeScript/nativescript-angular/pull/2121/files#diff-a9a6eac16b42fdf75830cb3859f906a97856e8322b0bdf70ea323979000aa6b6
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.