| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:32244078-e696-16c5-f4c6-93ebfcd03450 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BF62:2C8617:37944D:47CB46:697570FA |
| html-safe-nonce | e25ec8deeb209adef1b3f410fbe81639515fe86b0341895d0a0ac1788c285f1d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjYyOjJDODYxNzozNzk0NEQ6NDdDQjQ2OjY5NzU3MEZBIiwidmlzaXRvcl9pZCI6IjI1OTY2MzUwODE3MjM3MDM1NDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 967c8cb3f39efd8d514e7ce30a0fc37fee3c7c3bf33db2a70b32e467ec0806ce |
| hovercard-subject-tag | pull_request:220386459 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/NativeScript/nativescript-angular/1542/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d7859c13f675eff386b7a6b9ad883046540700cd73dcbcff39ed98ee8cb1919a/NativeScript/nativescript-angular/pull/1542 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d7859c13f675eff386b7a6b9ad883046540700cd73dcbcff39ed98ee8cb1919a/NativeScript/nativescript-angular/pull/1542 |
| og:image:alt | PR Checklist
The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | VladimirAmiorkov |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4a4bf5f4e28041a9d2e5c107d7d20b78b4294ba261cab243b28167c16a623a1f |
| turbo-cache-control | no-preview |
| go-import | github.com/NativeScript/nativescript-angular git https://github.com/NativeScript/nativescript-angular.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 35951404 |
| octolytics-dimension-repository_nwo | NativeScript/nativescript-angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 35951404 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/nativescript-angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 488b30e96dfd057fbbe44c6665ccbc030b729dde |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/NativeScript/nativescript-angular/pull/1542#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-angular%2Fpull%2F1542 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-angular%2Fpull%2F1542 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=NativeScript%2Fnativescript-angular |
| Reload | https://github.com/NativeScript/nativescript-angular/pull/1542 |
| Reload | https://github.com/NativeScript/nativescript-angular/pull/1542 |
| Reload | https://github.com/NativeScript/nativescript-angular/pull/1542 |
|
NativeScript
| https://github.com/NativeScript |
| nativescript-angular | https://github.com/NativeScript/nativescript-angular |
| Please reload this page | https://github.com/NativeScript/nativescript-angular/pull/1542 |
|
Notifications
| https://github.com/login?return_to=%2FNativeScript%2Fnativescript-angular |
|
Fork
240
| https://github.com/login?return_to=%2FNativeScript%2Fnativescript-angular |
|
Star
1.2k
| https://github.com/login?return_to=%2FNativeScript%2Fnativescript-angular |
|
Code
| https://github.com/NativeScript/nativescript-angular |
|
Issues
294
| https://github.com/NativeScript/nativescript-angular/issues |
|
Pull requests
2
| https://github.com/NativeScript/nativescript-angular/pulls |
|
Actions
| https://github.com/NativeScript/nativescript-angular/actions |
|
Security
0
| https://github.com/NativeScript/nativescript-angular/security |
|
Insights
| https://github.com/NativeScript/nativescript-angular/pulse |
|
Code
| https://github.com/NativeScript/nativescript-angular |
|
Issues
| https://github.com/NativeScript/nativescript-angular/issues |
|
Pull requests
| https://github.com/NativeScript/nativescript-angular/pulls |
|
Actions
| https://github.com/NativeScript/nativescript-angular/actions |
|
Security
| https://github.com/NativeScript/nativescript-angular/security |
|
Insights
| https://github.com/NativeScript/nativescript-angular/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2FNativeScript%2Fnativescript-angular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2FNativeScript%2Fnativescript-angular%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/NativeScript/nativescript-angular/pull/1542#issue-comment-box |
| vakrilov | https://github.com/vakrilov |
| master | https://github.com/NativeScript/nativescript-angular/tree/master |
| amiorkov/embedded-views-memory-leak-fix | https://github.com/NativeScript/nativescript-angular/tree/amiorkov/embedded-views-memory-leak-fix |
|
fix: Persist the original "parentNode" when "retrieving" the root View created by createEmbeddedView
| https://github.com/NativeScript/nativescript-angular/pull/1542#top |
| vakrilov | https://github.com/vakrilov |
| master | https://github.com/NativeScript/nativescript-angular/tree/master |
| amiorkov/embedded-views-memory-leak-fix | https://github.com/NativeScript/nativescript-angular/tree/amiorkov/embedded-views-memory-leak-fix |
|
Conversation
7
| https://github.com/NativeScript/nativescript-angular/pull/1542 |
|
Commits
3
| https://github.com/NativeScript/nativescript-angular/pull/1542/commits |
|
Checks
0
| https://github.com/NativeScript/nativescript-angular/pull/1542/checks |
|
Files changed
| https://github.com/NativeScript/nativescript-angular/pull/1542/files |
| Please reload this page | https://github.com/NativeScript/nativescript-angular/pull/1542 |
| https://github.co/hiddenchars |
| https://github.com/NativeScript/nativescript-angular/pull/{{ revealButtonHref }} |
|
| https://github.com/VladimirAmiorkov |
| VladimirAmiorkov | https://github.com/VladimirAmiorkov |
| Oct 4, 2018 | https://github.com/NativeScript/nativescript-angular/pull/1542#issue-366802149 |
| https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages | https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages |
| CLA | http://www.nativescript.org/cla |
| https://github.com/NativeScript/nativescript-angular/blob/master/DevelopmentWorkflow.md#running-the-tests | https://github.com/NativeScript/nativescript-angular/blob/master/DevelopmentWorkflow.md#running-the-tests |
| ProgressNS/nativescript-ui-feedback#825 | https://github.com/ProgressNS/nativescript-ui-feedback/issues/825 |
| Please reload this page | https://github.com/NativeScript/nativescript-angular/pull/1542 |
|
| https://github.com/VladimirAmiorkov |
| fix: Persist the original "parentNode" when "retrieving" the root Vie… | https://github.com/NativeScript/nativescript-angular/pull/1542/commits/8fa40a24e7c9f2fd2b9b6f5b235f4bc027989549 |
| 8fa40a2 | https://github.com/NativeScript/nativescript-angular/pull/1542/commits/8fa40a24e7c9f2fd2b9b6f5b235f4bc027989549 |
| https://github.com/VladimirAmiorkov |
| VladimirAmiorkov | https://github.com/VladimirAmiorkov |
| Oct 4, 2018 | https://github.com/NativeScript/nativescript-angular/pull/1542#event-1884687308 |
|
in progress
| https://github.com/NativeScript/nativescript-angular/issues?q=state%3Aopen%20label%3A%22in%20progress%22 |
| Oct 4, 2018 | https://github.com/NativeScript/nativescript-angular/pull/1542#event-1884687457 |
| https://github.com/VladimirAmiorkov |
| VladimirAmiorkov | https://github.com/VladimirAmiorkov |
|
Oct 4, 2018
| https://github.com/NativeScript/nativescript-angular/pull/1542#ref-issue-357064856 |
|
RLV Memory leak in Angular application
ProgressNS/nativescript-ui-feedback#825
| https://github.com/ProgressNS/nativescript-ui-feedback/issues/825 |
| https://github.com/NathanaelA |
| NathanaelA | https://github.com/NathanaelA |
|
Oct 4, 2018
| https://github.com/NativeScript/nativescript-angular/pull/1542#pullrequestreview-161646734 |
|
View reviewed changes
| https://github.com/NativeScript/nativescript-angular/pull/1542/files/8fa40a24e7c9f2fd2b9b6f5b235f4bc027989549 |
| nativescript-angular/element-registry.ts | https://github.com/NativeScript/nativescript-angular/pull/1542/files/8fa40a24e7c9f2fd2b9b6f5b235f4bc027989549#diff-f7ad4896398e4f00ec6bc73c4396445b76f33bceae25dd7caa0954cdf58b941b |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-angular%2Fpull%2F1542 |
| Please reload this page | https://github.com/NativeScript/nativescript-angular/pull/1542 |
| VladimirAmiorkov | https://github.com/VladimirAmiorkov |
| Oct 5, 2018 | https://github.com/NativeScript/nativescript-angular/pull/1542#discussion_r222905927 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @NathanaelA | https://github.com/NathanaelA |
| Please reload this page | https://github.com/NativeScript/nativescript-angular/pull/1542 |
| https://github.com/VladimirAmiorkov |
| VladimirAmiorkov | https://github.com/VladimirAmiorkov |
|
Oct 8, 2018
| https://github.com/NativeScript/nativescript-angular/pull/1542#ref-pullrequest-366802167 |
|
fix: Clear the "view" to avoid left over referenced once the View is detached and should be collected by GC
NativeScript/NativeScript#6353
| https://github.com/NativeScript/NativeScript/pull/6353 |
| VladimirAmiorkov | https://github.com/VladimirAmiorkov |
| October 8, 2018 13:41 | https://github.com/NativeScript/nativescript-angular/pull/1542#commits-pushed-04a2d87 |
|
| https://github.com/VladimirAmiorkov |
| Merge branch 'master' into amiorkov/embedded-views-memory-leak-fix | https://github.com/NativeScript/nativescript-angular/pull/1542/commits/04a2d87a1552f9b52ccdf80e60dbd3673ff9dd4f |
| 04a2d87 | https://github.com/NativeScript/nativescript-angular/pull/1542/commits/04a2d87a1552f9b52ccdf80e60dbd3673ff9dd4f |
|
| https://github.com/SvetoslavTsenov |
| Merge branch 'master' into amiorkov/embedded-views-memory-leak-fix | https://github.com/NativeScript/nativescript-angular/pull/1542/commits/5baae6c8c3f9dc0259b1ca11b0543c1cadf0c56e |
| 5baae6c | https://github.com/NativeScript/nativescript-angular/pull/1542/commits/5baae6c8c3f9dc0259b1ca11b0543c1cadf0c56e |
| SvetoslavTsenov | https://github.com/SvetoslavTsenov |
| Oct 11, 2018 | https://github.com/NativeScript/nativescript-angular/pull/1542#event-1899351076 |
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
|
Oct 17, 2018
| https://github.com/NativeScript/nativescript-angular/pull/1542#pullrequestreview-165471100 |
|
View reviewed changes
| https://github.com/NativeScript/nativescript-angular/pull/1542/files/5baae6c8c3f9dc0259b1ca11b0543c1cadf0c56e |
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
| Oct 17, 2018 | https://github.com/NativeScript/nativescript-angular/pull/1542#issuecomment-430508087 |
| @VladimirAmiorkov | https://github.com/VladimirAmiorkov |
| @sis0k0 | https://github.com/sis0k0 |
| Please reload this page | https://github.com/NativeScript/nativescript-angular/pull/1542 |
| https://github.com/NathanaelA |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-angular%2Fpull%2F1542 |
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
| Oct 17, 2018 | https://github.com/NativeScript/nativescript-angular/pull/1542#issuecomment-430737297 |
| @NathanaelA | https://github.com/NathanaelA |
| @angular | https://github.com/angular |
| Please reload this page | https://github.com/NativeScript/nativescript-angular/pull/1542 |
| https://github.com/NathanaelA |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-angular%2Fpull%2F1542 |
| https://github.com/SvetoslavTsenov |
| SvetoslavTsenov | https://github.com/SvetoslavTsenov |
| Oct 18, 2018 | https://github.com/NativeScript/nativescript-angular/pull/1542#issuecomment-430964851 |
| Please reload this page | https://github.com/NativeScript/nativescript-angular/pull/1542 |
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
| 0b8d2c5 | https://github.com/NativeScript/nativescript-angular/commit/0b8d2c550fa9b2ea95503fbcb7d5c203b1abe3bb |
| Oct 18, 2018 | https://github.com/NativeScript/nativescript-angular/pull/1542#event-1913408360 |
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
| October 18, 2018 21:29 | https://github.com/NativeScript/nativescript-angular/pull/1542#event-1913408453 |
|
in progress
| https://github.com/NativeScript/nativescript-angular/issues?q=state%3Aopen%20label%3A%22in%20progress%22 |
| Oct 18, 2018 | https://github.com/NativeScript/nativescript-angular/pull/1542#event-1913408831 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fnativescript-angular%2Fpull%2F1542 |
|
| https://github.com/NathanaelA |
|
NathanaelA
| https://github.com/NathanaelA |
|
| https://github.com/NativeScript/nativescript-angular/pull/1542/files/8fa40a24e7c9f2fd2b9b6f5b235f4bc027989549 |
|
| https://github.com/vakrilov |
|
vakrilov
| https://github.com/vakrilov |
|
| https://github.com/NativeScript/nativescript-angular/pull/1542/files/5baae6c8c3f9dc0259b1ca11b0543c1cadf0c56e |
|
| https://github.com/SvetoslavTsenov |
|
SvetoslavTsenov
| https://github.com/SvetoslavTsenov |
|
| https://github.com/VladimirAmiorkov |
|
VladimirAmiorkov
| https://github.com/VladimirAmiorkov |
| Please reload this page | https://github.com/NativeScript/nativescript-angular/pull/1542 |
|
| https://github.com/VladimirAmiorkov |
|
| https://github.com/vakrilov |
|
| https://github.com/NathanaelA |
|
| https://github.com/SvetoslavTsenov |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |