René's URL Explorer Experiment


Title: fix(runtime): quiesce in-flight http module loads when a worker terminates by edusperoni · Pull Request #584 · NativeScript/ios · GitHub

Open Graph Title: fix(runtime): quiesce in-flight http module loads when a worker terminates by edusperoni · Pull Request #584 · NativeScript/ios

X Title: fix(runtime): quiesce in-flight http module loads when a worker terminates by edusperoni · Pull Request #584 · NativeScript/ios

Description: What Isolate teardown now actually neutralizes in-flight async HTTP module-graph loads, so terminating a worker while one of its HTTP module fetches is in flight no longer crashes the app. Why ~Runtime invalidates the isolate's Caches first and calls QuiesceModuleLoadsForIsolate afterwards, still before the event loop shuts down and the isolate is disposed. KillAsyncGraphLoadsForIsolate found the loader state through Caches::StateFor, which returns null once the isolate has been invalidated. So the quiesce did nothing: in-flight AsyncGraphLoads were not marked dead, and their v8::Global handles were not reset. When the fetch finished later, the NSURLSession completion released the last reference to the load on the delegate queue. That destroyed the Global after the isolate was gone, crashing with V8_Fatal in GlobalHandles::NodeSpace::Release (EXC_BREAKPOINT, on com.apple.NSURLSession-delegate). The fix looks the state up with Caches::ExistingStateFor, which still returns it after invalidation. That is the only module-loader lookup on the quiesce path. How it was verified New spec, HTTP ESM Loader > HTTP Fetch Integration > worker teardown. It starts 5 workers, and each does a dynamic import() of a 2 s delayed HTTP module and reports once the fetch is in flight. Each worker is terminated on that report. The main isolate then imports a 3 s delayed HTTP module, so it settles only after every worker response has landed, and the spec asserts that import resolves. Without the fix, the app crashed during the run with no junit report. The crash report's faulting thread was the NSURLSession delegate queue, with ~AsyncGraphLoad → Global::~Global → GlobalHandles::NodeSpace::Release → V8_Fatal, reached from the fetch-completion lambda. With the fix, the spec passes and the full simulator suite reports 2157 test cases, 0 failures, 11 skipped (main plus this one spec). Summary by CodeRabbit Bug Fixes Improved reliability of delayed HTTP module imports when workers are terminated. In-flight imports from terminated workers are now handled without disrupting subsequent imports, allowing a separate import on the main thread to resolve successfully.

Open Graph Description: What Isolate teardown now actually neutralizes in-flight async HTTP module-graph loads, so terminating a worker while one of its HTTP module fetches is in flight no longer crashes the app. Why ~Run...

X Description: What Isolate teardown now actually neutralizes in-flight async HTTP module-graph loads, so terminating a worker while one of its HTTP module fetches is in flight no longer crashes the app. Why ~Run...

Opengraph URL: https://github.com/NativeScript/ios/pull/584

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:60f1c0b3-07f1-42c7-a60d-9721ca84b236
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE6C:19F84C:1E48C5D:2690910:6B014EB6
html-safe-nonce76a12fe205307653b9f2ffc59f359dc92c04de5f007eb7505529e32709871d20
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTZDOjE5Rjg0QzoxRTQ4QzVEOjI2OTA5MTA6NkIwMTRFQjYiLCJ2aXNpdG9yX2lkIjoiNzI1Nzk1NTA1MjIxNDYzNjIxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6a2a9b6a8c9995707fc5cf7a9d0d8539addaa685cb6f199906ac7715c6413920
hovercard-subject-tagpull_request:5406755163
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/ios/pull/584/files
twitter:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
og:image:altWhat Isolate teardown now actually neutralizes in-flight async HTTP module-graph loads, so terminating a worker while one of its HTTP module fetches is in flight no longer crashes the app. Why ~Run...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/ios git https://github.com/NativeScript/ios.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id172934359
octolytics-dimension-repository_nwoNativeScript/ios
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id172934359
octolytics-dimension-repository_network_root_nwoNativeScript/ios
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/ios/pull/584/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fios%2Fpull%2F584%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fios%2Fpull%2F584%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fios
Reloadhttps://github.com/NativeScript/ios/pull/584/files
Reloadhttps://github.com/NativeScript/ios/pull/584/files
Reloadhttps://github.com/NativeScript/ios/pull/584/files
NativeScripthttps://github.com/NativeScript
ioshttps://github.com/NativeScript/ios
Codehttps://github.com/NativeScript/ios
Issues56 (56)https://github.com/NativeScript/ios/issues
Pull requests42 (42)https://github.com/NativeScript/ios/pulls
Actionshttps://github.com/NativeScript/ios/actions
Projectshttps://github.com/NativeScript/ios/projects
Security and qualityhttps://github.com/NativeScript/ios/security
Insightshttps://github.com/NativeScript/ios/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fios%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fios%2Fissues%2Fnew%2Fchoose
edusperonihttps://github.com/edusperoni
mainhttps://github.com/NativeScript/ios/tree/main
fix/worker-teardown-http-module-loadshttps://github.com/NativeScript/ios/tree/fix/worker-teardown-http-module-loads
Conversation 1 https://github.com/NativeScript/ios/pull/584
Commits 1 https://github.com/NativeScript/ios/pull/584/commits
Checks 11 https://github.com/NativeScript/ios/pull/584/checks
Files changed https://github.com/NativeScript/ios/pull/584/files
Please reload this pagehttps://github.com/NativeScript/ios/pull/584/files
fix(runtime): quiesce in-flight http module loads when a worker terminates https://github.com/NativeScript/ios/pull/584/files#top
Show all changes 1 commit https://github.com/NativeScript/ios/pull/584/files
20d239c fix(runtime): quiesce in-flight http module loads when a worker termi… edusperoni Nov 20, 2026 https://github.com/NativeScript/ios/pull/584/commits/20d239c596c222dcae667c44118b11d86eb15007
Clear filters https://github.com/NativeScript/ios/pull/584/files
Please reload this pagehttps://github.com/NativeScript/ios/pull/584/files
Please reload this pagehttps://github.com/NativeScript/ios/pull/584/files
ModuleInternalCallbacks.mm https://github.com/NativeScript/ios/pull/584/files#diff-c89d1600a067dc2d44dd53c14a0b7e31ed1724f8e406f7e785338534c0a2ebc5
HttpEsmLoaderTests.js https://github.com/NativeScript/ios/pull/584/files#diff-a1161773c959dd71db23598811c79bd406fee1bd5f98bda3afdd67d97a3d2d41
httpImportTerminateWorker.js https://github.com/NativeScript/ios/pull/584/files#diff-78fc10737e0b93ad521d89aa35a34b361a3eef060c620824f40d69f036fc7c61
NativeScript/runtime/ModuleInternalCallbacks.mmhttps://github.com/NativeScript/ios/pull/584/files#diff-c89d1600a067dc2d44dd53c14a0b7e31ed1724f8e406f7e785338534c0a2ebc5
View file https://github.com/NativeScript/ios/blob/20d239c596c222dcae667c44118b11d86eb15007/NativeScript/runtime/ModuleInternalCallbacks.mm
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/ios/pull/584/{{ revealButtonHref }}
https://github.com/NativeScript/ios/pull/584/files#diff-c89d1600a067dc2d44dd53c14a0b7e31ed1724f8e406f7e785338534c0a2ebc5
https://github.com/NativeScript/ios/pull/584/files#diff-c89d1600a067dc2d44dd53c14a0b7e31ed1724f8e406f7e785338534c0a2ebc5
TestRunner/app/tests/HttpEsmLoaderTests.jshttps://github.com/NativeScript/ios/pull/584/files#diff-a1161773c959dd71db23598811c79bd406fee1bd5f98bda3afdd67d97a3d2d41
View file https://github.com/NativeScript/ios/blob/20d239c596c222dcae667c44118b11d86eb15007/TestRunner/app/tests/HttpEsmLoaderTests.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/ios/pull/584/{{ revealButtonHref }}
https://github.com/NativeScript/ios/pull/584/files#diff-a1161773c959dd71db23598811c79bd406fee1bd5f98bda3afdd67d97a3d2d41
https://github.com/NativeScript/ios/pull/584/files#diff-a1161773c959dd71db23598811c79bd406fee1bd5f98bda3afdd67d97a3d2d41
TestRunner/app/tests/httpImportTerminateWorker.jshttps://github.com/NativeScript/ios/pull/584/files#diff-78fc10737e0b93ad521d89aa35a34b361a3eef060c620824f40d69f036fc7c61
View file https://github.com/NativeScript/ios/blob/20d239c596c222dcae667c44118b11d86eb15007/TestRunner/app/tests/httpImportTerminateWorker.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/ios/pull/584/{{ revealButtonHref }}
Please reload this pagehttps://github.com/NativeScript/ios/pull/584/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.