René's URL Explorer Experiment


Title: fix(runtime): release wrappers made for JS methods called from native code by edusperoni · Pull Request #564 · NativeScript/ios · GitHub

Open Graph Title: fix(runtime): release wrappers made for JS methods called from native code by edusperoni · Pull Request #564 · NativeScript/ios

X Title: fix(runtime): release wrappers made for JS methods called from native code by edusperoni · Pull Request #564 · NativeScript/ios

Description: NativeScript for iOS and visionOS using V8. Contribute to NativeScript/ios development by creating an account on GitHub.

Open Graph Description: What Fixes several leaks where the runtime retained native objects, and the JS that referenced them, forever. The most visible case is @nativescript/core's ListView: every ListViewCell (and eve...

X Description: What Fixes several leaks where the runtime retained native objects, and the JS that referenced them, forever. The most visible case is @nativescript/core's ListView: every ListViewCell (and...

Opengraph URL: https://github.com/NativeScript/ios/pull/564

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:17b35f80-4757-4872-c742-2fa73bff7e56
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id99E8:19AA62:12A3A94:17B3FBA:6B012053
html-safe-noncebbee57396271838b28a19625666d0716782db4babc0ab38418b3e153a4d83350
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUU4OjE5QUE2MjoxMkEzQTk0OjE3QjNGQkE6NkIwMTIwNTMiLCJ2aXNpdG9yX2lkIjoiMzYyNjYwMjk0Njk2MTE1NDEzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca9a6ed9513119323ebfe0961e390136c3895c93f8eb1c9786b399fa102a92557
hovercard-subject-tagpull_request:5301210414
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/NativeScript/ios/564/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/59c602ef23c81891b6154c56a5949676714461eb7846b076eaff8c442f6cf8ac/NativeScript/ios/pull/564
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/59c602ef23c81891b6154c56a5949676714461eb7846b076eaff8c442f6cf8ac/NativeScript/ios/pull/564
og:image:altWhat Fixes several leaks where the runtime retained native objects, and the JS that referenced them, forever. The most visible case is @nativescript/core's ListView: every ListViewCell (and eve...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameedusperoni
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/NativeScript/ios git https://github.com/NativeScript/ios.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id172934359
octolytics-dimension-repository_nwoNativeScript/ios
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id172934359
octolytics-dimension-repository_network_root_nwoNativeScript/ios
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/NativeScript/ios/pull/564#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fios%2Fpull%2F564
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fios%2Fpull%2F564
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=NativeScript%2Fios
Reloadhttps://github.com/NativeScript/ios/pull/564
Reloadhttps://github.com/NativeScript/ios/pull/564
Reloadhttps://github.com/NativeScript/ios/pull/564
NativeScripthttps://github.com/NativeScript
ioshttps://github.com/NativeScript/ios
Codehttps://github.com/NativeScript/ios
Issues56 (56)https://github.com/NativeScript/ios/issues
Pull requests42 (42)https://github.com/NativeScript/ios/pulls
Actionshttps://github.com/NativeScript/ios/actions
Projectshttps://github.com/NativeScript/ios/projects
Security and qualityhttps://github.com/NativeScript/ios/security
Insightshttps://github.com/NativeScript/ios/insights
https://github.com/NativeScript/ios
edusperonihttps://github.com/edusperoni
mainhttps://github.com/NativeScript/ios/tree/main
fix/js-method-self-wraphttps://github.com/NativeScript/ios/tree/fix/js-method-self-wrap
Conversationhttps://github.com/NativeScript/ios/pull/564
Commits4 (4)https://github.com/NativeScript/ios/pull/564/commits
Checkshttps://github.com/NativeScript/ios/pull/564/checks
Files changedhttps://github.com/NativeScript/ios/pull/564/files
fix(runtime): release wrappers made for JS methods called from native codehttps://github.com/NativeScript/ios/pull/564#top
edusperonihttps://github.com/edusperoni
mainhttps://github.com/NativeScript/ios/tree/main
fix/js-method-self-wraphttps://github.com/NativeScript/ios/tree/fix/js-method-self-wrap
https://github.com/edusperoni
edusperonihttps://github.com/edusperoni
Nov 13, 2026https://github.com/NativeScript/ios/pull/564#issue-6378020191
Please reload this pagehttps://github.com/NativeScript/ios/pull/564
#566https://github.com/NativeScript/ios/issues/566
#566https://github.com/NativeScript/ios/issues/566
#311https://github.com/NativeScript/ios/pull/311
#409https://github.com/NativeScript/ios/pull/409
Please reload this pagehttps://github.com/NativeScript/ios/pull/564
https://github.com/edusperoni
fix(runtime): release wrappers made for JS methods called from native…https://github.com/NativeScript/ios/pull/564/commits/dccd5fcb9d87fc7a06b597b49944141128df77ad
dccd5fchttps://github.com/NativeScript/ios/pull/564/commits/dccd5fcb9d87fc7a06b597b49944141128df77ad
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Nov 13, 2026https://github.com/NativeScript/ios/pull/564#issuecomment-6862205619
Please reload this pagehttps://github.com/NativeScript/ios/pull/564
https://app.coderabbit.ai/change-stack/NativeScript/ios/pull/564?scope=ghh_OusAJGA4HG8ljoOV0wJvVx8NmnZIjc2DdjmxOu0xZWA&cs_source=review_comment
https://camo.githubusercontent.com/52c6b786492f6f8748feb782ecaf3a1d3152ec095001b1a26170cc7cbe533212/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f636f64657261626269745f7075626c69635f6173736574732f7072652d6d657267652d636865636b732d7061737365642e737667
https://camo.githubusercontent.com/52c6b786492f6f8748feb782ecaf3a1d3152ec095001b1a26170cc7cbe533212/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f636f64657261626269745f7075626c69635f6173736574732f7072652d6d657267652d636865636b732d7061737365642e737667
https://camo.githubusercontent.com/52c6b786492f6f8748feb782ecaf3a1d3152ec095001b1a26170cc7cbe533212/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f636f64657261626269745f7075626c69635f6173736574732f7072652d6d657267652d636865636b732d7061737365642e737667
https://camo.githubusercontent.com/52c6b786492f6f8748feb782ecaf3a1d3152ec095001b1a26170cc7cbe533212/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f636f64657261626269745f7075626c69635f6173736574732f7072652d6d657267652d636865636b732d7061737365642e737667
CodeRabbithttps://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=NativeScript/ios&utm_content=564
Xhttps://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai
Mastodonhttps://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai
Reddithttps://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai
LinkedInhttps://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code
Please reload this pagehttps://github.com/NativeScript/ios/pull/564
https://github.com/edusperoni
edusperonihttps://github.com/edusperoni
November 13, 2026 19:02https://github.com/NativeScript/ios/pull/564#event-36063944230
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Nov 13, 2026 https://github.com/NativeScript/ios/pull/564#pullrequestreview-5896655946
View reviewed changes https://github.com/NativeScript/ios/pull/564/files/dccd5fcb9d87fc7a06b597b49944141128df77ad
coderabbitaihttps://github.com/apps/coderabbitai
https://github.com/NativeScript/ios/pull/564#pullrequestreview-5896655946
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
95b52afhttps://github.com/NativeScript/ios/commit/95b52affd694bb0d933b3b81820c14ddc5e47341
dccd5fchttps://github.com/NativeScript/ios/commit/dccd5fcb9d87fc7a06b597b49944141128df77ad
Please reload this pagehttps://github.com/NativeScript/ios/pull/564
NativeScript/runtime/ArgConverter.mmhttps://github.com/NativeScript/ios/pull/564/files/dccd5fcb9d87fc7a06b597b49944141128df77ad#diff-65a98e0ce763ac29ef9ed8dd75b8b8d92447c04ffc1bfb5df78f5d33b67e2091
Please reload this pagehttps://github.com/NativeScript/ios/pull/564
NativeScript/runtime/ArgConverter.mmhttps://github.com/NativeScript/ios/pull/564/files/dccd5fcb9d87fc7a06b597b49944141128df77ad#diff-65a98e0ce763ac29ef9ed8dd75b8b8d92447c04ffc1bfb5df78f5d33b67e2091
Please reload this pagehttps://github.com/NativeScript/ios/pull/564
https://github.com/edusperoni
fix(runtime): address review of the self-wrap leak fixhttps://github.com/NativeScript/ios/pull/564/commits/01082bc8d3047f874a0787eb0239ec2c13a5e490
01082bchttps://github.com/NativeScript/ios/pull/564/commits/01082bc8d3047f874a0787eb0239ec2c13a5e490
https://github.com/edusperoni
edusperonihttps://github.com/edusperoni
Nov 13, 2026 https://github.com/NativeScript/ios/pull/564#ref-issue-6378848905
Owned instance-method returns that hit a cached wrapper leak a retain (immutable copy, alloc().init() with a JS initializer) #566 https://github.com/NativeScript/ios/issues/566
https://github.com/edusperoni
edusperonihttps://github.com/edusperoni
Nov 14, 2026https://github.com/NativeScript/ios/pull/564#issuecomment-6880738964
@coderabbitaihttps://github.com/coderabbitai
Please reload this pagehttps://github.com/NativeScript/ios/pull/564
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Nov 14, 2026https://github.com/NativeScript/ios/pull/564#issuecomment-6880740595
Please reload this pagehttps://github.com/NativeScript/ios/pull/564
Please reload this pagehttps://github.com/NativeScript/ios/pull/564
edusperonihttps://github.com/edusperoni
November 14, 2026 15:04https://github.com/NativeScript/ios/pull/564#commits-pushed-ee736af
https://github.com/edusperoni
fix(runtime): keep JS overrides out of receiver wrapping, own init re…https://github.com/NativeScript/ios/pull/564/commits/ee736af3ca73cf8582b0d873576932b85196a02f
ee736afhttps://github.com/NativeScript/ios/pull/564/commits/ee736af3ca73cf8582b0d873576932b85196a02f
#566https://github.com/NativeScript/ios/issues/566
https://github.com/edusperoni
refactor(runtime): drop the unused skipGCRegistration parameterhttps://github.com/NativeScript/ios/pull/564/commits/ad6045afdf5e2d8d5f6b408cd841c188bed171f0
ad6045ahttps://github.com/NativeScript/ios/pull/564/commits/ad6045afdf5e2d8d5f6b408cd841c188bed171f0
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Nov 14, 2026 https://github.com/NativeScript/ios/pull/564#pullrequestreview-5906293108
View reviewed changes https://github.com/NativeScript/ios/pull/564/files/ad6045afdf5e2d8d5f6b408cd841c188bed171f0
coderabbitaihttps://github.com/apps/coderabbitai
https://github.com/NativeScript/ios/pull/564#pullrequestreview-5906293108
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
dccd5fchttps://github.com/NativeScript/ios/commit/dccd5fcb9d87fc7a06b597b49944141128df77ad
ad6045ahttps://github.com/NativeScript/ios/commit/ad6045afdf5e2d8d5f6b408cd841c188bed171f0
Please reload this pagehttps://github.com/NativeScript/ios/pull/564
NativeScript/runtime/ArgConverter.mmhttps://github.com/NativeScript/ios/pull/564/files/ad6045afdf5e2d8d5f6b408cd841c188bed171f0#diff-65a98e0ce763ac29ef9ed8dd75b8b8d92447c04ffc1bfb5df78f5d33b67e2091
coderabbitaihttps://github.com/apps/coderabbitai
Nov 14, 2026https://github.com/NativeScript/ios/pull/564#discussion_r4575042564
Please reload this pagehttps://github.com/NativeScript/ios/pull/564
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/NativeScript/ios/pull/564
edusperonihttps://github.com/edusperoni
Nov 14, 2026https://github.com/NativeScript/ios/pull/564#discussion_r4575102755
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/NativeScript/ios/pull/564
NativeScript/runtime/ArgConverter.mmhttps://github.com/NativeScript/ios/pull/564/files/ad6045afdf5e2d8d5f6b408cd841c188bed171f0#diff-65a98e0ce763ac29ef9ed8dd75b8b8d92447c04ffc1bfb5df78f5d33b67e2091
Please reload this pagehttps://github.com/NativeScript/ios/pull/564
https://github.com/edusperoni
edusperonihttps://github.com/edusperoni
Nov 14, 2026 https://github.com/NativeScript/ios/pull/564#ref-issue-6394289951
this.super keeps a raw pointer to the receiver's wrapper and can outlive it #568 https://github.com/NativeScript/ios/issues/568
https://github.com/edusperoni
edusperonihttps://github.com/edusperoni
Nov 14, 2026https://github.com/NativeScript/ios/pull/564#issuecomment-6882262110
@coderabbitaihttps://github.com/coderabbitai
Please reload this pagehttps://github.com/NativeScript/ios/pull/564
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Nov 14, 2026https://github.com/NativeScript/ios/pull/564#issuecomment-6882273640
review instructionshttps://docs.coderabbit.ai/guides/review-instructions
apphttps://app.coderabbit.ai/learnings
Please reload this pagehttps://github.com/NativeScript/ios/pull/564
https://github.com/edusperoni
edusperonihttps://github.com/edusperoni
b1fc316https://github.com/NativeScript/ios/commit/b1fc316a172aad3206427c9f64b4356068b95374
Nov 14, 2026https://github.com/NativeScript/ios/pull/564#event-36143567203
Please reload this pagehttps://github.com/NativeScript/ios/pull/564
https://github.com/edusperoni
edusperonihttps://github.com/edusperoni
November 14, 2026 18:35https://github.com/NativeScript/ios/pull/564#event-36143568984
fix(runtime): release owned instance-method returns that hit a cached wrapper #569 https://github.com/NativeScript/ios/pull/569
fix(runtime): make this.super aliases resolve their receiver's wrapper at use #570 https://github.com/NativeScript/ios/pull/570
fix(runtime): run JS property accessors on the instance native code called #575 https://github.com/NativeScript/ios/pull/575
perf(runtime): cache the instance prototype per class meta #535 https://github.com/NativeScript/ios/pull/535
fix(runtime): release native objects on the runtime's thread #560 https://github.com/NativeScript/ios/pull/560
feat(runtime): rooted wrapper lifetime mode #559 https://github.com/NativeScript/ios/pull/559
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Nov 18, 2026 https://github.com/NativeScript/ios/pull/564#ref-pullrequest-6459914494
fix(runtime): read only the native retainCount when checking who owns a wrapped object #579 https://github.com/NativeScript/ios/pull/579
https://github.co/hiddenchars
https://github.com/NativeScript/ios/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fios%2Fpull%2F564
https://github.com/apps/coderabbitai
coderabbitai[bot] https://github.com/apps/coderabbitai
https://github.com/NativeScript/ios/pull/564/files/ad6045afdf5e2d8d5f6b408cd841c188bed171f0
Please reload this pagehttps://github.com/NativeScript/ios/pull/564
Please reload this pagehttps://github.com/NativeScript/ios/pull/564
https://github.com/edusperoni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.