| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:aadaec32-b143-5f5a-91e9-e5ebbbfeb5e2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C660:134361:1635DDC:1D392C3:6B012E4D |
| html-safe-nonce | c4d42a6d8e7d31ec35308c7f44aa9ab389f4260fad7d2db4019e33c261a53310 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjYwOjEzNDM2MToxNjM1RERDOjFEMzkyQzM6NkIwMTJFNEQiLCJ2aXNpdG9yX2lkIjoiMTIzMjY1Nzk0MDk1OTU5ODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2752780f6d4fcaf8de7e628e0374d07e421e88016f09270200c5ac4515cfbbea |
| hovercard-subject-tag | pull_request:4557603494 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/NativeScript/ios/478/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0f46137b5367d875aa16ee0caab43cc504bb4f2f879afd97ff12fa50b828865b/NativeScript/ios/pull/478 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0f46137b5367d875aa16ee0caab43cc504bb4f2f879afd97ff12fa50b828865b/NativeScript/ios/pull/478 |
| og:image:alt | A worker whose entry script sets a throwing onclose and then calls close() crashes the app:
onclose = () => { throw new Error("boom"); };
close();
CloseWorkerCallback reports the error... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | adrian-niculescu |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/NativeScript/ios git https://github.com/NativeScript/ios.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 172934359 |
| octolytics-dimension-repository_nwo | NativeScript/ios |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 172934359 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/ios |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/NativeScript/ios/pull/478#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fios%2Fpull%2F478 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fios%2Fpull%2F478 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=NativeScript%2Fios |
| Reload | https://github.com/NativeScript/ios/pull/478 |
| Reload | https://github.com/NativeScript/ios/pull/478 |
| Reload | https://github.com/NativeScript/ios/pull/478 |
| NativeScript | https://github.com/NativeScript |
| ios | https://github.com/NativeScript/ios |
| Code | https://github.com/NativeScript/ios |
| Issues56 (56) | https://github.com/NativeScript/ios/issues |
| Pull requests42 (42) | https://github.com/NativeScript/ios/pulls |
| Actions | https://github.com/NativeScript/ios/actions |
| Projects | https://github.com/NativeScript/ios/projects |
| Security and quality | https://github.com/NativeScript/ios/security |
| Insights | https://github.com/NativeScript/ios/insights |
| https://github.com/NativeScript/ios |
| edusperoni | https://github.com/edusperoni |
| NativeScript:main | https://github.com/NativeScript/ios/tree/main |
| adrian-niculescu:fix/worker-terminate-and-ended-races | https://github.com/adrian-niculescu/NativeScript-iOS/tree/fix/worker-terminate-and-ended-races |
| Conversation | https://github.com/NativeScript/ios/pull/478 |
| Commits4 (4) | https://github.com/NativeScript/ios/pull/478/commits |
| Checks | https://github.com/NativeScript/ios/pull/478/checks |
| Files changed | https://github.com/NativeScript/ios/pull/478/files |
| fix(worker): isolate and wrapper lifetime fixes around startup and teardown | https://github.com/NativeScript/ios/pull/478#top |
| edusperoni | https://github.com/edusperoni |
| NativeScript:main | https://github.com/NativeScript/ios/tree/main |
| adrian-niculescu:fix/worker-terminate-and-ended-races | https://github.com/adrian-niculescu/NativeScript-iOS/tree/fix/worker-terminate-and-ended-races |
|
| https://github.com/adrian-niculescu |
| adrian-niculescu | https://github.com/adrian-niculescu |
| Sep 17, 2026 | https://github.com/NativeScript/ios/pull/478#issue-5486399434 |
| Please reload this page | https://github.com/NativeScript/ios/pull/478 |
| Please reload this page | https://github.com/NativeScript/ios/pull/478 |
|
| https://github.com/adrian-niculescu |
| fix(worker): isolate and wrapper lifetime fixes around startup and te… | https://github.com/NativeScript/ios/pull/478/commits/6d8e58bd2ececf6e3830339f051b6ad2fb7fb08a |
| 6d8e58b | https://github.com/NativeScript/ios/pull/478/commits/6d8e58bd2ececf6e3830339f051b6ad2fb7fb08a |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
| Sep 17, 2026 | https://github.com/NativeScript/ios/pull/478#issuecomment-5713194358 |
| Please reload this page | https://github.com/NativeScript/ios/pull/478 |
| https://app.coderabbit.ai/change-stack/NativeScript/ios/pull/478#gh-light-mode-only |
| https://app.coderabbit.ai/change-stack/NativeScript/ios/pull/478#gh-dark-mode-only |
| Check out review usage here | https://app.coderabbit.ai/dashboard/review-capacity?orgId=afc69ef0-445c-4859-9557-1d9ea919e3f0 |
| Learn how review limits work | https://docs.coderabbit.ai/management/plans#rate-limits |
| 6d8e58b | https://github.com/NativeScript/ios/commit/6d8e58bd2ececf6e3830339f051b6ad2fb7fb08a |
| 70769c4 | https://github.com/NativeScript/ios/commit/70769c4b99a826a055ff1721c6631bf096b52b19 |
| CodeRabbit | https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=NativeScript/ios&utm_content=478 |
| X | https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai |
| Mastodon | https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai |
| Reddit | https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai |
| LinkedIn | https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code |
| Please reload this page | https://github.com/NativeScript/ios/pull/478 |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
|
Sep 17, 2026
| https://github.com/NativeScript/ios/pull/478#pullrequestreview-5234716395 |
|
View reviewed changes
| https://github.com/NativeScript/ios/pull/478/files/6d8e58bd2ececf6e3830339f051b6ad2fb7fb08a |
| coderabbitai | https://github.com/apps/coderabbitai |
| https://github.com/NativeScript/ios/pull/478#pullrequestreview-5234716395 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 6221ca8 | https://github.com/NativeScript/ios/commit/6221ca82e670eaa5a4bc8270090fccb55894b7df |
| 6d8e58b | https://github.com/NativeScript/ios/commit/6d8e58bd2ececf6e3830339f051b6ad2fb7fb08a |
| Please reload this page | https://github.com/NativeScript/ios/pull/478 |
| https://github.com/adrian-niculescu |
| adrian-niculescu | https://github.com/adrian-niculescu |
| Sep 17, 2026 | https://github.com/NativeScript/ios/pull/478#issuecomment-5713588585 |
| Please reload this page | https://github.com/NativeScript/ios/pull/478 |
| @coderabbitai | https://github.com/coderabbitai |
| Please reload this page | https://github.com/NativeScript/ios/pull/478 |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
| Sep 17, 2026 | https://github.com/NativeScript/ios/pull/478#issuecomment-5713631613 |
| review instructions | https://docs.coderabbit.ai/guides/review-instructions |
| app | https://app.coderabbit.ai/learnings |
| X | https://twitter.com/intent/tweet?related=CodeRabbitAI&text=%40coderabbitai%20caught%20a%20teardown%20race%3A%20locking%20queue%20signaling%20prevents%20use-after-release%2C%20while%20worker-side%20termination%20avoids%20stopping%20an%20exited%20run%20loop.%20Safer%20concurrency%E2%80%94try%20it%20%F0%9F%9A%80&url=https%3A%2F%2Fgithub.com%2FNativeScript%2Fios%2Fpull%2F478 |
| Please reload this page | https://github.com/NativeScript/ios/pull/478 |
|
| https://github.com/adrian-niculescu |
| fix(worker): serialize the message queue's run loop source with its t… | https://github.com/NativeScript/ios/pull/478/commits/1965a835bbd9e45ec1b6ade5766f8d210499503c |
| 1965a83 | https://github.com/NativeScript/ios/pull/478/commits/1965a835bbd9e45ec1b6ade5766f8d210499503c |
| https://github.com/adrian-niculescu |
| adrian-niculescu | https://github.com/adrian-niculescu |
| force-pushed | https://github.com/NativeScript/ios/compare/a0edb4cec5f4a76d7f45a3f29b3417373ca0bc6d..1965a835bbd9e45ec1b6ade5766f8d210499503c |
| a0edb4c | https://github.com/NativeScript/ios/commit/a0edb4cec5f4a76d7f45a3f29b3417373ca0bc6d |
| 1965a83 | https://github.com/NativeScript/ios/commit/1965a835bbd9e45ec1b6ade5766f8d210499503c |
|
Compare
| https://github.com/NativeScript/ios/compare/a0edb4cec5f4a76d7f45a3f29b3417373ca0bc6d..1965a835bbd9e45ec1b6ade5766f8d210499503c |
| September 17, 2026 11:46 | https://github.com/NativeScript/ios/pull/478#event-31316459019 |
| edusperoni | https://github.com/edusperoni |
| October 5, 2026 14:57 | https://github.com/NativeScript/ios/pull/478#commits-pushed-9a35ea8 |
|
| https://github.com/edusperoni |
| Merge remote-tracking branch 'origin/main' into fix/worker-terminate-… | https://github.com/NativeScript/ios/pull/478/commits/9a35ea8b22c12383eb1cc1b7ba5ff5657eedde51 |
| 9a35ea8 | https://github.com/NativeScript/ios/pull/478/commits/9a35ea8b22c12383eb1cc1b7ba5ff5657eedde51 |
|
| https://github.com/edusperoni |
| refactor(worker): rename the queue's run loop mutex and scope the iso… | https://github.com/NativeScript/ios/pull/478/commits/70769c4b99a826a055ff1721c6631bf096b52b19 |
| 70769c4 | https://github.com/NativeScript/ios/pull/478/commits/70769c4b99a826a055ff1721c6631bf096b52b19 |
| https://github.com/edusperoni |
| edusperoni | https://github.com/edusperoni |
| e146d4e | https://github.com/NativeScript/ios/commit/e146d4ec222fcc907e1d662c76ebe8322238fac7 |
| Oct 5, 2026 | https://github.com/NativeScript/ios/pull/478#event-32535091745 |
| Please reload this page | https://github.com/NativeScript/ios/pull/478 |
| https://github.com/adrian-niculescu |
| adrian-niculescu | https://github.com/adrian-niculescu |
| October 6, 2026 07:55 | https://github.com/NativeScript/ios/pull/478#event-32578630228 |
| https://github.com/adrian-niculescu |
| adrian-niculescu | https://github.com/adrian-niculescu |
|
Oct 6, 2026
| https://github.com/NativeScript/ios/pull/478#ref-pullrequest-5735266848 |
|
fix(worker): keep the worker isolate alive while terminate() uses it, and let it stop a closing worker
NativeScript/android#2067
| https://github.com/NativeScript/android/pull/2067 |
| https://github.com/edusperoni |
| edusperoni | https://github.com/edusperoni |
|
Oct 9, 2026
| https://github.com/NativeScript/ios/pull/478#ref-pullrequest-5782082465 |
|
fix(runtime): free a JS block's wrapper only once its isolate's teardown is done
#501
| https://github.com/NativeScript/ios/pull/501 |
| edusperoni | https://github.com/edusperoni |
|
Nov 11, 2026
| https://github.com/NativeScript/ios/pull/478#ref-commit-602e8ab |
|
| https://github.com/adrian-niculescu |
| fix(worker): keep the worker isolate alive while terminate() uses it,… | https://github.com/NativeScript/android/commit/602e8ab177f547e7c05eb868a3612b222d225abd |
| 602e8ab | https://github.com/NativeScript/android/commit/602e8ab177f547e7c05eb868a3612b222d225abd |
| #2067 | https://github.com/NativeScript/android/pull/2067 |
| NativeScript/ios#478 | https://github.com/NativeScript/ios/pull/478 |
| https://github.co/hiddenchars |
| https://github.com/NativeScript/ios/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fios%2Fpull%2F478 |
|
| https://github.com/apps/coderabbitai |
|
coderabbitai[bot]
| https://github.com/apps/coderabbitai |
|
| https://github.com/NativeScript/ios/pull/478/files/6d8e58bd2ececf6e3830339f051b6ad2fb7fb08a |
| Please reload this page | https://github.com/NativeScript/ios/pull/478 |
| Please reload this page | https://github.com/NativeScript/ios/pull/478 |
|
| https://github.com/adrian-niculescu |
|
| https://github.com/edusperoni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |