René's URL Explorer Experiment


Title: fix(worker): isolate and wrapper lifetime fixes around startup and teardown by adrian-niculescu · Pull Request #478 · NativeScript/ios · GitHub

Open Graph Title: fix(worker): isolate and wrapper lifetime fixes around startup and teardown by adrian-niculescu · Pull Request #478 · NativeScript/ios

X Title: fix(worker): isolate and wrapper lifetime fixes around startup and teardown by adrian-niculescu · Pull Request #478 · NativeScript/ios

Description: NativeScript for iOS and visionOS using V8. Contribute to NativeScript/ios development by creating an account on GitHub.

Open Graph Description: A worker whose entry script sets a throwing onclose and then calls close() crashes the app: onclose = () => { throw new Error("boom"); }; close(); CloseWorkerCallback reports the error...

X Description: A worker whose entry script sets a throwing onclose and then calls close() crashes the app: onclose = () => { throw new Error("boom"); }; close(); CloseWorkerCallback repor...

Opengraph URL: https://github.com/NativeScript/ios/pull/478

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:aadaec32-b143-5f5a-91e9-e5ebbbfeb5e2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC660:134361:1635DDC:1D392C3:6B012E4D
html-safe-noncec4d42a6d8e7d31ec35308c7f44aa9ab389f4260fad7d2db4019e33c261a53310
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjYwOjEzNDM2MToxNjM1RERDOjFEMzkyQzM6NkIwMTJFNEQiLCJ2aXNpdG9yX2lkIjoiMTIzMjY1Nzk0MDk1OTU5ODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2752780f6d4fcaf8de7e628e0374d07e421e88016f09270200c5ac4515cfbbea
hovercard-subject-tagpull_request:4557603494
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/NativeScript/ios/478/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0f46137b5367d875aa16ee0caab43cc504bb4f2f879afd97ff12fa50b828865b/NativeScript/ios/pull/478
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0f46137b5367d875aa16ee0caab43cc504bb4f2f879afd97ff12fa50b828865b/NativeScript/ios/pull/478
og:image:altA worker whose entry script sets a throwing onclose and then calls close() crashes the app: onclose = () => { throw new Error("boom"); }; close(); CloseWorkerCallback reports the error...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameadrian-niculescu
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/NativeScript/ios git https://github.com/NativeScript/ios.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id172934359
octolytics-dimension-repository_nwoNativeScript/ios
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id172934359
octolytics-dimension-repository_network_root_nwoNativeScript/ios
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/NativeScript/ios/pull/478#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fios%2Fpull%2F478
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fios%2Fpull%2F478
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=NativeScript%2Fios
Reloadhttps://github.com/NativeScript/ios/pull/478
Reloadhttps://github.com/NativeScript/ios/pull/478
Reloadhttps://github.com/NativeScript/ios/pull/478
NativeScripthttps://github.com/NativeScript
ioshttps://github.com/NativeScript/ios
Codehttps://github.com/NativeScript/ios
Issues56 (56)https://github.com/NativeScript/ios/issues
Pull requests42 (42)https://github.com/NativeScript/ios/pulls
Actionshttps://github.com/NativeScript/ios/actions
Projectshttps://github.com/NativeScript/ios/projects
Security and qualityhttps://github.com/NativeScript/ios/security
Insightshttps://github.com/NativeScript/ios/insights
https://github.com/NativeScript/ios
edusperonihttps://github.com/edusperoni
NativeScript:mainhttps://github.com/NativeScript/ios/tree/main
adrian-niculescu:fix/worker-terminate-and-ended-raceshttps://github.com/adrian-niculescu/NativeScript-iOS/tree/fix/worker-terminate-and-ended-races
Conversationhttps://github.com/NativeScript/ios/pull/478
Commits4 (4)https://github.com/NativeScript/ios/pull/478/commits
Checkshttps://github.com/NativeScript/ios/pull/478/checks
Files changedhttps://github.com/NativeScript/ios/pull/478/files
fix(worker): isolate and wrapper lifetime fixes around startup and teardownhttps://github.com/NativeScript/ios/pull/478#top
edusperonihttps://github.com/edusperoni
NativeScript:mainhttps://github.com/NativeScript/ios/tree/main
adrian-niculescu:fix/worker-terminate-and-ended-raceshttps://github.com/adrian-niculescu/NativeScript-iOS/tree/fix/worker-terminate-and-ended-races
https://github.com/adrian-niculescu
adrian-niculescuhttps://github.com/adrian-niculescu
Sep 17, 2026https://github.com/NativeScript/ios/pull/478#issue-5486399434
Please reload this pagehttps://github.com/NativeScript/ios/pull/478
Please reload this pagehttps://github.com/NativeScript/ios/pull/478
https://github.com/adrian-niculescu
fix(worker): isolate and wrapper lifetime fixes around startup and te…https://github.com/NativeScript/ios/pull/478/commits/6d8e58bd2ececf6e3830339f051b6ad2fb7fb08a
6d8e58bhttps://github.com/NativeScript/ios/pull/478/commits/6d8e58bd2ececf6e3830339f051b6ad2fb7fb08a
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Sep 17, 2026https://github.com/NativeScript/ios/pull/478#issuecomment-5713194358
Please reload this pagehttps://github.com/NativeScript/ios/pull/478
https://app.coderabbit.ai/change-stack/NativeScript/ios/pull/478#gh-light-mode-only
https://app.coderabbit.ai/change-stack/NativeScript/ios/pull/478#gh-dark-mode-only
Check out review usage herehttps://app.coderabbit.ai/dashboard/review-capacity?orgId=afc69ef0-445c-4859-9557-1d9ea919e3f0
Learn how review limits workhttps://docs.coderabbit.ai/management/plans#rate-limits
6d8e58bhttps://github.com/NativeScript/ios/commit/6d8e58bd2ececf6e3830339f051b6ad2fb7fb08a
70769c4https://github.com/NativeScript/ios/commit/70769c4b99a826a055ff1721c6631bf096b52b19
CodeRabbithttps://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=NativeScript/ios&utm_content=478
Xhttps://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai
Mastodonhttps://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai
Reddithttps://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai
LinkedInhttps://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code
Please reload this pagehttps://github.com/NativeScript/ios/pull/478
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Sep 17, 2026 https://github.com/NativeScript/ios/pull/478#pullrequestreview-5234716395
View reviewed changes https://github.com/NativeScript/ios/pull/478/files/6d8e58bd2ececf6e3830339f051b6ad2fb7fb08a
coderabbitaihttps://github.com/apps/coderabbitai
https://github.com/NativeScript/ios/pull/478#pullrequestreview-5234716395
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
6221ca8https://github.com/NativeScript/ios/commit/6221ca82e670eaa5a4bc8270090fccb55894b7df
6d8e58bhttps://github.com/NativeScript/ios/commit/6d8e58bd2ececf6e3830339f051b6ad2fb7fb08a
Please reload this pagehttps://github.com/NativeScript/ios/pull/478
https://github.com/adrian-niculescu
adrian-niculescuhttps://github.com/adrian-niculescu
Sep 17, 2026https://github.com/NativeScript/ios/pull/478#issuecomment-5713588585
Please reload this pagehttps://github.com/NativeScript/ios/pull/478
@coderabbitaihttps://github.com/coderabbitai
Please reload this pagehttps://github.com/NativeScript/ios/pull/478
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Sep 17, 2026https://github.com/NativeScript/ios/pull/478#issuecomment-5713631613
review instructionshttps://docs.coderabbit.ai/guides/review-instructions
apphttps://app.coderabbit.ai/learnings
Xhttps://twitter.com/intent/tweet?related=CodeRabbitAI&text=%40coderabbitai%20caught%20a%20teardown%20race%3A%20locking%20queue%20signaling%20prevents%20use-after-release%2C%20while%20worker-side%20termination%20avoids%20stopping%20an%20exited%20run%20loop.%20Safer%20concurrency%E2%80%94try%20it%20%F0%9F%9A%80&url=https%3A%2F%2Fgithub.com%2FNativeScript%2Fios%2Fpull%2F478
Please reload this pagehttps://github.com/NativeScript/ios/pull/478
https://github.com/adrian-niculescu
fix(worker): serialize the message queue's run loop source with its t…https://github.com/NativeScript/ios/pull/478/commits/1965a835bbd9e45ec1b6ade5766f8d210499503c
1965a83https://github.com/NativeScript/ios/pull/478/commits/1965a835bbd9e45ec1b6ade5766f8d210499503c
https://github.com/adrian-niculescu
adrian-niculescuhttps://github.com/adrian-niculescu
force-pushedhttps://github.com/NativeScript/ios/compare/a0edb4cec5f4a76d7f45a3f29b3417373ca0bc6d..1965a835bbd9e45ec1b6ade5766f8d210499503c
a0edb4chttps://github.com/NativeScript/ios/commit/a0edb4cec5f4a76d7f45a3f29b3417373ca0bc6d
1965a83https://github.com/NativeScript/ios/commit/1965a835bbd9e45ec1b6ade5766f8d210499503c
Compare https://github.com/NativeScript/ios/compare/a0edb4cec5f4a76d7f45a3f29b3417373ca0bc6d..1965a835bbd9e45ec1b6ade5766f8d210499503c
September 17, 2026 11:46https://github.com/NativeScript/ios/pull/478#event-31316459019
edusperonihttps://github.com/edusperoni
October 5, 2026 14:57https://github.com/NativeScript/ios/pull/478#commits-pushed-9a35ea8
https://github.com/edusperoni
Merge remote-tracking branch 'origin/main' into fix/worker-terminate-…https://github.com/NativeScript/ios/pull/478/commits/9a35ea8b22c12383eb1cc1b7ba5ff5657eedde51
9a35ea8https://github.com/NativeScript/ios/pull/478/commits/9a35ea8b22c12383eb1cc1b7ba5ff5657eedde51
https://github.com/edusperoni
refactor(worker): rename the queue's run loop mutex and scope the iso…https://github.com/NativeScript/ios/pull/478/commits/70769c4b99a826a055ff1721c6631bf096b52b19
70769c4https://github.com/NativeScript/ios/pull/478/commits/70769c4b99a826a055ff1721c6631bf096b52b19
https://github.com/edusperoni
edusperonihttps://github.com/edusperoni
e146d4ehttps://github.com/NativeScript/ios/commit/e146d4ec222fcc907e1d662c76ebe8322238fac7
Oct 5, 2026https://github.com/NativeScript/ios/pull/478#event-32535091745
Please reload this pagehttps://github.com/NativeScript/ios/pull/478
https://github.com/adrian-niculescu
adrian-niculescuhttps://github.com/adrian-niculescu
October 6, 2026 07:55https://github.com/NativeScript/ios/pull/478#event-32578630228
https://github.com/adrian-niculescu
adrian-niculescuhttps://github.com/adrian-niculescu
Oct 6, 2026 https://github.com/NativeScript/ios/pull/478#ref-pullrequest-5735266848
fix(worker): keep the worker isolate alive while terminate() uses it, and let it stop a closing worker NativeScript/android#2067 https://github.com/NativeScript/android/pull/2067
https://github.com/edusperoni
edusperonihttps://github.com/edusperoni
Oct 9, 2026 https://github.com/NativeScript/ios/pull/478#ref-pullrequest-5782082465
fix(runtime): free a JS block's wrapper only once its isolate's teardown is done #501 https://github.com/NativeScript/ios/pull/501
edusperonihttps://github.com/edusperoni
Nov 11, 2026 https://github.com/NativeScript/ios/pull/478#ref-commit-602e8ab
https://github.com/adrian-niculescu
fix(worker): keep the worker isolate alive while terminate() uses it,…https://github.com/NativeScript/android/commit/602e8ab177f547e7c05eb868a3612b222d225abd
602e8abhttps://github.com/NativeScript/android/commit/602e8ab177f547e7c05eb868a3612b222d225abd
#2067https://github.com/NativeScript/android/pull/2067
NativeScript/ios#478https://github.com/NativeScript/ios/pull/478
https://github.co/hiddenchars
https://github.com/NativeScript/ios/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fios%2Fpull%2F478
https://github.com/apps/coderabbitai
coderabbitai[bot] https://github.com/apps/coderabbitai
https://github.com/NativeScript/ios/pull/478/files/6d8e58bd2ececf6e3830339f051b6ad2fb7fb08a
Please reload this pagehttps://github.com/NativeScript/ios/pull/478
Please reload this pagehttps://github.com/NativeScript/ios/pull/478
https://github.com/adrian-niculescu
https://github.com/edusperoni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.