René's URL Explorer Experiment


Title: Fix #720 GC issue - No weak ref found by petekanev · Pull Request #744 · NativeScript/android · GitHub

Open Graph Title: Fix #720 GC issue - No weak ref found by petekanev · Pull Request #744 · NativeScript/android

X Title: Fix #720 GC issue - No weak ref found by petekanev · Pull Request #744 · NativeScript/android

Description: The proposed changes address the problem described in issue #720 - having the GC trigger during navigation can sometimes collect children of composite views, before recursively iterating over said children. That could happen if real Java objects were considered unreachable, while their JS counterparts were still accessible as elements of view's children (js array) property, or vice versa. (Best explained in mslavcher's blog - https://iobservable.net/blog/2014/06/07/synchronizing-gc-in-java-and-v8/) As an additional step now, during GC, array objects marked for collection will be iterated over to check whether references are reachable in JavaScript, in which case their Java proxies shouldn't be released. Implementation considerations: Depending on the application, this modification can impose a slight performance hit where huge arrays are used inside implementation objects (extending classes and implementing interfaces)

Open Graph Description: The proposed changes address the problem described in issue #720 - having the GC trigger during navigation can sometimes collect children of composite views, before recursively iterating over said ...

X Description: The proposed changes address the problem described in issue #720 - having the GC trigger during navigation can sometimes collect children of composite views, before recursively iterating over said ...

Opengraph URL: https://github.com/NativeScript/android/pull/744

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5bd89895-eb6f-5384-e4ba-58d13e619e84
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB4E2:117C62:188304E:20AAEF0:6B014D94
html-safe-nonce4023577882ab4f35d85055fed7c4e4d216b3ca1a9b68e09d523a0e03a905a4cd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEUyOjExN0M2MjoxODgzMDRFOjIwQUFFRjA6NkIwMTREOTQiLCJ2aXNpdG9yX2lkIjoiNTA0MTM1MzQ4MzM2MjU4NjAwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2b1c22c017fbfaaa1b8028c998979552841b288b84188f08f10afb1c1d663e6e
hovercard-subject-tagpull_request:116521716
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/android/pull/744/files
twitter:imagehttps://avatars.githubusercontent.com/u/10464986?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10464986?s=400&v=4
og:image:altThe proposed changes address the problem described in issue #720 - having the GC trigger during navigation can sometimes collect children of composite views, before recursively iterating over said ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/android git https://github.com/NativeScript/android.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id29137950
octolytics-dimension-repository_nwoNativeScript/android
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id29137950
octolytics-dimension-repository_network_root_nwoNativeScript/android
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/android/pull/744/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F744%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F744%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fandroid
Reloadhttps://github.com/NativeScript/android/pull/744/files
Reloadhttps://github.com/NativeScript/android/pull/744/files
Reloadhttps://github.com/NativeScript/android/pull/744/files
NativeScripthttps://github.com/NativeScript
androidhttps://github.com/NativeScript/android
Codehttps://github.com/NativeScript/android
Issues106 (106)https://github.com/NativeScript/android/issues
Pull requests25 (25)https://github.com/NativeScript/android/pulls
Actionshttps://github.com/NativeScript/android/actions
Projectshttps://github.com/NativeScript/android/projects
Wikihttps://github.com/NativeScript/android/wiki
Security and qualityhttps://github.com/NativeScript/android/security
Insightshttps://github.com/NativeScript/android/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
petekanevhttps://github.com/petekanev
releasehttps://github.com/NativeScript/android/tree/release
pete/fix-gc-issue-no-weakrefhttps://github.com/NativeScript/android/tree/pete/fix-gc-issue-no-weakref
Conversation 4 https://github.com/NativeScript/android/pull/744
Commits 2 https://github.com/NativeScript/android/pull/744/commits
Checks 0 https://github.com/NativeScript/android/pull/744/checks
Files changed https://github.com/NativeScript/android/pull/744/files
Please reload this pagehttps://github.com/NativeScript/android/pull/744/files
Fix #720 GC issue - No weak ref found https://github.com/NativeScript/android/pull/744/files#top
Show all changes 2 commits https://github.com/NativeScript/android/pull/744/files
38e894a check if array-enclosed elements are empty before trying to release t… petekanev Apr 19, 2017 https://github.com/NativeScript/android/pull/744/commits/38e894a45082c855caeb46c472849ceda4136edf
21c8834 add test case for no weak ref found bug petekanev Apr 19, 2017 https://github.com/NativeScript/android/pull/744/commits/21c88345437fb3b59cccd931a56f058d22edfb35
Clear filters https://github.com/NativeScript/android/pull/744/files
Please reload this pagehttps://github.com/NativeScript/android/pull/744/files
Please reload this pagehttps://github.com/NativeScript/android/pull/744/files
ObjectManager.cpp https://github.com/NativeScript/android/pull/744/files#diff-e86348e14773445a59a35d68ce5910fd559b11af66e44843a0c60f5c03209638
ObjectManager.h https://github.com/NativeScript/android/pull/744/files#diff-94c76ae1e5b22266edc8c5d659676fa9814aca42c95d0d72a64a490c79c3e275
testGC.js https://github.com/NativeScript/android/pull/744/files#diff-20bba87551a65fc6f1bda40b02771863735355a913719d4ad323000319577fc4
runtime/src/main/jni/ObjectManager.cpphttps://github.com/NativeScript/android/pull/744/files#diff-e86348e14773445a59a35d68ce5910fd559b11af66e44843a0c60f5c03209638
View file https://github.com/NativeScript/android/blob/21c88345437fb3b59cccd931a56f058d22edfb35/runtime/src/main/jni/ObjectManager.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/744/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/744/files#diff-e86348e14773445a59a35d68ce5910fd559b11af66e44843a0c60f5c03209638
https://github.com/NativeScript/android/pull/744/files#diff-e86348e14773445a59a35d68ce5910fd559b11af66e44843a0c60f5c03209638
https://github.com/NativeScript/android/pull/744/files#diff-e86348e14773445a59a35d68ce5910fd559b11af66e44843a0c60f5c03209638
https://github.com/NativeScript/android/pull/744/files#diff-e86348e14773445a59a35d68ce5910fd559b11af66e44843a0c60f5c03209638
runtime/src/main/jni/ObjectManager.hhttps://github.com/NativeScript/android/pull/744/files#diff-94c76ae1e5b22266edc8c5d659676fa9814aca42c95d0d72a64a490c79c3e275
View file https://github.com/NativeScript/android/blob/21c88345437fb3b59cccd931a56f058d22edfb35/runtime/src/main/jni/ObjectManager.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/744/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/744/files#diff-94c76ae1e5b22266edc8c5d659676fa9814aca42c95d0d72a64a490c79c3e275
https://github.com/NativeScript/android/pull/744/files#diff-94c76ae1e5b22266edc8c5d659676fa9814aca42c95d0d72a64a490c79c3e275
test-app/app/src/main/assets/app/tests/testGC.jshttps://github.com/NativeScript/android/pull/744/files#diff-20bba87551a65fc6f1bda40b02771863735355a913719d4ad323000319577fc4
View file https://github.com/NativeScript/android/blob/21c88345437fb3b59cccd931a56f058d22edfb35/test-app/app/src/main/assets/app/tests/testGC.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/744/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/744/files#diff-20bba87551a65fc6f1bda40b02771863735355a913719d4ad323000319577fc4
https://github.com/NativeScript/android/pull/744/files#diff-20bba87551a65fc6f1bda40b02771863735355a913719d4ad323000319577fc4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.