| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/commits(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:0fd0179f-8d6f-70cf-104c-f53b8ff49c89 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9412:B1B84:1331C6C:1852BC8:6B015F02 |
| html-safe-nonce | 89fc464b1e008e733316d74ea70289cecf86021acf78afd736c8e150a50bef1e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDEyOkIxQjg0OjEzMzFDNkM6MTg1MkJDODo2QjAxNUYwMiIsInZpc2l0b3JfaWQiOiI3NDU0NzU4NTU0MDI1NjgwNjQyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 2ed5065a4491e8c74f1e5114e86ee7ac99ec48d7b7b1fba72cd11dc94a305071 |
| hovercard-subject-tag | pull_request:5351966164 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/android/pull/2118/commits |
| twitter:image | https://opengraph.githubassets.com/6c67688efb7b304b364f2c6c1601cb1a6cb35d9ae6b61dd64d6fff4955e119dd/NativeScript/android/pull/2118 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6c67688efb7b304b364f2c6c1601cb1a6cb35d9ae6b61dd64d6fff4955e119dd/NativeScript/android/pull/2118 |
| og:image:alt | Description
A JS implementation of an interface default method was never called from Java when the class was generated on the device. This makes it work. The change is unconditional, not opt-in.
S... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | edusperoni |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/NativeScript/android git https://github.com/NativeScript/android.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 29137950 |
| octolytics-dimension-repository_nwo | NativeScript/android |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 29137950 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/android |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/NativeScript/android/pull/2118/commits#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2118%2Fcommits |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2118%2Fcommits |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=NativeScript%2Fandroid |
| Reload | https://github.com/NativeScript/android/pull/2118/commits |
| Reload | https://github.com/NativeScript/android/pull/2118/commits |
| Reload | https://github.com/NativeScript/android/pull/2118/commits |
| NativeScript | https://github.com/NativeScript |
| android | https://github.com/NativeScript/android |
| Code | https://github.com/NativeScript/android |
| Issues106 (106) | https://github.com/NativeScript/android/issues |
| Pull requests26 (26) | https://github.com/NativeScript/android/pulls |
| Actions | https://github.com/NativeScript/android/actions |
| Projects | https://github.com/NativeScript/android/projects |
| Wiki | https://github.com/NativeScript/android/wiki |
| Security and quality | https://github.com/NativeScript/android/security |
| Insights | https://github.com/NativeScript/android/insights |
| https://github.com/NativeScript/android |
| edusperoni | https://github.com/edusperoni |
| fix/proxy-dex-generation-followups | https://github.com/NativeScript/android/tree/fix/proxy-dex-generation-followups |
| fix/interface-default-method-overrides | https://github.com/NativeScript/android/tree/fix/interface-default-method-overrides |
| Conversation | https://github.com/NativeScript/android/pull/2118 |
| Commits16 (16) | https://github.com/NativeScript/android/pull/2118/commits |
| Checks | https://github.com/NativeScript/android/pull/2118/checks |
| Files changed | https://github.com/NativeScript/android/pull/2118/files |
| fix: call JS overrides of default methods | https://github.com/NativeScript/android/pull/2118/commits#top |
| edusperoni | https://github.com/edusperoni |
| fix/proxy-dex-generation-followups | https://github.com/NativeScript/android/tree/fix/proxy-dex-generation-followups |
| fix/interface-default-method-overrides | https://github.com/NativeScript/android/tree/fix/interface-default-method-overrides |
| feat(runtime): call an interface's default method non-virtually from Java | https://github.com/NativeScript/android/pull/2118/commits/d573d46fa93d6f51f0b314197033ef6994ee6d37 |
| https://github.com/edusperoni |
| edusperoni | https://github.com/NativeScript/android/commits?author=edusperoni |
| d573d46 | https://github.com/NativeScript/android/pull/2118/commits/d573d46fa93d6f51f0b314197033ef6994ee6d37 |
| https://github.com/NativeScript/android/tree/d573d46fa93d6f51f0b314197033ef6994ee6d37 |
| fix(bindings): call JS implementations of interface default methods | https://github.com/NativeScript/android/pull/2118/commits/2500a6bff632bfe2427c5c3f669b9b56f36cee13 |
| https://github.com/edusperoni |
| edusperoni | https://github.com/NativeScript/android/commits?author=edusperoni |
| 2500a6b | https://github.com/NativeScript/android/pull/2118/commits/2500a6bff632bfe2427c5c3f669b9b56f36cee13 |
| https://github.com/NativeScript/android/tree/2500a6bff632bfe2427c5c3f669b9b56f36cee13 |
| fix(bindings): call JS implementations of inherited default methods in class extends | https://github.com/NativeScript/android/pull/2118/commits/9dcc8a5c3b6b658d7ca65035534690c780f64033 |
| https://github.com/edusperoni |
| edusperoni | https://github.com/NativeScript/android/commits?author=edusperoni |
| 9dcc8a5 | https://github.com/NativeScript/android/pull/2118/commits/9dcc8a5c3b6b658d7ca65035534690c780f64033 |
| https://github.com/NativeScript/android/tree/9dcc8a5c3b6b658d7ca65035534690c780f64033 |
| fix(bindings): call JS implementations of default methods in named interface extends | https://github.com/NativeScript/android/pull/2118/commits/63e67e85053d4683fcf4f28243c453735ed85394 |
| https://github.com/edusperoni |
| edusperoni | https://github.com/NativeScript/android/commits?author=edusperoni |
| 63e67e8 | https://github.com/NativeScript/android/pull/2118/commits/63e67e85053d4683fcf4f28243c453735ed85394 |
| https://github.com/NativeScript/android/tree/63e67e85053d4683fcf4f28243c453735ed85394 |
| fix(bindings): resolve the default-overriding class without reading the JS object | https://github.com/NativeScript/android/pull/2118/commits/3fa214c145010afebddf20ece3e99b82a94e4ce3 |
| https://github.com/edusperoni |
| edusperoni | https://github.com/NativeScript/android/commits?author=edusperoni |
| 3fa214c | https://github.com/NativeScript/android/pull/2118/commits/3fa214c145010afebddf20ece3e99b82a94e4ce3 |
| https://github.com/NativeScript/android/tree/3fa214c145010afebddf20ece3e99b82a94e4ce3 |
| fix(bindings): let an extend with an empty interfaces list override defaults | https://github.com/NativeScript/android/pull/2118/commits/1bb49a558f3238a13530daffef97ac91b3b0e6b2 |
| https://github.com/edusperoni |
| edusperoni | https://github.com/NativeScript/android/commits?author=edusperoni |
| 1bb49a5 | https://github.com/NativeScript/android/pull/2118/commits/1bb49a558f3238a13530daffef97ac91b3b0e6b2 |
| https://github.com/NativeScript/android/tree/1bb49a558f3238a13530daffef97ac91b3b0e6b2 |
| fix(bindings): run inherited defaults of a non-public super-interface | https://github.com/NativeScript/android/pull/2118/commits/c9cef0c30d4fb61744c7a1e33914d5ec5489bbc2 |
| https://github.com/edusperoni |
| edusperoni | https://github.com/NativeScript/android/commits?author=edusperoni |
| c9cef0c | https://github.com/NativeScript/android/pull/2118/commits/c9cef0c30d4fb61744c7a1e33914d5ec5489bbc2 |
| https://github.com/NativeScript/android/tree/c9cef0c30d4fb61744c7a1e33914d5ec5489bbc2 |
| fix(bindings): key a cached default-overriding dex by the default method names | https://github.com/NativeScript/android/pull/2118/commits/54025b230d6299331359bba43c024bc6aaf78358 |
| https://github.com/edusperoni |
| edusperoni | https://github.com/NativeScript/android/commits?author=edusperoni |
| 54025b2 | https://github.com/NativeScript/android/pull/2118/commits/54025b230d6299331359bba43c024bc6aaf78358 |
| https://github.com/NativeScript/android/tree/54025b230d6299331359bba43c024bc6aaf78358 |
| test: pin extend() of a nested interface with a JS default method | https://github.com/NativeScript/android/pull/2118/commits/4240422ecd52fc9f3805669748e859cdf53e0c1f |
| https://github.com/edusperoni |
| edusperoni | https://github.com/NativeScript/android/commits?author=edusperoni |
| 4240422 | https://github.com/NativeScript/android/pull/2118/commits/4240422ecd52fc9f3805669748e859cdf53e0c1f |
| https://github.com/NativeScript/android/tree/4240422ecd52fc9f3805669748e859cdf53e0c1f |
| fix(bindings): key a cached default-overriding dex by the default method signatures | https://github.com/NativeScript/android/pull/2118/commits/916699e6f825d4f68b7d0f3095bb0e84ac4ddf87 |
| https://github.com/edusperoni |
| edusperoni | https://github.com/NativeScript/android/commits?author=edusperoni |
| 916699e | https://github.com/NativeScript/android/pull/2118/commits/916699e6f825d4f68b7d0f3095bb0e84ac4ddf87 |
| https://github.com/NativeScript/android/tree/916699e6f825d4f68b7d0f3095bb0e84ac4ddf87 |
| fix(bindings): leave a default a sub-interface bridges to the bridge | https://github.com/NativeScript/android/pull/2118/commits/8a7453a0da3cb8f2762c23d6cb9005f8b03f6247 |
| https://github.com/edusperoni |
| edusperoni | https://github.com/NativeScript/android/commits?author=edusperoni |
| 8a7453a | https://github.com/NativeScript/android/pull/2118/commits/8a7453a0da3cb8f2762c23d6cb9005f8b03f6247 |
| https://github.com/NativeScript/android/tree/8a7453a0da3cb8f2762c23d6cb9005f8b03f6247 |
| feat(asmdex): choose the dex format version per writer | https://github.com/NativeScript/android/pull/2118/commits/d876c0f7cdc7bef858e260a59047942319e5c296 |
| https://github.com/edusperoni |
| edusperoni | https://github.com/NativeScript/android/commits?author=edusperoni |
| d876c0f | https://github.com/NativeScript/android/pull/2118/commits/d876c0f7cdc7bef858e260a59047942319e5c296 |
| https://github.com/NativeScript/android/tree/d876c0f7cdc7bef858e260a59047942319e5c296 |
| perf(bindings): run the defaults a JS object lacks with invoke-super | https://github.com/NativeScript/android/pull/2118/commits/9135ab822519fe735d837dc0140073e3548fc706 |
| https://github.com/edusperoni |
| edusperoni | https://github.com/NativeScript/android/commits?author=edusperoni |
| 9135ab8 | https://github.com/NativeScript/android/pull/2118/commits/9135ab822519fe735d837dc0140073e3548fc706 |
| https://github.com/NativeScript/android/tree/9135ab822519fe735d837dc0140073e3548fc706 |
| test: run the runtime-call stubs of default methods in the default suite | https://github.com/NativeScript/android/pull/2118/commits/de85ebab524de570d30b008b7d1357b0da0033bf |
| https://github.com/edusperoni |
| edusperoni | https://github.com/NativeScript/android/commits?author=edusperoni |
| de85eba | https://github.com/NativeScript/android/pull/2118/commits/de85ebab524de570d30b008b7d1357b0da0033bf |
| https://github.com/NativeScript/android/tree/de85ebab524de570d30b008b7d1357b0da0033bf |
| test: check that no default-overriding class of either kind loads needlessly | https://github.com/NativeScript/android/pull/2118/commits/f06ab2c44882d75aaee3a794a34a898d902719e7 |
| https://github.com/edusperoni |
| edusperoni | https://github.com/NativeScript/android/commits?author=edusperoni |
| f06ab2c | https://github.com/NativeScript/android/pull/2118/commits/f06ab2c44882d75aaee3a794a34a898d902719e7 |
| https://github.com/NativeScript/android/tree/f06ab2c44882d75aaee3a794a34a898d902719e7 |
| docs(runtime): name the stubs that call callInterfaceDefault | https://github.com/NativeScript/android/pull/2118/commits/4834365d6d43051a7a6e7531f8a7812629387041 |
| https://github.com/edusperoni |
| edusperoni | https://github.com/NativeScript/android/commits?author=edusperoni |
| 4834365 | https://github.com/NativeScript/android/pull/2118/commits/4834365d6d43051a7a6e7531f8a7812629387041 |
| https://github.com/NativeScript/android/tree/4834365d6d43051a7a6e7531f8a7812629387041 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |