René's URL Explorer Experiment


Title: fix: call JS overrides of default methods by edusperoni · Pull Request #2118 · NativeScript/android · GitHub

Open Graph Title: fix: call JS overrides of default methods by edusperoni · Pull Request #2118 · NativeScript/android

X Title: fix: call JS overrides of default methods by edusperoni · Pull Request #2118 · NativeScript/android

Description: NativeScript for Android using v8. Contribute to NativeScript/android development by creating an account on GitHub.

Open Graph Description: Description A JS implementation of an interface default method was never called from Java when the class was generated on the device. This makes it work. The change is unconditional, not opt-in. S...

X Description: Description A JS implementation of an interface default method was never called from Java when the class was generated on the device. This makes it work. The change is unconditional, not opt-in. S...

Opengraph URL: https://github.com/NativeScript/android/pull/2118

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:0fd0179f-8d6f-70cf-104c-f53b8ff49c89
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9412:B1B84:1331C6C:1852BC8:6B015F02
html-safe-nonce89fc464b1e008e733316d74ea70289cecf86021acf78afd736c8e150a50bef1e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDEyOkIxQjg0OjEzMzFDNkM6MTg1MkJDODo2QjAxNUYwMiIsInZpc2l0b3JfaWQiOiI3NDU0NzU4NTU0MDI1NjgwNjQyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2ed5065a4491e8c74f1e5114e86ee7ac99ec48d7b7b1fba72cd11dc94a305071
hovercard-subject-tagpull_request:5351966164
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/android/pull/2118/commits
twitter:imagehttps://opengraph.githubassets.com/6c67688efb7b304b364f2c6c1601cb1a6cb35d9ae6b61dd64d6fff4955e119dd/NativeScript/android/pull/2118
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6c67688efb7b304b364f2c6c1601cb1a6cb35d9ae6b61dd64d6fff4955e119dd/NativeScript/android/pull/2118
og:image:altDescription A JS implementation of an interface default method was never called from Java when the class was generated on the device. This makes it work. The change is unconditional, not opt-in. S...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameedusperoni
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/NativeScript/android git https://github.com/NativeScript/android.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id29137950
octolytics-dimension-repository_nwoNativeScript/android
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id29137950
octolytics-dimension-repository_network_root_nwoNativeScript/android
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/NativeScript/android/pull/2118/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2118%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2118%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=NativeScript%2Fandroid
Reloadhttps://github.com/NativeScript/android/pull/2118/commits
Reloadhttps://github.com/NativeScript/android/pull/2118/commits
Reloadhttps://github.com/NativeScript/android/pull/2118/commits
NativeScripthttps://github.com/NativeScript
androidhttps://github.com/NativeScript/android
Codehttps://github.com/NativeScript/android
Issues106 (106)https://github.com/NativeScript/android/issues
Pull requests26 (26)https://github.com/NativeScript/android/pulls
Actionshttps://github.com/NativeScript/android/actions
Projectshttps://github.com/NativeScript/android/projects
Wikihttps://github.com/NativeScript/android/wiki
Security and qualityhttps://github.com/NativeScript/android/security
Insightshttps://github.com/NativeScript/android/insights
https://github.com/NativeScript/android
edusperonihttps://github.com/edusperoni
fix/proxy-dex-generation-followupshttps://github.com/NativeScript/android/tree/fix/proxy-dex-generation-followups
fix/interface-default-method-overrideshttps://github.com/NativeScript/android/tree/fix/interface-default-method-overrides
Conversationhttps://github.com/NativeScript/android/pull/2118
Commits16 (16)https://github.com/NativeScript/android/pull/2118/commits
Checkshttps://github.com/NativeScript/android/pull/2118/checks
Files changedhttps://github.com/NativeScript/android/pull/2118/files
fix: call JS overrides of default methodshttps://github.com/NativeScript/android/pull/2118/commits#top
edusperonihttps://github.com/edusperoni
fix/proxy-dex-generation-followupshttps://github.com/NativeScript/android/tree/fix/proxy-dex-generation-followups
fix/interface-default-method-overrideshttps://github.com/NativeScript/android/tree/fix/interface-default-method-overrides
feat(runtime): call an interface's default method non-virtually from Javahttps://github.com/NativeScript/android/pull/2118/commits/d573d46fa93d6f51f0b314197033ef6994ee6d37
https://github.com/edusperoni
edusperonihttps://github.com/NativeScript/android/commits?author=edusperoni
d573d46https://github.com/NativeScript/android/pull/2118/commits/d573d46fa93d6f51f0b314197033ef6994ee6d37
https://github.com/NativeScript/android/tree/d573d46fa93d6f51f0b314197033ef6994ee6d37
fix(bindings): call JS implementations of interface default methodshttps://github.com/NativeScript/android/pull/2118/commits/2500a6bff632bfe2427c5c3f669b9b56f36cee13
https://github.com/edusperoni
edusperonihttps://github.com/NativeScript/android/commits?author=edusperoni
2500a6bhttps://github.com/NativeScript/android/pull/2118/commits/2500a6bff632bfe2427c5c3f669b9b56f36cee13
https://github.com/NativeScript/android/tree/2500a6bff632bfe2427c5c3f669b9b56f36cee13
fix(bindings): call JS implementations of inherited default methods in class extendshttps://github.com/NativeScript/android/pull/2118/commits/9dcc8a5c3b6b658d7ca65035534690c780f64033
https://github.com/edusperoni
edusperonihttps://github.com/NativeScript/android/commits?author=edusperoni
9dcc8a5https://github.com/NativeScript/android/pull/2118/commits/9dcc8a5c3b6b658d7ca65035534690c780f64033
https://github.com/NativeScript/android/tree/9dcc8a5c3b6b658d7ca65035534690c780f64033
fix(bindings): call JS implementations of default methods in named interface extendshttps://github.com/NativeScript/android/pull/2118/commits/63e67e85053d4683fcf4f28243c453735ed85394
https://github.com/edusperoni
edusperonihttps://github.com/NativeScript/android/commits?author=edusperoni
63e67e8https://github.com/NativeScript/android/pull/2118/commits/63e67e85053d4683fcf4f28243c453735ed85394
https://github.com/NativeScript/android/tree/63e67e85053d4683fcf4f28243c453735ed85394
fix(bindings): resolve the default-overriding class without reading the JS objecthttps://github.com/NativeScript/android/pull/2118/commits/3fa214c145010afebddf20ece3e99b82a94e4ce3
https://github.com/edusperoni
edusperonihttps://github.com/NativeScript/android/commits?author=edusperoni
3fa214chttps://github.com/NativeScript/android/pull/2118/commits/3fa214c145010afebddf20ece3e99b82a94e4ce3
https://github.com/NativeScript/android/tree/3fa214c145010afebddf20ece3e99b82a94e4ce3
fix(bindings): let an extend with an empty interfaces list override defaultshttps://github.com/NativeScript/android/pull/2118/commits/1bb49a558f3238a13530daffef97ac91b3b0e6b2
https://github.com/edusperoni
edusperonihttps://github.com/NativeScript/android/commits?author=edusperoni
1bb49a5https://github.com/NativeScript/android/pull/2118/commits/1bb49a558f3238a13530daffef97ac91b3b0e6b2
https://github.com/NativeScript/android/tree/1bb49a558f3238a13530daffef97ac91b3b0e6b2
fix(bindings): run inherited defaults of a non-public super-interfacehttps://github.com/NativeScript/android/pull/2118/commits/c9cef0c30d4fb61744c7a1e33914d5ec5489bbc2
https://github.com/edusperoni
edusperonihttps://github.com/NativeScript/android/commits?author=edusperoni
c9cef0chttps://github.com/NativeScript/android/pull/2118/commits/c9cef0c30d4fb61744c7a1e33914d5ec5489bbc2
https://github.com/NativeScript/android/tree/c9cef0c30d4fb61744c7a1e33914d5ec5489bbc2
fix(bindings): key a cached default-overriding dex by the default method nameshttps://github.com/NativeScript/android/pull/2118/commits/54025b230d6299331359bba43c024bc6aaf78358
https://github.com/edusperoni
edusperonihttps://github.com/NativeScript/android/commits?author=edusperoni
54025b2https://github.com/NativeScript/android/pull/2118/commits/54025b230d6299331359bba43c024bc6aaf78358
https://github.com/NativeScript/android/tree/54025b230d6299331359bba43c024bc6aaf78358
test: pin extend() of a nested interface with a JS default methodhttps://github.com/NativeScript/android/pull/2118/commits/4240422ecd52fc9f3805669748e859cdf53e0c1f
https://github.com/edusperoni
edusperonihttps://github.com/NativeScript/android/commits?author=edusperoni
4240422https://github.com/NativeScript/android/pull/2118/commits/4240422ecd52fc9f3805669748e859cdf53e0c1f
https://github.com/NativeScript/android/tree/4240422ecd52fc9f3805669748e859cdf53e0c1f
fix(bindings): key a cached default-overriding dex by the default method signatureshttps://github.com/NativeScript/android/pull/2118/commits/916699e6f825d4f68b7d0f3095bb0e84ac4ddf87
https://github.com/edusperoni
edusperonihttps://github.com/NativeScript/android/commits?author=edusperoni
916699ehttps://github.com/NativeScript/android/pull/2118/commits/916699e6f825d4f68b7d0f3095bb0e84ac4ddf87
https://github.com/NativeScript/android/tree/916699e6f825d4f68b7d0f3095bb0e84ac4ddf87
fix(bindings): leave a default a sub-interface bridges to the bridgehttps://github.com/NativeScript/android/pull/2118/commits/8a7453a0da3cb8f2762c23d6cb9005f8b03f6247
https://github.com/edusperoni
edusperonihttps://github.com/NativeScript/android/commits?author=edusperoni
8a7453ahttps://github.com/NativeScript/android/pull/2118/commits/8a7453a0da3cb8f2762c23d6cb9005f8b03f6247
https://github.com/NativeScript/android/tree/8a7453a0da3cb8f2762c23d6cb9005f8b03f6247
feat(asmdex): choose the dex format version per writerhttps://github.com/NativeScript/android/pull/2118/commits/d876c0f7cdc7bef858e260a59047942319e5c296
https://github.com/edusperoni
edusperonihttps://github.com/NativeScript/android/commits?author=edusperoni
d876c0fhttps://github.com/NativeScript/android/pull/2118/commits/d876c0f7cdc7bef858e260a59047942319e5c296
https://github.com/NativeScript/android/tree/d876c0f7cdc7bef858e260a59047942319e5c296
perf(bindings): run the defaults a JS object lacks with invoke-superhttps://github.com/NativeScript/android/pull/2118/commits/9135ab822519fe735d837dc0140073e3548fc706
https://github.com/edusperoni
edusperonihttps://github.com/NativeScript/android/commits?author=edusperoni
9135ab8https://github.com/NativeScript/android/pull/2118/commits/9135ab822519fe735d837dc0140073e3548fc706
https://github.com/NativeScript/android/tree/9135ab822519fe735d837dc0140073e3548fc706
test: run the runtime-call stubs of default methods in the default suitehttps://github.com/NativeScript/android/pull/2118/commits/de85ebab524de570d30b008b7d1357b0da0033bf
https://github.com/edusperoni
edusperonihttps://github.com/NativeScript/android/commits?author=edusperoni
de85ebahttps://github.com/NativeScript/android/pull/2118/commits/de85ebab524de570d30b008b7d1357b0da0033bf
https://github.com/NativeScript/android/tree/de85ebab524de570d30b008b7d1357b0da0033bf
test: check that no default-overriding class of either kind loads needlesslyhttps://github.com/NativeScript/android/pull/2118/commits/f06ab2c44882d75aaee3a794a34a898d902719e7
https://github.com/edusperoni
edusperonihttps://github.com/NativeScript/android/commits?author=edusperoni
f06ab2chttps://github.com/NativeScript/android/pull/2118/commits/f06ab2c44882d75aaee3a794a34a898d902719e7
https://github.com/NativeScript/android/tree/f06ab2c44882d75aaee3a794a34a898d902719e7
docs(runtime): name the stubs that call callInterfaceDefaulthttps://github.com/NativeScript/android/pull/2118/commits/4834365d6d43051a7a6e7531f8a7812629387041
https://github.com/edusperoni
edusperonihttps://github.com/NativeScript/android/commits?author=edusperoni
4834365https://github.com/NativeScript/android/pull/2118/commits/4834365d6d43051a7a6e7531f8a7812629387041
https://github.com/NativeScript/android/tree/4834365d6d43051a7a6e7531f8a7812629387041
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.