René's URL Explorer Experiment


Title: ci(tests): fetch test results without adb root by edusperoni · Pull Request #2098 · NativeScript/android · GitHub

Open Graph Title: ci(tests): fetch test results without adb root by edusperoni · Pull Request #2098 · NativeScript/android

X Title: ci(tests): fetch test results without adb root by edusperoni · Pull Request #2098 · NativeScript/android

Description: Description runtestsAndVerifyResults no longer needs adb root, and it only touches the one device it's aimed at. No root The test results XML lives in the app's private data dir, and the debuggable test app can always read it back through adb exec-out run-as com.tns.testapplication cat …. That works on Play Store emulator images and on user-build physical devices, where adbd can't run as root. Remove the runAdbAsRoot task (and its fixed 10s sleep). On images that refuse root, adb root already exited 0 and did nothing. The poller reads the file only through run-as. The root-only adb pull /data/data/... attempt is gone. deletePreviousResultXml now runs after the debug install. If a release build of the test app was installed, run-as rm failed silently, so the poller picked up a stale XML from an earlier run and reported a pass. One device per run :app:installDebug installs on every connected device unless ANDROID_SERIAL is set, so an emulator run also overwrote the test app on an attached phone. The harness now resolves a single serial (ANDROID_SERIAL if set, else adb -d|-e get-serialno), passes it to installDebug, and uses -s for every adb call. If more than one device matches, it fails fast with "Could not pick a single emulator … Set ANDROID_SERIAL to choose one." The -d/-e selector was always followed by a hardcoded -e, and adb uses the last flag (adb -d -e → emulator), so -PrunOnDevice still targeted the emulator. Poller robustness A single failed liveness check was treated as a crash and aborted runs on a loaded host while the app was still alive. The poller now uses pidof and declares death only after 3 consecutive misses. Every adb call in the poller has a 30s timeout. On a wedged device, adb shell hangs forever, which blocked the poller and its overall 20-minute timeout. Does your commit message include the wording below to reference a specific issue in this repo? No related issue. Related Pull Requests Builds on the run-as fallback added in #1965. Does your pull request have unit tests? This change only touches the test harness. The CI emulator jobs run runtestsAndVerifyResults without adb root, so they exercise the new path. Local checks, with a user-build phone and two emulators attached: Serial resolution: the default run fails fast ("more than one emulator"), -PrunOnDevice picks the phone, and ANDROID_SERIAL overrides the choice. --dry-run task order: install → delete old results → start app → poll. Poller against a live emulator: finds the app and reads the results via -s + run-as. Poller against an emulator whose adb shell hangs: misses 1/3 and 2/3, then reports the process as dead, dumps logcat and exits 1, without hanging. adb root on a user build prints "adbd cannot run as root in production builds" and exits 0. Summary by CodeRabbit Tests Emulator test runs now use the same selected device throughout setup, app launch, and result collection. Test runs wait for the emulator, install the app, clear previous results, and then launch the app. Complete test results are saved locally as JUnit XML; incomplete or failed reads are not saved as results. Device selection accepts multiple arguments, and ADB operations use a timeout. Process checks tolerate two consecutive missing-process results before failing with a logcat dump.

Open Graph Description: Description runtestsAndVerifyResults no longer needs adb root, and it only touches the one device it's aimed at. No root The test results XML lives in the app's private data dir, and the de...

X Description: Description runtestsAndVerifyResults no longer needs adb root, and it only touches the one device it's aimed at. No root The test results XML lives in the app's private data dir, an...

Opengraph URL: https://github.com/NativeScript/android/pull/2098

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6d8b7376-0893-5745-ffd8-fdbdc10379cd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8BA6:842EC:17BA798:1FA4E4E:6B0146D1
html-safe-nonce4f1de1c723d45321fe53aec52eb7e1551ea770a57c06576bc9157fbb556ec9a0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkE2Ojg0MkVDOjE3QkE3OTg6MUZBNEU0RTo2QjAxNDZEMSIsInZpc2l0b3JfaWQiOiI1MjczMzMyNzgwMjEyNzY2NDE3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca7a1e8366aa999c96595f996ea6c87c1532aa96d848720b5b3c142d4ae503444
hovercard-subject-tagpull_request:5216406194
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/android/pull/2098/files
twitter:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
og:image:altDescription runtestsAndVerifyResults no longer needs adb root, and it only touches the one device it's aimed at. No root The test results XML lives in the app's private data dir, and the de...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/android git https://github.com/NativeScript/android.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id29137950
octolytics-dimension-repository_nwoNativeScript/android
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id29137950
octolytics-dimension-repository_network_root_nwoNativeScript/android
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/android/pull/2098/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2098%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2098%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fandroid
Reloadhttps://github.com/NativeScript/android/pull/2098/files
Reloadhttps://github.com/NativeScript/android/pull/2098/files
Reloadhttps://github.com/NativeScript/android/pull/2098/files
NativeScripthttps://github.com/NativeScript
androidhttps://github.com/NativeScript/android
Codehttps://github.com/NativeScript/android
Issues106 (106)https://github.com/NativeScript/android/issues
Pull requests24 (24)https://github.com/NativeScript/android/pulls
Actionshttps://github.com/NativeScript/android/actions
Projectshttps://github.com/NativeScript/android/projects
Wikihttps://github.com/NativeScript/android/wiki
Security and qualityhttps://github.com/NativeScript/android/security
Insightshttps://github.com/NativeScript/android/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
edusperonihttps://github.com/edusperoni
mainhttps://github.com/NativeScript/android/tree/main
ci/runtests-no-roothttps://github.com/NativeScript/android/tree/ci/runtests-no-root
Conversation 7 https://github.com/NativeScript/android/pull/2098
Commits 4 https://github.com/NativeScript/android/pull/2098/commits
Checks 8 https://github.com/NativeScript/android/pull/2098/checks
Files changed https://github.com/NativeScript/android/pull/2098/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2098/files
ci(tests): fetch test results without adb root https://github.com/NativeScript/android/pull/2098/files#top
Show all changes 4 commits https://github.com/NativeScript/android/pull/2098/files
7ef912f ci(tests): fetch test results without adb root edusperoni Nov 8, 2026 https://github.com/NativeScript/android/pull/2098/commits/7ef912f615e58d0b7c1adf2caa6e0def16a14b14
540ae7c ci(tests): pin runs to one device and tolerate slow adb calls edusperoni Nov 9, 2026 https://github.com/NativeScript/android/pull/2098/commits/540ae7ce86fe7cfbaf53140ad4a68e2b8dd556b5
c8a4ba1 ci(tests): raise the poller's exec output limit edusperoni Nov 9, 2026 https://github.com/NativeScript/android/pull/2098/commits/c8a4ba15a03c3316b3ebd23ff809d88517f17d9c
0149854 ci(tests): fall back to ps when the device has no pidof edusperoni Nov 9, 2026 https://github.com/NativeScript/android/pull/2098/commits/014985443e92d1b77c091c688296f38bb4f0037c
Clear filters https://github.com/NativeScript/android/pull/2098/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2098/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2098/files
runtests.gradle https://github.com/NativeScript/android/pull/2098/files#diff-0863940298ad310c8bbfe0dc3208f87c820e19182b2a04992c2c1318ceb383f5
make_sure_emulator_is_ready.js https://github.com/NativeScript/android/pull/2098/files#diff-7c0d03016fb4e65c11ec7b174e50410cc5e3b59544a41bdce8965679604f585e
try_to_find_test_result_file.js https://github.com/NativeScript/android/pull/2098/files#diff-6c271cd42254e3144102badb06d0fd1b71bab8a0ff78b2f5051d6da6948f9712
test-app/runtests.gradlehttps://github.com/NativeScript/android/pull/2098/files#diff-0863940298ad310c8bbfe0dc3208f87c820e19182b2a04992c2c1318ceb383f5
View file https://github.com/NativeScript/android/blob/014985443e92d1b77c091c688296f38bb4f0037c/test-app/runtests.gradle
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2098/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2098/files#diff-0863940298ad310c8bbfe0dc3208f87c820e19182b2a04992c2c1318ceb383f5
https://github.com/NativeScript/android/pull/2098/files#diff-0863940298ad310c8bbfe0dc3208f87c820e19182b2a04992c2c1318ceb383f5
https://github.com/NativeScript/android/pull/2098/files#diff-0863940298ad310c8bbfe0dc3208f87c820e19182b2a04992c2c1318ceb383f5
https://github.com/NativeScript/android/pull/2098/files#diff-0863940298ad310c8bbfe0dc3208f87c820e19182b2a04992c2c1318ceb383f5
https://github.com/NativeScript/android/pull/2098/files#diff-0863940298ad310c8bbfe0dc3208f87c820e19182b2a04992c2c1318ceb383f5
https://github.com/NativeScript/android/pull/2098/files#diff-0863940298ad310c8bbfe0dc3208f87c820e19182b2a04992c2c1318ceb383f5
https://github.com/NativeScript/android/pull/2098/files#diff-0863940298ad310c8bbfe0dc3208f87c820e19182b2a04992c2c1318ceb383f5
https://github.com/NativeScript/android/pull/2098/files#diff-0863940298ad310c8bbfe0dc3208f87c820e19182b2a04992c2c1318ceb383f5
https://github.com/NativeScript/android/pull/2098/files#diff-0863940298ad310c8bbfe0dc3208f87c820e19182b2a04992c2c1318ceb383f5
test-app/tools/make_sure_emulator_is_ready.jshttps://github.com/NativeScript/android/pull/2098/files#diff-7c0d03016fb4e65c11ec7b174e50410cc5e3b59544a41bdce8965679604f585e
View file https://github.com/NativeScript/android/blob/014985443e92d1b77c091c688296f38bb4f0037c/test-app/tools/make_sure_emulator_is_ready.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2098/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2098/files#diff-7c0d03016fb4e65c11ec7b174e50410cc5e3b59544a41bdce8965679604f585e
https://github.com/NativeScript/android/pull/2098/files#diff-7c0d03016fb4e65c11ec7b174e50410cc5e3b59544a41bdce8965679604f585e
test-app/tools/try_to_find_test_result_file.jshttps://github.com/NativeScript/android/pull/2098/files#diff-6c271cd42254e3144102badb06d0fd1b71bab8a0ff78b2f5051d6da6948f9712
View file https://github.com/NativeScript/android/blob/014985443e92d1b77c091c688296f38bb4f0037c/test-app/tools/try_to_find_test_result_file.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2098/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2098/files#diff-6c271cd42254e3144102badb06d0fd1b71bab8a0ff78b2f5051d6da6948f9712
https://github.com/NativeScript/android/pull/2098/files#diff-6c271cd42254e3144102badb06d0fd1b71bab8a0ff78b2f5051d6da6948f9712
https://github.com/NativeScript/android/pull/2098/files#diff-6c271cd42254e3144102badb06d0fd1b71bab8a0ff78b2f5051d6da6948f9712
https://github.com/NativeScript/android/pull/2098/files#diff-6c271cd42254e3144102badb06d0fd1b71bab8a0ff78b2f5051d6da6948f9712
https://github.com/NativeScript/android/pull/2098/files#diff-6c271cd42254e3144102badb06d0fd1b71bab8a0ff78b2f5051d6da6948f9712
Please reload this pagehttps://github.com/NativeScript/android/pull/2098/files
https://github.com/NativeScript/android/pull/2098/files#diff-6c271cd42254e3144102badb06d0fd1b71bab8a0ff78b2f5051d6da6948f9712
Please reload this pagehttps://github.com/NativeScript/android/pull/2098/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.