René's URL Explorer Experiment


Title: fix(worker): open a handle scope per delivered message, and fix two messaging specs by edusperoni · Pull Request #2090 · NativeScript/android · GitHub

Open Graph Title: fix(worker): open a handle scope per delivered message, and fix two messaging specs by edusperoni · Pull Request #2090 · NativeScript/android

X Title: fix(worker): open a handle scope per delivered message, and fix two messaging specs by edusperoni · Pull Request #2090 · NativeScript/android

Description: Three fixes from CodeRabbit's review of #2043 and #2040 that weren't addressed before the stack merged. A handle scope per delivered worker message. WorkerWrapper::DrainPendingTasks dispatches a whole batch of queued messages under one HandleScope, and WorkerEvents::EmitMessage opened none of its own. So the handles created while delivering every message in a batch (the deserialized payload, ports, the event and whatever listeners allocate) stayed alive until the batch ended. EmitMessage now opens its own scope, which is what the comment on SerializedValue::Deserialize already says each caller does. The parent-side path and NativeMessagePort::Drain already had a per-message scope. The on() + once() spec waited for the wrong reply. "lets the same listener be on() and once() at the same time" started its settle timer at the third reply but expects four, so it failed whenever the fourth reply took longer than the 400 ms settle window. It now waits for the fourth reply and then settles to catch a fifth. Its comment had the two registrations swapped and is corrected too. A caller-set DOMException stack. The structuredClone canary now sets a sentinel stack and asserts that the clone carries it. Before, only the stack the constructor generates was checked. Independent of #2087, #2088 and #2089; it merges cleanly with each of them, in any order. Full device suite on a Pixel_3a_API_36 arm64 emulator: 1456 specs, 0 failures. The same EmitMessage scope gap (Worker.mm OnMessageCallback) and the same spec bug (MessagingTests.js) exist on iOS. Summary by CodeRabbit Bug Fixes Improved worker message handling to support reliable delivery when the same listener is registered for both repeated and one-time notifications.

Open Graph Description: Three fixes from CodeRabbit's review of #2043 and #2040 that weren't addressed before the stack merged. A handle scope per delivered worker message. WorkerWrapper::DrainPendingTasks dispat...

X Description: Three fixes from CodeRabbit's review of #2043 and #2040 that weren't addressed before the stack merged. A handle scope per delivered worker message. WorkerWrapper::DrainPendingTask...

Opengraph URL: https://github.com/NativeScript/android/pull/2090

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f8823d88-bf2e-ddf1-b69d-431c86403dc3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B22:33D24F:147A7F0:1A4489B:6B013209
html-safe-nonceecb81878a2bed98cb5cd3786cd7c3e32787409ac10c59d8930b2effb6fb91919
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjIyOjMzRDI0RjoxNDdBN0YwOjFBNDQ4OUI6NkIwMTMyMDkiLCJ2aXNpdG9yX2lkIjoiNjc5NzI0OTI1MTk5NTg5MDE4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccd1bc61c53367711d00476ec5c042473752cae47a84b933563165cd18f3e4e44
hovercard-subject-tagpull_request:5177413469
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/android/pull/2090/files
twitter:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
og:image:altThree fixes from CodeRabbit's review of #2043 and #2040 that weren't addressed before the stack merged. A handle scope per delivered worker message. WorkerWrapper::DrainPendingTasks dispat...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/android git https://github.com/NativeScript/android.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id29137950
octolytics-dimension-repository_nwoNativeScript/android
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id29137950
octolytics-dimension-repository_network_root_nwoNativeScript/android
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/android/pull/2090/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2090%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2090%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fandroid
Reloadhttps://github.com/NativeScript/android/pull/2090/files
Reloadhttps://github.com/NativeScript/android/pull/2090/files
Reloadhttps://github.com/NativeScript/android/pull/2090/files
NativeScripthttps://github.com/NativeScript
androidhttps://github.com/NativeScript/android
Codehttps://github.com/NativeScript/android
Issues106 (106)https://github.com/NativeScript/android/issues
Pull requests24 (24)https://github.com/NativeScript/android/pulls
Actionshttps://github.com/NativeScript/android/actions
Projectshttps://github.com/NativeScript/android/projects
Wikihttps://github.com/NativeScript/android/wiki
Security and qualityhttps://github.com/NativeScript/android/security
Insightshttps://github.com/NativeScript/android/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
edusperonihttps://github.com/edusperoni
mainhttps://github.com/NativeScript/android/tree/main
fix/coderabbit-worker-followupshttps://github.com/NativeScript/android/tree/fix/coderabbit-worker-followups
Conversation 1 https://github.com/NativeScript/android/pull/2090
Commits 2 https://github.com/NativeScript/android/pull/2090/commits
Checks 8 https://github.com/NativeScript/android/pull/2090/checks
Files changed https://github.com/NativeScript/android/pull/2090/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2090/files
fix(worker): open a handle scope per delivered message, and fix two messaging specs https://github.com/NativeScript/android/pull/2090/files#top
Show all changes 2 commits https://github.com/NativeScript/android/pull/2090/files
0e9f6d4 test: assert a caller-set DOMException stack survives structuredClone edusperoni Nov 5, 2026 https://github.com/NativeScript/android/pull/2090/commits/0e9f6d428b6e9dc6cf2038971c5828ccbabc6243
b5b3f89 fix(worker): open a handle scope per delivered message, and wait for … edusperoni Nov 5, 2026 https://github.com/NativeScript/android/pull/2090/commits/b5b3f89006f2783a1440767ce04c60687ff8670b
Clear filters https://github.com/NativeScript/android/pull/2090/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2090/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2090/files
testMessaging.js https://github.com/NativeScript/android/pull/2090/files#diff-5ccfdc56f7ca4f349093e9d70b2342aa9590b99b78316ca51618a7f75766f55f
testRuntimeImplementedAPIs.js https://github.com/NativeScript/android/pull/2090/files#diff-89343d9468adafa4af36913353fa34980684c0c97df0ddeb5095c785f5230087
WorkerEvents.cpp https://github.com/NativeScript/android/pull/2090/files#diff-2e0498536ef0cddf4c00cfdacbfca48ca3b0c16abfdd51f8b86779cd02ec76ab
test-app/app/src/main/assets/app/tests/testMessaging.jshttps://github.com/NativeScript/android/pull/2090/files#diff-5ccfdc56f7ca4f349093e9d70b2342aa9590b99b78316ca51618a7f75766f55f
View file https://github.com/NativeScript/android/blob/b5b3f89006f2783a1440767ce04c60687ff8670b/test-app/app/src/main/assets/app/tests/testMessaging.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2090/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2090/files#diff-5ccfdc56f7ca4f349093e9d70b2342aa9590b99b78316ca51618a7f75766f55f
https://github.com/NativeScript/android/pull/2090/files#diff-5ccfdc56f7ca4f349093e9d70b2342aa9590b99b78316ca51618a7f75766f55f
test-app/app/src/main/assets/app/tests/testRuntimeImplementedAPIs.jshttps://github.com/NativeScript/android/pull/2090/files#diff-89343d9468adafa4af36913353fa34980684c0c97df0ddeb5095c785f5230087
View file https://github.com/NativeScript/android/blob/b5b3f89006f2783a1440767ce04c60687ff8670b/test-app/app/src/main/assets/app/tests/testRuntimeImplementedAPIs.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2090/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2090/files#diff-89343d9468adafa4af36913353fa34980684c0c97df0ddeb5095c785f5230087
https://github.com/NativeScript/android/pull/2090/files#diff-89343d9468adafa4af36913353fa34980684c0c97df0ddeb5095c785f5230087
test-app/runtime/src/main/cpp/WorkerEvents.cpphttps://github.com/NativeScript/android/pull/2090/files#diff-2e0498536ef0cddf4c00cfdacbfca48ca3b0c16abfdd51f8b86779cd02ec76ab
View file https://github.com/NativeScript/android/blob/b5b3f89006f2783a1440767ce04c60687ff8670b/test-app/runtime/src/main/cpp/WorkerEvents.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2090/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2090/files#diff-2e0498536ef0cddf4c00cfdacbfca48ca3b0c16abfdd51f8b86779cd02ec76ab
https://github.com/NativeScript/android/pull/2090/files#diff-2e0498536ef0cddf4c00cfdacbfca48ca3b0c16abfdd51f8b86779cd02ec76ab
Please reload this pagehttps://github.com/NativeScript/android/pull/2090/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.