René's URL Explorer Experiment


Title: fix(runtime): keep clone-only message reads read-only, and see an uncloneable brand created mid-clone by edusperoni · Pull Request #2088 · NativeScript/android · GitHub

Open Graph Title: fix(runtime): keep clone-only message reads read-only, and see an uncloneable brand created mid-clone by edusperoni · Pull Request #2088 · NativeScript/android

X Title: fix(runtime): keep clone-only message reads read-only, and see an uncloneable brand created mid-clone by edusperoni · Pull Request #2088 · NativeScript/android

Description: Supersedes #2064, which GitHub closed when its base branch (feat/worker-threads) was deleted at the #2043 squash. The commit is @adrian-niculescu's, replayed onto main with authorship kept. The only conflict was the adjacent spec additions in testMessaging.js. An object marked with markAsUncloneable from a getter, during the clone that reaches it, is cloned instead of throwing DataCloneError when that is the first markAsUncloneable call in the isolate. The serializer reads the brand once, when it is constructed, and at that point the brand does not exist yet. It now picks the brand up once markAsUncloneable creates it. Separately, SerializedValue::Deserialize cleared its transfer vectors on every read. A clone-only message is read by every BroadcastChannel receiver, and every getEnvironmentData call, with no lock, so those clears were concurrent writes to shared state, against what the comment on the consumed_ flag intends. Only the single receiver of a message with transferables writes them now. The same fix for iOS is NativeScript/ios#490; the StructuredSerialization.cpp change matches it. Merge after #2087. This branch is stacked on it, so until that squash lands the diff here also shows its commits. Full device suite with both applied: 1462 specs, 0 failures. Summary by CodeRabbit Bug Fixes Message delivery now preserves undefined payloads across message ports, broadcast channels, and workers, while constructed message events retain the expected default of null. Message deserialization errors now provide the relevant exception as event data, falling back to null when unavailable. Improved handling of uncloneable objects detected during serialization and messages containing transferables.

Open Graph Description: Supersedes #2064, which GitHub closed when its base branch (feat/worker-threads) was deleted at the #2043 squash. The commit is @adrian-niculescu's, replayed onto main with authorship kept. The...

X Description: Supersedes #2064, which GitHub closed when its base branch (feat/worker-threads) was deleted at the #2043 squash. The commit is @adrian-niculescu's, replayed onto main with authorship kept....

Opengraph URL: https://github.com/NativeScript/android/pull/2088

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6502dcab-d6e1-3cb7-b532-1af7e275c5c9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC32C:AC6A2:265D0:336FC:6B015ADE
html-safe-nonce577688b2044b13545316dc067c295ca519bbfbd9d779524fa800e924dd27d744
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzJDOkFDNkEyOjI2NUQwOjMzNkZDOjZCMDE1QURFIiwidmlzaXRvcl9pZCI6IjQ2MTA4NTM2NTU1NjA2NzQwMTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc6674d0be700c6fd2950f837b3f13be2c9774f5d832e6e0385df282d4b7a7e7c
hovercard-subject-tagpull_request:5177388897
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/android/pull/2088/files
twitter:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
og:image:altSupersedes #2064, which GitHub closed when its base branch (feat/worker-threads) was deleted at the #2043 squash. The commit is @adrian-niculescu's, replayed onto main with authorship kept. The...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/android git https://github.com/NativeScript/android.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id29137950
octolytics-dimension-repository_nwoNativeScript/android
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id29137950
octolytics-dimension-repository_network_root_nwoNativeScript/android
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/android/pull/2088/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2088%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2088%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fandroid
Reloadhttps://github.com/NativeScript/android/pull/2088/files
Reloadhttps://github.com/NativeScript/android/pull/2088/files
Reloadhttps://github.com/NativeScript/android/pull/2088/files
NativeScripthttps://github.com/NativeScript
androidhttps://github.com/NativeScript/android
Codehttps://github.com/NativeScript/android
Issues106 (106)https://github.com/NativeScript/android/issues
Pull requests26 (26)https://github.com/NativeScript/android/pulls
Actionshttps://github.com/NativeScript/android/actions
Projectshttps://github.com/NativeScript/android/projects
Wikihttps://github.com/NativeScript/android/wiki
Security and qualityhttps://github.com/NativeScript/android/security
Insightshttps://github.com/NativeScript/android/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
edusperonihttps://github.com/edusperoni
mainhttps://github.com/NativeScript/android/tree/main
fix/serialization-shared-readshttps://github.com/NativeScript/android/tree/fix/serialization-shared-reads
Conversation 1 https://github.com/NativeScript/android/pull/2088
Commits 2 https://github.com/NativeScript/android/pull/2088/commits
Checks 8 https://github.com/NativeScript/android/pull/2088/checks
Files changed https://github.com/NativeScript/android/pull/2088/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2088/files
fix(runtime): keep clone-only message reads read-only, and see an uncloneable brand created mid-clone https://github.com/NativeScript/android/pull/2088/files#top
Show all changes 2 commits https://github.com/NativeScript/android/pull/2088/files
93f917d fix(runtime): keep clone-only message reads read-only, and see an unc… adrian-niculescu Oct 6, 2026 https://github.com/NativeScript/android/pull/2088/commits/93f917dd130741570e7d314bd13894246a7b46ce
4088462 fix(runtime): don't cache an uncloneable brand handle made inside IsH… edusperoni Nov 5, 2026 https://github.com/NativeScript/android/pull/2088/commits/408846232c3c77bb463ec28a56b89d23bf6c1eee
Clear filters https://github.com/NativeScript/android/pull/2088/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2088/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2088/files
uncloneableAfterGetterWorker.js https://github.com/NativeScript/android/pull/2088/files#diff-48a6a4eec2b209ee98b0ca80782d9df4076966d1cec7d14335b54c5ce8e21c2f
uncloneableInGetterWorker.js https://github.com/NativeScript/android/pull/2088/files#diff-14d395aa72b608637e975681d6c0f565e26b3bc844d8c60920f324b1105ddad2
testMessaging.js https://github.com/NativeScript/android/pull/2088/files#diff-5ccfdc56f7ca4f349093e9d70b2342aa9590b99b78316ca51618a7f75766f55f
StructuredSerialization.cpp https://github.com/NativeScript/android/pull/2088/files#diff-b29450591b552ab7ef39137177cf76bc0a396ba3ef646332e5e25d8b3867403c
test-app/app/src/main/assets/app/tests/messaging/uncloneableAfterGetterWorker.jshttps://github.com/NativeScript/android/pull/2088/files#diff-48a6a4eec2b209ee98b0ca80782d9df4076966d1cec7d14335b54c5ce8e21c2f
View file https://github.com/NativeScript/android/blob/408846232c3c77bb463ec28a56b89d23bf6c1eee/test-app/app/src/main/assets/app/tests/messaging/uncloneableAfterGetterWorker.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2088/{{ revealButtonHref }}
test-app/app/src/main/assets/app/tests/messaging/uncloneableInGetterWorker.jshttps://github.com/NativeScript/android/pull/2088/files#diff-14d395aa72b608637e975681d6c0f565e26b3bc844d8c60920f324b1105ddad2
View file https://github.com/NativeScript/android/blob/408846232c3c77bb463ec28a56b89d23bf6c1eee/test-app/app/src/main/assets/app/tests/messaging/uncloneableInGetterWorker.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2088/{{ revealButtonHref }}
test-app/app/src/main/assets/app/tests/testMessaging.jshttps://github.com/NativeScript/android/pull/2088/files#diff-5ccfdc56f7ca4f349093e9d70b2342aa9590b99b78316ca51618a7f75766f55f
View file https://github.com/NativeScript/android/blob/408846232c3c77bb463ec28a56b89d23bf6c1eee/test-app/app/src/main/assets/app/tests/testMessaging.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2088/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2088/files#diff-5ccfdc56f7ca4f349093e9d70b2342aa9590b99b78316ca51618a7f75766f55f
https://github.com/NativeScript/android/pull/2088/files#diff-5ccfdc56f7ca4f349093e9d70b2342aa9590b99b78316ca51618a7f75766f55f
test-app/runtime/src/main/cpp/StructuredSerialization.cpphttps://github.com/NativeScript/android/pull/2088/files#diff-b29450591b552ab7ef39137177cf76bc0a396ba3ef646332e5e25d8b3867403c
View file https://github.com/NativeScript/android/blob/408846232c3c77bb463ec28a56b89d23bf6c1eee/test-app/runtime/src/main/cpp/StructuredSerialization.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2088/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2088/files#diff-b29450591b552ab7ef39137177cf76bc0a396ba3ef646332e5e25d8b3867403c
https://github.com/NativeScript/android/pull/2088/files#diff-b29450591b552ab7ef39137177cf76bc0a396ba3ef646332e5e25d8b3867403c
https://github.com/NativeScript/android/pull/2088/files#diff-b29450591b552ab7ef39137177cf76bc0a396ba3ef646332e5e25d8b3867403c
https://github.com/NativeScript/android/pull/2088/files#diff-b29450591b552ab7ef39137177cf76bc0a396ba3ef646332e5e25d8b3867403c
https://github.com/NativeScript/android/pull/2088/files#diff-b29450591b552ab7ef39137177cf76bc0a396ba3ef646332e5e25d8b3867403c
https://github.com/NativeScript/android/pull/2088/files#diff-b29450591b552ab7ef39137177cf76bc0a396ba3ef646332e5e25d8b3867403c
Please reload this pagehttps://github.com/NativeScript/android/pull/2088/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.