René's URL Explorer Experiment


Title: perf: ArrayBuffer.from without the isDirect() call by triniwiz · Pull Request #2076 · NativeScript/android · GitHub

Open Graph Title: perf: ArrayBuffer.from without the isDirect() call by triniwiz · Pull Request #2076 · NativeScript/android

X Title: perf: ArrayBuffer.from without the isDirect() call by triniwiz · Pull Request #2076 · NativeScript/android

Description: What ArrayBuffer.from(byteBuffer) called ByteBuffer.isDirect() in Java to choose between the direct and copying paths. GetDirectBufferAddress already returns null for a heap buffer, so the null check now picks the path and the Java call is gone. A direct buffer whose address is unavailable falls back to the copying path, which works for both kinds. The nativeObject key set on the returned buffer is now one internalized v8::Eternal string, so a new string is no longer made on every call. Measurements Measured together with #2075 (same setup and numbers there): grid-dashboard and tree-fanout attached 0.96, other scenarios flat. This part on its own removes one JNI call into Java and one string allocation per ArrayBuffer.from. Testing :runtime:assembleRelease -Poptimized -Pabis=arm64-v8a builds; ran in the benchmark app as above. The runtime test suite has not been run. Summary by CodeRabbit Bug Fixes Improved handling of Java byte buffers when creating array buffers. Direct buffers can share their underlying storage, while other buffers retain their remaining bytes through a copy. This helps ensure buffer contents are available in the resulting array buffer across both buffer types.

Open Graph Description: What ArrayBuffer.from(byteBuffer) called ByteBuffer.isDirect() in Java to choose between the direct and copying paths. GetDirectBufferAddress already returns null for a heap buffer, so the null che...

X Description: What ArrayBuffer.from(byteBuffer) called ByteBuffer.isDirect() in Java to choose between the direct and copying paths. GetDirectBufferAddress already returns null for a heap buffer, so the null che...

Opengraph URL: https://github.com/NativeScript/android/pull/2076

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:08aa0371-e988-6d96-16f2-949f7b04168b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC62A:117C62:157346A:1C9E069:6B013886
html-safe-nonce46be2e92288aff2303bf486455386cac35aa909be27511a376064d690f187c26
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjJBOjExN0M2MjoxNTczNDZBOjFDOUUwNjk6NkIwMTM4ODYiLCJ2aXNpdG9yX2lkIjoiNDU3ODYyNzQ5MzczNjU2MDc3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacebfdc2a0bbd080da6f7ad2ca1d6b2b31a54889addb9dcae20a4437749e73348b
hovercard-subject-tagpull_request:5102386285
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/android/pull/2076/files
twitter:imagehttps://avatars.githubusercontent.com/u/6695919?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6695919?s=400&v=4
og:image:altWhat ArrayBuffer.from(byteBuffer) called ByteBuffer.isDirect() in Java to choose between the direct and copying paths. GetDirectBufferAddress already returns null for a heap buffer, so the null che...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/android git https://github.com/NativeScript/android.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id29137950
octolytics-dimension-repository_nwoNativeScript/android
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id29137950
octolytics-dimension-repository_network_root_nwoNativeScript/android
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/android/pull/2076/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2076%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2076%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fandroid
Reloadhttps://github.com/NativeScript/android/pull/2076/files
Reloadhttps://github.com/NativeScript/android/pull/2076/files
Reloadhttps://github.com/NativeScript/android/pull/2076/files
NativeScripthttps://github.com/NativeScript
androidhttps://github.com/NativeScript/android
Codehttps://github.com/NativeScript/android
Issues106 (106)https://github.com/NativeScript/android/issues
Pull requests24 (24)https://github.com/NativeScript/android/pulls
Actionshttps://github.com/NativeScript/android/actions
Projectshttps://github.com/NativeScript/android/projects
Wikihttps://github.com/NativeScript/android/wiki
Security and qualityhttps://github.com/NativeScript/android/security
Insightshttps://github.com/NativeScript/android/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
edusperonihttps://github.com/edusperoni
mainhttps://github.com/NativeScript/android/tree/main
perf/arraybuffer-fromhttps://github.com/NativeScript/android/tree/perf/arraybuffer-from
Conversation 1 https://github.com/NativeScript/android/pull/2076
Commits 1 https://github.com/NativeScript/android/pull/2076/commits
Checks 8 https://github.com/NativeScript/android/pull/2076/checks
Files changed https://github.com/NativeScript/android/pull/2076/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2076/files
perf: ArrayBuffer.from without the isDirect() call https://github.com/NativeScript/android/pull/2076/files#top
Show all changes 1 commit https://github.com/NativeScript/android/pull/2076/files
17268bf perf: ArrayBuffer.from without the isDirect() call triniwiz Oct 31, 2026 https://github.com/NativeScript/android/pull/2076/commits/17268bfd4d0af145d3d62dc6024e66157354d61b
Clear filters https://github.com/NativeScript/android/pull/2076/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2076/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2076/files
ArrayBufferHelper.cpp https://github.com/NativeScript/android/pull/2076/files#diff-e77228e12c94770c10f5c1c3d4ca713b50d743b18b8bca784d17047251ba9ecc
ArrayBufferHelper.h https://github.com/NativeScript/android/pull/2076/files#diff-7a772502af80a384b9d22ef4afd6cb2e93b2439eae9629483cd9b2084f55c562
test-app/runtime/src/main/cpp/ArrayBufferHelper.cpphttps://github.com/NativeScript/android/pull/2076/files#diff-e77228e12c94770c10f5c1c3d4ca713b50d743b18b8bca784d17047251ba9ecc
View file https://github.com/NativeScript/android/blob/17268bfd4d0af145d3d62dc6024e66157354d61b/test-app/runtime/src/main/cpp/ArrayBufferHelper.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2076/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2076/files#diff-e77228e12c94770c10f5c1c3d4ca713b50d743b18b8bca784d17047251ba9ecc
https://github.com/NativeScript/android/pull/2076/files#diff-e77228e12c94770c10f5c1c3d4ca713b50d743b18b8bca784d17047251ba9ecc
https://github.com/NativeScript/android/pull/2076/files#diff-e77228e12c94770c10f5c1c3d4ca713b50d743b18b8bca784d17047251ba9ecc
https://github.com/NativeScript/android/pull/2076/files#diff-e77228e12c94770c10f5c1c3d4ca713b50d743b18b8bca784d17047251ba9ecc
https://github.com/NativeScript/android/pull/2076/files#diff-e77228e12c94770c10f5c1c3d4ca713b50d743b18b8bca784d17047251ba9ecc
https://github.com/NativeScript/android/pull/2076/files#diff-e77228e12c94770c10f5c1c3d4ca713b50d743b18b8bca784d17047251ba9ecc
https://github.com/NativeScript/android/pull/2076/files#diff-e77228e12c94770c10f5c1c3d4ca713b50d743b18b8bca784d17047251ba9ecc
test-app/runtime/src/main/cpp/ArrayBufferHelper.hhttps://github.com/NativeScript/android/pull/2076/files#diff-7a772502af80a384b9d22ef4afd6cb2e93b2439eae9629483cd9b2084f55c562
View file https://github.com/NativeScript/android/blob/17268bfd4d0af145d3d62dc6024e66157354d61b/test-app/runtime/src/main/cpp/ArrayBufferHelper.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2076/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2076/files#diff-7a772502af80a384b9d22ef4afd6cb2e93b2439eae9629483cd9b2084f55c562
https://github.com/NativeScript/android/pull/2076/files#diff-7a772502af80a384b9d22ef4afd6cb2e93b2439eae9629483cd9b2084f55c562
Please reload this pagehttps://github.com/NativeScript/android/pull/2076/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.