René's URL Explorer Experiment


Title: perf: skip Class.getName() when wrapping a returned object of a seen class by triniwiz · Pull Request #2075 · NativeScript/android · GitHub

Open Graph Title: perf: skip Class.getName() when wrapping a returned object of a seen class by triniwiz · Pull Request #2075 · NativeScript/android

X Title: perf: skip Class.getName() when wrapping a returned object of a seen class by triniwiz · Pull Request #2075 · NativeScript/android

Description: What When a Java method returns an object that has no JS wrapper yet, ObjectManager::CreateJSWrapper called Class.getName() in Java, copied the jstring into a std::string, replaced . with /, and then looked the class up again with FindClass for Link. ObjectManager now remembers up to four runtime classes per declared type. Each is matched with IsSameObject, which runs no Java code, and the cached class name and global class are reused. On a miss the old path runs, with FindClass still after the wrapper is created. The cached jclass values come from JEnv's class cache, whose global refs are never deleted. Measurements Pixel 9 Pro emulator (arm64, headless), xplat-benchmarks NativeScript app, size M, release build, 5 interleaved rounds. Both runtimes were built from main with and without this change and #2076 (measured together). attached B/A: Scenario attached per round grid-dashboard 0.96 0.95 0.95 0.99 0.97 0.98 tree-fanout 0.96 1.02 0.93 0.92 0.96 1.00 flex-wrap-tiles 1.00 styled-cards 1.01 text-flow 1.00 The gain is small; most of the per-object cost is still getOrCreateJavaObjectID, which this does not touch. Testing :runtime:assembleRelease -Poptimized -Pabis=arm64-v8a builds; the runtime swapped into a 9.1.1 app ran every benchmark round. The runtime test suite has not been run. Summary by CodeRabbit Performance Java-backed object wrappers can now be created with less repeated class lookup work, which may improve wrapper creation efficiency. Wrapper creation continues to use the runtime class when it differs from a previously linked class.

Open Graph Description: What When a Java method returns an object that has no JS wrapper yet, ObjectManager::CreateJSWrapper called Class.getName() in Java, copied the jstring into a std::string, replaced . with /, and th...

X Description: What When a Java method returns an object that has no JS wrapper yet, ObjectManager::CreateJSWrapper called Class.getName() in Java, copied the jstring into a std::string, replaced . with /, and th...

Opengraph URL: https://github.com/NativeScript/android/pull/2075

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:988ae136-3935-6de7-9e35-885a9658233b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA9C8:1201C:1863100:206DDA9:6B014427
html-safe-noncec219381779b66f20997860b34fd84aaba790af2e3da26d988163329faa45546b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUM4OjEyMDFDOjE4NjMxMDA6MjA2RERBOTo2QjAxNDQyNyIsInZpc2l0b3JfaWQiOiI3NzUzMjM2ODQxMzgyMDYyNDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2ec8995d6311d7dddde48ff777b83a7b40ba1d80bf2412ac7e5acbbc0a046173
hovercard-subject-tagpull_request:5102385229
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/android/pull/2075/files
twitter:imagehttps://avatars.githubusercontent.com/u/6695919?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6695919?s=400&v=4
og:image:altWhat When a Java method returns an object that has no JS wrapper yet, ObjectManager::CreateJSWrapper called Class.getName() in Java, copied the jstring into a std::string, replaced . with /, and th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/android git https://github.com/NativeScript/android.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id29137950
octolytics-dimension-repository_nwoNativeScript/android
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id29137950
octolytics-dimension-repository_network_root_nwoNativeScript/android
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/android/pull/2075/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2075%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2075%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fandroid
Reloadhttps://github.com/NativeScript/android/pull/2075/files
Reloadhttps://github.com/NativeScript/android/pull/2075/files
Reloadhttps://github.com/NativeScript/android/pull/2075/files
NativeScripthttps://github.com/NativeScript
androidhttps://github.com/NativeScript/android
Codehttps://github.com/NativeScript/android
Issues106 (106)https://github.com/NativeScript/android/issues
Pull requests24 (24)https://github.com/NativeScript/android/pulls
Actionshttps://github.com/NativeScript/android/actions
Projectshttps://github.com/NativeScript/android/projects
Wikihttps://github.com/NativeScript/android/wiki
Security and qualityhttps://github.com/NativeScript/android/security
Insightshttps://github.com/NativeScript/android/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
triniwizhttps://github.com/triniwiz
mainhttps://github.com/NativeScript/android/tree/main
perf/wrapper-class-cachehttps://github.com/NativeScript/android/tree/perf/wrapper-class-cache
Conversation 1 https://github.com/NativeScript/android/pull/2075
Commits 1 https://github.com/NativeScript/android/pull/2075/commits
Checks 8 https://github.com/NativeScript/android/pull/2075/checks
Files changed https://github.com/NativeScript/android/pull/2075/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2075/files
perf: skip Class.getName() when wrapping a returned object of a seen class https://github.com/NativeScript/android/pull/2075/files#top
Show all changes 1 commit https://github.com/NativeScript/android/pull/2075/files
f9c8af5 perf: skip Class.getName() when wrapping a returned object of a seen … triniwiz Oct 31, 2026 https://github.com/NativeScript/android/pull/2075/commits/f9c8af59c9e1affa34049540d30bedfb78a32937
Clear filters https://github.com/NativeScript/android/pull/2075/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2075/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2075/files
ObjectManager.cpp https://github.com/NativeScript/android/pull/2075/files#diff-0591ab8dc271af7e8ef11fabf0642e44b932f38003bd07a3696de149a02b2c9b
ObjectManager.h https://github.com/NativeScript/android/pull/2075/files#diff-d491cf1566875df8740b3e9d732ac891286a776623aad17b249b36781ac7047d
test-app/runtime/src/main/cpp/ObjectManager.cpphttps://github.com/NativeScript/android/pull/2075/files#diff-0591ab8dc271af7e8ef11fabf0642e44b932f38003bd07a3696de149a02b2c9b
View file https://github.com/NativeScript/android/blob/f9c8af59c9e1affa34049540d30bedfb78a32937/test-app/runtime/src/main/cpp/ObjectManager.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2075/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2075/files#diff-0591ab8dc271af7e8ef11fabf0642e44b932f38003bd07a3696de149a02b2c9b
https://github.com/NativeScript/android/pull/2075/files#diff-0591ab8dc271af7e8ef11fabf0642e44b932f38003bd07a3696de149a02b2c9b
test-app/runtime/src/main/cpp/ObjectManager.hhttps://github.com/NativeScript/android/pull/2075/files#diff-d491cf1566875df8740b3e9d732ac891286a776623aad17b249b36781ac7047d
View file https://github.com/NativeScript/android/blob/f9c8af59c9e1affa34049540d30bedfb78a32937/test-app/runtime/src/main/cpp/ObjectManager.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2075/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2075/files#diff-d491cf1566875df8740b3e9d732ac891286a776623aad17b249b36781ac7047d
https://github.com/NativeScript/android/pull/2075/files#diff-d491cf1566875df8740b3e9d732ac891286a776623aad17b249b36781ac7047d
https://github.com/NativeScript/android/pull/2075/files#diff-d491cf1566875df8740b3e9d732ac891286a776623aad17b249b36781ac7047d
https://github.com/NativeScript/android/pull/2075/files#diff-d491cf1566875df8740b3e9d732ac891286a776623aad17b249b36781ac7047d
Please reload this pagehttps://github.com/NativeScript/android/pull/2075/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.