| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8c6dae82-d65e-d4e7-ed64-0fcac4621e90 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CE98:2463BD:198EB24:20B1721:6B0138A5 |
| html-safe-nonce | bb697c1daf076f576ba4b055d40f9db14ccabf2483b7783173547cc5c97ffe8c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTk4OjI0NjNCRDoxOThFQjI0OjIwQjE3MjE6NkIwMTM4QTUiLCJ2aXNpdG9yX2lkIjoiMjkyMzkzMjk1NzE2NzEzODk4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | bf4e7d49e50ca7fd001a69ebb191084414eb3b83b0ccd8e727bb6e76359088c6 |
| hovercard-subject-tag | pull_request:4832809259 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/android/pull/2072/files |
| twitter:image | https://avatars.githubusercontent.com/u/4061767?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4061767?s=400&v=4 |
| og:image:alt | Description
Two small, independent commits in the JS-to-Java argument marshalling.
1. Remove the unused JSToJavaConverter
test-app/runtime/src/main/cpp/conversions/ (JSToJavaConverter, JNIArgRefsSt... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/NativeScript/android git https://github.com/NativeScript/android.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 29137950 |
| octolytics-dimension-repository_nwo | NativeScript/android |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 29137950 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/android |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/NativeScript/android/pull/2072/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2072%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2072%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fandroid |
| Reload | https://github.com/NativeScript/android/pull/2072/files |
| Reload | https://github.com/NativeScript/android/pull/2072/files |
| Reload | https://github.com/NativeScript/android/pull/2072/files |
| NativeScript | https://github.com/NativeScript |
| android | https://github.com/NativeScript/android |
| Code | https://github.com/NativeScript/android |
| Issues106 (106) | https://github.com/NativeScript/android/issues |
| Pull requests24 (24) | https://github.com/NativeScript/android/pulls |
| Actions | https://github.com/NativeScript/android/actions |
| Projects | https://github.com/NativeScript/android/projects |
| Wiki | https://github.com/NativeScript/android/wiki |
| Security and quality | https://github.com/NativeScript/android/security |
| Insights | https://github.com/NativeScript/android/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose |
| edusperoni | https://github.com/edusperoni |
| main | https://github.com/NativeScript/android/tree/main |
| chore/remove-dead-js-to-java-converter | https://github.com/NativeScript/android/tree/chore/remove-dead-js-to-java-converter |
|
Conversation
1
| https://github.com/NativeScript/android/pull/2072 |
|
Commits
2
| https://github.com/NativeScript/android/pull/2072/commits |
|
Checks
8
| https://github.com/NativeScript/android/pull/2072/checks |
|
Files changed
| https://github.com/NativeScript/android/pull/2072/files |
| Please reload this page | https://github.com/NativeScript/android/pull/2072/files |
|
chore(runtime): remove the unused JSToJavaConverter and reuse cached signature tokens
| https://github.com/NativeScript/android/pull/2072/files#top |
|
Show all changes
2 commits
| https://github.com/NativeScript/android/pull/2072/files |
|
4c6535e
chore(runtime): remove the unused JSToJavaConverter
edusperoni Oct 12, 2026
| https://github.com/NativeScript/android/pull/2072/commits/4c6535e73d8c87272c01c5b19c90cf40df10697f |
|
ee8114b
perf(runtime): reuse the cached signature tokens in JsArgConverter
edusperoni Oct 12, 2026
| https://github.com/NativeScript/android/pull/2072/commits/ee8114b6d11e77d2a115f1d9f4ad98cbf469da53 |
|
Clear filters
| https://github.com/NativeScript/android/pull/2072/files |
| Please reload this page | https://github.com/NativeScript/android/pull/2072/files |
| Please reload this page | https://github.com/NativeScript/android/pull/2072/files |
|
v8-14-migration.md
| https://github.com/NativeScript/android/pull/2072/files#diff-2df2cb15be19a3ae5c88e839d572eb050dec27a86a3464d08b54658df7b6c905 |
|
CMakeLists.txt
| https://github.com/NativeScript/android/pull/2072/files#diff-9aa48152a82c07a60ab6e09923a9b266e2985f78e579653848df730cd8ec5e4c |
|
CallbackHandlers.cpp
| https://github.com/NativeScript/android/pull/2072/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e |
|
JsArgConverter.cpp
| https://github.com/NativeScript/android/pull/2072/files#diff-9b41f905739990783e7f543f4c38aab34593873cf03762c959d6c3c7b6e991b7 |
|
JsArgConverter.h
| https://github.com/NativeScript/android/pull/2072/files#diff-bdd1e3debf725d5c60ef05e04e14346e55e103c6650314a49c83bf3d0c40cce6 |
|
CastTypes.h
| https://github.com/NativeScript/android/pull/2072/files#diff-1f6247d1ca79b6ea3732454971c6a58ddb6cf7146f340d1aa0a21eea00a35df4 |
|
ConversionConsts.h
| https://github.com/NativeScript/android/pull/2072/files#diff-dbcc9455cb19bdbb013563181c5ed17db0572e41ef2fd44a69cf75c2bdb6ad97 |
|
JNIArgRefsState.h
| https://github.com/NativeScript/android/pull/2072/files#diff-9f29e1dc73762da471b82ba9b18f91e7a2cfb22818e335b64e2804a02fb0485f |
|
JSToJavaConverter.cpp
| https://github.com/NativeScript/android/pull/2072/files#diff-37fa678bfbd89c41201fb6ec4e5478d8ba38e285984229f8160f7fffcc991c83 |
|
JSToJavaConverter.h
| https://github.com/NativeScript/android/pull/2072/files#diff-d549b378d1bfc37834219fd726f2fa3fa1455a32dba41c76071e69e624b99254 |
|
JSToJavaArraysConverter.cpp
| https://github.com/NativeScript/android/pull/2072/files#diff-93d4aee46b8aff7f09ecaa49c6ae56113e7a2273c7e65d98a4afd72a190ee45b |
|
JSToJavaArraysConverter.h
| https://github.com/NativeScript/android/pull/2072/files#diff-ed210af4b3f396c20086039712396df08315ef6d6760f10f30745c5f0e316a82 |
|
JSToJavaObjectsConverter.cpp
| https://github.com/NativeScript/android/pull/2072/files#diff-9c569fe7120beb768be43fa9b870d53c8bfb1809305c15b07f1e9f3445186480 |
|
JSToJavaObjectsConverter.h
| https://github.com/NativeScript/android/pull/2072/files#diff-8465d5afdf29c86020b90363a4351a0e8bf7459489f9ad8c381e899354eec802 |
|
JSToJavaPrimitivesConverter.cpp
| https://github.com/NativeScript/android/pull/2072/files#diff-329cabccb562f6925a4c4a1e3a965259cd40c80ef5d99076cc2d9864052c1aa8 |
|
JSToJavaPrimitivesConverter.h
| https://github.com/NativeScript/android/pull/2072/files#diff-a6191b8c2893ad256280e390c02c5a637f9b65087fd445c677720c16be2cc77b |
| docs/knowledge/v8-14-migration.md | https://github.com/NativeScript/android/pull/2072/files#diff-2df2cb15be19a3ae5c88e839d572eb050dec27a86a3464d08b54658df7b6c905 |
|
View file
| https://github.com/NativeScript/android/blob/ee8114b6d11e77d2a115f1d9f4ad98cbf469da53/docs/knowledge/v8-14-migration.md |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/NativeScript/android/pull/2072/{{ revealButtonHref }} |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-2df2cb15be19a3ae5c88e839d572eb050dec27a86a3464d08b54658df7b6c905 |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-2df2cb15be19a3ae5c88e839d572eb050dec27a86a3464d08b54658df7b6c905 |
| test-app/runtime/CMakeLists.txt | https://github.com/NativeScript/android/pull/2072/files#diff-9aa48152a82c07a60ab6e09923a9b266e2985f78e579653848df730cd8ec5e4c |
|
View file
| https://github.com/NativeScript/android/blob/ee8114b6d11e77d2a115f1d9f4ad98cbf469da53/test-app/runtime/CMakeLists.txt |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/NativeScript/android/pull/2072/{{ revealButtonHref }} |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-9aa48152a82c07a60ab6e09923a9b266e2985f78e579653848df730cd8ec5e4c |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-9aa48152a82c07a60ab6e09923a9b266e2985f78e579653848df730cd8ec5e4c |
| test-app/runtime/src/main/cpp/CallbackHandlers.cpp | https://github.com/NativeScript/android/pull/2072/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e |
|
View file
| https://github.com/NativeScript/android/blob/ee8114b6d11e77d2a115f1d9f4ad98cbf469da53/test-app/runtime/src/main/cpp/CallbackHandlers.cpp |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/NativeScript/android/pull/2072/{{ revealButtonHref }} |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e |
| test-app/runtime/src/main/cpp/JsArgConverter.cpp | https://github.com/NativeScript/android/pull/2072/files#diff-9b41f905739990783e7f543f4c38aab34593873cf03762c959d6c3c7b6e991b7 |
|
View file
| https://github.com/NativeScript/android/blob/ee8114b6d11e77d2a115f1d9f4ad98cbf469da53/test-app/runtime/src/main/cpp/JsArgConverter.cpp |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/NativeScript/android/pull/2072/{{ revealButtonHref }} |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-9b41f905739990783e7f543f4c38aab34593873cf03762c959d6c3c7b6e991b7 |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-9b41f905739990783e7f543f4c38aab34593873cf03762c959d6c3c7b6e991b7 |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-9b41f905739990783e7f543f4c38aab34593873cf03762c959d6c3c7b6e991b7 |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-9b41f905739990783e7f543f4c38aab34593873cf03762c959d6c3c7b6e991b7 |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-9b41f905739990783e7f543f4c38aab34593873cf03762c959d6c3c7b6e991b7 |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-9b41f905739990783e7f543f4c38aab34593873cf03762c959d6c3c7b6e991b7 |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-9b41f905739990783e7f543f4c38aab34593873cf03762c959d6c3c7b6e991b7 |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-9b41f905739990783e7f543f4c38aab34593873cf03762c959d6c3c7b6e991b7 |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-9b41f905739990783e7f543f4c38aab34593873cf03762c959d6c3c7b6e991b7 |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-9b41f905739990783e7f543f4c38aab34593873cf03762c959d6c3c7b6e991b7 |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-9b41f905739990783e7f543f4c38aab34593873cf03762c959d6c3c7b6e991b7 |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-9b41f905739990783e7f543f4c38aab34593873cf03762c959d6c3c7b6e991b7 |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-9b41f905739990783e7f543f4c38aab34593873cf03762c959d6c3c7b6e991b7 |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-9b41f905739990783e7f543f4c38aab34593873cf03762c959d6c3c7b6e991b7 |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-9b41f905739990783e7f543f4c38aab34593873cf03762c959d6c3c7b6e991b7 |
| test-app/runtime/src/main/cpp/JsArgConverter.h | https://github.com/NativeScript/android/pull/2072/files#diff-bdd1e3debf725d5c60ef05e04e14346e55e103c6650314a49c83bf3d0c40cce6 |
|
View file
| https://github.com/NativeScript/android/blob/ee8114b6d11e77d2a115f1d9f4ad98cbf469da53/test-app/runtime/src/main/cpp/JsArgConverter.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/NativeScript/android/pull/2072/{{ revealButtonHref }} |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-bdd1e3debf725d5c60ef05e04e14346e55e103c6650314a49c83bf3d0c40cce6 |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-bdd1e3debf725d5c60ef05e04e14346e55e103c6650314a49c83bf3d0c40cce6 |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-bdd1e3debf725d5c60ef05e04e14346e55e103c6650314a49c83bf3d0c40cce6 |
|
| https://github.com/NativeScript/android/pull/2072/files#diff-bdd1e3debf725d5c60ef05e04e14346e55e103c6650314a49c83bf3d0c40cce6 |
| test-app/runtime/src/main/cpp/conversions/CastTypes.h | https://github.com/NativeScript/android/pull/2072/files#diff-1f6247d1ca79b6ea3732454971c6a58ddb6cf7146f340d1aa0a21eea00a35df4 |
|
View file
| https://github.com/NativeScript/android/blob/d24703c6b152f50a06067ef91b21b84d80c13f60/test-app/runtime/src/main/cpp/conversions/CastTypes.h |
|
Open in desktop
| https://desktop.github.com |
| Please reload this page | https://github.com/NativeScript/android/pull/2072/files |
| test-app/runtime/src/main/cpp/conversions/ConversionConsts.h | https://github.com/NativeScript/android/pull/2072/files#diff-dbcc9455cb19bdbb013563181c5ed17db0572e41ef2fd44a69cf75c2bdb6ad97 |
|
View file
| https://github.com/NativeScript/android/blob/d24703c6b152f50a06067ef91b21b84d80c13f60/test-app/runtime/src/main/cpp/conversions/ConversionConsts.h |
|
Open in desktop
| https://desktop.github.com |
| Please reload this page | https://github.com/NativeScript/android/pull/2072/files |
| test-app/runtime/src/main/cpp/conversions/JNIArgRefsState.h | https://github.com/NativeScript/android/pull/2072/files#diff-9f29e1dc73762da471b82ba9b18f91e7a2cfb22818e335b64e2804a02fb0485f |
|
View file
| https://github.com/NativeScript/android/blob/d24703c6b152f50a06067ef91b21b84d80c13f60/test-app/runtime/src/main/cpp/conversions/JNIArgRefsState.h |
|
Open in desktop
| https://desktop.github.com |
| Please reload this page | https://github.com/NativeScript/android/pull/2072/files |
| Please reload this page | https://github.com/NativeScript/android/pull/2072/files |
| Please reload this page | https://github.com/NativeScript/android/pull/2072/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |