René's URL Explorer Experiment


Title: fix(worker): leave the inspector pause loop when the worker is terminating by adrian-niculescu · Pull Request #2071 · NativeScript/android · GitHub

Open Graph Title: fix(worker): leave the inspector pause loop when the worker is terminating by adrian-niculescu · Pull Request #2071 · NativeScript/android

X Title: fix(worker): leave the inspector pause loop when the worker is terminating by adrian-niculescu · Pull Request #2071 · NativeScript/android

Description: In a debug build, a worker paused at a breakpoint inside console.log (for example a debugger statement in a getter that the message text conversion runs) makes the parent's worker.terminate() block until the debugger resumes, freezing the parent's thread. WorkerWrapper::ConsoleLog holds inspectorMutex_ across WorkerInspectorClient::consoleLog, so the pause loop runs with that mutex held. Terminate() ends a pause through NotifyTerminating(), which it reaches by taking the same mutex, so it waits for the pause, and the pause only waits for the debugger. The pause loop now also leaves on the worker's own isTerminating_ flag, which Terminate() sets before it takes the mutex and which the loop checks on each pass while it waits. The paused worker then returns from consoleLog, the mutex is released, and Terminate() continues. Leaving the pause on the flag lets the worker run on to its own teardown while the parent may still be interrupting its isolate. Terminate() holds the worker's isolate mutex across that use, so the isolate stays alive until the parent is done with it. With the pause entered by hand at that point, the parent's terminate() on main blocks in mutex::lock() while the worker sits in runMessageLoopOnPause, and with this change it returns and the worker ends. Reproducing it for real needs a DevTools session paused inside the getter, so there is no spec for it. The full device suite passes. Summary by CodeRabbit Bug Fixes Worker shutdown now exits promptly when a worker is terminating, including while paused for inspection. This prevents shutdown from waiting for the inspector pause loop to finish and improves reliability when stopping workers. Updated inspector handling to recognize worker termination during pauses, so shutdown can proceed without relying solely on a separate notification.

Open Graph Description: In a debug build, a worker paused at a breakpoint inside console.log (for example a debugger statement in a getter that the message text conversion runs) makes the parent's worker.terminate() b...

X Description: In a debug build, a worker paused at a breakpoint inside console.log (for example a debugger statement in a getter that the message text conversion runs) makes the parent's worker.terminate...

Opengraph URL: https://github.com/NativeScript/android/pull/2071

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:decc0f97-179e-ea30-be56-d22b9b0dd2be
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD1A:237673:14363FC:1AFC492:6B012F98
html-safe-nonce12925d56c2ce3cbf07a25daab192425ad80c330971d21b02f394346c115c1673
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDFBOjIzNzY3MzoxNDM2M0ZDOjFBRkM0OTI6NkIwMTJGOTgiLCJ2aXNpdG9yX2lkIjoiNjMwNDY5OTI1ODU3NDU0ODg4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb1a4fd6a20edd973ee5f8b6f1595b3e72d4c585e95ff787863a5958c2e0f9165
hovercard-subject-tagpull_request:4765714793
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/android/pull/2071/files
twitter:imagehttps://avatars.githubusercontent.com/u/15037449?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15037449?s=400&v=4
og:image:altIn a debug build, a worker paused at a breakpoint inside console.log (for example a debugger statement in a getter that the message text conversion runs) makes the parent's worker.terminate() b...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/android git https://github.com/NativeScript/android.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id29137950
octolytics-dimension-repository_nwoNativeScript/android
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id29137950
octolytics-dimension-repository_network_root_nwoNativeScript/android
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/android/pull/2071/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2071%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2071%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fandroid
Reloadhttps://github.com/NativeScript/android/pull/2071/files
Reloadhttps://github.com/NativeScript/android/pull/2071/files
Reloadhttps://github.com/NativeScript/android/pull/2071/files
NativeScripthttps://github.com/NativeScript
androidhttps://github.com/NativeScript/android
Codehttps://github.com/NativeScript/android
Issues106 (106)https://github.com/NativeScript/android/issues
Pull requests24 (24)https://github.com/NativeScript/android/pulls
Actionshttps://github.com/NativeScript/android/actions
Projectshttps://github.com/NativeScript/android/projects
Wikihttps://github.com/NativeScript/android/wiki
Security and qualityhttps://github.com/NativeScript/android/security
Insightshttps://github.com/NativeScript/android/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
adrian-niculescuhttps://github.com/adrian-niculescu
NativeScript:mainhttps://github.com/NativeScript/android/tree/main
adrian-niculescu:fix/worker-terminate-while-pausedhttps://github.com/adrian-niculescu/NativeScript-Android/tree/fix/worker-terminate-while-paused
Conversation 2 https://github.com/NativeScript/android/pull/2071
Commits 1 https://github.com/NativeScript/android/pull/2071/commits
Checks 4 https://github.com/NativeScript/android/pull/2071/checks
Files changed 3 https://github.com/NativeScript/android/pull/2071/files
fix(worker): leave the inspector pause loop when the worker is terminating https://github.com/NativeScript/android/pull/2071/files#top
Show all changes 1 commit https://github.com/NativeScript/android/pull/2071/files
8df7256 fix(worker): leave the inspector pause loop when the worker is termin… adrian-niculescu Oct 6, 2026 https://github.com/NativeScript/android/pull/2071/commits/8df72564c45e257d290ba24f21ef542c8b4cbdd1
Clear filters https://github.com/NativeScript/android/pull/2071/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2071/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2071/files
WorkerInspectorClient.cpp https://github.com/NativeScript/android/pull/2071/files#diff-3b7cfdba262c67e16167468c464564cdf766c2b30d662e2588728897038a0c99
WorkerInspectorClient.h https://github.com/NativeScript/android/pull/2071/files#diff-2c771616a3286c8b34cb5ad61f4df81eb7dbccd076a96ed637f32a892aa865bc
WorkerWrapper.cpp https://github.com/NativeScript/android/pull/2071/files#diff-1344a5b85b9f266cab5024f2d52426ba56e3832c074d2c139fb560bcaaabfdc7
test-app/runtime/src/main/cpp/WorkerInspectorClient.cpphttps://github.com/NativeScript/android/pull/2071/files#diff-3b7cfdba262c67e16167468c464564cdf766c2b30d662e2588728897038a0c99
View file https://github.com/NativeScript/android/blob/8df72564c45e257d290ba24f21ef542c8b4cbdd1/test-app/runtime/src/main/cpp/WorkerInspectorClient.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2071/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2071/files#diff-3b7cfdba262c67e16167468c464564cdf766c2b30d662e2588728897038a0c99
https://github.com/NativeScript/android/pull/2071/files#diff-3b7cfdba262c67e16167468c464564cdf766c2b30d662e2588728897038a0c99
https://github.com/NativeScript/android/pull/2071/files#diff-3b7cfdba262c67e16167468c464564cdf766c2b30d662e2588728897038a0c99
https://github.com/NativeScript/android/pull/2071/files#diff-3b7cfdba262c67e16167468c464564cdf766c2b30d662e2588728897038a0c99
https://github.com/NativeScript/android/pull/2071/files#diff-3b7cfdba262c67e16167468c464564cdf766c2b30d662e2588728897038a0c99
test-app/runtime/src/main/cpp/WorkerInspectorClient.hhttps://github.com/NativeScript/android/pull/2071/files#diff-2c771616a3286c8b34cb5ad61f4df81eb7dbccd076a96ed637f32a892aa865bc
View file https://github.com/NativeScript/android/blob/8df72564c45e257d290ba24f21ef542c8b4cbdd1/test-app/runtime/src/main/cpp/WorkerInspectorClient.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2071/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2071/files#diff-2c771616a3286c8b34cb5ad61f4df81eb7dbccd076a96ed637f32a892aa865bc
https://github.com/NativeScript/android/pull/2071/files#diff-2c771616a3286c8b34cb5ad61f4df81eb7dbccd076a96ed637f32a892aa865bc
https://github.com/NativeScript/android/pull/2071/files#diff-2c771616a3286c8b34cb5ad61f4df81eb7dbccd076a96ed637f32a892aa865bc
https://github.com/NativeScript/android/pull/2071/files#diff-2c771616a3286c8b34cb5ad61f4df81eb7dbccd076a96ed637f32a892aa865bc
test-app/runtime/src/main/cpp/WorkerWrapper.cpphttps://github.com/NativeScript/android/pull/2071/files#diff-1344a5b85b9f266cab5024f2d52426ba56e3832c074d2c139fb560bcaaabfdc7
View file https://github.com/NativeScript/android/blob/8df72564c45e257d290ba24f21ef542c8b4cbdd1/test-app/runtime/src/main/cpp/WorkerWrapper.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2071/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2071/files#diff-1344a5b85b9f266cab5024f2d52426ba56e3832c074d2c139fb560bcaaabfdc7
https://github.com/NativeScript/android/pull/2071/files#diff-1344a5b85b9f266cab5024f2d52426ba56e3832c074d2c139fb560bcaaabfdc7
https://github.com/NativeScript/android/pull/2071/files#diff-1344a5b85b9f266cab5024f2d52426ba56e3832c074d2c139fb560bcaaabfdc7
https://github.com/NativeScript/android/pull/2071/files#diff-1344a5b85b9f266cab5024f2d52426ba56e3832c074d2c139fb560bcaaabfdc7
Please reload this pagehttps://github.com/NativeScript/android/pull/2071/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.