René's URL Explorer Experiment


Title: fix(worker): keep a worker isolate alive while a __runOnMainThread callback locks it by adrian-niculescu · Pull Request #2068 · NativeScript/android · GitHub

Open Graph Title: fix(worker): keep a worker isolate alive while a __runOnMainThread callback locks it by adrian-niculescu · Pull Request #2068 · NativeScript/android

X Title: fix(worker): keep a worker isolate alive while a __runOnMainThread callback locks it by adrian-niculescu · Pull Request #2068 · NativeScript/android

Description: A worker that calls __runOnMainThread(fn) and ends shortly after, for example through close(), can crash the app: the main thread locks the worker's isolate after the worker has disposed it, and dies with a SIGSEGV in v8::Locker::Initialize. CallbackHandlers::RunMainThreadEntry reads the isolate from its cache entry, releases cacheMutex_, and only then constructs the v8::Locker. Worker teardown removes the entry in DestroyRuntime and disposes the isolate right after, so an entry the main thread already took can outlive its isolate. The main thread now records a hold on the isolate in the same cacheMutex_ section where it reads the entry, and drops it only after its Locker is released. The worker waits for those holds after it has released its own Locker and before it disposes the isolate. Waiting with the worker's Locker still held would deadlock against the main thread's Locker. A callback that took the entry before RemoveIsolateEntries ran then finds the entry gone under a live isolate and returns, and one that did not take it never sees the isolate. A callback that throws has the same problem in another form: the exception kept a handle into the worker isolate after the hold was gone, and the event loop resolved that handle against the main thread's isolate when it reported it. For a worker's callback the exception now drops the handle while the isolate is still held, so the report carries its message and stack, as a failed runtime initialization already does. A callback on the main isolate keeps the handle, so its report is unchanged. The window is a few instructions wide, so there is no spec for it. With a sleep injected between reading the entry and taking the Locker, a worker that closes right after posting its callback crashes the main thread on main and does not with this change. The full device suite passes. Summary by CodeRabbit Bug Fixes Improved worker shutdown reliability by waiting for pending main-thread callbacks to finish before disposing of the worker runtime. Prevented callback activity from accessing an isolate during disposal. Fixed cleanup of JavaScript handles when worker callbacks throw unhandled exceptions.

Open Graph Description: A worker that calls __runOnMainThread(fn) and ends shortly after, for example through close(), can crash the app: the main thread locks the worker's isolate after the worker has disposed it, an...

X Description: A worker that calls __runOnMainThread(fn) and ends shortly after, for example through close(), can crash the app: the main thread locks the worker's isolate after the worker has disposed it...

Opengraph URL: https://github.com/NativeScript/android/pull/2068

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:23d2f047-878b-6224-67f7-eab4e0079a48
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8820:3C21B:175723E:1DDCD01:6B012B7F
html-safe-nonce4b70ba1f9fc6a947b980867b72f3da581720d075bcfa8ab94595d13bad04b7dd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODIwOjNDMjFCOjE3NTcyM0U6MUREQ0QwMTo2QjAxMkI3RiIsInZpc2l0b3JfaWQiOiIxNzAyMDkwNTcxOTIyODc3MzExIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb10fab2419b4b1d43a9e2b9e9624f54d38bc316623a04b0a38bc07b38e5699c1
hovercard-subject-tagpull_request:4764746022
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/android/pull/2068/files
twitter:imagehttps://avatars.githubusercontent.com/u/15037449?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15037449?s=400&v=4
og:image:altA worker that calls __runOnMainThread(fn) and ends shortly after, for example through close(), can crash the app: the main thread locks the worker's isolate after the worker has disposed it, an...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/android git https://github.com/NativeScript/android.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id29137950
octolytics-dimension-repository_nwoNativeScript/android
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id29137950
octolytics-dimension-repository_network_root_nwoNativeScript/android
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/android/pull/2068/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2068%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2068%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fandroid
Reloadhttps://github.com/NativeScript/android/pull/2068/files
Reloadhttps://github.com/NativeScript/android/pull/2068/files
Reloadhttps://github.com/NativeScript/android/pull/2068/files
NativeScripthttps://github.com/NativeScript
androidhttps://github.com/NativeScript/android
Codehttps://github.com/NativeScript/android
Issues106 (106)https://github.com/NativeScript/android/issues
Pull requests24 (24)https://github.com/NativeScript/android/pulls
Actionshttps://github.com/NativeScript/android/actions
Projectshttps://github.com/NativeScript/android/projects
Wikihttps://github.com/NativeScript/android/wiki
Security and qualityhttps://github.com/NativeScript/android/security
Insightshttps://github.com/NativeScript/android/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
adrian-niculescuhttps://github.com/adrian-niculescu
NativeScript:mainhttps://github.com/NativeScript/android/tree/main
adrian-niculescu:fix/run-on-main-thread-isolate-lifetimehttps://github.com/adrian-niculescu/NativeScript-Android/tree/fix/run-on-main-thread-isolate-lifetime
Conversation 2 https://github.com/NativeScript/android/pull/2068
Commits 2 https://github.com/NativeScript/android/pull/2068/commits
Checks 3 https://github.com/NativeScript/android/pull/2068/checks
Files changed https://github.com/NativeScript/android/pull/2068/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2068/files
fix(worker): keep a worker isolate alive while a __runOnMainThread callback locks it https://github.com/NativeScript/android/pull/2068/files#top
Show all changes 2 commits https://github.com/NativeScript/android/pull/2068/files
168ff7c fix(worker): keep a worker isolate alive while a __runOnMainThread ca… adrian-niculescu Oct 6, 2026 https://github.com/NativeScript/android/pull/2068/commits/168ff7cf100dccc823b171babe51aa83bf86a33a
a340e10 fix(worker): report a worker's __runOnMainThread exception without it… adrian-niculescu Oct 6, 2026 https://github.com/NativeScript/android/pull/2068/commits/a340e10143105ed90a4a19afbd4ea202f829c513
Clear filters https://github.com/NativeScript/android/pull/2068/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2068/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2068/files
CallbackHandlers.cpp https://github.com/NativeScript/android/pull/2068/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e
CallbackHandlers.h https://github.com/NativeScript/android/pull/2068/files#diff-1f7b413d95b12ea3b982950185ce4f7e56c5c02952d656a5dcc0ff8878e37722
Runtime.cpp https://github.com/NativeScript/android/pull/2068/files#diff-b9490640f5d26f7cd6b9a176a2142b8e985a6aac9e2d64287de37fc694e80cc3
WorkerWrapper.cpp https://github.com/NativeScript/android/pull/2068/files#diff-1344a5b85b9f266cab5024f2d52426ba56e3832c074d2c139fb560bcaaabfdc7
test-app/runtime/src/main/cpp/CallbackHandlers.cpphttps://github.com/NativeScript/android/pull/2068/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e
View file https://github.com/adrian-niculescu/NativeScript-Android/blob/a340e10143105ed90a4a19afbd4ea202f829c513/test-app/runtime/src/main/cpp/CallbackHandlers.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2068/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2068/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e
https://github.com/NativeScript/android/pull/2068/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e
https://github.com/NativeScript/android/pull/2068/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e
https://github.com/NativeScript/android/pull/2068/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e
https://github.com/NativeScript/android/pull/2068/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e
test-app/runtime/src/main/cpp/CallbackHandlers.hhttps://github.com/NativeScript/android/pull/2068/files#diff-1f7b413d95b12ea3b982950185ce4f7e56c5c02952d656a5dcc0ff8878e37722
View file https://github.com/adrian-niculescu/NativeScript-Android/blob/a340e10143105ed90a4a19afbd4ea202f829c513/test-app/runtime/src/main/cpp/CallbackHandlers.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2068/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2068/files#diff-1f7b413d95b12ea3b982950185ce4f7e56c5c02952d656a5dcc0ff8878e37722
https://github.com/NativeScript/android/pull/2068/files#diff-1f7b413d95b12ea3b982950185ce4f7e56c5c02952d656a5dcc0ff8878e37722
https://github.com/NativeScript/android/pull/2068/files#diff-1f7b413d95b12ea3b982950185ce4f7e56c5c02952d656a5dcc0ff8878e37722
https://github.com/NativeScript/android/pull/2068/files#diff-1f7b413d95b12ea3b982950185ce4f7e56c5c02952d656a5dcc0ff8878e37722
https://github.com/NativeScript/android/pull/2068/files#diff-1f7b413d95b12ea3b982950185ce4f7e56c5c02952d656a5dcc0ff8878e37722
https://github.com/NativeScript/android/pull/2068/files#diff-1f7b413d95b12ea3b982950185ce4f7e56c5c02952d656a5dcc0ff8878e37722
test-app/runtime/src/main/cpp/Runtime.cpphttps://github.com/NativeScript/android/pull/2068/files#diff-b9490640f5d26f7cd6b9a176a2142b8e985a6aac9e2d64287de37fc694e80cc3
View file https://github.com/adrian-niculescu/NativeScript-Android/blob/a340e10143105ed90a4a19afbd4ea202f829c513/test-app/runtime/src/main/cpp/Runtime.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2068/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2068/files#diff-b9490640f5d26f7cd6b9a176a2142b8e985a6aac9e2d64287de37fc694e80cc3
https://github.com/NativeScript/android/pull/2068/files#diff-b9490640f5d26f7cd6b9a176a2142b8e985a6aac9e2d64287de37fc694e80cc3
test-app/runtime/src/main/cpp/WorkerWrapper.cpphttps://github.com/NativeScript/android/pull/2068/files#diff-1344a5b85b9f266cab5024f2d52426ba56e3832c074d2c139fb560bcaaabfdc7
View file https://github.com/adrian-niculescu/NativeScript-Android/blob/a340e10143105ed90a4a19afbd4ea202f829c513/test-app/runtime/src/main/cpp/WorkerWrapper.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2068/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2068/files#diff-1344a5b85b9f266cab5024f2d52426ba56e3832c074d2c139fb560bcaaabfdc7
https://github.com/NativeScript/android/pull/2068/files#diff-1344a5b85b9f266cab5024f2d52426ba56e3832c074d2c139fb560bcaaabfdc7
Please reload this pagehttps://github.com/NativeScript/android/pull/2068/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.