René's URL Explorer Experiment


Title: fix(worker): keep the worker isolate alive while terminate() uses it, and let it stop a closing worker by adrian-niculescu · Pull Request #2067 · NativeScript/android · GitHub

Open Graph Title: fix(worker): keep the worker isolate alive while terminate() uses it, and let it stop a closing worker by adrian-niculescu · Pull Request #2067 · NativeScript/android

X Title: fix(worker): keep the worker isolate alive while terminate() uses it, and let it stop a closing worker by adrian-niculescu · Pull Request #2067 · NativeScript/android

Description: Calling terminate() on a Worker that is ending on its own at the same moment, for example through its own close(), can make the parent thread interrupt the worker's isolate after the worker thread has already disposed it. A parent that terminates its child workers during its own shutdown races the same way. Separately, terminate() cannot stop a worker that called close() and kept running, so close(); while (true) {} spins forever. WorkerWrapper::Terminate reads workerIsolate_ and then calls TerminateExecution() and the event-loop lookup on it with no lock, while BackgroundLooper clears the pointer and disposes the isolate during teardown. Nothing makes the worker thread wait for a Terminate that has already read the pointer. Terminate now holds a mutex across the read and the use, and the worker thread takes the same mutex when it clears the pointer, before disposing the isolate: a terminate that already read it finishes with it first, and a later one finds null. This is the same fix as NativeScript/ios#478 on iOS. close() only ends the worker once its running callback returns, and Terminate returned early for a closing worker. It no longer returns early for a closing worker, which matches the iOS runtime, so it interrupts one that is still running. The isolate race window is a few instructions wide, so it has no spec. With a sleep injected between the read and the use, a worker that closes itself while terminate() runs is already disposed when the parent touches its isolate on main, and stays alive until the parent is done with this change. The new spec for a worker spinning after close() fails on main and passes here, and the full device suite passes. Summary by CodeRabbit Bug Fixes Workers that have called close() but continue running can now be terminated reliably. Their ongoing activity stops after termination is requested. Tests Added coverage verifying that termination stops a closing worker’s ongoing activity. The test checks that its shared counter remains unchanged after termination.

Open Graph Description: Calling terminate() on a Worker that is ending on its own at the same moment, for example through its own close(), can make the parent thread interrupt the worker's isolate after the worker thr...

X Description: Calling terminate() on a Worker that is ending on its own at the same moment, for example through its own close(), can make the parent thread interrupt the worker's isolate after the worker...

Opengraph URL: https://github.com/NativeScript/android/pull/2067

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:35237b80-e0c6-b080-d1c0-f0ca69940ac0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA11C:26ECEB:1CD146C:24ADFFC:6B0146AA
html-safe-nonce7ff503610978a4746e3029adf1e2166fbf8514208eacddbf638536a0ba2f6487
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTFDOjI2RUNFQjoxQ0QxNDZDOjI0QURGRkM6NkIwMTQ2QUEiLCJ2aXNpdG9yX2lkIjoiMjU2NDQwODAxNzk4MjQwODM2MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf444a258849f8506e46c372bcf6f46c1b7bad5bf1bf7246ca2d455b8dda10e84
hovercard-subject-tagpull_request:4764527709
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/android/pull/2067/files
twitter:imagehttps://avatars.githubusercontent.com/u/15037449?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15037449?s=400&v=4
og:image:altCalling terminate() on a Worker that is ending on its own at the same moment, for example through its own close(), can make the parent thread interrupt the worker's isolate after the worker thr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/android git https://github.com/NativeScript/android.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id29137950
octolytics-dimension-repository_nwoNativeScript/android
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id29137950
octolytics-dimension-repository_network_root_nwoNativeScript/android
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/android/pull/2067/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2067%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2067%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fandroid
Reloadhttps://github.com/NativeScript/android/pull/2067/files
Reloadhttps://github.com/NativeScript/android/pull/2067/files
Reloadhttps://github.com/NativeScript/android/pull/2067/files
NativeScripthttps://github.com/NativeScript
androidhttps://github.com/NativeScript/android
Codehttps://github.com/NativeScript/android
Issues106 (106)https://github.com/NativeScript/android/issues
Pull requests24 (24)https://github.com/NativeScript/android/pulls
Actionshttps://github.com/NativeScript/android/actions
Projectshttps://github.com/NativeScript/android/projects
Wikihttps://github.com/NativeScript/android/wiki
Security and qualityhttps://github.com/NativeScript/android/security
Insightshttps://github.com/NativeScript/android/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
edusperonihttps://github.com/edusperoni
NativeScript:mainhttps://github.com/NativeScript/android/tree/main
adrian-niculescu:fix/worker-terminate-isolate-racehttps://github.com/adrian-niculescu/NativeScript-Android/tree/fix/worker-terminate-isolate-race
Conversation 1 https://github.com/NativeScript/android/pull/2067
Commits 4 https://github.com/NativeScript/android/pull/2067/commits
Checks 4 https://github.com/NativeScript/android/pull/2067/checks
Files changed https://github.com/NativeScript/android/pull/2067/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2067/files
fix(worker): keep the worker isolate alive while terminate() uses it, and let it stop a closing worker https://github.com/NativeScript/android/pull/2067/files#top
Show all changes 4 commits https://github.com/NativeScript/android/pull/2067/files
a9a5ea4 fix(worker): keep the worker isolate alive while terminate() uses it adrian-niculescu Oct 6, 2026 https://github.com/NativeScript/android/pull/2067/commits/a9a5ea44006dd3021fbeb7ea46aea30f50c5a087
921209f fix(worker): let terminate() stop a worker that called close() adrian-niculescu Oct 6, 2026 https://github.com/NativeScript/android/pull/2067/commits/921209ff4d01a647c0c9a046dd7dc456bf7fcb35
44f3c8c test(worker): stop the close-then-spin worker on cleanup and fit the … adrian-niculescu Oct 6, 2026 https://github.com/NativeScript/android/pull/2067/commits/44f3c8cf3dc9843f8dddb6d259a6484b322cd644
7e3a456 Merge branch 'main' into fix/worker-terminate-isolate-race edusperoni Nov 11, 2026 https://github.com/NativeScript/android/pull/2067/commits/7e3a456540431de8e7c202863eecbd14fd395508
Clear filters https://github.com/NativeScript/android/pull/2067/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2067/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2067/files
mainpage.js https://github.com/NativeScript/android/pull/2067/files#diff-b7fd6c22bfc29391e9e3ed935d6c6194b1ad595c7592690229952b5ddb99c0d5
testWorkerTerminateAfterClose.js https://github.com/NativeScript/android/pull/2067/files#diff-2f2b660411016a3cde6b4b67f01b22da4704cc95334ac0d674524c1db4e811be
workerCloseThenSpinWorker.js https://github.com/NativeScript/android/pull/2067/files#diff-ab38d8b6554fbdad52ed43084926bdda0a5127dbbba07225fe9b8b2e876b8ce0
WorkerWrapper.cpp https://github.com/NativeScript/android/pull/2067/files#diff-1344a5b85b9f266cab5024f2d52426ba56e3832c074d2c139fb560bcaaabfdc7
WorkerWrapper.h https://github.com/NativeScript/android/pull/2067/files#diff-94a94304b1fb4dd29852688ec48aa5583d6b2d6017d149c731cf5f191bf08a2e
test-app/app/src/main/assets/app/mainpage.jshttps://github.com/NativeScript/android/pull/2067/files#diff-b7fd6c22bfc29391e9e3ed935d6c6194b1ad595c7592690229952b5ddb99c0d5
View file https://github.com/adrian-niculescu/NativeScript-Android/blob/7e3a456540431de8e7c202863eecbd14fd395508/test-app/app/src/main/assets/app/mainpage.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2067/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2067/files#diff-b7fd6c22bfc29391e9e3ed935d6c6194b1ad595c7592690229952b5ddb99c0d5
https://github.com/NativeScript/android/pull/2067/files#diff-b7fd6c22bfc29391e9e3ed935d6c6194b1ad595c7592690229952b5ddb99c0d5
test-app/app/src/main/assets/app/tests/testWorkerTerminateAfterClose.jshttps://github.com/NativeScript/android/pull/2067/files#diff-2f2b660411016a3cde6b4b67f01b22da4704cc95334ac0d674524c1db4e811be
View file https://github.com/adrian-niculescu/NativeScript-Android/blob/7e3a456540431de8e7c202863eecbd14fd395508/test-app/app/src/main/assets/app/tests/testWorkerTerminateAfterClose.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2067/{{ revealButtonHref }}
test-app/app/src/main/assets/app/tests/workerCloseThenSpinWorker.jshttps://github.com/NativeScript/android/pull/2067/files#diff-ab38d8b6554fbdad52ed43084926bdda0a5127dbbba07225fe9b8b2e876b8ce0
View file https://github.com/adrian-niculescu/NativeScript-Android/blob/7e3a456540431de8e7c202863eecbd14fd395508/test-app/app/src/main/assets/app/tests/workerCloseThenSpinWorker.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2067/{{ revealButtonHref }}
test-app/runtime/src/main/cpp/WorkerWrapper.cpphttps://github.com/NativeScript/android/pull/2067/files#diff-1344a5b85b9f266cab5024f2d52426ba56e3832c074d2c139fb560bcaaabfdc7
View file https://github.com/adrian-niculescu/NativeScript-Android/blob/7e3a456540431de8e7c202863eecbd14fd395508/test-app/runtime/src/main/cpp/WorkerWrapper.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2067/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2067/files#diff-1344a5b85b9f266cab5024f2d52426ba56e3832c074d2c139fb560bcaaabfdc7
https://github.com/NativeScript/android/pull/2067/files#diff-1344a5b85b9f266cab5024f2d52426ba56e3832c074d2c139fb560bcaaabfdc7
https://github.com/NativeScript/android/pull/2067/files#diff-1344a5b85b9f266cab5024f2d52426ba56e3832c074d2c139fb560bcaaabfdc7
https://github.com/NativeScript/android/pull/2067/files#diff-1344a5b85b9f266cab5024f2d52426ba56e3832c074d2c139fb560bcaaabfdc7
https://github.com/NativeScript/android/pull/2067/files#diff-1344a5b85b9f266cab5024f2d52426ba56e3832c074d2c139fb560bcaaabfdc7
test-app/runtime/src/main/cpp/WorkerWrapper.hhttps://github.com/NativeScript/android/pull/2067/files#diff-94a94304b1fb4dd29852688ec48aa5583d6b2d6017d149c731cf5f191bf08a2e
View file https://github.com/adrian-niculescu/NativeScript-Android/blob/7e3a456540431de8e7c202863eecbd14fd395508/test-app/runtime/src/main/cpp/WorkerWrapper.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2067/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2067/files#diff-94a94304b1fb4dd29852688ec48aa5583d6b2d6017d149c731cf5f191bf08a2e
https://github.com/NativeScript/android/pull/2067/files#diff-94a94304b1fb4dd29852688ec48aa5583d6b2d6017d149c731cf5f191bf08a2e
Please reload this pagehttps://github.com/NativeScript/android/pull/2067/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.