René's URL Explorer Experiment


Title: fix(worker): keep the worker isolate alive while terminate() uses it, and let it stop a closing worker by adrian-niculescu · Pull Request #2067 · NativeScript/android · GitHub

Open Graph Title: fix(worker): keep the worker isolate alive while terminate() uses it, and let it stop a closing worker by adrian-niculescu · Pull Request #2067 · NativeScript/android

X Title: fix(worker): keep the worker isolate alive while terminate() uses it, and let it stop a closing worker by adrian-niculescu · Pull Request #2067 · NativeScript/android

Description: NativeScript for Android using v8. Contribute to NativeScript/android development by creating an account on GitHub.

Open Graph Description: Calling terminate() on a Worker that is ending on its own at the same moment, for example through its own close(), can make the parent thread interrupt the worker's isolate after the worker thr...

X Description: Calling terminate() on a Worker that is ending on its own at the same moment, for example through its own close(), can make the parent thread interrupt the worker's isolate after the worker...

Opengraph URL: https://github.com/NativeScript/android/pull/2067

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b085b8be-e819-8ba1-ec45-36eb4f5b98dd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC6A:28815B:1382712:19F9687:6B0127CF
html-safe-noncef681a469b700935d18b8bae45c86de00f01ec300f621a06c15a2dcd226b12764
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzZBOjI4ODE1QjoxMzgyNzEyOjE5Rjk2ODc6NkIwMTI3Q0YiLCJ2aXNpdG9yX2lkIjoiMjgzMjU5NDI5NzE1OTc1NTcyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd6b2f67556619b5bd6c2cc69dcbfd86a2aacfe73edc026c4e1d13beb43ea0f08
hovercard-subject-tagpull_request:4764527709
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/NativeScript/android/2067/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0e4769555224d743e3b70011dc85349fbe3c3801725ee01975084ef50377b835/NativeScript/android/pull/2067
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0e4769555224d743e3b70011dc85349fbe3c3801725ee01975084ef50377b835/NativeScript/android/pull/2067
og:image:altCalling terminate() on a Worker that is ending on its own at the same moment, for example through its own close(), can make the parent thread interrupt the worker's isolate after the worker thr...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameadrian-niculescu
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/NativeScript/android git https://github.com/NativeScript/android.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id29137950
octolytics-dimension-repository_nwoNativeScript/android
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id29137950
octolytics-dimension-repository_network_root_nwoNativeScript/android
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/NativeScript/android/pull/2067#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2067
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2067
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=NativeScript%2Fandroid
Reloadhttps://github.com/NativeScript/android/pull/2067
Reloadhttps://github.com/NativeScript/android/pull/2067
Reloadhttps://github.com/NativeScript/android/pull/2067
NativeScripthttps://github.com/NativeScript
androidhttps://github.com/NativeScript/android
Codehttps://github.com/NativeScript/android
Issues106 (106)https://github.com/NativeScript/android/issues
Pull requests24 (24)https://github.com/NativeScript/android/pulls
Actionshttps://github.com/NativeScript/android/actions
Projectshttps://github.com/NativeScript/android/projects
Wikihttps://github.com/NativeScript/android/wiki
Security and qualityhttps://github.com/NativeScript/android/security
Insightshttps://github.com/NativeScript/android/insights
https://github.com/NativeScript/android
edusperonihttps://github.com/edusperoni
NativeScript:mainhttps://github.com/NativeScript/android/tree/main
adrian-niculescu:fix/worker-terminate-isolate-racehttps://github.com/adrian-niculescu/NativeScript-Android/tree/fix/worker-terminate-isolate-race
Conversationhttps://github.com/NativeScript/android/pull/2067
Commits4 (4)https://github.com/NativeScript/android/pull/2067/commits
Checkshttps://github.com/NativeScript/android/pull/2067/checks
Files changedhttps://github.com/NativeScript/android/pull/2067/files
fix(worker): keep the worker isolate alive while terminate() uses it, and let it stop a closing workerhttps://github.com/NativeScript/android/pull/2067#top
edusperonihttps://github.com/edusperoni
NativeScript:mainhttps://github.com/NativeScript/android/tree/main
adrian-niculescu:fix/worker-terminate-isolate-racehttps://github.com/adrian-niculescu/NativeScript-Android/tree/fix/worker-terminate-isolate-race
https://github.com/adrian-niculescu
adrian-niculescuhttps://github.com/adrian-niculescu
Oct 6, 2026https://github.com/NativeScript/android/pull/2067#issue-5735266848
Please reload this pagehttps://github.com/NativeScript/android/pull/2067
NativeScript/ios#478https://github.com/NativeScript/ios/pull/478
Please reload this pagehttps://github.com/NativeScript/android/pull/2067
https://github.com/adrian-niculescu
fix(worker): keep the worker isolate alive while terminate() uses ithttps://github.com/NativeScript/android/pull/2067/commits/a9a5ea44006dd3021fbeb7ea46aea30f50c5a087
a9a5ea4https://github.com/NativeScript/android/pull/2067/commits/a9a5ea44006dd3021fbeb7ea46aea30f50c5a087
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Oct 6, 2026https://github.com/NativeScript/android/pull/2067#issuecomment-6025259377
Please reload this pagehttps://github.com/NativeScript/android/pull/2067
https://app.coderabbit.ai/change-stack/NativeScript/android/pull/2067?scope=ghh_OusAJGA4HG8ljoOV0wJvVx8NmnZIjc2DdjmxOu0xZWA&cs_source=review_comment
NativeScript/android#2044https://github.com/NativeScript/android/pull/2044
https://camo.githubusercontent.com/52c6b786492f6f8748feb782ecaf3a1d3152ec095001b1a26170cc7cbe533212/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f636f64657261626269745f7075626c69635f6173736574732f7072652d6d657267652d636865636b732d7061737365642e737667
https://camo.githubusercontent.com/52c6b786492f6f8748feb782ecaf3a1d3152ec095001b1a26170cc7cbe533212/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f636f64657261626269745f7075626c69635f6173736574732f7072652d6d657267652d636865636b732d7061737365642e737667
https://camo.githubusercontent.com/52c6b786492f6f8748feb782ecaf3a1d3152ec095001b1a26170cc7cbe533212/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f636f64657261626269745f7075626c69635f6173736574732f7072652d6d657267652d636865636b732d7061737365642e737667
https://camo.githubusercontent.com/52c6b786492f6f8748feb782ecaf3a1d3152ec095001b1a26170cc7cbe533212/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f636f64657261626269745f7075626c69635f6173736574732f7072652d6d657267652d636865636b732d7061737365642e737667
CodeRabbithttps://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=NativeScript/android&utm_content=2067
Xhttps://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai
Mastodonhttps://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai
Reddithttps://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai
LinkedInhttps://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code
NativeScript/androidhttps://github.com/NativeScript/android
mainhttps://github.com/NativeScript/android/tree/main
.coderabbit.yamlhttps://github.com/NativeScript/android/blob/560b3bf9549f6659ec66d6a129a3b4008f2577a5/.coderabbit.yaml
560b3bfhttps://github.com/NativeScript/android/commit/560b3bf9549f6659ec66d6a129a3b4008f2577a5
44f3c8chttps://github.com/NativeScript/android/commit/44f3c8cf3dc9843f8dddb6d259a6484b322cd644
7e3a456https://github.com/NativeScript/android/commit/7e3a456540431de8e7c202863eecbd14fd395508
Please reload this pagehttps://github.com/NativeScript/android/pull/2067
https://github.com/adrian-niculescu
fix(worker): let terminate() stop a worker that called close()https://github.com/NativeScript/android/pull/2067/commits/921209ff4d01a647c0c9a046dd7dc456bf7fcb35
921209fhttps://github.com/NativeScript/android/pull/2067/commits/921209ff4d01a647c0c9a046dd7dc456bf7fcb35
https://github.com/adrian-niculescu
adrian-niculescuhttps://github.com/adrian-niculescu
Oct 6, 2026https://github.com/NativeScript/android/pull/2067#event-32637603084
https://github.com/adrian-niculescu
test(worker): stop the close-then-spin worker on cleanup and fit the …https://github.com/NativeScript/android/pull/2067/commits/44f3c8cf3dc9843f8dddb6d259a6484b322cd644
44f3c8chttps://github.com/NativeScript/android/pull/2067/commits/44f3c8cf3dc9843f8dddb6d259a6484b322cd644
https://github.com/adrian-niculescu
adrian-niculescuhttps://github.com/adrian-niculescu
October 6, 2026 21:52https://github.com/NativeScript/android/pull/2067#event-32640340662
https://github.com/adrian-niculescu
adrian-niculescuhttps://github.com/adrian-niculescu
Oct 6, 2026 https://github.com/NativeScript/android/pull/2067#ref-pullrequest-5736692120
fix(worker): leave the inspector pause loop when the worker is terminating #2071 https://github.com/NativeScript/android/pull/2071
https://github.com/edusperoni
Merge branch 'main' into fix/worker-terminate-isolate-racehttps://github.com/NativeScript/android/pull/2067/commits/7e3a456540431de8e7c202863eecbd14fd395508
7e3a456https://github.com/NativeScript/android/pull/2067/commits/7e3a456540431de8e7c202863eecbd14fd395508
https://github.com/edusperoni
edusperonihttps://github.com/edusperoni
Nov 11, 2026 https://github.com/NativeScript/android/pull/2067#ref-pullrequest-6338146415
ci: keep crash diagnostics when the test app dies or hangs #2109 https://github.com/NativeScript/android/pull/2109
https://github.com/edusperoni
edusperonihttps://github.com/edusperoni
Nov 11, 2026 https://github.com/NativeScript/android/pull/2067#pullrequestreview-5866063385
View reviewed changes https://github.com/NativeScript/android/pull/2067/files/7e3a456540431de8e7c202863eecbd14fd395508
edusperonihttps://github.com/edusperoni
https://github.com/NativeScript/android/pull/2067#pullrequestreview-5866063385
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#2067https://github.com/NativeScript/android/pull/2067
#2070https://github.com/NativeScript/android/pull/2070
#2069https://github.com/NativeScript/android/pull/2069
Please reload this pagehttps://github.com/NativeScript/android/pull/2067
https://github.com/edusperoni
edusperonihttps://github.com/edusperoni
602e8abhttps://github.com/NativeScript/android/commit/602e8ab177f547e7c05eb868a3612b222d225abd
Nov 11, 2026https://github.com/NativeScript/android/pull/2067#event-35849098654
Please reload this pagehttps://github.com/NativeScript/android/pull/2067
fix(worker): let a heap-limit terminate re-enter the inspector lock from console.log #2070 https://github.com/NativeScript/android/pull/2070
fix(worker): tear down a worker runtime whose Java bootstrap failed #2069 https://github.com/NativeScript/android/pull/2069
fix(worker): drop callbacks from closing workers #2108 https://github.com/NativeScript/android/pull/2108
fix: tear down a failed runtime bootstrap so it can be retried #2047 https://github.com/NativeScript/android/pull/2047
fix(worker): keep a worker isolate alive while a __runOnMainThread callback locks it #2068 https://github.com/NativeScript/android/pull/2068
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2067
https://github.com/edusperoni
edusperoni https://github.com/edusperoni
https://github.com/NativeScript/android/pull/2067/files/7e3a456540431de8e7c202863eecbd14fd395508
Please reload this pagehttps://github.com/NativeScript/android/pull/2067
Please reload this pagehttps://github.com/NativeScript/android/pull/2067
https://github.com/adrian-niculescu
https://github.com/edusperoni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.