René's URL Explorer Experiment


Title: fix(worker): throw when an environment-data key cannot be converted to a string by adrian-niculescu · Pull Request #2066 · NativeScript/android · GitHub

Open Graph Title: fix(worker): throw when an environment-data key cannot be converted to a string by adrian-niculescu · Pull Request #2066 · NativeScript/android

X Title: fix(worker): throw when an environment-data key cannot be converted to a string by adrian-niculescu · Pull Request #2066 · NativeScript/android

Description: setEnvironmentData(key, value) with a key whose toString() throws does not throw. It stores the value under the empty-string key instead, replacing whatever was there, and getEnvironmentData(key) and setEnvironmentData(key) read or delete that unrelated entry. Both callbacks convert the key with a helper that swallows a throwing toString() and returns an empty string. They now convert it with a checked ToString and return with the exception pending, so it reaches the caller. Keys stay stringified, as the shared stringifies keys spec expects. A symbol key now throws a TypeError, as any string conversion of a symbol does, rather than mapping to the empty-string key. Stacked on #2043; the same fix for iOS is NativeScript/ios#492. The throwing-key spec fails on that branch and passes here, a second spec keeps a key with an embedded NUL distinct from its prefix, and the full device suite passes. Summary by CodeRabbit Bug Fixes Environment-data keys containing null characters are now kept distinct from their prefixes, and deleting a key no longer affects its prefix. Errors raised while converting keys to strings now propagate correctly when setting or retrieving environment data.

Open Graph Description: setEnvironmentData(key, value) with a key whose toString() throws does not throw. It stores the value under the empty-string key instead, replacing whatever was there, and getEnvironmentData(key) a...

X Description: setEnvironmentData(key, value) with a key whose toString() throws does not throw. It stores the value under the empty-string key instead, replacing whatever was there, and getEnvironmentData(key) a...

Opengraph URL: https://github.com/NativeScript/android/pull/2066

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:af3d3aa7-eb64-8f6a-ac03-b3cd05476cc4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB9C:38E318:12600BB:1726EDE:6B015813
html-safe-noncec06ebe84f9f72f7d692169553160a6078a503c5d945e0820bd2f564664c39dc3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjlDOjM4RTMxODoxMjYwMEJCOjE3MjZFREU6NkIwMTU4MTMiLCJ2aXNpdG9yX2lkIjoiMjQ4NTQ3MTg5MjA4NjAyMDExNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4686639bc72bc3e0c84aea596e34953cb03306e1001b4906a4f4be6d175f5f4a
hovercard-subject-tagpull_request:4762550861
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/android/pull/2066/files
twitter:imagehttps://avatars.githubusercontent.com/u/15037449?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15037449?s=400&v=4
og:image:altsetEnvironmentData(key, value) with a key whose toString() throws does not throw. It stores the value under the empty-string key instead, replacing whatever was there, and getEnvironmentData(key) a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/android git https://github.com/NativeScript/android.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id29137950
octolytics-dimension-repository_nwoNativeScript/android
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id29137950
octolytics-dimension-repository_network_root_nwoNativeScript/android
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/android/pull/2066/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2066%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2066%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fandroid
Reloadhttps://github.com/NativeScript/android/pull/2066/files
Reloadhttps://github.com/NativeScript/android/pull/2066/files
Reloadhttps://github.com/NativeScript/android/pull/2066/files
NativeScripthttps://github.com/NativeScript
androidhttps://github.com/NativeScript/android
Codehttps://github.com/NativeScript/android
Issues106 (106)https://github.com/NativeScript/android/issues
Pull requests26 (26)https://github.com/NativeScript/android/pulls
Actionshttps://github.com/NativeScript/android/actions
Projectshttps://github.com/NativeScript/android/projects
Wikihttps://github.com/NativeScript/android/wiki
Security and qualityhttps://github.com/NativeScript/android/security
Insightshttps://github.com/NativeScript/android/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
adrian-niculescuhttps://github.com/adrian-niculescu
NativeScript:feat/worker-threadshttps://github.com/NativeScript/android/tree/feat/worker-threads
adrian-niculescu:fix/environment-data-key-conversionhttps://github.com/adrian-niculescu/NativeScript-Android/tree/fix/environment-data-key-conversion
Conversation 3 https://github.com/NativeScript/android/pull/2066
Commits 1 https://github.com/NativeScript/android/pull/2066/commits
Checks 3 https://github.com/NativeScript/android/pull/2066/checks
Files changed https://github.com/NativeScript/android/pull/2066/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2066/files
fix(worker): throw when an environment-data key cannot be converted to a string https://github.com/NativeScript/android/pull/2066/files#top
Show all changes 1 commit https://github.com/NativeScript/android/pull/2066/files
1e23b14 fix(worker): throw when an environment-data key cannot be converted t… adrian-niculescu Oct 6, 2026 https://github.com/NativeScript/android/pull/2066/commits/1e23b1420bb6ded4791d6f2d9b7116a6ad30eebb
Clear filters https://github.com/NativeScript/android/pull/2066/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2066/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2066/files
testMessaging.js https://github.com/NativeScript/android/pull/2066/files#diff-5ccfdc56f7ca4f349093e9d70b2342aa9590b99b78316ca51618a7f75766f55f
Messaging.cpp https://github.com/NativeScript/android/pull/2066/files#diff-e0e0c32f536b0b13eb0d0e24ca35eae8a829d7993bc06bedab5337338072f411
test-app/app/src/main/assets/app/tests/testMessaging.jshttps://github.com/NativeScript/android/pull/2066/files#diff-5ccfdc56f7ca4f349093e9d70b2342aa9590b99b78316ca51618a7f75766f55f
View file https://github.com/adrian-niculescu/NativeScript-Android/blob/1e23b1420bb6ded4791d6f2d9b7116a6ad30eebb/test-app/app/src/main/assets/app/tests/testMessaging.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2066/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2066/files#diff-5ccfdc56f7ca4f349093e9d70b2342aa9590b99b78316ca51618a7f75766f55f
https://github.com/NativeScript/android/pull/2066/files#diff-5ccfdc56f7ca4f349093e9d70b2342aa9590b99b78316ca51618a7f75766f55f
test-app/runtime/src/main/cpp/Messaging.cpphttps://github.com/NativeScript/android/pull/2066/files#diff-e0e0c32f536b0b13eb0d0e24ca35eae8a829d7993bc06bedab5337338072f411
View file https://github.com/adrian-niculescu/NativeScript-Android/blob/1e23b1420bb6ded4791d6f2d9b7116a6ad30eebb/test-app/runtime/src/main/cpp/Messaging.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2066/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2066/files#diff-e0e0c32f536b0b13eb0d0e24ca35eae8a829d7993bc06bedab5337338072f411
https://github.com/NativeScript/android/pull/2066/files#diff-e0e0c32f536b0b13eb0d0e24ca35eae8a829d7993bc06bedab5337338072f411
https://github.com/NativeScript/android/pull/2066/files#diff-e0e0c32f536b0b13eb0d0e24ca35eae8a829d7993bc06bedab5337338072f411
Please reload this pagehttps://github.com/NativeScript/android/pull/2066/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.