Title: fix: keep ErrorReportActivity content below the status bar on edge-to-edge by aleclarson · Pull Request #2054 · NativeScript/android · GitHub
Open Graph Title: fix: keep ErrorReportActivity content below the status bar on edge-to-edge by aleclarson · Pull Request #2054 · NativeScript/android
X Title: fix: keep ErrorReportActivity content below the status bar on edge-to-edge by aleclarson · Pull Request #2054 · NativeScript/android
Description: Closes #2053 Summary The debug crash screen (com.tns.ErrorReportActivity / error_activity.xml) applies no window-insets handling, so on targetSdkVersion 35 — where Android 15 enforces edge-to-edge — the root RelativeLayout draws behind the status bar and clips the top errorException banner. Adds android:fitsSystemWindows="true" to the root RelativeLayout, so the default inset dispatch pads the content by the system window insets (status bar, navigation bar, display cutout). No-op on older targets and non-edge-to-edge windows, where the decor consumes those insets before they reach the content view. Side benefit: the bottom button rows now also clear the gesture/nav bar. NativeScriptActivity lives in the app template, not this repo, and nothing here handles insets today, so there was no existing convention to match — this is the minimal fix suggested in the issue (#1833 tracks the same root cause for normal app content). Test plan ns run android on an API 35 emulator/device, throw an uncaught JS exception on startup, confirm the red error banner renders fully below the status bar and the bottom buttons clear the nav bar Repeat on a pre-35 device/emulator and confirm no layout change Summary by CodeRabbit Bug Fixes Updated the error screen layout to account for system window insets.
Open Graph Description: Closes #2053 Summary The debug crash screen (com.tns.ErrorReportActivity / error_activity.xml) applies no window-insets handling, so on targetSdkVersion 35 — where Android 15 enforces edge-to-edge...
X Description: Closes #2053 Summary The debug crash screen (com.tns.ErrorReportActivity / error_activity.xml) applies no window-insets handling, so on targetSdkVersion 35 — where Android 15 enforces edge-to-edge...
Opengraph URL: https://github.com/NativeScript/android/pull/2054
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:74d5d076-31a1-3546-32d2-79eff93bb2e9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A0B4:33A17:2BEB0:3896A:6B01585A |
| html-safe-nonce | aa7c400425a1ebfadddf2826269950950fddef33fbf2ea80fed9edf928ade41a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEI0OjMzQTE3OjJCRUIwOjM4OTZBOjZCMDE1ODVBIiwidmlzaXRvcl9pZCI6Ijg0MTc1OTAyODY0ODk4MzU2MTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a1b2dfdd16554fb8cade34b79c65c05e1abb04d3f1b6daf6d6e18b622f641a79 |
| hovercard-subject-tag | pull_request:4693952220 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/android/pull/2054/files |
| twitter:image | https://avatars.githubusercontent.com/u/1925840?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1925840?s=400&v=4 |
| og:image:alt | Closes #2053 Summary The debug crash screen (com.tns.ErrorReportActivity / error_activity.xml) applies no window-insets handling, so on targetSdkVersion 35 — where Android 15 enforces edge-to-edge... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/NativeScript/android git https://github.com/NativeScript/android.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 29137950 |
| octolytics-dimension-repository_nwo | NativeScript/android |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 29137950 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/android |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width