René's URL Explorer Experiment


Title: refactor: replace assert() with NS_CHECK/NS_DCHECK by edusperoni · Pull Request #2014 · NativeScript/android · GitHub

Open Graph Title: refactor: replace assert() with NS_CHECK/NS_DCHECK by edusperoni · Pull Request #2014 · NativeScript/android

X Title: refactor: replace assert() with NS_CHECK/NS_DCHECK by edusperoni · Pull Request #2014 · NativeScript/android

Description: Why assert() never runs in a build we ship. assembleRelease maps to the RelWithDebInfo CMake config, whose stock CMAKE_CXX_FLAGS_RELWITHDEBINFO carries -DNDEBUG. CMakeLists.txt appends -O3 to that variable (line 113) rather than replacing it, so nothing removes the define. Verified from the generated ninja files: -DNDEBUG appears 82× under .cxx/RelWithDebInfo/ and 0× under .cxx/Debug/. So all 123 first-party asserts were diagnostics that existed only in debug and test runs — the two environments where the invariants were least likely to be violated in the first place. On a user's device they were absent, and the invariant violation surfaced later as an unattributed SIGSEGV. The macros are named NS_CHECK/NS_DCHECK rather than CHECK/DCHECK because V8's v8_inspector/src/base/logging.h already defines both bare names and is compiled into debug builds. What Two macros in NativeScriptAssert.h (which, despite the filename, previously held only the DEBUG_WRITE family): debug release NS_CHECK(expr) evaluates, aborts on failure evaluates, aborts on failure NS_DCHECK(expr) evaluates, aborts on failure not evaluated NS_DCHECK keeps exactly the semantics assert() had, so its expression must remain free of side effects. It still compiles the expression under NDEBUG in a branch that is never taken, so an expression that stops making sense is a build failure rather than something only a debug build notices. The split: 73 NS_CHECK, 50 NS_DCHECK The rule, sharpened during review: NS_CHECK where the value is stored or dereferenced unconditionally and the failure is not reachable from application JavaScript. That second clause is what keeps the per-call conversion paths debug-only. ArgConverter::ConvertToJavaLong can fail because a JS getter threw, and that has to propagate as an exception rather than abort the process. Init-time failures have no such path — nothing catches them, and the next statement dereferences an empty handle. Promoted to NS_CHECK — the JNIEnv/JavaVM handles and the jclass/jmethodID/jfieldID lookups resolved once during runtime init from fixed class names, the per-isolate V8StringConstants block, the EventLoop handler object, the require factory and per-directory require functions, StructuredClone::Init, the tracing agent's compile/run/call results, and LRUCache's load callback (a raw function pointer, so a null call is undefined rather than a throw). Each is used unconditionally a statement or two later, so a null is undefined behaviour today. These are backstops rather than the primary error path: JEnv::GetMethodID and friends already call CheckForJavaException, which throws NativeScriptException. An NS_CHECK here fires only when a lookup returns null with no pending Java exception. Kept as NS_DCHECK — everything else, including one case worth calling out: JEnv::FindClass deliberately returns nullptr with a pending Java exception for a genuinely missing class (JEnv.cpp:740-742, 757-761 — "just return null and let the runtime deal with the NativeScriptException"). MethodCache.cpp:63 and FieldAccessor.cpp:217-224 check that result for metadata-driven class names. Promoting those would have converted a designed, recoverable path into a hard abort. They stay debug-only. Crash reporting A failed NS_CHECK routes through CrashBreadcrumbs::RecordFatal and logs at ANDROID_LOG_FATAL, which claims the bionic abort-message slot. The check therefore names itself both in the tombstone and in the breadcrumb file the next launch reports, instead of arriving as a bare SIGABRT. RecordFatal takes no lock and writes into a buffer the signal handler already knows how to emit, so it stays safe on a thread aborting from under one of the runtime's own locks. Deliberately not included clang-tidy bugprone-assert-side-effect. The only mechanical guarantee against a side-effecting NS_DCHECK, but there is no .clang-tidy in the repo, so it is new infrastructure; and with CheckFunctionCalls: true it flags every NS_DCHECK(!x.IsEmpty()) and would need an IgnoredFunctions list. An always-evaluating debug-only variant (VERIFY-style). It silently discards failures in production, which is usually the wrong default. If a call must run and its failure matters, that is NS_CHECK. Three bugs this surfaced Making the "these never run in production" claim explicit turned up defects that predate the PR: CallbackHandlers never validated DISABLE_VERBOSE_LOGGING_METHOD_ID. Line 60 checked ENABLE_VERBOSE_LOGGING_METHOD_ID a second time, immediately after assigning the disable id — which is passed to CallVoidMethod. Promoting it unchanged would have frozen the wrong check in permanently. AssetExtractor mishandled every libzip failure. A null zip_fopen_index reached zip_fread and zip_fclose; a zip_fread of 0 stalled the copy loop; -1 reached fwrite widened to size_t. Now handled rather than checked. Extraction is also atomic now. It wrote straight into the destination, which fopen(..., "w") truncates before the first read, so a failed extraction replaced a good asset with its opening bytes and then stamped the apk's mtime onto it. An entry is only re-extracted when the apk's copy is strictly newer than what is on disk, so that truncated file would have survived every later launch. (Deleting the remains instead would not have helped: a partial file left with the current time is newer still, so it sticks too.) Entries now go through an mkstemp temporary, renamed only once the entry has been fully read, written and closed cleanly. utime runs after the rename, so the apk mtime is still what the up-to-date shortcut compares against. BuildMetadata parsed a truncated treeNodeStream.dat. It now throws NativeScriptException with the actual length and record size, matching how the same function already reports a file it cannot open, and rejects a negative ftell before it reaches new char[lenNodes]. A first-party file under v8_inspector/ The first push broke both CI jobs, in one place. v8_inspector/ns-v8-tracing-agent-impl.cpp is built by CMakeLists like any other source, but it lives under v8_inspector/, which the sweep skipped as vendored. It called assert() while receiving transitively from MetadataReader.h, so replacing that include left it with no declaration — in release for the Build job and in debug for the Test job. Its three checks follow ToLocal() on a MaybeLocal, so they are NS_DCHECK. Second commit. Swept for the same signature afterwards: only three other files call assert( without including it directly, and all three are false positives — two are comments (absl/base/options.h, include/v8-fast-api-calls.h) and crdtp/protocol_core.h picks it up from its own status.h. All vendored and untouched. Testing Full local run on an arm64 emulator (Pixel_9_Pro_API_35): Build, the CI Build job's command (./gradlew --stacktrace): exit 0, 0 compile errors across 7 nested gradle invocations and all four ABIs. Debug build + install (:app:installDebug -PuseKotlin=true): exit 0, 0 errors, all four ABIs — this is the configuration the Test job failed in. Specs: 879 across 124 suites, 0 failures, 0 errors. Logcat shows 0 NS_CHECK failed, 0 native crashes and 0 breadcrumb reports from a prior process. The one FATAL EXCEPTION: native-crash-on-alien-thread is the intentional UncaughtErrorPolicyTest fixture, and the run continued past it. Note that a debug build has all 123 checks live — the 50 NS_DCHECK sites as well as the 73 NS_CHECK ones — so a full green suite exercises every converted predicate. Re-run after the review fixes with app data cleared first, so every asset was extracted through the rewritten path: same 879 specs, 0 failures, 0 errors, 0 NS_CHECK fired, no AssetExtractor: diagnostics, and no .ns-partial.* temporaries left behind. Also verified: Both macros compile clean under the repo's own flags (-std=c++20 -Werror) with and without -DNDEBUG, across the statement shapes in the tree: if/else without braces, switch cases, loop bodies, x && "message" predicates, and expressions containing a top-level comma (the macros are variadic, so NS_DCHECK(map.find(k) == map.end()) is one argument). Execution semantics confirmed by running a host binary: under NDEBUG, NS_DCHECK(SideEffect()) ran 0 times and NS_CHECK(SideEffect()) ran 1; a failing NS_CHECK aborted in both configurations. Every one of the 123 removed lines was an assert( or a now-dead / include — checked mechanically against the diff. static_assert, __android_log_assert, assertCallback and the "assert" string literal in Console.cpp are untouched. -Wall/-Wextra are not in the flag set, so the discarded-expression form cannot break the -Werror release build on unused-variable warnings. Summary by CodeRabbit Bug Fixes Improved crash diagnostics by recording failed runtime checks in fatal breadcrumbs and logs. Strengthened validation of runtime and JNI initialization failures. Improved asset extraction reliability by detecting incomplete reads/writes and cleaning up temporary files. Added clearer handling for truncated or corrupt metadata files. Reliability Standardized runtime assertions and failure handling across native components. Improved detection and reporting of critical runtime failures.

Open Graph Description: Why assert() never runs in a build we ship. assembleRelease maps to the RelWithDebInfo CMake config, whose stock CMAKE_CXX_FLAGS_RELWITHDEBINFO carries -DNDEBUG. CMakeLists.txt appends -O3 to that ...

X Description: Why assert() never runs in a build we ship. assembleRelease maps to the RelWithDebInfo CMake config, whose stock CMAKE_CXX_FLAGS_RELWITHDEBINFO carries -DNDEBUG. CMakeLists.txt appends -O3 to that ...

Opengraph URL: https://github.com/NativeScript/android/pull/2014

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:396bbe0b-6fe6-9097-fb34-506a2fbc1a86
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD272:1EB1:3CA607:4F7B8D:6B01307C
html-safe-noncebe629a417e4379f6312dc2cf53c260e35f8bee9e9838ebe04cb19b417130679f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjcyOjFFQjE6M0NBNjA3OjRGN0I4RDo2QjAxMzA3QyIsInZpc2l0b3JfaWQiOiI0OTcyNjQ3Mzc2ODU5NzcxMDA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac801d6437044a221336e641ed5b44d77a967985ae1e46cbfa8b5a7c68918bf759
hovercard-subject-tagpull_request:4287234172
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/android/pull/2014/files
twitter:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4061767?s=400&v=4
og:image:altWhy assert() never runs in a build we ship. assembleRelease maps to the RelWithDebInfo CMake config, whose stock CMAKE_CXX_FLAGS_RELWITHDEBINFO carries -DNDEBUG. CMakeLists.txt appends -O3 to that ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/android git https://github.com/NativeScript/android.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id29137950
octolytics-dimension-repository_nwoNativeScript/android
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id29137950
octolytics-dimension-repository_network_root_nwoNativeScript/android
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/android/pull/2014/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2014%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F2014%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fandroid
Reloadhttps://github.com/NativeScript/android/pull/2014/files
Reloadhttps://github.com/NativeScript/android/pull/2014/files
Reloadhttps://github.com/NativeScript/android/pull/2014/files
NativeScripthttps://github.com/NativeScript
androidhttps://github.com/NativeScript/android
Codehttps://github.com/NativeScript/android
Issues106 (106)https://github.com/NativeScript/android/issues
Pull requests24 (24)https://github.com/NativeScript/android/pulls
Actionshttps://github.com/NativeScript/android/actions
Projectshttps://github.com/NativeScript/android/projects
Wikihttps://github.com/NativeScript/android/wiki
Security and qualityhttps://github.com/NativeScript/android/security
Insightshttps://github.com/NativeScript/android/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
edusperonihttps://github.com/edusperoni
mainhttps://github.com/NativeScript/android/tree/main
refactor/ns-check-macroshttps://github.com/NativeScript/android/tree/refactor/ns-check-macros
Conversation 37 https://github.com/NativeScript/android/pull/2014
Commits 5 https://github.com/NativeScript/android/pull/2014/commits
Checks 7 https://github.com/NativeScript/android/pull/2014/checks
Files changed https://github.com/NativeScript/android/pull/2014/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2014/files
refactor: replace assert() with NS_CHECK/NS_DCHECK https://github.com/NativeScript/android/pull/2014/files#top
Show all changes 5 commits https://github.com/NativeScript/android/pull/2014/files
25b49c2 refactor: replace assert() with NS_CHECK/NS_DCHECK edusperoni Aug 15, 2026 https://github.com/NativeScript/android/pull/2014/commits/25b49c2994c482e6d460911f978d1c238fbc03d3
f0251e1 refactor: convert the tracing agent's asserts too edusperoni Aug 15, 2026 https://github.com/NativeScript/android/pull/2014/commits/f0251e1e333bb20ac8e6ad42914a29cd9f2defe9
036fe53 refactor: address review of the check macros edusperoni Aug 15, 2026 https://github.com/NativeScript/android/pull/2014/commits/036fe53d221c56c25e50b2690ab9594942b7ef7d
2c7149e refactor: extract assets atomically, and never drop a claimed check edusperoni Aug 15, 2026 https://github.com/NativeScript/android/pull/2014/commits/2c7149edaf08d3240dcf7d7d0f0dbf42be577604
b1686ea refactor: create the extraction temporary exclusively edusperoni Aug 15, 2026 https://github.com/NativeScript/android/pull/2014/commits/b1686eaf9c4bebcf80d8c8a7869f08090250fb3a
Clear filters https://github.com/NativeScript/android/pull/2014/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2014/files
Please reload this pagehttps://github.com/NativeScript/android/pull/2014/files
CMakeLists.txt https://github.com/NativeScript/android/pull/2014/files#diff-9aa48152a82c07a60ab6e09923a9b266e2985f78e579653848df730cd8ec5e4c
ArgConverter.cpp https://github.com/NativeScript/android/pull/2014/files#diff-86196b2a12999ec659c091aaa11bf59cae203ca3bbf677eb4669bc53df6218a7
ArrayBufferHelper.cpp https://github.com/NativeScript/android/pull/2014/files#diff-e77228e12c94770c10f5c1c3d4ca713b50d743b18b8bca784d17047251ba9ecc
ArrayHelper.cpp https://github.com/NativeScript/android/pull/2014/files#diff-80d0684b73853a3a7490064fa105595f46c5be59777c2ef04d4c5002f22fbd84
AssetExtractor.cpp https://github.com/NativeScript/android/pull/2014/files#diff-fd8d434f7248b8709ccf8ed0d0f50439fca8ab2894154f93d79a84c3cb6b41d8
CallbackHandlers.cpp https://github.com/NativeScript/android/pull/2014/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e
CrashBreadcrumbs.cpp https://github.com/NativeScript/android/pull/2014/files#diff-81db450b8526cb5292cfcddba4bd2ca674328fdd241bb176a6faca54413303c6
CrashBreadcrumbs.h https://github.com/NativeScript/android/pull/2014/files#diff-06cfbb9d416f1db8fc8e565c3565c577f6480ad0db4395479677098072be1390
EventLoop.cpp https://github.com/NativeScript/android/pull/2014/files#diff-d06fde4169cccc7688752e9634848b89dbd0d9350760b2350ea06f81ac0a86b1
FieldAccessor.cpp https://github.com/NativeScript/android/pull/2014/files#diff-5e991aad04b31c0e151e4adbed673d0ce073d20e3ce3050c59f864907f96bccf
File.cpp https://github.com/NativeScript/android/pull/2014/files#diff-62afd30e33a0c60837abc82931e9684899b7f5575491d192d31df82120e9f0dc
FrameCallbacks.cpp https://github.com/NativeScript/android/pull/2014/files#diff-e99baff1ea363893ffad6767b0020ce886eb0572c2574084443911ac57d508b5
JEnv.cpp https://github.com/NativeScript/android/pull/2014/files#diff-73f675d8548b1b431bfd52b52b051f173bdf8408f03caf73f00891debdb15641
JSONObjectHelper.cpp https://github.com/NativeScript/android/pull/2014/files#diff-1c649d7a77241ceffe1e358e47277c8b2dd1b0c668d2678f3534663903773b65
JniSignatureParser.cpp https://github.com/NativeScript/android/pull/2014/files#diff-d20c056862e02a89c9aba6eb437cc337f25eae7a1a27f5cc6c6c8c6ec178ba74
JsV8InspectorClient.cpp https://github.com/NativeScript/android/pull/2014/files#diff-7cc5549c646c336c9433ef2829baa891d29a8322a7043780b8bbcbdb402daacf
LRUCache.h https://github.com/NativeScript/android/pull/2014/files#diff-0a9f9505289be20c65f9e67b1540900685b18492089185e6e1b06e829ecfc46f
MetadataNode.cpp https://github.com/NativeScript/android/pull/2014/files#diff-6f6c5b64f60875e24b75b8a21b3164f114822aa7e5add5755f072f36403f7f8b
MetadataReader.cpp https://github.com/NativeScript/android/pull/2014/files#diff-c10689703cc3f34ede1d9fe01cad25579a071758c828e86ad0cad3d9e179bb1e
MetadataReader.h https://github.com/NativeScript/android/pull/2014/files#diff-4fda5fc04e9fe4f5478ca473515ea8d2af62f9187b876614daaa2d023c459104
MethodCache.cpp https://github.com/NativeScript/android/pull/2014/files#diff-a66a356aeaaeaeb65c73d7d5cec58ad7f02506b4bae581ec8b8c03de93a682b9
ModuleInternal.cpp https://github.com/NativeScript/android/pull/2014/files#diff-8fb647a9437c57deb39dc2079f0cdfc94a75fafef82b46766fd7d1d276af246e
NativeScriptAssert.cpp https://github.com/NativeScript/android/pull/2014/files#diff-7e4c190a9361f5e94f15b8eeb57b52464b297c2e7f7322e1594a2bc6a9461d1c
NativeScriptAssert.h https://github.com/NativeScript/android/pull/2014/files#diff-5c9dfe478b6a26d51478430e6237f61fa5c43e41f68aa14638a519fe9f82c3d8
NativeScriptException.cpp https://github.com/NativeScript/android/pull/2014/files#diff-93d70766ca3edeb71b49baba2158c55cc56fbd8a53a22f093384344d5a3cb0f3
ObjectManager.cpp https://github.com/NativeScript/android/pull/2014/files#diff-0591ab8dc271af7e8ef11fabf0642e44b932f38003bd07a3696de149a02b2c9b
Runtime.cpp https://github.com/NativeScript/android/pull/2014/files#diff-b9490640f5d26f7cd6b9a176a2142b8e985a6aac9e2d64287de37fc694e80cc3
StructuredClone.cpp https://github.com/NativeScript/android/pull/2014/files#diff-0ef6b17466dd6795b94a4a0cac60975ba14334214b95bdfef39628e0034eb602
StructuredSerialization.cpp https://github.com/NativeScript/android/pull/2014/files#diff-b29450591b552ab7ef39137177cf76bc0a396ba3ef646332e5e25d8b3867403c
V8StringConstants.cpp https://github.com/NativeScript/android/pull/2014/files#diff-c8b460c2ca71019e700b24a2d30c7828e2718a2ad541fcdaf58ab14efd311cd8
WeakRef.cpp https://github.com/NativeScript/android/pull/2014/files#diff-778041b0edab39527fa328e75b85bf1b2fd40a6799bdc070157272cefcb7bec0
WorkerWrapper.cpp https://github.com/NativeScript/android/pull/2014/files#diff-1344a5b85b9f266cab5024f2d52426ba56e3832c074d2c139fb560bcaaabfdc7
Console.cpp https://github.com/NativeScript/android/pull/2014/files#diff-e809a7c5f84aa5b41d82cb99d07062a5644f7cb64a3b702069a145e4a2bdf190
PageResources.cpp https://github.com/NativeScript/android/pull/2014/files#diff-143f5e82ebc94962e7e2ec5e3ac06c02e2162b561bf784d6b1b7e03557c11447
ns-v8-tracing-agent-impl.cpp https://github.com/NativeScript/android/pull/2014/files#diff-0453fb7bfe1ccaee9a2d3511a652dff84e9048b692d2a9b7ae36e6ab8f3e9dd0
test-app/runtime/CMakeLists.txthttps://github.com/NativeScript/android/pull/2014/files#diff-9aa48152a82c07a60ab6e09923a9b266e2985f78e579653848df730cd8ec5e4c
View file https://github.com/NativeScript/android/blob/b1686eaf9c4bebcf80d8c8a7869f08090250fb3a/test-app/runtime/CMakeLists.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2014/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2014/files#diff-9aa48152a82c07a60ab6e09923a9b266e2985f78e579653848df730cd8ec5e4c
https://github.com/NativeScript/android/pull/2014/files#diff-9aa48152a82c07a60ab6e09923a9b266e2985f78e579653848df730cd8ec5e4c
test-app/runtime/src/main/cpp/ArgConverter.cpphttps://github.com/NativeScript/android/pull/2014/files#diff-86196b2a12999ec659c091aaa11bf59cae203ca3bbf677eb4669bc53df6218a7
View file https://github.com/NativeScript/android/blob/b1686eaf9c4bebcf80d8c8a7869f08090250fb3a/test-app/runtime/src/main/cpp/ArgConverter.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2014/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2014/files#diff-86196b2a12999ec659c091aaa11bf59cae203ca3bbf677eb4669bc53df6218a7
https://github.com/NativeScript/android/pull/2014/files#diff-86196b2a12999ec659c091aaa11bf59cae203ca3bbf677eb4669bc53df6218a7
test-app/runtime/src/main/cpp/ArrayBufferHelper.cpphttps://github.com/NativeScript/android/pull/2014/files#diff-e77228e12c94770c10f5c1c3d4ca713b50d743b18b8bca784d17047251ba9ecc
View file https://github.com/NativeScript/android/blob/b1686eaf9c4bebcf80d8c8a7869f08090250fb3a/test-app/runtime/src/main/cpp/ArrayBufferHelper.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2014/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2014/files#diff-e77228e12c94770c10f5c1c3d4ca713b50d743b18b8bca784d17047251ba9ecc
https://github.com/NativeScript/android/pull/2014/files#diff-e77228e12c94770c10f5c1c3d4ca713b50d743b18b8bca784d17047251ba9ecc
https://github.com/NativeScript/android/pull/2014/files#diff-e77228e12c94770c10f5c1c3d4ca713b50d743b18b8bca784d17047251ba9ecc
https://github.com/NativeScript/android/pull/2014/files#diff-e77228e12c94770c10f5c1c3d4ca713b50d743b18b8bca784d17047251ba9ecc
https://github.com/NativeScript/android/pull/2014/files#diff-e77228e12c94770c10f5c1c3d4ca713b50d743b18b8bca784d17047251ba9ecc
test-app/runtime/src/main/cpp/ArrayHelper.cpphttps://github.com/NativeScript/android/pull/2014/files#diff-80d0684b73853a3a7490064fa105595f46c5be59777c2ef04d4c5002f22fbd84
View file https://github.com/NativeScript/android/blob/b1686eaf9c4bebcf80d8c8a7869f08090250fb3a/test-app/runtime/src/main/cpp/ArrayHelper.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2014/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2014/files#diff-80d0684b73853a3a7490064fa105595f46c5be59777c2ef04d4c5002f22fbd84
https://github.com/NativeScript/android/pull/2014/files#diff-80d0684b73853a3a7490064fa105595f46c5be59777c2ef04d4c5002f22fbd84
test-app/runtime/src/main/cpp/AssetExtractor.cpphttps://github.com/NativeScript/android/pull/2014/files#diff-fd8d434f7248b8709ccf8ed0d0f50439fca8ab2894154f93d79a84c3cb6b41d8
View file https://github.com/NativeScript/android/blob/b1686eaf9c4bebcf80d8c8a7869f08090250fb3a/test-app/runtime/src/main/cpp/AssetExtractor.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2014/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2014/files#diff-fd8d434f7248b8709ccf8ed0d0f50439fca8ab2894154f93d79a84c3cb6b41d8
https://github.com/NativeScript/android/pull/2014/files#diff-fd8d434f7248b8709ccf8ed0d0f50439fca8ab2894154f93d79a84c3cb6b41d8
https://github.com/NativeScript/android/pull/2014/files#diff-fd8d434f7248b8709ccf8ed0d0f50439fca8ab2894154f93d79a84c3cb6b41d8
Please reload this pagehttps://github.com/NativeScript/android/pull/2014/files
https://github.com/NativeScript/android/pull/2014/files#diff-fd8d434f7248b8709ccf8ed0d0f50439fca8ab2894154f93d79a84c3cb6b41d8
test-app/runtime/src/main/cpp/CallbackHandlers.cpphttps://github.com/NativeScript/android/pull/2014/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e
View file https://github.com/NativeScript/android/blob/b1686eaf9c4bebcf80d8c8a7869f08090250fb3a/test-app/runtime/src/main/cpp/CallbackHandlers.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/2014/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/2014/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e
https://github.com/NativeScript/android/pull/2014/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e
https://github.com/NativeScript/android/pull/2014/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e
https://github.com/NativeScript/android/pull/2014/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e
https://github.com/NativeScript/android/pull/2014/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e
https://github.com/NativeScript/android/pull/2014/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e
https://github.com/NativeScript/android/pull/2014/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e
https://github.com/NativeScript/android/pull/2014/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e
https://github.com/NativeScript/android/pull/2014/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e
https://github.com/NativeScript/android/pull/2014/files#diff-a784229ab7689cd9ce3d502557091158b2943269fad47c1891a15a07c355500e
Please reload this pagehttps://github.com/NativeScript/android/pull/2014/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.