René's URL Explorer Experiment


Title: Remove remainder of support for external startup data by ptomato · Pull Request #1758 · NativeScript/android · GitHub

Open Graph Title: Remove remainder of support for external startup data by ptomato · Pull Request #1758 · NativeScript/android

X Title: Remove remainder of support for external startup data by ptomato · Pull Request #1758 · NativeScript/android

Description: Description As per NativeScript/NativeScript#8926, external startup data is no longer supported. We can gain a small amount of size savings by building V8 with support for external startup data switched off. Without the machinery to load an external snapshot from a file, nothing is using MemoryMappedFile any longer, so we can remove it. File::Exists has one remaining usage, but that usage is redundant, so we can remove it as well. As you can see in this PR, the V8 libraries get slightly larger (30–40 kb depending on architecture) because they now include the snapshot internally. But the total size of an APK shrinks, because we don't need to link the external startup data into the runtime. I tested with a hello world app, and got -564 kb for debug, -23 kb for release. We also don't need to separately commit snapshot_blob.h to this repo anymore, which makes the process for modifying V8 slightly easier. The V8 artifacts added in this PR were built from my fork of v8-buildscripts, with commits from NativeScript/v8-buildscripts#2 ported to all the Android branches. Unfortunately I had to delete and recreate my fork in order to open the PR (I guess because I forked it when the repo was private?) so the jobs that created those artifacts are gone. In order to establish provenance for the artifacts, what I'd recommend is to review and merge NativeScript/v8-buildscripts#2 first and port it to the other Android branches, then we can rebuild all 4 of them and I'll update this PR with the resulting artifacts from those jobs. Related Pull Requests NativeScript/v8-buildscripts#2 NativeScript/ios#210 Does your pull request have unit tests? No tests; all functionality should be unchanged, except that the heapSnapshotScript and snapshot.blob config options should now be ignored completely.

Open Graph Description: Description As per NativeScript/NativeScript#8926, external startup data is no longer supported. We can gain a small amount of size savings by building V8 with support for external startup data swi...

X Description: Description As per NativeScript/NativeScript#8926, external startup data is no longer supported. We can gain a small amount of size savings by building V8 with support for external startup data swi...

Opengraph URL: https://github.com/NativeScript/android/pull/1758

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7e8ea34d-7742-ce7c-cff6-3c1954440923
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA314:157C65:15249B1:1C3A47C:6B013644
html-safe-nonceafc6494fd429392a3667ad1f5ab9c703dc9c4223d385ecd5ff57b17e3cb79e77
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzE0OjE1N0M2NToxNTI0OUIxOjFDM0E0N0M6NkIwMTM2NDQiLCJ2aXNpdG9yX2lkIjoiNDA1MzAyODQ3ODU5MTc3NjMyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca7467b12a5388108509e63a7516c9bbb9b56f3fe9c2bc01d3d48fb69340c0636
hovercard-subject-tagpull_request:1320299589
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/android/pull/1758/files
twitter:imagehttps://avatars.githubusercontent.com/u/459371?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/459371?s=400&v=4
og:image:altDescription As per NativeScript/NativeScript#8926, external startup data is no longer supported. We can gain a small amount of size savings by building V8 with support for external startup data swi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/android git https://github.com/NativeScript/android.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id29137950
octolytics-dimension-repository_nwoNativeScript/android
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id29137950
octolytics-dimension-repository_network_root_nwoNativeScript/android
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/android/pull/1758/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F1758%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F1758%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fandroid
Reloadhttps://github.com/NativeScript/android/pull/1758/files
Reloadhttps://github.com/NativeScript/android/pull/1758/files
Reloadhttps://github.com/NativeScript/android/pull/1758/files
NativeScripthttps://github.com/NativeScript
androidhttps://github.com/NativeScript/android
Codehttps://github.com/NativeScript/android
Issues106 (106)https://github.com/NativeScript/android/issues
Pull requests24 (24)https://github.com/NativeScript/android/pulls
Actionshttps://github.com/NativeScript/android/actions
Projectshttps://github.com/NativeScript/android/projects
Wikihttps://github.com/NativeScript/android/wiki
Security and qualityhttps://github.com/NativeScript/android/security
Insightshttps://github.com/NativeScript/android/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
triniwizhttps://github.com/triniwiz
NativeScript:mainhttps://github.com/NativeScript/android/tree/main
ptomato:rm-snapshothttps://github.com/ptomato/ns-android/tree/rm-snapshot
Conversation 1 https://github.com/NativeScript/android/pull/1758
Commits 3 https://github.com/NativeScript/android/pull/1758/commits
Checks 0 https://github.com/NativeScript/android/pull/1758/checks
Files changed https://github.com/NativeScript/android/pull/1758/files
Please reload this pagehttps://github.com/NativeScript/android/pull/1758/files
Remove remainder of support for external startup data https://github.com/NativeScript/android/pull/1758/files#top
Show all changes 3 commits https://github.com/NativeScript/android/pull/1758/files
43b5a43 feat: Remove V8 heap snapshot machinery ptomato Feb 10, 2023 https://github.com/NativeScript/android/pull/1758/commits/43b5a43e23ed32b10ede9a2f7c42c71423e87657
c4f0980 chore: Remove File::Exists() ptomato Feb 10, 2023 https://github.com/NativeScript/android/pull/1758/commits/c4f0980b45bfda0210cd4aa6b30fcc675eff0799
84931d0 chore: Remove MemoryMappedFile ptomato Feb 10, 2023 https://github.com/NativeScript/android/pull/1758/commits/84931d0611f760432591ca2fe6a5035c3a3739c2
Clear filters https://github.com/NativeScript/android/pull/1758/files
Please reload this pagehttps://github.com/NativeScript/android/pull/1758/files
Please reload this pagehttps://github.com/NativeScript/android/pull/1758/files
RuntimeHelper.java https://github.com/NativeScript/android/pull/1758/files#diff-a6ee85463ca2d55dd2854a14d0687b6f453164f39df08f81c186ea494bbca575
CMakeLists.txt https://github.com/NativeScript/android/pull/1758/files#diff-9aa48152a82c07a60ab6e09923a9b266e2985f78e579653848df730cd8ec5e4c
Constants.cpp https://github.com/NativeScript/android/pull/1758/files#diff-8ce88346e6491bc9827a5e564c7e4c6ace8fa600f41cc9776d96fc7343087d49
Constants.h https://github.com/NativeScript/android/pull/1758/files#diff-b26429c2750c7df3d38ee30285898dcba063da8a8e8969111f78982c098b39d8
File.cpp https://github.com/NativeScript/android/pull/1758/files#diff-62afd30e33a0c60837abc82931e9684899b7f5575491d192d31df82120e9f0dc
File.h https://github.com/NativeScript/android/pull/1758/files#diff-6bf0c34ab4a924850c3d88f15318d60d430fb10882e01c46c33d8036de89cb52
Runtime.cpp https://github.com/NativeScript/android/pull/1758/files#diff-b9490640f5d26f7cd6b9a176a2142b8e985a6aac9e2d64287de37fc694e80cc3
Runtime.h https://github.com/NativeScript/android/pull/1758/files#diff-87f802d33bb6047fdb5ef6dc8d73551485ecb092edff4de77ecc9affc3e9341c
com_tns_Runtime.cpp https://github.com/NativeScript/android/pull/1758/files#diff-12525df874d33d128becf0dc90001af73fcb89c72d20a9f185d5070848daef23
AppConfig.java https://github.com/NativeScript/android/pull/1758/files#diff-28ca67ca4d113035ce897a844df426c1e1fdd804d4c0d0dea8584cdcced29108
Runtime.java https://github.com/NativeScript/android/pull/1758/files#diff-cf9bb4e9ca1a476cacd6e270fc8bcd12c71f89d52d272915bc99df57b3581f59
snapshot_blob.h https://github.com/NativeScript/android/pull/1758/files#diff-22aa2c717d4bac8c25bb538772eb24604ff7af6db476cf763488a885b0d74cda
libv8_monolith.a https://github.com/NativeScript/android/pull/1758/files#diff-69da2c78937a001dbdf462b12acaab0fdf5edc489b8f4d71107ba44fbb560d16
snapshot_blob.h https://github.com/NativeScript/android/pull/1758/files#diff-ea2cdf2cef0101dd440dd52d81f313d470920de3ca4a2327d89c1eb8002c1b86
libv8_monolith.a https://github.com/NativeScript/android/pull/1758/files#diff-37023ce62c6fcf375f6a68c7a2ce82fa031b414ba89aa2ceb2e4d0727d707e6f
snapshot_blob.h https://github.com/NativeScript/android/pull/1758/files#diff-c73088bf6aa6b61c5c4cb1e7de55b3cb7d2617e6c0c1fd2a568108eae22d8e82
libv8_monolith.a https://github.com/NativeScript/android/pull/1758/files#diff-9ab992f978c27842f61a9e9a6ee6b4064ba5ede9fb597d7e6a32721ad72fb29f
snapshot_blob.h https://github.com/NativeScript/android/pull/1758/files#diff-da565ea4d782d8c07647438f1daa2acb9ebdb32e22b4192e327fe6e982812da7
libv8_monolith.a https://github.com/NativeScript/android/pull/1758/files#diff-baa33ad5ada410ea6ad1c9166ddba98d237b2555ecd89bf2a104c069470e7e7b
test-app/app/src/main/java/com/tns/RuntimeHelper.javahttps://github.com/NativeScript/android/pull/1758/files#diff-a6ee85463ca2d55dd2854a14d0687b6f453164f39df08f81c186ea494bbca575
View file https://github.com/ptomato/ns-android/blob/84931d0611f760432591ca2fe6a5035c3a3739c2/test-app/app/src/main/java/com/tns/RuntimeHelper.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/1758/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/1758/files#diff-a6ee85463ca2d55dd2854a14d0687b6f453164f39df08f81c186ea494bbca575
https://github.com/NativeScript/android/pull/1758/files#diff-a6ee85463ca2d55dd2854a14d0687b6f453164f39df08f81c186ea494bbca575
test-app/runtime/CMakeLists.txthttps://github.com/NativeScript/android/pull/1758/files#diff-9aa48152a82c07a60ab6e09923a9b266e2985f78e579653848df730cd8ec5e4c
View file https://github.com/ptomato/ns-android/blob/84931d0611f760432591ca2fe6a5035c3a3739c2/test-app/runtime/CMakeLists.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/1758/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/1758/files#diff-9aa48152a82c07a60ab6e09923a9b266e2985f78e579653848df730cd8ec5e4c
https://github.com/NativeScript/android/pull/1758/files#diff-9aa48152a82c07a60ab6e09923a9b266e2985f78e579653848df730cd8ec5e4c
test-app/runtime/src/main/cpp/Constants.cpphttps://github.com/NativeScript/android/pull/1758/files#diff-8ce88346e6491bc9827a5e564c7e4c6ace8fa600f41cc9776d96fc7343087d49
View file https://github.com/ptomato/ns-android/blob/84931d0611f760432591ca2fe6a5035c3a3739c2/test-app/runtime/src/main/cpp/Constants.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/1758/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/1758/files#diff-8ce88346e6491bc9827a5e564c7e4c6ace8fa600f41cc9776d96fc7343087d49
test-app/runtime/src/main/cpp/Constants.hhttps://github.com/NativeScript/android/pull/1758/files#diff-b26429c2750c7df3d38ee30285898dcba063da8a8e8969111f78982c098b39d8
View file https://github.com/ptomato/ns-android/blob/84931d0611f760432591ca2fe6a5035c3a3739c2/test-app/runtime/src/main/cpp/Constants.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/1758/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/1758/files#diff-b26429c2750c7df3d38ee30285898dcba063da8a8e8969111f78982c098b39d8
https://github.com/NativeScript/android/pull/1758/files#diff-b26429c2750c7df3d38ee30285898dcba063da8a8e8969111f78982c098b39d8
test-app/runtime/src/main/cpp/File.cpphttps://github.com/NativeScript/android/pull/1758/files#diff-62afd30e33a0c60837abc82931e9684899b7f5575491d192d31df82120e9f0dc
View file https://github.com/ptomato/ns-android/blob/84931d0611f760432591ca2fe6a5035c3a3739c2/test-app/runtime/src/main/cpp/File.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/1758/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/1758/files#diff-62afd30e33a0c60837abc82931e9684899b7f5575491d192d31df82120e9f0dc
https://github.com/NativeScript/android/pull/1758/files#diff-62afd30e33a0c60837abc82931e9684899b7f5575491d192d31df82120e9f0dc
https://github.com/NativeScript/android/pull/1758/files#diff-62afd30e33a0c60837abc82931e9684899b7f5575491d192d31df82120e9f0dc
https://github.com/NativeScript/android/pull/1758/files#diff-62afd30e33a0c60837abc82931e9684899b7f5575491d192d31df82120e9f0dc
https://github.com/NativeScript/android/pull/1758/files#diff-62afd30e33a0c60837abc82931e9684899b7f5575491d192d31df82120e9f0dc
test-app/runtime/src/main/cpp/File.hhttps://github.com/NativeScript/android/pull/1758/files#diff-6bf0c34ab4a924850c3d88f15318d60d430fb10882e01c46c33d8036de89cb52
View file https://github.com/ptomato/ns-android/blob/84931d0611f760432591ca2fe6a5035c3a3739c2/test-app/runtime/src/main/cpp/File.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/1758/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/1758/files#diff-6bf0c34ab4a924850c3d88f15318d60d430fb10882e01c46c33d8036de89cb52
https://github.com/NativeScript/android/pull/1758/files#diff-6bf0c34ab4a924850c3d88f15318d60d430fb10882e01c46c33d8036de89cb52
test-app/runtime/src/main/cpp/Runtime.cpphttps://github.com/NativeScript/android/pull/1758/files#diff-b9490640f5d26f7cd6b9a176a2142b8e985a6aac9e2d64287de37fc694e80cc3
View file https://github.com/ptomato/ns-android/blob/84931d0611f760432591ca2fe6a5035c3a3739c2/test-app/runtime/src/main/cpp/Runtime.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/1758/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/1758/files#diff-b9490640f5d26f7cd6b9a176a2142b8e985a6aac9e2d64287de37fc694e80cc3
https://github.com/NativeScript/android/pull/1758/files#diff-b9490640f5d26f7cd6b9a176a2142b8e985a6aac9e2d64287de37fc694e80cc3
https://github.com/NativeScript/android/pull/1758/files#diff-b9490640f5d26f7cd6b9a176a2142b8e985a6aac9e2d64287de37fc694e80cc3
https://github.com/NativeScript/android/pull/1758/files#diff-b9490640f5d26f7cd6b9a176a2142b8e985a6aac9e2d64287de37fc694e80cc3
https://github.com/NativeScript/android/pull/1758/files#diff-b9490640f5d26f7cd6b9a176a2142b8e985a6aac9e2d64287de37fc694e80cc3
https://github.com/NativeScript/android/pull/1758/files#diff-b9490640f5d26f7cd6b9a176a2142b8e985a6aac9e2d64287de37fc694e80cc3
https://github.com/NativeScript/android/pull/1758/files#diff-b9490640f5d26f7cd6b9a176a2142b8e985a6aac9e2d64287de37fc694e80cc3
https://github.com/NativeScript/android/pull/1758/files#diff-b9490640f5d26f7cd6b9a176a2142b8e985a6aac9e2d64287de37fc694e80cc3
https://github.com/NativeScript/android/pull/1758/files#diff-b9490640f5d26f7cd6b9a176a2142b8e985a6aac9e2d64287de37fc694e80cc3
https://github.com/NativeScript/android/pull/1758/files#diff-b9490640f5d26f7cd6b9a176a2142b8e985a6aac9e2d64287de37fc694e80cc3
test-app/runtime/src/main/cpp/Runtime.hhttps://github.com/NativeScript/android/pull/1758/files#diff-87f802d33bb6047fdb5ef6dc8d73551485ecb092edff4de77ecc9affc3e9341c
View file https://github.com/ptomato/ns-android/blob/84931d0611f760432591ca2fe6a5035c3a3739c2/test-app/runtime/src/main/cpp/Runtime.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/1758/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/1758/files#diff-87f802d33bb6047fdb5ef6dc8d73551485ecb092edff4de77ecc9affc3e9341c
https://github.com/NativeScript/android/pull/1758/files#diff-87f802d33bb6047fdb5ef6dc8d73551485ecb092edff4de77ecc9affc3e9341c
https://github.com/NativeScript/android/pull/1758/files#diff-87f802d33bb6047fdb5ef6dc8d73551485ecb092edff4de77ecc9affc3e9341c
https://github.com/NativeScript/android/pull/1758/files#diff-87f802d33bb6047fdb5ef6dc8d73551485ecb092edff4de77ecc9affc3e9341c
https://github.com/NativeScript/android/pull/1758/files#diff-87f802d33bb6047fdb5ef6dc8d73551485ecb092edff4de77ecc9affc3e9341c
test-app/runtime/src/main/cpp/com_tns_Runtime.cpphttps://github.com/NativeScript/android/pull/1758/files#diff-12525df874d33d128becf0dc90001af73fcb89c72d20a9f185d5070848daef23
View file https://github.com/ptomato/ns-android/blob/84931d0611f760432591ca2fe6a5035c3a3739c2/test-app/runtime/src/main/cpp/com_tns_Runtime.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/1758/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/1758/files#diff-12525df874d33d128becf0dc90001af73fcb89c72d20a9f185d5070848daef23
https://github.com/NativeScript/android/pull/1758/files#diff-12525df874d33d128becf0dc90001af73fcb89c72d20a9f185d5070848daef23
Please reload this pagehttps://github.com/NativeScript/android/pull/1758/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.