René's URL Explorer Experiment


Title: fix(crash): Fix for #887 by DickSmith · Pull Request #1113 · NativeScript/android · GitHub

Open Graph Title: fix(crash): Fix for #887 by DickSmith · Pull Request #1113 · NativeScript/android

X Title: fix(crash): Fix for #887 by DickSmith · Pull Request #1113 · NativeScript/android

Description: https://www.telerik.com/account/support-tickets/view-ticket?threadid=1175125 #887 We enabled "markingMode: none" some month back which noticeably improve performance, however, there has been an increase in crashes that seem to appear related to these garbage collected objects when traversing the app rapidly. All are caused by "Fatal Exception: com.tns.NativeScriptException" They generally fall into a few different types: Calling js method onCreateView failed Error: java.lang.NoSuchMethodError: no non-static method Seen with multiple classes/methods: "Landroid/widget/TextView;.setHint()Ljava/util/Set;" "Lorg/nativescript/widgets/GridLayout;.addView()Z" "Lcom/facebook/drawee/view/SimpleDraweeView;.setImageURI(Ljava/lang/Object;)Ljava/lang/Object;" "Landroid/widget/TextView;.setPadding()Ljava/util/Set;" "Landroid/animation/AnimatorSet;.clone()Ljava/util/Iterator;" "Lorg/nativescript/widgets/GridLayout;.addView()Ljava/lang/Object;" "Lorg/nativescript/widgets/GridLayout;.addView(Ljava/lang/Object;)Ljava/lang/Object;" "Lorg/nativescript/widgets/GridLayout;.addView()Z" Attempt to use cleared object reference id= Calling js method onCreateView failed Error: java.lang.Exception: Failed resolving method addView on class Various classes: Calling js method onCreateView failed Error: java.lang.Exception: Failed resolving method addView on class android.view.ViewGroup com.tns.Runtime.resolveMethodOverload(Runtime.java:1062) com.tns.Runtime.callJSMethodNative(Native Method) com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1101) Calling js method onCreateView failed Error: java.lang.Exception: Failed resolving method addView on class org.nativescript.widgets.GridLayout com.tns.Runtime.resolveMethodOverload(Runtime.java:1062) com.tns.Runtime.callJSMethodNative(Native Method) com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1101) Calling js method onDismiss failed Error: java.lang.IllegalStateException: Activity has been destroyed android.app.FragmentManagerImpl.enqueueAction(FragmentManager.java:1460) 4b. Calling js method onDismiss failed TypeError: Cannot read property 'setOnTouchListener' of null File: ", line: 37, column: 522034 StackTrace: Frame: function:'t.onUnloaded', Possible others: Unable to start activity ComponentInfo{com.ugroupmedia.pnp14/com.tns.NativeScriptActivity}: com.tns.NativeScriptException: Calling js method onCreate failed Error: Could not find a page for fragment3[3]. File: ", line: 37, column: 640522 StackTrace: Frame: function:'c', file:'', line: 37, column: 1307106 Frame: function:'L', file:'', line: 37, column: 637193 Frame: function:'e.onCreate', file:'', line: 37, column: 638611 Frame: function:'n.onCreate', file:'', line: 37, column: 1690605 Frame: function:'e.onCreate', file:'', line: 37, column: 640523 Frame: function:'n.onCreate', file:'', line: 37, column: 1689023 Failure delivering result ResultInfo{who=null, request=64206, result=-1, data=Intent { (has extras) }} to activity {com.ugroupmedia.pnp14/com.tns.NativeScriptActivity}: com.tns.NativeScriptException: Calling js method onActivityResult failed Error: Cannot convert object to Lcom/google/android/gms/tasks/OnCompleteListener; at index 0 File: ", line: 37, column: 729120 StackTrace: Frame: function:'onSuccess', file:'', line: 37, column: 746398 Frame: function:'', file:'', line: 37, column: 729121 Frame: function:'e.notify', file:'', line: 37, column: 779309 Frame: function:'e.onActivityResult', file:'', line: 37, column: 642514 Frame: function:'n.onActivityResult', file:'', line: 37, column: 1689820 Calling js method run failed TypeError: Cannot read property 'getWindow' of undefined Calling js method run failed Error: java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState android.app.FragmentManagerImpl.checkStateLoss(FragmentManager.java:1411) While all, or none of these may not all be related to the garbage collection, I though I would just include some of them for now. I think the main issue is that the method may through an error, but is never caught, and many of these are occurring in asynchronous contexts. Strangely enough, the same method when not called on the main thread (for workers?) is silently caught but no logging is preformed, which may explain some difficulty I've encounter in the pas when workers have failed silently; so this PR catching and logging both. (I wasn't sure if there is a preference for logging, so I included both the logger.write and e.printStackTrace().)

Open Graph Description: https://www.telerik.com/account/support-tickets/view-ticket?threadid=1175125 #887 We enabled "markingMode: none" some month back which noticeably improve performance, however, there has b...

X Description: https://www.telerik.com/account/support-tickets/view-ticket?threadid=1175125 #887 We enabled "markingMode: none" some month back which noticeably improve performance, however, the...

Opengraph URL: https://github.com/NativeScript/android/pull/1113

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1f8ab6ae-6b79-0064-042d-929be30e9109
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE7B0:399E4B:1A12A77:2296E29:6B014DE3
html-safe-nonce8e1b59aa0de66df98fa54f822bb9f39ce5bf4e99119ce54cba91e71a1b0a2073
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0IwOjM5OUU0QjoxQTEyQTc3OjIyOTZFMjk6NkIwMTRERTMiLCJ2aXNpdG9yX2lkIjoiNDc4NTA3NzIxNzIxNjUxNTU1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6c5e72ddd088f000dadc9b25b9209fafc2b290afc5562215df14a346a4206d2c
hovercard-subject-tagpull_request:201525345
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/android/pull/1113/files
twitter:imagehttps://avatars.githubusercontent.com/u/6675511?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6675511?s=400&v=4
og:image:althttps://www.telerik.com/account/support-tickets/view-ticket?threadid=1175125 #887 We enabled "markingMode: none" some month back which noticeably improve performance, however, there has b...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/android git https://github.com/NativeScript/android.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id29137950
octolytics-dimension-repository_nwoNativeScript/android
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id29137950
octolytics-dimension-repository_network_root_nwoNativeScript/android
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/android/pull/1113/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F1113%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F1113%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fandroid
Reloadhttps://github.com/NativeScript/android/pull/1113/files
Reloadhttps://github.com/NativeScript/android/pull/1113/files
Reloadhttps://github.com/NativeScript/android/pull/1113/files
NativeScripthttps://github.com/NativeScript
androidhttps://github.com/NativeScript/android
Codehttps://github.com/NativeScript/android
Issues106 (106)https://github.com/NativeScript/android/issues
Pull requests25 (25)https://github.com/NativeScript/android/pulls
Actionshttps://github.com/NativeScript/android/actions
Projectshttps://github.com/NativeScript/android/projects
Wikihttps://github.com/NativeScript/android/wiki
Security and qualityhttps://github.com/NativeScript/android/security
Insightshttps://github.com/NativeScript/android/insights
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose
DickSmithhttps://github.com/DickSmith
NativeScript:masterhttps://github.com/NativeScript/android/tree/master
Conversation 14 https://github.com/NativeScript/android/pull/1113
Commits 2 https://github.com/NativeScript/android/pull/1113/commits
Checks 0 https://github.com/NativeScript/android/pull/1113/checks
Files changed https://github.com/NativeScript/android/pull/1113/files
Please reload this pagehttps://github.com/NativeScript/android/pull/1113/files
fix(crash): Fix for #887 https://github.com/NativeScript/android/pull/1113/files#top
Show all changes 2 commits https://github.com/NativeScript/android/pull/1113/files
33b053f fix(crash): Fix for #887 Jul 16, 2018 https://github.com/NativeScript/android/pull/1113/commits/33b053fccdac96966320f0b362c5116227fa7ab7
42b15ee Merge branch 'master' into master DickSmith Jul 19, 2018 https://github.com/NativeScript/android/pull/1113/commits/42b15ee17addbe4fcec31dc91e73d2adbdbb6d02
Clear filters https://github.com/NativeScript/android/pull/1113/files
Please reload this pagehttps://github.com/NativeScript/android/pull/1113/files
Please reload this pagehttps://github.com/NativeScript/android/pull/1113/files
test-app/runtime/src/main/java/com/tns/Runtime.javahttps://github.com/NativeScript/android/pull/1113/files#diff-cf9bb4e9ca1a476cacd6e270fc8bcd12c71f89d52d272915bc99df57b3581f59
View file https://github.com/NativeScript/android/blob/42b15ee17addbe4fcec31dc91e73d2adbdbb6d02/test-app/runtime/src/main/java/com/tns/Runtime.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/android/pull/1113/{{ revealButtonHref }}
https://github.com/NativeScript/android/pull/1113/files#diff-cf9bb4e9ca1a476cacd6e270fc8bcd12c71f89d52d272915bc99df57b3581f59
https://github.com/NativeScript/android/pull/1113/files#diff-cf9bb4e9ca1a476cacd6e270fc8bcd12c71f89d52d272915bc99df57b3581f59
https://github.com/NativeScript/android/pull/1113/files#diff-cf9bb4e9ca1a476cacd6e270fc8bcd12c71f89d52d272915bc99df57b3581f59
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.