René's URL Explorer Experiment
Title: fix(crash): Fix for #887 by DickSmith · Pull Request #1113 · NativeScript/android · GitHub
Open Graph Title: fix(crash): Fix for #887 by DickSmith · Pull Request #1113 · NativeScript/android
X Title: fix(crash): Fix for #887 by DickSmith · Pull Request #1113 · NativeScript/android
Description: https://www.telerik.com/account/support-tickets/view-ticket?threadid=1175125
#887
We enabled "markingMode: none" some month back which noticeably improve performance, however, there has been an increase in crashes that seem to appear related to these garbage collected objects when traversing the app rapidly.
All are caused by "Fatal Exception: com.tns.NativeScriptException"
They generally fall into a few different types:
Calling js method onCreateView failed Error: java.lang.NoSuchMethodError: no non-static method
Seen with multiple classes/methods:
"Landroid/widget/TextView;.setHint()Ljava/util/Set;"
"Lorg/nativescript/widgets/GridLayout;.addView()Z"
"Lcom/facebook/drawee/view/SimpleDraweeView;.setImageURI(Ljava/lang/Object;)Ljava/lang/Object;"
"Landroid/widget/TextView;.setPadding()Ljava/util/Set;"
"Landroid/animation/AnimatorSet;.clone()Ljava/util/Iterator;"
"Lorg/nativescript/widgets/GridLayout;.addView()Ljava/lang/Object;"
"Lorg/nativescript/widgets/GridLayout;.addView(Ljava/lang/Object;)Ljava/lang/Object;"
"Lorg/nativescript/widgets/GridLayout;.addView()Z"
Attempt to use cleared object reference id=
Calling js method onCreateView failed Error: java.lang.Exception: Failed resolving method addView on class
Various classes:
Calling js method onCreateView failed Error: java.lang.Exception: Failed resolving method addView on class android.view.ViewGroup com.tns.Runtime.resolveMethodOverload(Runtime.java:1062) com.tns.Runtime.callJSMethodNative(Native Method) com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1101)
Calling js method onCreateView failed Error: java.lang.Exception: Failed resolving method addView on class org.nativescript.widgets.GridLayout com.tns.Runtime.resolveMethodOverload(Runtime.java:1062) com.tns.Runtime.callJSMethodNative(Native Method) com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1101)
Calling js method onDismiss failed Error: java.lang.IllegalStateException: Activity has been destroyed android.app.FragmentManagerImpl.enqueueAction(FragmentManager.java:1460)
4b. Calling js method onDismiss failed TypeError: Cannot read property 'setOnTouchListener' of null File: ", line: 37, column: 522034 StackTrace: Frame: function:'t.onUnloaded',
Possible others:
Unable to start activity ComponentInfo{com.ugroupmedia.pnp14/com.tns.NativeScriptActivity}: com.tns.NativeScriptException: Calling js method onCreate failed Error: Could not find a page for fragment3[3]. File: ", line: 37, column: 640522 StackTrace: Frame: function:'c', file:'', line: 37, column: 1307106 Frame: function:'L', file:'', line: 37, column: 637193 Frame: function:'e.onCreate', file:'', line: 37, column: 638611 Frame: function:'n.onCreate', file:'', line: 37, column: 1690605 Frame: function:'e.onCreate', file:'', line: 37, column: 640523 Frame: function:'n.onCreate', file:'', line: 37, column: 1689023
Failure delivering result ResultInfo{who=null, request=64206, result=-1, data=Intent { (has extras) }} to activity {com.ugroupmedia.pnp14/com.tns.NativeScriptActivity}: com.tns.NativeScriptException: Calling js method onActivityResult failed Error: Cannot convert object to Lcom/google/android/gms/tasks/OnCompleteListener; at index 0 File: ", line: 37, column: 729120 StackTrace: Frame: function:'onSuccess', file:'', line: 37, column: 746398 Frame: function:'', file:'', line: 37, column: 729121 Frame: function:'e.notify', file:'', line: 37, column: 779309 Frame: function:'e.onActivityResult', file:'', line: 37, column: 642514 Frame: function:'n.onActivityResult', file:'', line: 37, column: 1689820
Calling js method run failed TypeError: Cannot read property 'getWindow' of undefined
Calling js method run failed Error: java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState android.app.FragmentManagerImpl.checkStateLoss(FragmentManager.java:1411)
While all, or none of these may not all be related to the garbage collection, I though I would just include some of them for now.
I think the main issue is that the method may through an error, but is never caught, and many of these are occurring in asynchronous contexts. Strangely enough, the same method when not called on the main thread (for workers?) is silently caught but no logging is preformed, which may explain some difficulty I've encounter in the pas when workers have failed silently; so this PR catching and logging both. (I wasn't sure if there is a preference for logging, so I included both the logger.write and e.printStackTrace().)
Open Graph Description: https://www.telerik.com/account/support-tickets/view-ticket?threadid=1175125
#887
We enabled "markingMode: none" some month back which noticeably improve performance, however, there has b...
X Description: https://www.telerik.com/account/support-tickets/view-ticket?threadid=1175125
#887
We enabled "markingMode: none" some month back which noticeably improve performance, however, the...
Opengraph URL: https://github.com/NativeScript/android/pull/1113
X: @github
direct link
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1f8ab6ae-6b79-0064-042d-929be30e9109 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E7B0:399E4B:1A12A77:2296E29:6B014DE3 |
| html-safe-nonce | 8e1b59aa0de66df98fa54f822bb9f39ce5bf4e99119ce54cba91e71a1b0a2073 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0IwOjM5OUU0QjoxQTEyQTc3OjIyOTZFMjk6NkIwMTRERTMiLCJ2aXNpdG9yX2lkIjoiNDc4NTA3NzIxNzIxNjUxNTU1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6c5e72ddd088f000dadc9b25b9209fafc2b290afc5562215df14a346a4206d2c |
| hovercard-subject-tag | pull_request:201525345 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/android/pull/1113/files |
| twitter:image | https://avatars.githubusercontent.com/u/6675511?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/6675511?s=400&v=4 |
| og:image:alt | https://www.telerik.com/account/support-tickets/view-ticket?threadid=1175125
#887
We enabled "markingMode: none" some month back which noticeably improve performance, however, there has b... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/NativeScript/android git https://github.com/NativeScript/android.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 29137950 |
| octolytics-dimension-repository_nwo | NativeScript/android |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 29137950 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/android |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
| Skip to content | https://github.com/NativeScript/android/pull/1113/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F1113%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fpull%2F1113%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2Fandroid |
| Reload | https://github.com/NativeScript/android/pull/1113/files |
| Reload | https://github.com/NativeScript/android/pull/1113/files |
| Reload | https://github.com/NativeScript/android/pull/1113/files |
| NativeScript | https://github.com/NativeScript |
| android | https://github.com/NativeScript/android |
| Code | https://github.com/NativeScript/android |
| Issues106 (106) | https://github.com/NativeScript/android/issues |
| Pull requests25 (25) | https://github.com/NativeScript/android/pulls |
| Actions | https://github.com/NativeScript/android/actions |
| Projects | https://github.com/NativeScript/android/projects |
| Wiki | https://github.com/NativeScript/android/wiki |
| Security and quality | https://github.com/NativeScript/android/security |
| Insights | https://github.com/NativeScript/android/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2FNativeScript%2Fandroid%2Fissues%2Fnew%2Fchoose |
| DickSmith | https://github.com/DickSmith |
| NativeScript:master | https://github.com/NativeScript/android/tree/master |
|
Conversation
14
| https://github.com/NativeScript/android/pull/1113 |
|
Commits
2
| https://github.com/NativeScript/android/pull/1113/commits |
|
Checks
0
| https://github.com/NativeScript/android/pull/1113/checks |
|
Files changed
| https://github.com/NativeScript/android/pull/1113/files |
| Please reload this page | https://github.com/NativeScript/android/pull/1113/files |
|
fix(crash): Fix for #887
| https://github.com/NativeScript/android/pull/1113/files#top |
|
Show all changes
2 commits
| https://github.com/NativeScript/android/pull/1113/files |
|
33b053f
fix(crash): Fix for #887
Jul 16, 2018
| https://github.com/NativeScript/android/pull/1113/commits/33b053fccdac96966320f0b362c5116227fa7ab7 |
|
42b15ee
Merge branch 'master' into master
DickSmith Jul 19, 2018
| https://github.com/NativeScript/android/pull/1113/commits/42b15ee17addbe4fcec31dc91e73d2adbdbb6d02 |
|
Clear filters
| https://github.com/NativeScript/android/pull/1113/files |
| Please reload this page | https://github.com/NativeScript/android/pull/1113/files |
| Please reload this page | https://github.com/NativeScript/android/pull/1113/files |
| test-app/runtime/src/main/java/com/tns/Runtime.java | https://github.com/NativeScript/android/pull/1113/files#diff-cf9bb4e9ca1a476cacd6e270fc8bcd12c71f89d52d272915bc99df57b3581f59 |
|
View file
| https://github.com/NativeScript/android/blob/42b15ee17addbe4fcec31dc91e73d2adbdbb6d02/test-app/runtime/src/main/java/com/tns/Runtime.java |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/NativeScript/android/pull/1113/{{ revealButtonHref }} |
|
| https://github.com/NativeScript/android/pull/1113/files#diff-cf9bb4e9ca1a476cacd6e270fc8bcd12c71f89d52d272915bc99df57b3581f59 |
|
| https://github.com/NativeScript/android/pull/1113/files#diff-cf9bb4e9ca1a476cacd6e270fc8bcd12c71f89d52d272915bc99df57b3581f59 |
|
| https://github.com/NativeScript/android/pull/1113/files#diff-cf9bb4e9ca1a476cacd6e270fc8bcd12c71f89d52d272915bc99df57b3581f59 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |
Viewport: width=device-width
URLs of crawlers that visited me.