René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Static binding generator creates wrong files, when two extended classes have the same name","articleBody":"_Problem:_\r\nStatic binding generator creates wrong files, when two extended classes have the same name\r\nHow can I reproduce the problem:\r\n* The same class is extended 2 times in typescript\r\nhttps://github.com/NativeScript/NativeScript/blob/84c469d61b148544bd1ef8b4f41ce689f9145754/tns-core-modules/ui/gestures/gestures.android.ts#L198\r\nhttps://github.com/NativeScript/NativeScript/blob/84c469d61b148544bd1ef8b4f41ce689f9145754/tns-core-modules/ui/gestures/gestures.android.ts#L339\r\n* Uglify is used and the names `SwipeGestureListener` and `TapAndDoubleTapGestureListener` become `e` or some other letter.\r\n* while we analyze the uglified, minified javascript the AST parser generates the same name for both classes: `GestureDetector_SimpleOnGestureListener_frnal_ts_helpers_l58_c38__e.java`.\r\n\r\nThe name is generated as follows: \r\n`\u003cextended_class_name\u003e_f\u003cfile_path\u003e_l\u003cline\u003e_c\u003ccolumn\u003e__\u003cunique_name\u003e.java`\r\n* Because both classes extend the same base class, both names start with the same `\u003cextended_class_name\u003e`\r\n* Because the typescript extends all pass through the [ts_helpers file](https://github.com/NativeScript/android-runtime/blob/master/build-artifacts/project-template-gradle/src/main/assets/internal/ts_helpers.js#L58), all files have the same `_f\u003cfile_path\u003e_l\u003cline\u003e_c\u003ccolumn\u003e`. \r\n* Because uglifyer minifies the names of both classes the `\u003cunique_name\u003e` is not so unique anymore.\r\n\r\n_Solution_\r\nThere are two general paths we can take:\r\n* Suggest the user makes an exception when uglifying for the `\u003cunique_name\u003e` so it stays unique\r\n* Find a different way to generate names, that will generate classes with different names, that's also compatible with the way the runtime binding generator would generate them.\r\n\r\nThis problem does not happen when extending an interface, because the native implementation name does not take part in finding the js counterpart implementation, and all can use the same implementation of an interface.","author":{"url":"https://github.com/Plamen5kov","@type":"Person","name":"Plamen5kov"},"datePublished":"2017-01-18T15:24:37.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/692/android/issues/692"}