René's URL Explorer Experiment


Title: Proxy dex generation: thread-safety and latent naming bugs (follow-up to #2016) · Issue #2019 · NativeScript/android · GitHub

Open Graph Title: Proxy dex generation: thread-safety and latent naming bugs (follow-up to #2016) · Issue #2019 · NativeScript/android

X Title: Proxy dex generation: thread-safety and latent naming bugs (follow-up to #2016) · Issue #2019 · NativeScript/android

Description: Follow-up to #2016, which makes runtime proxy dex generation a routine path (dev servers keeping @nativescript/core off disk) instead of a rare one. None of the items below block that PR — they are pre-existing defects in the generation ...

Open Graph Description: Follow-up to #2016, which makes runtime proxy dex generation a routine path (dev servers keeping @nativescript/core off disk) instead of a rare one. None of the items below block that PR — they are...

X Description: Follow-up to #2016, which makes runtime proxy dex generation a routine path (dev servers keeping @nativescript/core off disk) instead of a rare one. None of the items below block that PR — they are...

Opengraph URL: https://github.com/NativeScript/android/issues/2019

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Proxy dex generation: thread-safety and latent naming bugs (follow-up to #2016)","articleBody":"Follow-up to #2016, which makes runtime proxy dex generation a routine path (dev servers keeping `@nativescript/core` off disk) instead of a rare one. None of the items below block that PR — they are pre-existing defects in the generation path whose exposure it raises, plus small latent bugs found while reviewing it. Intended to be picked up after the ESM/loader work lands.\n\n## Concurrency (the substantive part)\n\nProxy generation has no synchronization, but it is reachable from every runtime's thread (`extend` works on workers; each `Runtime` has its own `DexFactory`, but they share one `dexDir` and the static state below):\n\n- **Silent dex corruption:** `Dump.methodDescriptorBuilder` is a `static final StringBuffer` used as `setLength(0)` → append → `toString()` (runtime-binding-generator, `Dump.java:27`). Two concurrent generations interleave and bake wrong method descriptors into a dex — no error, just a wrong class. `Dump.interfaceImplementedInterfaces[1] = classSignature` (`Dump.java:810,820`) is the same hazard on a static array.\n- **`EACCES` on the loser thread:** `jarFile.exists()` / `setReadOnly()` is a check-then-act pair (`DexFactory.java` jar assembly), and `setReadOnly()` runs on every resolve including cache hits, widening the window. Two threads resolving the same class can leave one opening a 0444 file for write.\n- **Truncated jar persisted read-only:** `fi.read(dexData, 0, dexData.length)` is a single unchecked read (`DexFactory.java`, jar assembly). A short read — e.g. racing a concurrent write of the same dex — zero-pads the jar, which is then made read-only and reused on subsequent launches within the install.\n- **`ConcurrentModificationException` window:** `ClassStorageServiceImpl.retrieveClass` iterates the loaders collection (an `unmodifiableCollection` over a `synchronizedSet`) without holding its lock while `storeClass` → `addClassLoader` mutates it. Every runtime-generated proxy adds a loader, so #2016 directly raises the hit rate (and makes the miss path O(loaders)).\n\nSuggested shape: make `Dump`'s scratch state instance-local (it already is instantiated per `ProxyGenerator`); loop the read or use `Files.readAllBytes`; write the jar to a temp name and atomically rename; synchronize the loaders iteration on the underlying set.\n\n## Latent bugs / nits\n\n- `dexFile.getPath().replace(\".dex\", \".jar\")` replaces **all** occurrences, not the suffix — a package segment containing `.dex` (e.g. `com.example.dexter…` does not, but `….dext` shapes can) mangles both names identically, so it works until two distinct classes mangle to the same jar. Use a suffix strip.\n- `$` → `_` normalization is applied to `className` but never to `baseClassName`, so `Interface.extend({...})` on a **nested** interface computes `classNameToLoad = com.tns.gen.…$…` while the generator emits `…_…` → `ClassNotFoundException`. Pre-existing; sits on the exact line #2016 guards.\n- The two prefix predicates disagree: `ClassResolver` tests `startsWith(\"com.tns.gen\")`, `DexFactory` tests `\"com.tns.gen.\"` (trailing dot). A name like `com.tns.generated.Foo` is a binding class to one and a named proxy to the other.\n- `com.tns.tests.*` is excluded from `isBindingClass`, so a missing test class now falls through to runtime generation instead of throwing — an unintended widening from #2016's fallthrough.\n- There is no name validation at all for dotted extend names (`ValidateExtendArguments` is skipped on the `hasDot` branch), and the extend-name validation specs in `extendClassNameTests.js` are commented out. A named proxy colliding with a derived anonymous name fails with a bare CNFE.\n- `JEnv::InsertClassIntoCache` caches `nullptr` on a failed resolve, and the cache read treats that as a miss forever — a name that fails once and succeeds later re-crosses JNI on every lookup (perf only).\n\n## Explicitly not included\n\nA \"migration sweep\" for legacy un-thumbed cache files was considered and rejected: `dexDir` lives under the app's `code_cache`, which the platform wipes on every app upgrade — the same event that changes the thumb — so pre-#2016 files cannot survive into a post-#2016 install. The only residue is the rare fallback dir (`files/secondary-dexes`, used when `code_cache` is unusable), which is not platform-wiped; not worth machinery.\n","author":{"url":"https://github.com/edusperoni","@type":"Person","name":"edusperoni"},"datePublished":"2026-08-20T01:58:13Z","url":"https://github.com/NativeScript/android/issues/2019"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:39a05797-c8b0-96af-5f21-45c7f486e9c5
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8B8A:1EC9BC:1497925:1A4294C:6B012E39
html-safe-noncead2cf138e9e2cd6f7001006c3d73649bb9236c9cf6e944877e7c7bf24bf23c83
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjhBOjFFQzlCQzoxNDk3OTI1OjFBNDI5NEM6NkIwMTJFMzkiLCJ2aXNpdG9yX2lkIjoiODg0Njg0NDc2Mjc1NDQ2MTI0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8ba36243995b8c2fb2e7f189cf2ec1ff06b840eeed9d7dbb5782823efd36b3b2
hovercard-subject-tagissue:5198870328
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/NativeScript/android/2019/issue_layout
twitter:imagehttps://opengraph.githubassets.com/132793a20dba5b8a1d745c319e8a2aed3061ad17cc04dd1ab1c209c7854fd437/NativeScript/android/issues/2019
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/132793a20dba5b8a1d745c319e8a2aed3061ad17cc04dd1ab1c209c7854fd437/NativeScript/android/issues/2019
og:image:altFollow-up to #2016, which makes runtime proxy dex generation a routine path (dev servers keeping @nativescript/core off disk) instead of a rare one. None of the items below block that PR — they are...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameedusperoni
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/NativeScript/android git https://github.com/NativeScript/android.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id29137950
octolytics-dimension-repository_nwoNativeScript/android
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id29137950
octolytics-dimension-repository_network_root_nwoNativeScript/android
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/NativeScript/android/issues/2019#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fissues%2F2019
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2Fandroid%2Fissues%2F2019
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=NativeScript%2Fandroid
Reloadhttps://github.com/NativeScript/android/issues/2019
Reloadhttps://github.com/NativeScript/android/issues/2019
Reloadhttps://github.com/NativeScript/android/issues/2019
NativeScripthttps://github.com/NativeScript
androidhttps://github.com/NativeScript/android
Codehttps://github.com/NativeScript/android
Issues106 (106)https://github.com/NativeScript/android/issues
Pull requests24 (24)https://github.com/NativeScript/android/pulls
Actionshttps://github.com/NativeScript/android/actions
Projectshttps://github.com/NativeScript/android/projects
Wikihttps://github.com/NativeScript/android/wiki
Security and qualityhttps://github.com/NativeScript/android/security
Insightshttps://github.com/NativeScript/android/insights
https://github.com/NativeScript/android
New issuehttps://github.com/login?return_to=https://github.com/NativeScript/android/issues/2019
New issuehttps://github.com/login?return_to=https://github.com/NativeScript/android/issues/2019
#2116https://github.com/NativeScript/android/pull/2116
Proxy dex generation: thread-safety and latent naming bugs (follow-up to #2016)https://github.com/NativeScript/android/issues/2019#top
#2116https://github.com/NativeScript/android/pull/2116
https://github.com/edusperoni
edusperonihttps://github.com/edusperoni
on Aug 20, 2026https://github.com/NativeScript/android/issues/2019#issue-5198870328
#2016https://github.com/NativeScript/android/pull/2016
fix(runtime): generate named Java proxies at runtime when not precompiled #2016https://github.com/NativeScript/android/pull/2016
fix(runtime): generate named Java proxies at runtime when not precompiled #2016https://github.com/NativeScript/android/pull/2016
fix(runtime): generate named Java proxies at runtime when not precompiled #2016https://github.com/NativeScript/android/pull/2016
#2016https://github.com/NativeScript/android/pull/2016
#2016https://github.com/NativeScript/android/pull/2016
edusperonihttps://github.com/edusperoni
completedhttps://github.com/NativeScript/android/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#2116https://github.com/NativeScript/android/pull/2116
on Nov 18, 2026https://github.com/NativeScript/android/issues/2019#event-36488899712
Sign up for freehttps://github.com/signup?return_to=https://github.com/NativeScript/android/issues/2019
Sign in to commenthttps://github.com/login?return_to=https://github.com/NativeScript/android/issues/2019
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.