| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:d0bbd1e0-9f38-de56-f418-07b05a21c718 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 844C:D3A0E:DDBFB6:128AFC0:6A5CF947 |
| html-safe-nonce | 293bfb7df10f9e57fbf023ced3a4a3b7652d03232d695990686068d65d7319ec |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDRDOkQzQTBFOkREQkZCNjoxMjhBRkMwOjZBNUNGOTQ3IiwidmlzaXRvcl9pZCI6Ijc1ODY0NjgwMDgyMjkxNDA4MDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8b81c6eb55da8a9bd72a6e0d45d1fdc1f87048df68971c309bd0a3c1108145be |
| hovercard-subject-tag | pull_request:917246805 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/9879 |
| twitter:image | https://opengraph.githubassets.com/39911541e1daea479713ea4c6be254b5c97cc525322648aed31e8619b1a8ba73/NativeScript/NativeScript/pull/9879 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/39911541e1daea479713ea4c6be254b5c97cc525322648aed31e8619b1a8ba73/NativeScript/NativeScript/pull/9879 |
| og:image:alt | PR Checklist
The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | CatchABus |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-cache |
| go-import | github.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31492490 |
| octolytics-dimension-repository_nwo | NativeScript/NativeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31492490 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/NativeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/NativeScript/NativeScript/pull/9879#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F9879 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F9879 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=NativeScript%2FNativeScript |
| Reload | https://github.com/NativeScript/NativeScript/pull/9879 |
| Reload | https://github.com/NativeScript/NativeScript/pull/9879 |
| Reload | https://github.com/NativeScript/NativeScript/pull/9879 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/9879 |
|
NativeScript
| https://github.com/NativeScript |
| NativeScript | https://github.com/NativeScript/NativeScript |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/9879 |
|
Notifications
| https://github.com/login?return_to=%2FNativeScript%2FNativeScript |
|
Fork
1.7k
| https://github.com/login?return_to=%2FNativeScript%2FNativeScript |
|
Star
25.6k
| https://github.com/login?return_to=%2FNativeScript%2FNativeScript |
|
Code
| https://github.com/NativeScript/NativeScript |
|
Issues
771
| https://github.com/NativeScript/NativeScript/issues |
|
Pull requests
67
| https://github.com/NativeScript/NativeScript/pulls |
|
Discussions
| https://github.com/NativeScript/NativeScript/discussions |
|
Actions
| https://github.com/NativeScript/NativeScript/actions |
|
Projects
| https://github.com/NativeScript/NativeScript/projects |
|
Wiki
| https://github.com/NativeScript/NativeScript/wiki |
|
Security and quality
0
| https://github.com/NativeScript/NativeScript/security |
|
Insights
| https://github.com/NativeScript/NativeScript/pulse |
|
Code
| https://github.com/NativeScript/NativeScript |
|
Issues
| https://github.com/NativeScript/NativeScript/issues |
|
Pull requests
| https://github.com/NativeScript/NativeScript/pulls |
|
Discussions
| https://github.com/NativeScript/NativeScript/discussions |
|
Actions
| https://github.com/NativeScript/NativeScript/actions |
|
Projects
| https://github.com/NativeScript/NativeScript/projects |
|
Wiki
| https://github.com/NativeScript/NativeScript/wiki |
|
Security and quality
| https://github.com/NativeScript/NativeScript/security |
|
Insights
| https://github.com/NativeScript/NativeScript/pulse |
| NathanWalker | https://github.com/NathanWalker |
| NativeScript:alpha | https://github.com/NativeScript/NativeScript/tree/alpha |
| CatchABus:clear-ios-native-view | https://github.com/CatchABus/NativeScript/tree/clear-ios-native-view |
| Conversation | https://github.com/NativeScript/NativeScript/pull/9879 |
| Commits8 (8) | https://github.com/NativeScript/NativeScript/pull/9879/commits |
| Checks | https://github.com/NativeScript/NativeScript/pull/9879/checks |
| Files changed | https://github.com/NativeScript/NativeScript/pull/9879/files |
| fix(ios): proper disposal and recreation of iOS native views | https://github.com/NativeScript/NativeScript/pull/9879#top |
| NathanWalker | https://github.com/NathanWalker |
| NativeScript:alpha | https://github.com/NativeScript/NativeScript/tree/alpha |
| CatchABus:clear-ios-native-view | https://github.com/CatchABus/NativeScript/tree/clear-ios-native-view |
|
| https://github.com/CatchABus |
| CatchABus | https://github.com/CatchABus |
| Apr 23, 2022 | https://github.com/NativeScript/NativeScript/pull/9879#issue-1213369703 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/9879 |
| https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages | https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages |
| CLA | http://www.nativescript.org/cla |
| https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application | https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application |
| https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md | https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md |
| @farfromrefug | https://github.com/farfromrefug |
| #9671 | https://github.com/NativeScript/NativeScript/pull/9671 |
| @rigor789 | https://github.com/rigor789 |
| #9671 | https://github.com/NativeScript/NativeScript/pull/9671 |
| @farfromrefug | https://github.com/farfromrefug |
| https://github.com/NativeScript/NativeScript/pull/9879/files#diff-86ce61f77399a980c83c5a14ee2ac54b8c672d375d0280597c217eb17811a076 | https://github.com/NativeScript/NativeScript/pull/9879/files#diff-86ce61f77399a980c83c5a14ee2ac54b8c672d375d0280597c217eb17811a076 |
| https://user-images.githubusercontent.com/55595100/164916598-a478e68c-409c-4113-93b9-9b1e0b07c78a.png |
| https://user-images.githubusercontent.com/55595100/164916702-3261301a-cf05-42b7-b6dc-4856577f3fcf.png |
| #9671 | https://github.com/NativeScript/NativeScript/pull/9671 |
| https://user-images.githubusercontent.com/55595100/164916821-461b5cfd-4a54-4ad1-974e-19378a15ee3f.png |
| https://github.com/NativeScript/NativeScript/pull/9879/files#diff-025d8125f2c2388468769424324a18b7a896921f7b44f720db8014eb653b5f84R67 | https://github.com/NativeScript/NativeScript/pull/9879/files#diff-025d8125f2c2388468769424324a18b7a896921f7b44f720db8014eb653b5f84R67 |
| https://user-images.githubusercontent.com/55595100/164916998-5ced8db6-8569-486c-bc10-eeb3b08cf41f.png |
| https://github.com/NativeScript/NativeScript/pull/9879/files#diff-025d8125f2c2388468769424324a18b7a896921f7b44f720db8014eb653b5f84R132 | https://github.com/NativeScript/NativeScript/pull/9879/files#diff-025d8125f2c2388468769424324a18b7a896921f7b44f720db8014eb653b5f84R132 |
| https://user-images.githubusercontent.com/55595100/164917121-c78297e2-294d-43fd-bbe4-ad697f1f2388.png |
| #9820 | https://github.com/NativeScript/NativeScript/issues/9820 |
| #9875 | https://github.com/NativeScript/NativeScript/pull/9875 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/9879 |
| CatchABus | https://github.com/CatchABus |
| April 22, 2022 17:00 | https://github.com/NativeScript/NativeScript/pull/9879#commits-pushed-b6dddc3 |
|
| https://github.com/CatchABus |
| fix: Ensure we clear ios view. See | https://github.com/NativeScript/NativeScript/pull/9879/commits/b6dddc3f1ca72cf0c5729ca0b0535a0bca720b6f |
| NativeScript#9671 | https://github.com/NativeScript/NativeScript/pull/9671 |
| b6dddc3 | https://github.com/NativeScript/NativeScript/pull/9879/commits/b6dddc3f1ca72cf0c5729ca0b0535a0bca720b6f |
|
| https://github.com/CatchABus |
| test: Updated a test related to new changes. | https://github.com/NativeScript/NativeScript/pull/9879/commits/eaa7b2a638caefcbfc1e9a34a56bb5a413b11b50 |
| eaa7b2a | https://github.com/NativeScript/NativeScript/pull/9879/commits/eaa7b2a638caefcbfc1e9a34a56bb5a413b11b50 |
|
| https://github.com/CatchABus |
| chore: Minor naming corrections. | https://github.com/NativeScript/NativeScript/pull/9879/commits/e86bb79d981cc63521683ad3a8c5e91370c78873 |
| e86bb79 | https://github.com/NativeScript/NativeScript/pull/9879/commits/e86bb79d981cc63521683ad3a8c5e91370c78873 |
|
| https://github.com/CatchABus |
| fix: View size was corrupted after re-adding it to view tree. | https://github.com/NativeScript/NativeScript/pull/9879/commits/bd28654dd78ba292cf6c6ab97137c76d0c4dcb48 |
| bd28654 | https://github.com/NativeScript/NativeScript/pull/9879/commits/bd28654dd78ba292cf6c6ab97137c76d0c4dcb48 |
|
| https://github.com/CatchABus |
| fix: Children layout padding and insets were miscalculated if native … | https://github.com/NativeScript/NativeScript/pull/9879/commits/abfdf4ba6596972c7384a17cbc952862c549f1af |
| abfdf4b | https://github.com/NativeScript/NativeScript/pull/9879/commits/abfdf4ba6596972c7384a17cbc952862c549f1af |
|
| https://github.com/CatchABus |
| chore: Unset possible pending transform flag. | https://github.com/NativeScript/NativeScript/pull/9879/commits/9bf6c668a786b8764ce084f080bad4bccaca2acb |
| 9bf6c66 | https://github.com/NativeScript/NativeScript/pull/9879/commits/9bf6c668a786b8764ce084f080bad4bccaca2acb |
| https://github.com/apps/cla-bot |
| cla-bot | https://github.com/apps/cla-bot |
|
cla: yes
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Apr 23, 2022 | https://github.com/NativeScript/NativeScript/pull/9879#event-6484453224 |
| https://github.com/CatchABus |
| CatchABus | https://github.com/CatchABus |
| April 23, 2022 18:10 | https://github.com/NativeScript/NativeScript/pull/9879#event-6484522910 |
|
| https://github.com/NathanWalker |
| Merge branch 'master' into clear-ios-native-view | https://github.com/NativeScript/NativeScript/pull/9879/commits/abd2e2035ea13df94bdec48678f457cedbcca921 |
| abd2e20 | https://github.com/NativeScript/NativeScript/pull/9879/commits/abd2e2035ea13df94bdec48678f457cedbcca921 |
| https://github.com/apps/cla-bot |
| cla-bot | https://github.com/apps/cla-bot |
| Apr 25, 2022 | https://github.com/NativeScript/NativeScript/pull/9879#issuecomment-1108748036 |
| https://www.nativescript.org/cla | https://www.nativescript.org/cla |
| @CatchABus | https://github.com/CatchABus |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/9879 |
| https://github.com/apps/cla-bot |
| cla-bot | https://github.com/apps/cla-bot |
|
cla: yes
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Apr 25, 2022 | https://github.com/NativeScript/NativeScript/pull/9879#event-6491667182 |
|
| https://github.com/NathanWalker |
| chore: 8.2.4-alpha.0 | https://github.com/NativeScript/NativeScript/pull/9879/commits/d8100217b0c2a6f0920fa011a149b2fe37314ec9 |
| d810021 | https://github.com/NativeScript/NativeScript/pull/9879/commits/d8100217b0c2a6f0920fa011a149b2fe37314ec9 |
| https://github.com/apps/cla-bot |
| cla-bot | https://github.com/apps/cla-bot |
| Apr 25, 2022 | https://github.com/NativeScript/NativeScript/pull/9879#issuecomment-1108751031 |
| https://www.nativescript.org/cla | https://www.nativescript.org/cla |
| @CatchABus | https://github.com/CatchABus |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/9879 |
| https://github.com/CatchABus |
| CatchABus | https://github.com/CatchABus |
| Apr 25, 2022 | https://github.com/NativeScript/NativeScript/pull/9879#issuecomment-1108770913 |
| @cla-bot | https://github.com/cla-bot |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/9879 |
| https://github.com/apps/cla-bot |
| cla-bot | https://github.com/apps/cla-bot |
|
cla: yes
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Apr 25, 2022 | https://github.com/NativeScript/NativeScript/pull/9879#event-6491828334 |
| https://github.com/apps/cla-bot |
| cla-bot | https://github.com/apps/cla-bot |
| Apr 25, 2022 | https://github.com/NativeScript/NativeScript/pull/9879#issuecomment-1108770981 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/9879 |
| https://github.com/NathanWalker |
| NathanWalker | https://github.com/NathanWalker |
| April 30, 2022 17:59 | https://github.com/NativeScript/NativeScript/pull/9879#event-6528334731 |
| https://github.com/NathanWalker |
| NathanWalker | https://github.com/NathanWalker |
| Apr 30, 2022 | https://github.com/NativeScript/NativeScript/pull/9879#event-6528335004 |
| https://github.com/NathanWalker |
| NathanWalker | https://github.com/NathanWalker |
| 96a575d | https://github.com/NativeScript/NativeScript/commit/96a575da8cdbbf86995c92704026a3aa910f6191 |
| Apr 30, 2022 | https://github.com/NativeScript/NativeScript/pull/9879#event-6528335289 |
| NathanWalker | https://github.com/NathanWalker |
|
Jul 9, 2022
| https://github.com/NativeScript/NativeScript/pull/9879#ref-commit-d2d6a0b |
|
| https://github.com/CatchABus |
|
| https://github.com/NathanWalker |
| fix(ios): proper disposal and recreation of iOS native views ( | https://github.com/NativeScript/NativeScript/commit/d2d6a0b48234cc6a4daff39819afd973b1cd3cce |
| #9879 | https://github.com/NativeScript/NativeScript/pull/9879 |
| ) | https://github.com/NativeScript/NativeScript/commit/d2d6a0b48234cc6a4daff39819afd973b1cd3cce |
| d2d6a0b | https://github.com/NativeScript/NativeScript/commit/d2d6a0b48234cc6a4daff39819afd973b1cd3cce |
| NathanWalker | https://github.com/NathanWalker |
|
Jul 9, 2022
| https://github.com/NativeScript/NativeScript/pull/9879#ref-commit-f548fdc |
|
| https://github.com/CatchABus |
|
| https://github.com/NathanWalker |
| fix(ios): proper disposal and recreation of iOS native views ( | https://github.com/NativeScript/NativeScript/commit/f548fdc73512bb74e7ec500550e2db0166e7237b |
| #9879 | https://github.com/NativeScript/NativeScript/pull/9879 |
| ) | https://github.com/NativeScript/NativeScript/commit/f548fdc73512bb74e7ec500550e2db0166e7237b |
| f548fdc | https://github.com/NativeScript/NativeScript/commit/f548fdc73512bb74e7ec500550e2db0166e7237b |
| https://github.com/CatchABus |
| CatchABus | https://github.com/CatchABus |
|
Aug 23, 2022
| https://github.com/NativeScript/NativeScript/pull/9879#ref-pullrequest-1345028388 |
|
fix(ios): ListView _prepareCell null safety
#10001
| https://github.com/NativeScript/NativeScript/pull/10001 |
| https://github.co/hiddenchars |
| https://github.com/NativeScript/NativeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F9879 |
|
cla: yes
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/9879 |
|
| https://github.com/CatchABus |
|
| https://github.com/NathanWalker |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |