René's URL Explorer Experiment

Title: fix(ios): Do not call setNeedsLayout() when another layout update request is in process by CatchABus · Pull Request #9875 · NativeScript/NativeScript · GitHub

Open Graph Title: fix(ios): Do not call setNeedsLayout() when another layout update request is in process by CatchABus · Pull Request #9875 · NativeScript/NativeScript

X Title: fix(ios): Do not call setNeedsLayout() when another layout update request is in process by CatchABus · Pull Request #9875 · NativeScript/NativeScript

Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md. What is the current behavior? There are cases that a layout contains children that often get updated because of bindings. In my case, it was a list of GridLayouts with nested images, the visibility of which was changing through user interactivity. Upon 2-3 uses, my app was crashing with an assertion failed message: ====== Assertion failed ====== Native stack trace: 1 0x103a1e7d8 tns::Assert(bool, v8::Isolate*) + 128 2 0x1039a6848 tns::ArgConverter::Invoke(v8::Local, objc_class*, v8::Local, tns::V8Args&, tns::MethodMeta const*, bool) + 100 3 0x1039f9658 tns::MetadataBuilder::InvokeMethod(v8::Local, tns::MethodMeta const*, v8::Local, tns::V8Args&, std::__1::basic_string, std::__1::allocator >, bool) + 88 4 0x1039f8ec0 tns::MetadataBuilder::MethodCallback(v8::FunctionCallbackInfo const&) + 220 5 0x103b300e4 v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) + 544 6 0x103b2f5e4 v8::internal::MaybeHandle v8::internal::(anonymous namespace)::HandleApiCallHelper(v8::internal::Isolate*, v8::internal::Handle, v8::internal::Handle, v8::internal::Handle, v8::internal::Handle, v8::internal::BuiltinArguments) + 524 7 0x103b2ed7c v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) + 228 8 0x10420a64c Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_BuiltinExit + 108 9 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 10 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 11 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 12 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 13 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 14 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 15 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 16 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 17 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 18 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 19 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 20 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 21 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 22 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 23 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 24 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 25 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 26 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 27 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 28 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 29 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 30 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 31 0x1041dd220 Builtins_StoreIC + 832 32 0x10428ab74 Builtins_StaNamedPropertyHandler + 148 33 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 34 0x1041a15ec Builtins_JSEntryTrampoline + 172 35 0x1041a1284 Builtins_JSEntry + 164 36 0x103c7bcf4 v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) + 2532 37 0x103c7b2dc v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle, v8::internal::Handle, int, v8::internal::Handle*) + 216 38 0x103e06f98 v8::internal::Object::SetPropertyWithAccessor(v8::internal::LookupIterator*, v8::internal::Handle, v8::Maybe) + 864 39 0x103e0aa88 v8::internal::Object::SetPropertyInternal(v8::internal::LookupIterator*, v8::internal::Handle, v8::Maybe, v8::internal::StoreOrigin, bool*) + 420 40 0x103e0a808 v8::internal::Object::SetProperty(v8::internal::LookupIterator*, v8::internal::Handle, v8::internal::StoreOrigin, v8::Maybe) + 80 41 0x103ed8774 v8::internal::Runtime::SetObjectProperty(v8::internal::Isolate*, v8::internal::Handle, v8::internal::Handle, v8::internal::Handle, v8::internal::StoreOrigin, v8::Maybe) + 272 42 0x103edbe58 v8::internal::Runtime_SetKeyedProperty(int, unsigned long*, v8::internal::Isolate*) + 88 43 0x10420a50c Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_NoBuiltinExit + 108 44 0x10428adec Builtins_StaKeyedPropertyHandler + 140 45 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 46 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 47 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 48 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 49 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 50 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 51 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 52 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 53 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 54 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 55 0x1041ada24 Builtins_StoreIC_NoFeedback + 4132 56 0x10428ab74 Builtins_StaNamedPropertyHandler + 148 57 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 58 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 59 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 60 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 61 0x1041a3818 Builtins_InterpreterEntryTrampoline + 248 62 0x1041a15ec Builtins_JSEntryTrampoline + 172 63 0x1041a1284 Builtins_JSEntry + 164 64 0x103c7bcf4 v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) + 2532 65 0x103c7b2dc v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle, v8::internal::Handle, int, v8::internal::Handle*) + 216 66 0x103ace780 v8::Function::Call(v8::Local, v8::Local, int, v8::Local*) + 448 67 0x1039a7f90 tns::ArgConverter::MethodCallback(ffi_cif*, void*, void**, void*) + 1156 68 0x103a99264 ffi_closure_SYSV_inner + 800 69 0x103a9c1b4 .Ldo_closure + 20 70 0x18624f42c + 56 71 0x186218560 + 116 72 0x1861e1260 + 284 73 0x18621a910 + 636 74 0x1861d2ad0 + 1988 75 0x1862068c8 + 784 76 0x186213a68 + 4428 77 0x1863c3318 + 828 78 0x1861e6c30 + 7904 79 0x1861dba1c + 6760 80 0x18701d7dc + 176 81 0x18684c7d8 + 84 82 0x186ec6008 + 144 83 0x186ec55f8 + 60 84 0x183c84020 + 28 85 0x183c94ce0 + 208 86 0x183bcefe8 + 268 87 0x183bd47f4 + 820 88 0x183be83b8 CFRunLoopRunSpecific + 600 89 0x19f57838c GSEventRunModal + 164 90 0x1865886a8 + 1100 91 0x1863077f4 UIApplicationMain + 2092 92 0x103a9c044 ffi_call_SYSV + 68 93 0x103a98ac8 ffi_call_int + 968 94 0x103a3b9dc tns::Interop::CallFunctionInternal(tns::MethodCall&) + 428 95 0x1039fe65c std::__1::__function::__func const&)::$_2, std::__1::allocator const&)::$_2>, void ()>::operator()() + 560 96 0x103a5ec04 tns::Tasks::Drain() + 100 97 0x103a58fd0 -[NativeScript initWithConfig:] + 600 98 0x102dff430 98 mobile 0x0000000102dff430 mobile + 29744 99 0x103901a24 99 dyld 0x0000000103901a24 start + 520 JavaScript stack trace: at requestLayout (file: node_modules/@nativescript/core/ui/core/view/index.ios.js:42:0) at performLayout (file: node_modules/@nativescript/core/ui/core/view-base/index.js:412:0) at requestLayout (file: node_modules/@nativescript/core/ui/core/view-base/index.js:419:0) at requestLayout (file: node_modules/@nativescript/core/ui/core/view/view-common.js:735:0) at requestLayout (file: node_modules/@nativescript/core/ui/core/view/index.ios.js:38:0) at performLayout (file: node_modules/@nativescript/core/ui/core/view-base/index.js:412:0) at requestLayout (file: node_modules/@nativescript/core/ui/core/view-base/index.js:419:0) at requestLayout (file: node_modules/@nativescript/core/ui/core/view/view-common.js:735:0) at requestLayout (file: node_modules/@nativescript/core/ui/core/view/index.ios.js:38:0) at performLayout (file: node_modules/@nativescript/core/ui/core/view-base/index.js:412:0) What is the new behavior? I concluded that an additional setNeedsLayout call was causing this crash in my app. My patch checks if a layout update has already been requested, and prevents pointless setNeedsLayout calls. Runtime version: 8.2 Core version: 8.2

Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this...

Opengraph URL: https://github.com/NativeScript/NativeScript/pull/9875

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width