René's URL Explorer Experiment


Title: fix: return default tab background color when the background color is not explicitely set through css by vtrifonov · Pull Request #8240 · NativeScript/NativeScript · GitHub

Open Graph Title: fix: return default tab background color when the background color is not explicitely set through css by vtrifonov · Pull Request #8240 · NativeScript/NativeScript

X Title: fix: return default tab background color when the background color is not explicitely set through css by vtrifonov · Pull Request #8240 · NativeScript/NativeScript

Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md. What is the current behavior? When a tab's in tabs/bottom-navigation is activated and its background-color is changed it does not return to its default background-color after deactivating it. What is the new behavior? When a tab's in tabs/bottom-navigation is activated and its background-color is changed it returns to its default background-color after deactivating it. Fixes #8235.

Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...

X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...

Opengraph URL: https://github.com/NativeScript/NativeScript/pull/8240

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a8d8dfd1-8d12-5d4c-704e-af033911af86
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAB10:1C7DFD:83AF55:A762FC:69741F46
html-safe-nonceb462df5bb86c51e78919fa72708e6d56eaf1aefb2b42aafda1d7c0864b7cb493
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjEwOjFDN0RGRDo4M0FGNTU6QTc2MkZDOjY5NzQxRjQ2IiwidmlzaXRvcl9pZCI6IjY2NDcxMDI1MjUzNTYxMjE5MjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0ede4c90e9a9ef7c09f59e2430018cbcb6515ad931ba3d5a266cc16340399adf
hovercard-subject-tagpull_request:362104093
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/8240/files
twitter:imagehttps://avatars.githubusercontent.com/u/2012477?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2012477?s=400&v=4
og:image:altPR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None447dc9917c3d68d647a01abfdefe55ec7ee1785922136c1d8395dbb3ab6d57b9
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8dad7bdfecbe3eaa97ac4e632d6b47e2b23e81d9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/pull/8240/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F8240%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F8240%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/pull/8240/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/8240/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/8240/files
NativeScript https://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/8240/files
Notifications https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Fork 1.7k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Star 25.4k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Code https://github.com/NativeScript/NativeScript
Issues 869 https://github.com/NativeScript/NativeScript/issues
Pull requests 61 https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects 0 https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security 0 https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
Code https://github.com/NativeScript/NativeScript
Issues https://github.com/NativeScript/NativeScript/issues
Pull requests https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
vtrifonovhttps://github.com/vtrifonov
masterhttps://github.com/NativeScript/NativeScript/tree/master
trifonov/android-bn-backgroundColor-fixhttps://github.com/NativeScript/NativeScript/tree/trifonov/android-bn-backgroundColor-fix
Conversation 0 https://github.com/NativeScript/NativeScript/pull/8240
Commits 5 https://github.com/NativeScript/NativeScript/pull/8240/commits
Checks 0 https://github.com/NativeScript/NativeScript/pull/8240/checks
Files changed https://github.com/NativeScript/NativeScript/pull/8240/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/8240/files
fix: return default tab background color when the background color is not explicitely set through css https://github.com/NativeScript/NativeScript/pull/8240/files#top
Show all changes 5 commits https://github.com/NativeScript/NativeScript/pull/8240/files
aa05c68 fix: return default tab background color vtrifonov Jan 13, 2020 https://github.com/NativeScript/NativeScript/pull/8240/commits/aa05c68198a4cf82146dcef4036f5ab2554b63a4
7621d3b chore: update NativeScript.api.md vtrifonov Jan 13, 2020 https://github.com/NativeScript/NativeScript/pull/8240/commits/7621d3bdb5761df3c3860ed9ed175202b99e19e0
01991df fix: do not cast return getTabBarBackgroundColor to ColorDrawable vtrifonov Jan 13, 2020 https://github.com/NativeScript/NativeScript/pull/8240/commits/01991df18282a50334055355416780b5635519f3
83938e6 chore: added comment and method check Jan 14, 2020 https://github.com/NativeScript/NativeScript/pull/8240/commits/83938e615d6fe189ceba90cdf1bdd0034dfdc02d
fd34575 Merge branch 'master' into trifonov/android-bn-backgroundColor-fix Jan 14, 2020 https://github.com/NativeScript/NativeScript/pull/8240/commits/fd345750bc98f1c681cb20a5a5ab66acfefbb710
Clear filters https://github.com/NativeScript/NativeScript/pull/8240/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/8240/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/8240/files
NativeScript.api.md https://github.com/NativeScript/NativeScript/pull/8240/files#diff-560901ccf3159eb83b6d8fa86a703adf6e2a4ade243886eea5d1da1acdb6650c
bottom-navigation.android.ts https://github.com/NativeScript/NativeScript/pull/8240/files#diff-12d1ac4e54abbd6313895e57328ec2b42fd8c8e65db568b254d0560261e54f63
tab-navigation-base.d.ts https://github.com/NativeScript/NativeScript/pull/8240/files#diff-2ea3bf10b0db65be6aa6a0d83af1bcbc3ee609dd8095edcf3423ea11150577e1
tab-navigation-base.ts https://github.com/NativeScript/NativeScript/pull/8240/files#diff-7829e3e767d430f6a1f191bb2c01a2714b50bc4336b5a5dd270478369fb7fe33
tabs.android.ts https://github.com/NativeScript/NativeScript/pull/8240/files#diff-072fca00292906952e0ccfee734f7647d2f5dd1b641c5dc02a4012762575ab10
api-reports/NativeScript.api.mdhttps://github.com/NativeScript/NativeScript/pull/8240/files#diff-560901ccf3159eb83b6d8fa86a703adf6e2a4ade243886eea5d1da1acdb6650c
View file https://github.com/NativeScript/NativeScript/blob/fd345750bc98f1c681cb20a5a5ab66acfefbb710/api-reports/NativeScript.api.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/8240/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/8240/files#diff-560901ccf3159eb83b6d8fa86a703adf6e2a4ade243886eea5d1da1acdb6650c
https://github.com/NativeScript/NativeScript/pull/8240/files#diff-560901ccf3159eb83b6d8fa86a703adf6e2a4ade243886eea5d1da1acdb6650c
nativescript-core/ui/bottom-navigation/bottom-navigation.android.tshttps://github.com/NativeScript/NativeScript/pull/8240/files#diff-12d1ac4e54abbd6313895e57328ec2b42fd8c8e65db568b254d0560261e54f63
View file https://github.com/NativeScript/NativeScript/blob/fd345750bc98f1c681cb20a5a5ab66acfefbb710/nativescript-core/ui/bottom-navigation/bottom-navigation.android.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/8240/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/8240/files#diff-12d1ac4e54abbd6313895e57328ec2b42fd8c8e65db568b254d0560261e54f63
https://github.com/NativeScript/NativeScript/pull/8240/files#diff-12d1ac4e54abbd6313895e57328ec2b42fd8c8e65db568b254d0560261e54f63
nativescript-core/ui/tab-navigation-base/tab-navigation-base/tab-navigation-base.d.tshttps://github.com/NativeScript/NativeScript/pull/8240/files#diff-2ea3bf10b0db65be6aa6a0d83af1bcbc3ee609dd8095edcf3423ea11150577e1
View file https://github.com/NativeScript/NativeScript/blob/fd345750bc98f1c681cb20a5a5ab66acfefbb710/nativescript-core/ui/tab-navigation-base/tab-navigation-base/tab-navigation-base.d.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/8240/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/8240/files#diff-2ea3bf10b0db65be6aa6a0d83af1bcbc3ee609dd8095edcf3423ea11150577e1
https://github.com/NativeScript/NativeScript/pull/8240/files#diff-2ea3bf10b0db65be6aa6a0d83af1bcbc3ee609dd8095edcf3423ea11150577e1
nativescript-core/ui/tab-navigation-base/tab-navigation-base/tab-navigation-base.tshttps://github.com/NativeScript/NativeScript/pull/8240/files#diff-7829e3e767d430f6a1f191bb2c01a2714b50bc4336b5a5dd270478369fb7fe33
View file https://github.com/NativeScript/NativeScript/blob/fd345750bc98f1c681cb20a5a5ab66acfefbb710/nativescript-core/ui/tab-navigation-base/tab-navigation-base/tab-navigation-base.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/8240/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/8240/files#diff-7829e3e767d430f6a1f191bb2c01a2714b50bc4336b5a5dd270478369fb7fe33
https://github.com/NativeScript/NativeScript/pull/8240/files#diff-7829e3e767d430f6a1f191bb2c01a2714b50bc4336b5a5dd270478369fb7fe33
nativescript-core/ui/tabs/tabs.android.tshttps://github.com/NativeScript/NativeScript/pull/8240/files#diff-072fca00292906952e0ccfee734f7647d2f5dd1b641c5dc02a4012762575ab10
View file https://github.com/NativeScript/NativeScript/blob/fd345750bc98f1c681cb20a5a5ab66acfefbb710/nativescript-core/ui/tabs/tabs.android.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/8240/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/8240/files#diff-072fca00292906952e0ccfee734f7647d2f5dd1b641c5dc02a4012762575ab10
https://github.com/NativeScript/NativeScript/pull/8240/files#diff-072fca00292906952e0ccfee734f7647d2f5dd1b641c5dc02a4012762575ab10
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.