| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e8f51167-8455-caef-aad9-6383062fea47 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AB9C:1B6BE9:7B42CDB:9F6F962:6975B1E2 |
| html-safe-nonce | 4c911206b5a11d7f94dc0772345c7073730aa629fc9257aaa12f3dbde7ddf1d9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjlDOjFCNkJFOTo3QjQyQ0RCOjlGNkY5NjI6Njk3NUIxRTIiLCJ2aXNpdG9yX2lkIjoiNzY2MjU2NTU4NTkyOTQ4MjcyMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | cead295d8feac4844e9e4c5ae0127ea0611b307cfc036675de958f870c9f4cde |
| hovercard-subject-tag | pull_request:326096664 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/NativeScript/NativeScript/7925/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bb26fdbb96c74cbc79425ddb347f7d3470db9ee9683f40519f4951e7110b910f/NativeScript/NativeScript/pull/7925 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bb26fdbb96c74cbc79425ddb347f7d3470db9ee9683f40519f4951e7110b910f/NativeScript/NativeScript/pull/7925 |
| og:image:alt | Tracking issue |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ADjenkov |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4a4bf5f4e28041a9d2e5c107d7d20b78b4294ba261cab243b28167c16a623a1f |
| turbo-cache-control | no-preview |
| go-import | github.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31492490 |
| octolytics-dimension-repository_nwo | NativeScript/NativeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31492490 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/NativeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 488b30e96dfd057fbbe44c6665ccbc030b729dde |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/NativeScript/NativeScript/pull/7925#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F7925 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F7925 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=NativeScript%2FNativeScript |
| Reload | https://github.com/NativeScript/NativeScript/pull/7925 |
| Reload | https://github.com/NativeScript/NativeScript/pull/7925 |
| Reload | https://github.com/NativeScript/NativeScript/pull/7925 |
|
NativeScript
| https://github.com/NativeScript |
| NativeScript | https://github.com/NativeScript/NativeScript |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
|
Notifications
| https://github.com/login?return_to=%2FNativeScript%2FNativeScript |
|
Fork
1.7k
| https://github.com/login?return_to=%2FNativeScript%2FNativeScript |
|
Star
25.4k
| https://github.com/login?return_to=%2FNativeScript%2FNativeScript |
|
Code
| https://github.com/NativeScript/NativeScript |
|
Issues
869
| https://github.com/NativeScript/NativeScript/issues |
|
Pull requests
58
| https://github.com/NativeScript/NativeScript/pulls |
|
Discussions
| https://github.com/NativeScript/NativeScript/discussions |
|
Actions
| https://github.com/NativeScript/NativeScript/actions |
|
Projects
0
| https://github.com/NativeScript/NativeScript/projects |
|
Wiki
| https://github.com/NativeScript/NativeScript/wiki |
|
Security
0
| https://github.com/NativeScript/NativeScript/security |
|
Insights
| https://github.com/NativeScript/NativeScript/pulse |
|
Code
| https://github.com/NativeScript/NativeScript |
|
Issues
| https://github.com/NativeScript/NativeScript/issues |
|
Pull requests
| https://github.com/NativeScript/NativeScript/pulls |
|
Discussions
| https://github.com/NativeScript/NativeScript/discussions |
|
Actions
| https://github.com/NativeScript/NativeScript/actions |
|
Projects
| https://github.com/NativeScript/NativeScript/projects |
|
Wiki
| https://github.com/NativeScript/NativeScript/wiki |
|
Security
| https://github.com/NativeScript/NativeScript/security |
|
Insights
| https://github.com/NativeScript/NativeScript/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/NativeScript/NativeScript/pull/7925#issue-comment-box |
| ADjenkov | https://github.com/ADjenkov |
| master | https://github.com/NativeScript/NativeScript/tree/master |
| djenkov/animations-overhaul | https://github.com/NativeScript/NativeScript/tree/djenkov/animations-overhaul |
|
feat: overhaul and streamline Android page navigation transitions
| https://github.com/NativeScript/NativeScript/pull/7925#top |
| ADjenkov | https://github.com/ADjenkov |
| master | https://github.com/NativeScript/NativeScript/tree/master |
| djenkov/animations-overhaul | https://github.com/NativeScript/NativeScript/tree/djenkov/animations-overhaul |
|
Conversation
19
| https://github.com/NativeScript/NativeScript/pull/7925 |
|
Commits
12
| https://github.com/NativeScript/NativeScript/pull/7925/commits |
|
Checks
0
| https://github.com/NativeScript/NativeScript/pull/7925/checks |
|
Files changed
| https://github.com/NativeScript/NativeScript/pull/7925/files |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
| https://github.co/hiddenchars |
| https://github.com/NativeScript/NativeScript/pull/{{ revealButtonHref }} |
|
| https://github.com/ADjenkov |
| ADjenkov | https://github.com/ADjenkov |
| Oct 9, 2019 | https://github.com/NativeScript/NativeScript/pull/7925#issue-504451952 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
| Tracking issue | https://github.com/NativeScript/NativeScript/issues/7772 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
| ADjenkov | https://github.com/ADjenkov |
| October 8, 2019 16:22 | https://github.com/NativeScript/NativeScript/pull/7925#commits-pushed-63fcf3d |
|
| https://github.com/ADjenkov |
| feat: remove Animators and replace with Transitions | https://github.com/NativeScript/NativeScript/pull/7925/commits/63fcf3db548b62bd3112f142e7593cb215a9f06c |
| 63fcf3d | https://github.com/NativeScript/NativeScript/pull/7925/commits/63fcf3db548b62bd3112f142e7593cb215a9f06c |
|
| https://github.com/ADjenkov |
| fix: handle disappearing nested fragments for tabs. | https://github.com/NativeScript/NativeScript/pull/7925/commits/7527507f864b4fae82576b4ce975e5e060c30216 |
| 7527507 | https://github.com/NativeScript/NativeScript/pull/7925/commits/7527507f864b4fae82576b4ce975e5e060c30216 |
| https://github.com/ADjenkov |
| ADjenkov | https://github.com/ADjenkov |
| Oct 9, 2019 | https://github.com/NativeScript/NativeScript/pull/7925#event-2697856567 |
| https://github.com/apps/cla-bot |
| cla-bot | https://github.com/apps/cla-bot |
|
cla: yes
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Oct 9, 2019 | https://github.com/NativeScript/NativeScript/pull/7925#event-2697856660 |
|
| https://github.com/ADjenkov |
| Merge branch 'master' into djenkov/animations-overhaul | https://github.com/NativeScript/NativeScript/pull/7925/commits/99f477cc9eb0504dd8cb7bb5795923060fd9a1c2 |
| 99f477c | https://github.com/NativeScript/NativeScript/pull/7925/commits/99f477cc9eb0504dd8cb7bb5795923060fd9a1c2 |
| https://github.com/ADjenkov |
| ADjenkov | https://github.com/ADjenkov |
| force-pushed | https://github.com/NativeScript/NativeScript/compare/2b3631dbfe99de5c2c66bdae557c5f91c9029296..99f477cc9eb0504dd8cb7bb5795923060fd9a1c2 |
| 2b3631d | https://github.com/NativeScript/NativeScript/commit/2b3631dbfe99de5c2c66bdae557c5f91c9029296 |
| 99f477c | https://github.com/NativeScript/NativeScript/commit/99f477cc9eb0504dd8cb7bb5795923060fd9a1c2 |
|
Compare
| https://github.com/NativeScript/NativeScript/compare/2b3631dbfe99de5c2c66bdae557c5f91c9029296..99f477cc9eb0504dd8cb7bb5795923060fd9a1c2 |
| October 9, 2019 08:01 | https://github.com/NativeScript/NativeScript/pull/7925#event-2698033873 |
| ADjenkov | https://github.com/ADjenkov |
| October 9, 2019 11:25 | https://github.com/NativeScript/NativeScript/pull/7925#commits-pushed-e5c9c5e |
|
| https://github.com/ADjenkov |
| chore: bump webpack cycles counter | https://github.com/NativeScript/NativeScript/pull/7925/commits/e5c9c5ec7199c40e87ae526c081db1555605de20 |
| e5c9c5e | https://github.com/NativeScript/NativeScript/pull/7925/commits/e5c9c5ec7199c40e87ae526c081db1555605de20 |
|
| https://github.com/ADjenkov |
| feat(android-widgets): add androidx.transition:transition as dependency | https://github.com/NativeScript/NativeScript/pull/7925/commits/864d406300f6a5084ae7654ebe1219df6269ec8e |
| 864d406 | https://github.com/NativeScript/NativeScript/pull/7925/commits/864d406300f6a5084ae7654ebe1219df6269ec8e |
|
| https://github.com/ADjenkov |
| chore: fix typescript errors | https://github.com/NativeScript/NativeScript/pull/7925/commits/548992e5f8adfd13ecd3d1436843b2cd0a33608d |
| 548992e | https://github.com/NativeScript/NativeScript/pull/7925/commits/548992e5f8adfd13ecd3d1436843b2cd0a33608d |
|
| https://github.com/ADjenkov |
| fix(frame-android): child already has a parent. Replace removeView wi… | https://github.com/NativeScript/NativeScript/pull/7925/commits/da2e8a8e9a0382be89dc0f6efd2a90fc1212094f |
| da2e8a8 | https://github.com/NativeScript/NativeScript/pull/7925/commits/da2e8a8e9a0382be89dc0f6efd2a90fc1212094f |
| https://github.com/ADjenkov |
| ADjenkov | https://github.com/ADjenkov |
| force-pushed | https://github.com/NativeScript/NativeScript/compare/d79fadde84d14924fe2b7f59d821c35ba0f4c98f..d17e71037a5ec6b93671a56e390fc599fb10a709 |
| d79fadd | https://github.com/NativeScript/NativeScript/commit/d79fadde84d14924fe2b7f59d821c35ba0f4c98f |
| d17e710 | https://github.com/NativeScript/NativeScript/commit/d17e71037a5ec6b93671a56e390fc599fb10a709 |
|
Compare
| https://github.com/NativeScript/NativeScript/compare/d79fadde84d14924fe2b7f59d821c35ba0f4c98f..d17e71037a5ec6b93671a56e390fc599fb10a709 |
| October 10, 2019 10:28 | https://github.com/NativeScript/NativeScript/pull/7925#event-2702180615 |
| https://github.com/SvetoslavTsenov |
| SvetoslavTsenov | https://github.com/SvetoslavTsenov |
| force-pushed | https://github.com/NativeScript/NativeScript/compare/d17e71037a5ec6b93671a56e390fc599fb10a709..da2e8a8e9a0382be89dc0f6efd2a90fc1212094f |
| d17e710 | https://github.com/NativeScript/NativeScript/commit/d17e71037a5ec6b93671a56e390fc599fb10a709 |
| da2e8a8 | https://github.com/NativeScript/NativeScript/commit/da2e8a8e9a0382be89dc0f6efd2a90fc1212094f |
|
Compare
| https://github.com/NativeScript/NativeScript/compare/d17e71037a5ec6b93671a56e390fc599fb10a709..da2e8a8e9a0382be89dc0f6efd2a90fc1212094f |
| October 10, 2019 10:51 | https://github.com/NativeScript/NativeScript/pull/7925#event-2702241308 |
|
| https://github.com/ADjenkov |
| fix(tests): wait for fragment before isAdded() check | https://github.com/NativeScript/NativeScript/pull/7925/commits/be232d2a0798840ea0958b11f27fde1afe68b8d9 |
| be232d2 | https://github.com/NativeScript/NativeScript/pull/7925/commits/be232d2a0798840ea0958b11f27fde1afe68b8d9 |
| https://github.com/SvetoslavTsenov |
| SvetoslavTsenov | https://github.com/SvetoslavTsenov |
| Oct 10, 2019 | https://github.com/NativeScript/NativeScript/pull/7925#issuecomment-540607230 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
| ADjenkov | https://github.com/ADjenkov |
| October 10, 2019 17:24 | https://github.com/NativeScript/NativeScript/pull/7925#commits-pushed-6d29974 |
|
| https://github.com/ADjenkov |
| fix(bottom-navigation): prevent changeTab logic when fragment manager… | https://github.com/NativeScript/NativeScript/pull/7925/commits/6d299742d046dfdab4da3a6d08c6c26c7ebc107b |
| 6d29974 | https://github.com/NativeScript/NativeScript/pull/7925/commits/6d299742d046dfdab4da3a6d08c6c26c7ebc107b |
|
| https://github.com/ADjenkov |
| Merge branch 'master' into djenkov/animations-overhaul | https://github.com/NativeScript/NativeScript/pull/7925/commits/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316 |
| 2006de4 | https://github.com/NativeScript/NativeScript/pull/7925/commits/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316 |
| https://github.com/ADjenkov |
| ADjenkov | https://github.com/ADjenkov |
| Oct 11, 2019 | https://github.com/NativeScript/NativeScript/pull/7925#issuecomment-540968643 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
| https://github.com/ADjenkov |
| ADjenkov | https://github.com/ADjenkov |
| Oct 11, 2019 | https://github.com/NativeScript/NativeScript/pull/7925#issuecomment-540977286 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
| https://github.com/ADjenkov |
| ADjenkov | https://github.com/ADjenkov |
|
Oct 14, 2019
| https://github.com/NativeScript/NativeScript/pull/7925#ref-pullrequest-506660821 |
|
tests: comment tabs tests partially
NativeScript/nativescript-angular#2015
| https://github.com/NativeScript/nativescript-angular/pull/2015 |
| https://github.com/ADjenkov |
| ADjenkov | https://github.com/ADjenkov |
| Oct 14, 2019 | https://github.com/NativeScript/NativeScript/pull/7925#issuecomment-541688305 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
| https://github.com/manoldonev |
| manoldonev | https://github.com/manoldonev |
|
Oct 15, 2019
| https://github.com/NativeScript/NativeScript/pull/7925#pullrequestreview-301786848 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316 |
| tns-platform-declarations/android/org.nativescript.widgets.d.ts | https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316#diff-3bac36997e3b95a4c39bfee3dbd32972502c0a3d6869a39a9a8ea118466f4f2d |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
| https://github.com/manoldonev |
| manoldonev | https://github.com/manoldonev |
|
Oct 15, 2019
| https://github.com/NativeScript/NativeScript/pull/7925#pullrequestreview-301787918 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316 |
| ...modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/CustomTransition.java | https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316#diff-cdfecc10664e82fbdeb36379a6adc5840c95aadad2dcd3f52c2d065d1973a3e3 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
| https://github.com/manoldonev |
| manoldonev | https://github.com/manoldonev |
|
Oct 15, 2019
| https://github.com/NativeScript/NativeScript/pull/7925#pullrequestreview-301788946 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316 |
| ...modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/CustomTransition.java | https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316#diff-cdfecc10664e82fbdeb36379a6adc5840c95aadad2dcd3f52c2d065d1973a3e3 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
| https://github.com/manoldonev |
| manoldonev | https://github.com/manoldonev |
|
Oct 15, 2019
| https://github.com/NativeScript/NativeScript/pull/7925#pullrequestreview-301789906 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316 |
| ...modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/CustomTransition.java | https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316#diff-cdfecc10664e82fbdeb36379a6adc5840c95aadad2dcd3f52c2d065d1973a3e3 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
| https://github.com/manoldonev |
| manoldonev | https://github.com/manoldonev |
|
Oct 15, 2019
| https://github.com/NativeScript/NativeScript/pull/7925#pullrequestreview-301790903 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316 |
| tns-core-modules/ui/bottom-navigation/bottom-navigation.android.ts | https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316#diff-e708e177f2afc6312bd9ad73183ba5262f131a5a204121c1094dc308965fb331 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
| https://github.com/manoldonev |
| manoldonev | https://github.com/manoldonev |
|
Oct 15, 2019
| https://github.com/NativeScript/NativeScript/pull/7925#pullrequestreview-301791774 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316 |
| tns-core-modules/ui/bottom-navigation/bottom-navigation.android.ts | https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316#diff-e708e177f2afc6312bd9ad73183ba5262f131a5a204121c1094dc308965fb331 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
| https://github.com/manoldonev |
| manoldonev | https://github.com/manoldonev |
|
Oct 15, 2019
| https://github.com/NativeScript/NativeScript/pull/7925#pullrequestreview-301804480 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316 |
| ...modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/CustomTransition.java | https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316#diff-cdfecc10664e82fbdeb36379a6adc5840c95aadad2dcd3f52c2d065d1973a3e3 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
| https://github.com/manoldonev |
| manoldonev | https://github.com/manoldonev |
|
Oct 15, 2019
| https://github.com/NativeScript/NativeScript/pull/7925#pullrequestreview-301804747 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316 |
| ...modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/CustomTransition.java | https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316#diff-cdfecc10664e82fbdeb36379a6adc5840c95aadad2dcd3f52c2d065d1973a3e3 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
| https://github.com/manoldonev |
| manoldonev | https://github.com/manoldonev |
|
Oct 15, 2019
| https://github.com/NativeScript/NativeScript/pull/7925#pullrequestreview-301806055 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316 |
| ...modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/CustomTransition.java | https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316#diff-cdfecc10664e82fbdeb36379a6adc5840c95aadad2dcd3f52c2d065d1973a3e3 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
| https://github.com/manoldonev |
| manoldonev | https://github.com/manoldonev |
|
Oct 15, 2019
| https://github.com/NativeScript/NativeScript/pull/7925#pullrequestreview-301809990 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316 |
| tns-core-modules/ui/bottom-navigation/bottom-navigation.android.ts | https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316#diff-e708e177f2afc6312bd9ad73183ba5262f131a5a204121c1094dc308965fb331 |
| manoldonev | https://github.com/manoldonev |
| Oct 15, 2019 | https://github.com/NativeScript/NativeScript/pull/7925#discussion_r334876171 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
| https://github.com/manoldonev |
| manoldonev | https://github.com/manoldonev |
|
Oct 15, 2019
| https://github.com/NativeScript/NativeScript/pull/7925#pullrequestreview-301810490 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316 |
| tns-core-modules/ui/bottom-navigation/bottom-navigation.android.ts | https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316#diff-e708e177f2afc6312bd9ad73183ba5262f131a5a204121c1094dc308965fb331 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
| https://github.com/manoldonev |
| manoldonev | https://github.com/manoldonev |
|
Oct 15, 2019
| https://github.com/NativeScript/NativeScript/pull/7925#pullrequestreview-301814025 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316 |
| tns-core-modules/ui/frame/fragment.transitions.android.ts | https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316#diff-c05c997e50e6f450823033ae396c793fa8446e0a6e0c61d5f05ca762fefb0bce |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
| https://github.com/manoldonev |
| manoldonev | https://github.com/manoldonev |
|
Oct 15, 2019
| https://github.com/NativeScript/NativeScript/pull/7925#pullrequestreview-301823481 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316 |
| tns-core-modules/ui/tab-view/tab-view.android.ts | https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316#diff-ba0ae3c5019461db5aea8e7017306a7f019bd9e1bbd8768d25a787bf7eb1b6ec |
| manoldonev | https://github.com/manoldonev |
| Oct 15, 2019 | https://github.com/NativeScript/NativeScript/pull/7925#discussion_r334886712 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
| https://github.com/manoldonev |
| manoldonev | https://github.com/manoldonev |
|
Oct 15, 2019
| https://github.com/NativeScript/NativeScript/pull/7925#pullrequestreview-301834948 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316 |
| ADjenkov | https://github.com/ADjenkov |
| October 15, 2019 15:20 | https://github.com/NativeScript/NativeScript/pull/7925#commits-pushed-1fbeb15 |
|
| https://github.com/ADjenkov |
| chore: apply PR comments changes | https://github.com/NativeScript/NativeScript/pull/7925/commits/1fbeb15e9736e1e65d236e6df4edc644f843210b |
| 1fbeb15 | https://github.com/NativeScript/NativeScript/pull/7925/commits/1fbeb15e9736e1e65d236e6df4edc644f843210b |
|
| https://github.com/ADjenkov |
| Merge branch 'master' into djenkov/animations-overhaul | https://github.com/NativeScript/NativeScript/pull/7925/commits/c19cefe8e326ba1b43b87a4913adb2c4f248ea07 |
| c19cefe | https://github.com/NativeScript/NativeScript/pull/7925/commits/c19cefe8e326ba1b43b87a4913adb2c4f248ea07 |
| https://github.com/ADjenkov |
| ADjenkov | https://github.com/ADjenkov |
| Oct 15, 2019 | https://github.com/NativeScript/NativeScript/pull/7925#issuecomment-542185012 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
| https://github.com/ADjenkov |
| ADjenkov | https://github.com/ADjenkov |
| 08e23bc | https://github.com/NativeScript/NativeScript/commit/08e23bcc3b8e0b0ea967b6a27ab89eeec8fdd496 |
| Oct 15, 2019 | https://github.com/NativeScript/NativeScript/pull/7925#event-2714417388 |
| https://github.com/ADjenkov |
| ADjenkov | https://github.com/ADjenkov |
| October 16, 2019 08:10 | https://github.com/NativeScript/NativeScript/pull/7925#event-2716637900 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F7925 |
|
| https://github.com/manoldonev |
|
manoldonev
| https://github.com/manoldonev |
|
| https://github.com/NativeScript/NativeScript/pull/7925/files/2006de4ea1c5f4ee7dfcc09b3b80f78502a99316 |
|
| https://github.com/ADjenkov |
|
ADjenkov
| https://github.com/ADjenkov |
|
cla: yes
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7925 |
|
| https://github.com/ADjenkov |
|
| https://github.com/SvetoslavTsenov |
|
| https://github.com/manoldonev |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |