| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:91369a66-0579-3680-b3c4-a8397a60ea0e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D7D8:20A8F8:3A1A3D5:51A6762:697937E6 |
| html-safe-nonce | 26ff23d29050040a8b8fb267c5c209e363c4acfb525527b32ee336ba3342645f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0Q4OjIwQThGODozQTFBM0Q1OjUxQTY3NjI6Njk3OTM3RTYiLCJ2aXNpdG9yX2lkIjoiMTQyMTkyNTUzODczNjk3Nzg5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2ab21212aa9e598e96f61c43e137c8d2534c99a30d9c0318761052043d7b0af3 |
| hovercard-subject-tag | pull_request:325328014 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/NativeScript/NativeScript/7911/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/44049e98917516fb38b130101959e60a2a8d2c2c6969c038f6d6e9d3825c4e1a/NativeScript/NativeScript/pull/7911 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/44049e98917516fb38b130101959e60a2a8d2c2c6969c038f6d6e9d3825c4e1a/NativeScript/NativeScript/pull/7911 |
| og:image:alt | PR Checklist
The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | vakrilov |
| hostname | github.com |
| expected-hostname | github.com |
| None | 33d60f7e5c009874ca1d3bae4ff07a11d7994e6b4b54cf6e64121c500cc10bc5 |
| turbo-cache-control | no-preview |
| go-import | github.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31492490 |
| octolytics-dimension-repository_nwo | NativeScript/NativeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31492490 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/NativeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2391a1af9753b168299d1cbf80f8bb67be4430bd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/NativeScript/NativeScript/pull/7911#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F7911 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F7911 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=NativeScript%2FNativeScript |
| Reload | https://github.com/NativeScript/NativeScript/pull/7911 |
| Reload | https://github.com/NativeScript/NativeScript/pull/7911 |
| Reload | https://github.com/NativeScript/NativeScript/pull/7911 |
|
NativeScript
| https://github.com/NativeScript |
| NativeScript | https://github.com/NativeScript/NativeScript |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
|
Notifications
| https://github.com/login?return_to=%2FNativeScript%2FNativeScript |
|
Fork
1.7k
| https://github.com/login?return_to=%2FNativeScript%2FNativeScript |
|
Star
25.4k
| https://github.com/login?return_to=%2FNativeScript%2FNativeScript |
|
Code
| https://github.com/NativeScript/NativeScript |
|
Issues
869
| https://github.com/NativeScript/NativeScript/issues |
|
Pull requests
58
| https://github.com/NativeScript/NativeScript/pulls |
|
Discussions
| https://github.com/NativeScript/NativeScript/discussions |
|
Actions
| https://github.com/NativeScript/NativeScript/actions |
|
Projects
0
| https://github.com/NativeScript/NativeScript/projects |
|
Wiki
| https://github.com/NativeScript/NativeScript/wiki |
|
Security
0
| https://github.com/NativeScript/NativeScript/security |
|
Insights
| https://github.com/NativeScript/NativeScript/pulse |
|
Code
| https://github.com/NativeScript/NativeScript |
|
Issues
| https://github.com/NativeScript/NativeScript/issues |
|
Pull requests
| https://github.com/NativeScript/NativeScript/pulls |
|
Discussions
| https://github.com/NativeScript/NativeScript/discussions |
|
Actions
| https://github.com/NativeScript/NativeScript/actions |
|
Projects
| https://github.com/NativeScript/NativeScript/projects |
|
Wiki
| https://github.com/NativeScript/NativeScript/wiki |
|
Security
| https://github.com/NativeScript/NativeScript/security |
|
Insights
| https://github.com/NativeScript/NativeScript/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/NativeScript/NativeScript/pull/7911#issue-comment-box |
| vakrilov | https://github.com/vakrilov |
| master | https://github.com/NativeScript/NativeScript/tree/master |
| scoped-packages-generate-master | https://github.com/NativeScript/NativeScript/tree/scoped-packages-generate-master |
|
feat: Scoped Packages
| https://github.com/NativeScript/NativeScript/pull/7911#top |
| vakrilov | https://github.com/vakrilov |
| master | https://github.com/NativeScript/NativeScript/tree/master |
| scoped-packages-generate-master | https://github.com/NativeScript/NativeScript/tree/scoped-packages-generate-master |
|
Conversation
34
| https://github.com/NativeScript/NativeScript/pull/7911 |
|
Commits
60
| https://github.com/NativeScript/NativeScript/pull/7911/commits |
|
Checks
0
| https://github.com/NativeScript/NativeScript/pull/7911/checks |
|
Files changed
| https://github.com/NativeScript/NativeScript/pull/7911/files |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| https://github.co/hiddenchars |
| https://github.com/NativeScript/NativeScript/pull/{{ revealButtonHref }} |
|
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
| Oct 7, 2019 | https://github.com/NativeScript/NativeScript/pull/7911#issue-503484856 |
| https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages | https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages |
| CLA | http://www.nativescript.org/cla |
| https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests | https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests |
| https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md | https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md |
| #4041 | https://github.com/NativeScript/NativeScript/issues/4041 |
| #7895 | https://github.com/NativeScript/NativeScript/issues/7895 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| https://github.com/apps/cla-bot |
| cla-bot | https://github.com/apps/cla-bot |
|
cla: yes
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Oct 7, 2019 | https://github.com/NativeScript/NativeScript/pull/7911#event-2692025302 |
| https://github.com/SvetoslavTsenov |
| SvetoslavTsenov | https://github.com/SvetoslavTsenov |
| Oct 7, 2019 | https://github.com/NativeScript/NativeScript/pull/7911#issuecomment-539082027 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
| force-pushed | https://github.com/NativeScript/NativeScript/compare/42160e5b97d2c7a144cbab1cf11e915fdae31443..f0c50e0683a35c753c8692f293554f93f3612893 |
| 42160e5 | https://github.com/NativeScript/NativeScript/commit/42160e5b97d2c7a144cbab1cf11e915fdae31443 |
| f0c50e0 | https://github.com/NativeScript/NativeScript/commit/f0c50e0683a35c753c8692f293554f93f3612893 |
|
Compare
| https://github.com/NativeScript/NativeScript/compare/42160e5b97d2c7a144cbab1cf11e915fdae31443..f0c50e0683a35c753c8692f293554f93f3612893 |
| October 10, 2019 20:02 | https://github.com/NativeScript/NativeScript/pull/7911#event-2704014167 |
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
| October 11, 2019 20:42 | https://github.com/NativeScript/NativeScript/pull/7911#event-2707375047 |
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
| force-pushed | https://github.com/NativeScript/NativeScript/compare/3f584b35ac08ac9809d7b62bf0a9f6bb2ae04eda..864b444d441de579400d1db5f4fc08760ca2d462 |
| 3f584b3 | https://github.com/NativeScript/NativeScript/commit/3f584b35ac08ac9809d7b62bf0a9f6bb2ae04eda |
| 864b444 | https://github.com/NativeScript/NativeScript/commit/864b444d441de579400d1db5f4fc08760ca2d462 |
|
Compare
| https://github.com/NativeScript/NativeScript/compare/3f584b35ac08ac9809d7b62bf0a9f6bb2ae04eda..864b444d441de579400d1db5f4fc08760ca2d462 |
| October 11, 2019 21:13 | https://github.com/NativeScript/NativeScript/pull/7911#event-2707446152 |
| https://github.com/SvetoslavTsenov |
| SvetoslavTsenov | https://github.com/SvetoslavTsenov |
| Oct 14, 2019 | https://github.com/NativeScript/NativeScript/pull/7911#issuecomment-541557244 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
|
Oct 14, 2019
| https://github.com/NativeScript/NativeScript/pull/7911#pullrequestreview-301246540 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/7911/files |
| DevelopmentWorkflow.md | https://github.com/NativeScript/NativeScript/pull/7911/files#diff-1e0229d1c9e5290b5deacbb1119b86e4c400c092c03e968a559392c35ea3880a |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| DevelopmentWorkflow.md | https://github.com/NativeScript/NativeScript/pull/7911/files#diff-1e0229d1c9e5290b5deacbb1119b86e4c400c092c03e968a559392c35ea3880a |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| nativescript-core/http/http-request/http-request.android.ts | https://github.com/NativeScript/NativeScript/pull/7911/files#diff-6bf3c822d689921ed16dfd87f7690c0fc7568cb53e8d3e929251735c31d6e2a8 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| nativescript-core/index.d.ts | https://github.com/NativeScript/NativeScript/pull/7911/files#diff-fd0dd494f799a19f2852cbd9cfee048522df0b81f92aae16424e74ae76c29e87 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| nativescript-core/index.d.ts | https://github.com/NativeScript/NativeScript/pull/7911/files#diff-fd0dd494f799a19f2852cbd9cfee048522df0b81f92aae16424e74ae76c29e87 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| nativescript-core/index.ts | https://github.com/NativeScript/NativeScript/pull/7911/files#diff-55d6902288c6b9130527156b7626f44a98ad08bc487cefcfedbd6de1fdba399f |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| nativescript-core/index.ts | https://github.com/NativeScript/NativeScript/pull/7911/files#diff-55d6902288c6b9130527156b7626f44a98ad08bc487cefcfedbd6de1fdba399f |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| nativescript-core/index.d.ts | https://github.com/NativeScript/NativeScript/pull/7911/files#diff-fd0dd494f799a19f2852cbd9cfee048522df0b81f92aae16424e74ae76c29e87 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
| force-pushed | https://github.com/NativeScript/NativeScript/compare/49bea9cbe96d6707f6c46ba966f22b669f2741cf..d44d249bf7f22c40d8819435c8b6d2ad0580305c |
| 49bea9c | https://github.com/NativeScript/NativeScript/commit/49bea9cbe96d6707f6c46ba966f22b669f2741cf |
| d44d249 | https://github.com/NativeScript/NativeScript/commit/d44d249bf7f22c40d8819435c8b6d2ad0580305c |
|
Compare
| https://github.com/NativeScript/NativeScript/compare/49bea9cbe96d6707f6c46ba966f22b669f2741cf..d44d249bf7f22c40d8819435c8b6d2ad0580305c |
| October 15, 2019 06:29 | https://github.com/NativeScript/NativeScript/pull/7911#event-2712705442 |
| https://github.com/SvetoslavTsenov |
| SvetoslavTsenov | https://github.com/SvetoslavTsenov |
| Oct 15, 2019 | https://github.com/NativeScript/NativeScript/pull/7911#issuecomment-542139200 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
|
Oct 15, 2019
| https://github.com/NativeScript/NativeScript/pull/7911#pullrequestreview-301685031 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/7911/files |
| nativescript-core/ui/core/control-state-change/control-state-change.android.ts | https://github.com/NativeScript/NativeScript/pull/7911/files#diff-11585bd180be95fe23d7d6294c70dad3f6f4a5a548658ff8fcf668b5945feebe |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| nativescript-core/ui/dialogs/dialogs-common.ts | https://github.com/NativeScript/NativeScript/pull/7911/files#diff-80f258979a5b806f1a0d27c1eea1c05929084cb4cb02027facf001d045f7162f |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| nativescript-core/ui/index.d.ts | https://github.com/NativeScript/NativeScript/pull/7911/files#diff-31d27682739bd14744d0e1e8e41c7c4147cb8c2ef0d8ed946e5bd52061a66712 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| nativescript-core/ui/index.d.ts | https://github.com/NativeScript/NativeScript/pull/7911/files#diff-31d27682739bd14744d0e1e8e41c7c4147cb8c2ef0d8ed946e5bd52061a66712 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| nativescript-core/ui/index.d.ts | https://github.com/NativeScript/NativeScript/pull/7911/files#diff-31d27682739bd14744d0e1e8e41c7c4147cb8c2ef0d8ed946e5bd52061a66712 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| nativescript-core/ui/index.ts | https://github.com/NativeScript/NativeScript/pull/7911/files#diff-917d37f9e96e3f4af0d9ff40209381e8b8657c28e5907c61fd26ca978fac4a95 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| nativescript-core/ui/index.ts | https://github.com/NativeScript/NativeScript/pull/7911/files#diff-917d37f9e96e3f4af0d9ff40209381e8b8657c28e5907c61fd26ca978fac4a95 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| nativescript-core/ui/index.ts | https://github.com/NativeScript/NativeScript/pull/7911/files#diff-917d37f9e96e3f4af0d9ff40209381e8b8657c28e5907c61fd26ca978fac4a95 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| nativescript-core/ui/index.ts | https://github.com/NativeScript/NativeScript/pull/7911/files#diff-917d37f9e96e3f4af0d9ff40209381e8b8657c28e5907c61fd26ca978fac4a95 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| DevelopmentWorkflow.md | https://github.com/NativeScript/NativeScript/pull/7911/files#diff-1e0229d1c9e5290b5deacbb1119b86e4c400c092c03e968a559392c35ea3880a |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| https://github.com/SvetoslavTsenov |
| SvetoslavTsenov | https://github.com/SvetoslavTsenov |
| Oct 15, 2019 | https://github.com/NativeScript/NativeScript/pull/7911#issuecomment-542174695 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| https://github.com/SvetoslavTsenov |
| SvetoslavTsenov | https://github.com/SvetoslavTsenov |
| Oct 15, 2019 | https://github.com/NativeScript/NativeScript/pull/7911#issuecomment-542174902 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
| force-pushed | https://github.com/NativeScript/NativeScript/compare/1c15ae9adb2b30da8d91f430c45d8401950787a9..c58ec1f5709954ecdc668f05211b6869bc2fe2b5 |
| 1c15ae9 | https://github.com/NativeScript/NativeScript/commit/1c15ae9adb2b30da8d91f430c45d8401950787a9 |
| c58ec1f | https://github.com/NativeScript/NativeScript/commit/c58ec1f5709954ecdc668f05211b6869bc2fe2b5 |
|
Compare
| https://github.com/NativeScript/NativeScript/compare/1c15ae9adb2b30da8d91f430c45d8401950787a9..c58ec1f5709954ecdc668f05211b6869bc2fe2b5 |
| October 15, 2019 13:37 | https://github.com/NativeScript/NativeScript/pull/7911#event-2714006515 |
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
| Oct 15, 2019 | https://github.com/NativeScript/NativeScript/pull/7911#issuecomment-542215946 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
|
Oct 16, 2019
| https://github.com/NativeScript/NativeScript/pull/7911#pullrequestreview-302405287 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/7911/files |
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
| Oct 16, 2019 | https://github.com/NativeScript/NativeScript/pull/7911#issuecomment-542640338 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
| force-pushed | https://github.com/NativeScript/NativeScript/compare/e5abd0c8f9014333b97cc83c9b470b968159a8cf..4345d3c12c51e790bd28ddc8ab550b1212957da1 |
| e5abd0c | https://github.com/NativeScript/NativeScript/commit/e5abd0c8f9014333b97cc83c9b470b968159a8cf |
| 4345d3c | https://github.com/NativeScript/NativeScript/commit/4345d3c12c51e790bd28ddc8ab550b1212957da1 |
|
Compare
| https://github.com/NativeScript/NativeScript/compare/e5abd0c8f9014333b97cc83c9b470b968159a8cf..4345d3c12c51e790bd28ddc8ab550b1212957da1 |
| October 16, 2019 12:55 | https://github.com/NativeScript/NativeScript/pull/7911#event-2717505741 |
| October 16, 2019 16:43 | https://github.com/NativeScript/NativeScript/pull/7911#commits-pushed-67bf6b4 |
| chore: move tns-core-modules to nativescript-core | https://github.com/NativeScript/NativeScript/pull/7911/commits/67bf6b40f1231967e30dbec21ea460a01f5d0705 |
| 67bf6b4 | https://github.com/NativeScript/NativeScript/pull/7911/commits/67bf6b40f1231967e30dbec21ea460a01f5d0705 |
| chore: preparing compat generate script | https://github.com/NativeScript/NativeScript/pull/7911/commits/faa240f08f48fb64a0fc29bb908f6c41ed615430 |
| faa240f | https://github.com/NativeScript/NativeScript/pull/7911/commits/faa240f08f48fb64a0fc29bb908f6c41ed615430 |
| chore: add missing definitions | https://github.com/NativeScript/NativeScript/pull/7911/commits/8b6e8e5d6e7ac8291216e49654bf3aaca4e3cadd |
| 8b6e8e5 | https://github.com/NativeScript/NativeScript/pull/7911/commits/8b6e8e5d6e7ac8291216e49654bf3aaca4e3cadd |
| chore: no need for http-request to be private | https://github.com/NativeScript/NativeScript/pull/7911/commits/73887ba9832e8f21b2ae7b1fc11d107546abad38 |
| 73887ba | https://github.com/NativeScript/NativeScript/pull/7911/commits/73887ba9832e8f21b2ae7b1fc11d107546abad38 |
| chore: packages chore | https://github.com/NativeScript/NativeScript/pull/7911/commits/73b3bc87eb3a1b585410976cda4a888d0a1c0e8a |
| 73b3bc8 | https://github.com/NativeScript/NativeScript/pull/7911/commits/73b3bc87eb3a1b585410976cda4a888d0a1c0e8a |
| test: generate tests for tns-core-modules | https://github.com/NativeScript/NativeScript/pull/7911/commits/011cefdc611750b3c96122f016edc9e099c5e312 |
| 011cefd | https://github.com/NativeScript/NativeScript/pull/7911/commits/011cefdc611750b3c96122f016edc9e099c5e312 |
| chore: add anroid module for consistency | https://github.com/NativeScript/NativeScript/pull/7911/commits/4437b082624dfe41e6fe8303f0028e6ea1a45b5f |
| 4437b08 | https://github.com/NativeScript/NativeScript/pull/7911/commits/4437b082624dfe41e6fe8303f0028e6ea1a45b5f |
| chore: add .npmignore | https://github.com/NativeScript/NativeScript/pull/7911/commits/22caa10bd493b26840c41c15b5f291dca41433e7 |
| 22caa10 | https://github.com/NativeScript/NativeScript/pull/7911/commits/22caa10bd493b26840c41c15b5f291dca41433e7 |
| SvetoslavTsenov | https://github.com/SvetoslavTsenov |
| October 16, 2019 16:47 | https://github.com/NativeScript/NativeScript/pull/7911#commits-pushed-80d23af |
|
| https://github.com/SvetoslavTsenov |
| chore: update NATIVESCRIPT_CORE_ARGS | https://github.com/NativeScript/NativeScript/pull/7911/commits/80d23af7dfd32c2db155ed8a9c0f93ad762f494d |
| 80d23af | https://github.com/NativeScript/NativeScript/pull/7911/commits/80d23af7dfd32c2db155ed8a9c0f93ad762f494d |
|
| https://github.com/SvetoslavTsenov |
| chore: fix compat pack | https://github.com/NativeScript/NativeScript/pull/7911/commits/7b7434bfd873375bad99ae5781559ae493e5236c |
| 7b7434b | https://github.com/NativeScript/NativeScript/pull/7911/commits/7b7434bfd873375bad99ae5781559ae493e5236c |
| chore: fix tslint errors | https://github.com/NativeScript/NativeScript/pull/7911/commits/67b73f105457d1abc075a30e758df5c017fdc00d |
| 67b73f1 | https://github.com/NativeScript/NativeScript/pull/7911/commits/67b73f105457d1abc075a30e758df5c017fdc00d |
| chore: fix ui-test-app build with linked modules | https://github.com/NativeScript/NativeScript/pull/7911/commits/b632585d64861c6920757bf923aa4e6610eaf775 |
| b632585 | https://github.com/NativeScript/NativeScript/pull/7911/commits/b632585d64861c6920757bf923aa4e6610eaf775 |
| chore: Application, ApplicationSettings, Connectivity and Http | https://github.com/NativeScript/NativeScript/pull/7911/commits/e32c2c393d0ebad370c52fd3611f0498b9d09844 |
| e32c2c3 | https://github.com/NativeScript/NativeScript/pull/7911/commits/e32c2c393d0ebad370c52fd3611f0498b9d09844 |
| chore: export Trace, Profiling and Utils | https://github.com/NativeScript/NativeScript/pull/7911/commits/5b69c4cfdacb68666b8ef01b88cf51684c869baa |
| 5b69c4c | https://github.com/NativeScript/NativeScript/pull/7911/commits/5b69c4cfdacb68666b8ef01b88cf51684c869baa |
| refactor: Static create methods for ImageSource | https://github.com/NativeScript/NativeScript/pull/7911/commits/06235a15c31e72facb2d7be1b7ee24a0fd442c78 |
| 06235a1 | https://github.com/NativeScript/NativeScript/pull/7911/commits/06235a15c31e72facb2d7be1b7ee24a0fd442c78 |
| chore: fix deprecated usages of ImageSource | https://github.com/NativeScript/NativeScript/pull/7911/commits/83a15a03043ca3b0f8314548cdf0cb9c7e6a5f9b |
| 83a15a0 | https://github.com/NativeScript/NativeScript/pull/7911/commits/83a15a03043ca3b0f8314548cdf0cb9c7e6a5f9b |
| chore: move Span and FormattedString to ui | https://github.com/NativeScript/NativeScript/pull/7911/commits/ff0a0038c9585f69efee99bbbfe6566c0708d8b6 |
| ff0a003 | https://github.com/NativeScript/NativeScript/pull/7911/commits/ff0a0038c9585f69efee99bbbfe6566c0708d8b6 |
| chore: add events-args and ImageSource to index files | https://github.com/NativeScript/NativeScript/pull/7911/commits/7a85180c4bdd58ddf800c2f9ec7d9ad8c87e1224 |
| 7a85180 | https://github.com/NativeScript/NativeScript/pull/7911/commits/7a85180c4bdd58ddf800c2f9ec7d9ad8c87e1224 |
| chore: check for CLI >= 6.2 when building for IOS | https://github.com/NativeScript/NativeScript/pull/7911/commits/d4059aa1df6deb60d7f20e63d4f5be56c95dd6c5 |
| d4059aa | https://github.com/NativeScript/NativeScript/pull/7911/commits/d4059aa1df6deb60d7f20e63d4f5be56c95dd6c5 |
| chore: update travis build | https://github.com/NativeScript/NativeScript/pull/7911/commits/cf501d8237a6f90d70ef667e46eb51025b002e75 |
| cf501d8 | https://github.com/NativeScript/NativeScript/pull/7911/commits/cf501d8237a6f90d70ef667e46eb51025b002e75 |
|
| https://github.com/SvetoslavTsenov |
| chore: copy Pod file to compat package | https://github.com/NativeScript/NativeScript/pull/7911/commits/0d561f5aff5e447b3e0f2f11c2e8b1068e6872bb |
| 0d561f5 | https://github.com/NativeScript/NativeScript/pull/7911/commits/0d561f5aff5e447b3e0f2f11c2e8b1068e6872bb |
|
| https://github.com/SvetoslavTsenov |
| chore: update error msg ui-tests-app | https://github.com/NativeScript/NativeScript/pull/7911/commits/16f05b59707aeb0a19934eb2d0a12031f3088970 |
| 16f05b5 | https://github.com/NativeScript/NativeScript/pull/7911/commits/16f05b59707aeb0a19934eb2d0a12031f3088970 |
|
| https://github.com/MartoYankov |
| refactor: Apply suggestions from code review | https://github.com/NativeScript/NativeScript/pull/7911/commits/3e3314e994f2112247d5113d4c38721e5430473f |
| 3e3314e | https://github.com/NativeScript/NativeScript/pull/7911/commits/3e3314e994f2112247d5113d4c38721e5430473f |
| chore: typings and refs | https://github.com/NativeScript/NativeScript/pull/7911/commits/1d413f8e8bcd8fe2b870ac4c1bcc366fc484edb2 |
| 1d413f8 | https://github.com/NativeScript/NativeScript/pull/7911/commits/1d413f8e8bcd8fe2b870ac4c1bcc366fc484edb2 |
| chore: add missing d.ts files for public API | https://github.com/NativeScript/NativeScript/pull/7911/commits/657aec4458df56aec20e02f9b256a9d16de8fe6e |
| 657aec4 | https://github.com/NativeScript/NativeScript/pull/7911/commits/657aec4458df56aec20e02f9b256a9d16de8fe6e |
| chore: adress code review FB | https://github.com/NativeScript/NativeScript/pull/7911/commits/24fb668bb28cdd26ababdc7ae612e004d5f5c1e0 |
| 24fb668 | https://github.com/NativeScript/NativeScript/pull/7911/commits/24fb668bb28cdd26ababdc7ae612e004d5f5c1e0 |
| chore: update api-report | https://github.com/NativeScript/NativeScript/pull/7911/commits/148813770b76894f606fae40c09a396ec57a8d6b |
| 1488137 | https://github.com/NativeScript/NativeScript/pull/7911/commits/148813770b76894f606fae40c09a396ec57a8d6b |
| chore: dev-workflow for other apps | https://github.com/NativeScript/NativeScript/pull/7911/commits/bc4e29316e0a097c5397d815386f58ba31643866 |
| bc4e293 | https://github.com/NativeScript/NativeScript/pull/7911/commits/bc4e29316e0a097c5397d815386f58ba31643866 |
| chore: api update | https://github.com/NativeScript/NativeScript/pull/7911/commits/bdb1336b5f832cf45c5b570fb19f3d9a816cbccd |
| bdb1336 | https://github.com/NativeScript/NativeScript/pull/7911/commits/bdb1336b5f832cf45c5b570fb19f3d9a816cbccd |
| chore: update api-report | https://github.com/NativeScript/NativeScript/pull/7911/commits/babb3a71d945021c1151aff1f69404d80058c907 |
| babb3a7 | https://github.com/NativeScript/NativeScript/pull/7911/commits/babb3a71d945021c1151aff1f69404d80058c907 |
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
| force-pushed | https://github.com/NativeScript/NativeScript/compare/4345d3c12c51e790bd28ddc8ab550b1212957da1..babb3a71d945021c1151aff1f69404d80058c907 |
| 4345d3c | https://github.com/NativeScript/NativeScript/commit/4345d3c12c51e790bd28ddc8ab550b1212957da1 |
| babb3a7 | https://github.com/NativeScript/NativeScript/commit/babb3a71d945021c1151aff1f69404d80058c907 |
|
Compare
| https://github.com/NativeScript/NativeScript/compare/4345d3c12c51e790bd28ddc8ab550b1212957da1..babb3a71d945021c1151aff1f69404d80058c907 |
| October 16, 2019 13:53 | https://github.com/NativeScript/NativeScript/pull/7911#event-2717714900 |
| https://github.com/SvetoslavTsenov |
| SvetoslavTsenov | https://github.com/SvetoslavTsenov |
| Oct 16, 2019 | https://github.com/NativeScript/NativeScript/pull/7911#issuecomment-542777276 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
| Oct 16, 2019 | https://github.com/NativeScript/NativeScript/pull/7911#issuecomment-542836199 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
| cc97a16 | https://github.com/NativeScript/NativeScript/commit/cc97a1680009f1bf6dbf97c421f6e8dc535295b5 |
| Oct 16, 2019 | https://github.com/NativeScript/NativeScript/pull/7911#event-2719228570 |
| https://github.com/vakrilov |
| vakrilov | https://github.com/vakrilov |
| October 16, 2019 21:45 | https://github.com/NativeScript/NativeScript/pull/7911#event-2719228767 |
|
docs(dev-workflow): Added steps for developing pure JS apps with {N} source code
#7957
| https://github.com/NativeScript/NativeScript/pull/7957 |
|
Developer workflow broken when linking plain JS app with NativeScript/tns-core-modules
#7942
| https://github.com/NativeScript/NativeScript/issues/7942 |
| https://github.com/manoldonev |
| manoldonev | https://github.com/manoldonev |
|
Oct 22, 2019
| https://github.com/NativeScript/NativeScript/pull/7911#ref-pullrequest-510741192 |
|
refactor: deprecated topmost() usage
NativeScript/nativescript-angular#2029
| https://github.com/NativeScript/nativescript-angular/pull/2029 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F7911 |
|
| https://github.com/MartoYankov |
|
MartoYankov
| https://github.com/MartoYankov |
|
| https://github.com/NativeScript/NativeScript/pull/7911/files/220e2e2b516a42d8024514907ff6b82154cd57ed |
|
cla: yes
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7911 |
|
| https://github.com/vakrilov |
|
| https://github.com/SvetoslavTsenov |
|
| https://github.com/MartoYankov |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |