Title: fix(button-android): use setMinWidth to set TextView widgets min-width by bundyo · Pull Request #7804 · NativeScript/NativeScript · GitHub
Open Graph Title: fix(button-android): use setMinWidth to set TextView widgets min-width by bundyo · Pull Request #7804 · NativeScript/NativeScript
X Title: fix(button-android): use setMinWidth to set TextView widgets min-width by bundyo · Pull Request #7804 · NativeScript/NativeScript
Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md. What is the current behavior? Aligned Buttons with short text have a min-width that can't be removed. What is the new behavior? Removes the min-width. According to Android docs: The value given with TextView.setMinWidth(int) is different than View.setMinimumWidth(int). Between setMinWidth and the value set in View.setMinimumWidth(int), the greater one is used to decide the final width. Thus for TextViews as the Button, both should be set. https://developer.android.com/reference/android/widget/TextView.html#setMinWidth(int) Fixes/Implements/Closes #7803.
Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...
X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...
Opengraph URL: https://github.com/NativeScript/NativeScript/pull/7804
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:159d019c-cffb-3b9c-4f0d-911535893139 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AF98:17169E:E3BBE3:12F172C:697321C1 |
| html-safe-nonce | 76b28c1c9e4521beaf5d2ebeaf584b436abbbb88dfaf42760c61c0556f97f5df |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjk4OjE3MTY5RTpFM0JCRTM6MTJGMTcyQzo2OTczMjFDMSIsInZpc2l0b3JfaWQiOiIzMDM2NjI3NTg2MTEzNTQ0NjQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ccaa7bde13a42a76dbcc03a3b8fca1ec6312f43b7a1440e678d7a209b857c48f |
| hovercard-subject-tag | pull_request:316136339 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/7804/files |
| twitter:image | https://avatars.githubusercontent.com/u/98318?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/98318?s=400&v=4 |
| og:image:alt | PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 44ab3188c1dcfe3be0f9c3feca2e04e14fb79f120939ce2395e4f15ab96ec1d4 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31492490 |
| octolytics-dimension-repository_nwo | NativeScript/NativeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31492490 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/NativeScript |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a5e2b48bd1260476599758f5d253b5d24092ab84 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width