René's URL Explorer Experiment


Title: fix(hmr): close modal views during livesync #7668 by VladimirAmiorkov · Pull Request #7679 · NativeScript/NativeScript · GitHub

Open Graph Title: fix(hmr): close modal views during livesync #7668 by VladimirAmiorkov · Pull Request #7679 · NativeScript/NativeScript

X Title: fix(hmr): close modal views during livesync #7668 by VladimirAmiorkov · Pull Request #7679 · NativeScript/NativeScript

Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests. Tests for the changes are included What is the current behavior? Any opened modal views are not updated or closed during HMR livesync What is the new behavior? Any opened modal views are closed during HMR livesync Fixes/Implements/Closes #[Issue Number]. #7668

Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...

X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...

Opengraph URL: https://github.com/NativeScript/NativeScript/pull/7679

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:eee689e3-e8e7-314b-6e84-e55df2499c4f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF6A:31363C:24ABCB0:2F25067:6975EE78
html-safe-nonce225de45484d38439d788c3337b90cf6d5fc11e252b5063942cf608eee35c1392
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjZBOjMxMzYzQzoyNEFCQ0IwOjJGMjUwNjc6Njk3NUVFNzgiLCJ2aXNpdG9yX2lkIjoiNzQ5NDc0NDk1NzIyMzU2Mjg3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac49efad0413914c85d603b8220f29f7bbe41176b06272ce0153b50fb114dc04eb
hovercard-subject-tagpull_request:307221408
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/7679/files
twitter:imagehttps://avatars.githubusercontent.com/u/4989411?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4989411?s=400&v=4
og:image:altPR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2bce766e7450b03e00b2fc5badd417927ce33a860e78cda3e4ecb9bbd1374cc6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefcca2b8ef702b5f7f91427a6e920fa44446fe312
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/pull/7679/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F7679%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F7679%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/pull/7679/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/7679/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/7679/files
NativeScript https://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/7679/files
Notifications https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Fork 1.7k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Star 25.4k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Code https://github.com/NativeScript/NativeScript
Issues 869 https://github.com/NativeScript/NativeScript/issues
Pull requests 58 https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects 0 https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security 0 https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
Code https://github.com/NativeScript/NativeScript
Issues https://github.com/NativeScript/NativeScript/issues
Pull requests https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
VladimirAmiorkovhttps://github.com/VladimirAmiorkov
releasehttps://github.com/NativeScript/NativeScript/tree/release
amiorkov/modal-views-hrm-fixhttps://github.com/NativeScript/NativeScript/tree/amiorkov/modal-views-hrm-fix
Conversation 1 https://github.com/NativeScript/NativeScript/pull/7679
Commits 1 https://github.com/NativeScript/NativeScript/pull/7679/commits
Checks 0 https://github.com/NativeScript/NativeScript/pull/7679/checks
Files changed https://github.com/NativeScript/NativeScript/pull/7679/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/7679/files
fix(hmr): close modal views during livesync #7668 https://github.com/NativeScript/NativeScript/pull/7679/files#top
Show all changes 1 commit https://github.com/NativeScript/NativeScript/pull/7679/files
91f3bd1 fix(hmr): close modal views during livesync #7668 Aug 9, 2019 https://github.com/NativeScript/NativeScript/pull/7679/commits/91f3bd1db6c1861b3d262a33778cc328e99956b3
Clear filters https://github.com/NativeScript/NativeScript/pull/7679/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/7679/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/7679/files
livesync-modal-view-page.css https://github.com/NativeScript/NativeScript/pull/7679/files#diff-c735d7c6e2f72876953f446b711bdb03e34660fc36282c7101988547ade8a1f9
livesync-modal-view-page.scss https://github.com/NativeScript/NativeScript/pull/7679/files#diff-061b9355656dea5be6e3077f85c0e70b9fa987bb1fa82dc70f6ec976c6180b54
livesync-modal-view-page.ts https://github.com/NativeScript/NativeScript/pull/7679/files#diff-d921e380dd9d0c17caa74c740427b3c5a9de1421ae664ea7577c132a683e7945
livesync-modal-view-page.xml https://github.com/NativeScript/NativeScript/pull/7679/files#diff-52b9567d506a42f9f6078026ee25d97d0e0ce5cd3dce1ee7669b57ef41e9750f
livesync-tests.ts https://github.com/NativeScript/NativeScript/pull/7679/files#diff-048ab20f3e863324f052e362bba9ceed273d56bc16828b851140492ba8d7866d
view-common.ts https://github.com/NativeScript/NativeScript/pull/7679/files#diff-e07b1b76289f935e05ac85e276f898137958cbf4e7d795bf6364fde17ab8d92c
view.d.ts https://github.com/NativeScript/NativeScript/pull/7679/files#diff-53c4cfb45d44c042076eaf2de18174ac194887d58944829abdb1c464f2c6687f
tests/app/livesync/livesync-modal-view-page.csshttps://github.com/NativeScript/NativeScript/pull/7679/files#diff-c735d7c6e2f72876953f446b711bdb03e34660fc36282c7101988547ade8a1f9
View file https://github.com/NativeScript/NativeScript/blob/91f3bd1db6c1861b3d262a33778cc328e99956b3/tests/app/livesync/livesync-modal-view-page.css
Open in desktop https://desktop.github.com
tests/app/livesync/livesync-modal-view-page.scsshttps://github.com/NativeScript/NativeScript/pull/7679/files#diff-061b9355656dea5be6e3077f85c0e70b9fa987bb1fa82dc70f6ec976c6180b54
View file https://github.com/NativeScript/NativeScript/blob/91f3bd1db6c1861b3d262a33778cc328e99956b3/tests/app/livesync/livesync-modal-view-page.scss
Open in desktop https://desktop.github.com
tests/app/livesync/livesync-modal-view-page.tshttps://github.com/NativeScript/NativeScript/pull/7679/files#diff-d921e380dd9d0c17caa74c740427b3c5a9de1421ae664ea7577c132a683e7945
View file https://github.com/NativeScript/NativeScript/blob/91f3bd1db6c1861b3d262a33778cc328e99956b3/tests/app/livesync/livesync-modal-view-page.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/7679/{{ revealButtonHref }}
tests/app/livesync/livesync-modal-view-page.xmlhttps://github.com/NativeScript/NativeScript/pull/7679/files#diff-52b9567d506a42f9f6078026ee25d97d0e0ce5cd3dce1ee7669b57ef41e9750f
View file https://github.com/NativeScript/NativeScript/blob/91f3bd1db6c1861b3d262a33778cc328e99956b3/tests/app/livesync/livesync-modal-view-page.xml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/7679/{{ revealButtonHref }}
tests/app/livesync/livesync-tests.tshttps://github.com/NativeScript/NativeScript/pull/7679/files#diff-048ab20f3e863324f052e362bba9ceed273d56bc16828b851140492ba8d7866d
View file https://github.com/NativeScript/NativeScript/blob/91f3bd1db6c1861b3d262a33778cc328e99956b3/tests/app/livesync/livesync-tests.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/7679/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/7679/files#diff-048ab20f3e863324f052e362bba9ceed273d56bc16828b851140492ba8d7866d
https://github.com/NativeScript/NativeScript/pull/7679/files#diff-048ab20f3e863324f052e362bba9ceed273d56bc16828b851140492ba8d7866d
https://github.com/NativeScript/NativeScript/pull/7679/files#diff-048ab20f3e863324f052e362bba9ceed273d56bc16828b851140492ba8d7866d
https://github.com/NativeScript/NativeScript/pull/7679/files#diff-048ab20f3e863324f052e362bba9ceed273d56bc16828b851140492ba8d7866d
https://github.com/NativeScript/NativeScript/pull/7679/files#diff-048ab20f3e863324f052e362bba9ceed273d56bc16828b851140492ba8d7866d
https://github.com/NativeScript/NativeScript/pull/7679/files#diff-048ab20f3e863324f052e362bba9ceed273d56bc16828b851140492ba8d7866d
tns-core-modules/ui/core/view/view-common.tshttps://github.com/NativeScript/NativeScript/pull/7679/files#diff-e07b1b76289f935e05ac85e276f898137958cbf4e7d795bf6364fde17ab8d92c
View file https://github.com/NativeScript/NativeScript/blob/91f3bd1db6c1861b3d262a33778cc328e99956b3/tns-core-modules/ui/core/view/view-common.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/7679/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/7679/files#diff-e07b1b76289f935e05ac85e276f898137958cbf4e7d795bf6364fde17ab8d92c
https://github.com/NativeScript/NativeScript/pull/7679/files#diff-e07b1b76289f935e05ac85e276f898137958cbf4e7d795bf6364fde17ab8d92c
tns-core-modules/ui/core/view/view.d.tshttps://github.com/NativeScript/NativeScript/pull/7679/files#diff-53c4cfb45d44c042076eaf2de18174ac194887d58944829abdb1c464f2c6687f
View file https://github.com/NativeScript/NativeScript/blob/91f3bd1db6c1861b3d262a33778cc328e99956b3/tns-core-modules/ui/core/view/view.d.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/7679/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/7679/files#diff-53c4cfb45d44c042076eaf2de18174ac194887d58944829abdb1c464f2c6687f
https://github.com/NativeScript/NativeScript/pull/7679/files#diff-53c4cfb45d44c042076eaf2de18174ac194887d58944829abdb1c464f2c6687f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.