René's URL Explorer Experiment


Title: feat(file-system): async read/write by PeterStaev · Pull Request #7671 · NativeScript/NativeScript · GitHub

Open Graph Title: feat(file-system): async read/write by PeterStaev · Pull Request #7671 · NativeScript/NativeScript

X Title: feat(file-system): async read/write by PeterStaev · Pull Request #7671 · NativeScript/NativeScript

Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests. Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md. What is the current behavior? Current file-system methods for read/write files are synchronous which makes the UI thread block if a big file is read/written. What is the new behavior? True async methods have been added that use native code inside tns-core-modules-widgets execute the read/write operations in a separate thread. Closes #2239 .

Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...

X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...

Opengraph URL: https://github.com/NativeScript/NativeScript/pull/7671

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6cf8eb8d-bd75-b6f6-6eb3-c307ce8b3118
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB538:2CD505:27D6FE:36B29B:69774941
html-safe-nonce60923c6a291af83f23f5ab28d2f7bd7467e03f4c69ea376c1ecc3ebdf4b7c4d6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTM4OjJDRDUwNToyN0Q2RkU6MzZCMjlCOjY5Nzc0OTQxIiwidmlzaXRvcl9pZCI6IjU3NzA1NjkyNTI5NDMxMjA3MDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac70343d2ce5f956ba07a61d7e9ca1216690785993b79f3b3f1d19ff0897066dae
hovercard-subject-tagpull_request:306269810
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/7671/files
twitter:imagehttps://avatars.githubusercontent.com/u/9464097?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9464097?s=400&v=4
og:image:altPR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None01d198479908d09a841b2febe8eb105a81af2af7d81830960fe0971e1f4adc09
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released37e99eca9fba24ee37da98481d573461cc1ab7d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/pull/7671/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F7671%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F7671%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/pull/7671/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/7671/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/7671/files
NativeScript https://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/7671/files
Notifications https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Fork 1.7k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Star 25.4k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Code https://github.com/NativeScript/NativeScript
Issues 869 https://github.com/NativeScript/NativeScript/issues
Pull requests 58 https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects 0 https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security 0 https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
Code https://github.com/NativeScript/NativeScript
Issues https://github.com/NativeScript/NativeScript/issues
Pull requests https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
manoldonevhttps://github.com/manoldonev
NativeScript:masterhttps://github.com/NativeScript/NativeScript/tree/master
PeterStaev:issue-2239https://github.com/PeterStaev/NativeScript/tree/issue-2239
Conversation 15 https://github.com/NativeScript/NativeScript/pull/7671
Commits 13 https://github.com/NativeScript/NativeScript/pull/7671/commits
Checks 0 https://github.com/NativeScript/NativeScript/pull/7671/checks
Files changed https://github.com/NativeScript/NativeScript/pull/7671/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/7671/files
feat(file-system): async read/write https://github.com/NativeScript/NativeScript/pull/7671/files#top
Show all changes 13 commits https://github.com/NativeScript/NativeScript/pull/7671/files
59dc60c feat(files-system): async read/write PeterStaev Aug 7, 2019 https://github.com/NativeScript/NativeScript/pull/7671/commits/59dc60c135e1e1a84516a8bb032281887b9643db
5577495 Merge branch 'master' into issue-2239 PeterStaev Aug 11, 2019 https://github.com/NativeScript/NativeScript/pull/7671/commits/55774955619266dbdd975bd9768bcffc2a0d37c0
1e433d3 Merge branch 'master' into issue-2239 PeterStaev Aug 13, 2019 https://github.com/NativeScript/NativeScript/pull/7671/commits/1e433d319f46ee1438488e97e398a71a3c758743
cfd9f90 refactor(files-system/file-system-access): remove breaking changes PeterStaev Aug 13, 2019 https://github.com/NativeScript/NativeScript/pull/7671/commits/cfd9f906326eb7ad2934f5130e9a613a97562bb9
11afcf6 Merge branch 'master' into issue-2239 manoldonev Sep 18, 2019 https://github.com/NativeScript/NativeScript/pull/7671/commits/11afcf68c7ea62b4d17de2cf1e08c1c464332c62
ca88dac comment fixes PeterStaev Sep 18, 2019 https://github.com/NativeScript/NativeScript/pull/7671/commits/ca88dac840ec2b0f6284d75b2dddf37dec2d4910
625eba2 Merge branch 'master' into issue-2239 manoldonev Sep 19, 2019 https://github.com/NativeScript/NativeScript/pull/7671/commits/625eba21e690425f187f23d1e1172502965d1722
bc902f8 Merge branch 'master' into issue-2239 manoldonev Sep 24, 2019 https://github.com/NativeScript/NativeScript/pull/7671/commits/bc902f8a0e4f4b7ee874f0154a784ac2bc940779
8847801 added test PeterStaev Sep 26, 2019 https://github.com/NativeScript/NativeScript/pull/7671/commits/8847801adefc22d81727ae69278c5d4a59c69494
6511827 fix ci errors PeterStaev Sep 26, 2019 https://github.com/NativeScript/NativeScript/pull/7671/commits/65118274f5a0ebabf021219459a2f5773f22692b
593223b Merge branch 'master' into issue-2239 manoldonev Oct 1, 2019 https://github.com/NativeScript/NativeScript/pull/7671/commits/593223b30327e42bc957d9697601631474b73b3b
69cbab1 Merge branch 'master' into issue-2239 manoldonev Oct 1, 2019 https://github.com/NativeScript/NativeScript/pull/7671/commits/69cbab16096c8ae771cf0ca47582d47916a57d52
1cea819 Merge branch 'master' into issue-2239 manoldonev Oct 1, 2019 https://github.com/NativeScript/NativeScript/pull/7671/commits/1cea8194117efd99f490aa17d40c89e1e1444daf
Clear filters https://github.com/NativeScript/NativeScript/pull/7671/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/7671/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/7671/files
file-system-tests.ts https://github.com/NativeScript/NativeScript/pull/7671/files#diff-82dcdb58e97ce2df4de458a21c716640fce8672e05ded05d33e3b4c833292d13
Async.java https://github.com/NativeScript/NativeScript/pull/7671/files#diff-8c43cd55d974defef3350441586253a0233c30a8843252026361dba115019e78
project.pbxproj https://github.com/NativeScript/NativeScript/pull/7671/files#diff-8cfddac7cb33d14ee3a3ce4c8cfe00fe099049845f6ede438fb7861f5416f531
NSData+Async.h https://github.com/NativeScript/NativeScript/pull/7671/files#diff-3fde17ce34e9d4533d5c091cb2e0307146f0349789b5a7344a954790fd41ce28
NSData+Async.m https://github.com/NativeScript/NativeScript/pull/7671/files#diff-36da0b5c015bde21807df61274ce18dd88898487fae981ca2b24c0e68191e551
NSString+Async.h https://github.com/NativeScript/NativeScript/pull/7671/files#diff-8a278aefa8ac1dfc582120bec07a60c429eac5b819d6b9828c61eaba15f956a7
NSString+Async.m https://github.com/NativeScript/NativeScript/pull/7671/files#diff-d2368a689409d62701952a4c7af48289f03008318057409f376d36a810436fc2
TNSWidgets.h https://github.com/NativeScript/NativeScript/pull/7671/files#diff-673a5f1b09d017b8763424fb4bafeeab4fae4fa6dff4341c9a3b3388a3883e65
file-system-access.android.ts https://github.com/NativeScript/NativeScript/pull/7671/files#diff-0a93d80855f94a0545b71792baa849c3d7928e854e41122c0a4ca57e1a3e9c13
file-system-access.d.ts https://github.com/NativeScript/NativeScript/pull/7671/files#diff-60116c2fb5be27baa194569016d94641db7938f656ab140d9ea5bc7efdf6f63f
file-system-access.ios.ts https://github.com/NativeScript/NativeScript/pull/7671/files#diff-8a19d9bd5225f458cddcd5c721ab8a496e0dbf356d178a0c7c1c4239f0dd165f
file-system.d.ts https://github.com/NativeScript/NativeScript/pull/7671/files#diff-1e0d790fdd9dc2fa3aab19d5b58edbca732e045d98bb8de60b719e03f8575fa1
file-system.ts https://github.com/NativeScript/NativeScript/pull/7671/files#diff-da35d10e2ed913da757f387dd25f0a2697ff845f93aec1ceb804e2b640b7c647
org.nativescript.widgets.d.ts https://github.com/NativeScript/NativeScript/pull/7671/files#diff-3bac36997e3b95a4c39bfee3dbd32972502c0a3d6869a39a9a8ea118466f4f2d
tests/app/file-system/file-system-tests.tshttps://github.com/NativeScript/NativeScript/pull/7671/files#diff-82dcdb58e97ce2df4de458a21c716640fce8672e05ded05d33e3b4c833292d13
View file https://github.com/PeterStaev/NativeScript/blob/1cea8194117efd99f490aa17d40c89e1e1444daf/tests/app/file-system/file-system-tests.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/7671/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/7671/files#diff-82dcdb58e97ce2df4de458a21c716640fce8672e05ded05d33e3b4c833292d13
https://github.com/NativeScript/NativeScript/pull/7671/files#diff-82dcdb58e97ce2df4de458a21c716640fce8672e05ded05d33e3b4c833292d13
tns-core-modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/Async.javahttps://github.com/NativeScript/NativeScript/pull/7671/files#diff-8c43cd55d974defef3350441586253a0233c30a8843252026361dba115019e78
View file https://github.com/PeterStaev/NativeScript/blob/1cea8194117efd99f490aa17d40c89e1e1444daf/tns-core-modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/Async.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/7671/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/7671/files#diff-8c43cd55d974defef3350441586253a0233c30a8843252026361dba115019e78
https://github.com/NativeScript/NativeScript/pull/7671/files#diff-8c43cd55d974defef3350441586253a0233c30a8843252026361dba115019e78
https://github.com/NativeScript/NativeScript/pull/7671/files#diff-8c43cd55d974defef3350441586253a0233c30a8843252026361dba115019e78
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/7671/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.