René's URL Explorer Experiment


Title: fix(hmr): close modal views during livesync by VladimirAmiorkov · Pull Request #7669 · NativeScript/NativeScript · GitHub

Open Graph Title: fix(hmr): close modal views during livesync by VladimirAmiorkov · Pull Request #7669 · NativeScript/NativeScript

X Title: fix(hmr): close modal views during livesync by VladimirAmiorkov · Pull Request #7669 · NativeScript/NativeScript

Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. You have signed the CLA. All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests. Tests for the changes are included What is the current behavior? Any opened modal views are not updated or closed during HMR livesync What is the new behavior? Any opened modal views are closed during HMR livesync Fixes/Implements/Closes #[Issue Number]. #7668

Open Graph Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...

X Description: PR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...

Opengraph URL: https://github.com/NativeScript/NativeScript/pull/7669

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4c942205-a723-caf8-1874-87416ee311e1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD652:338A3B:350469:43C4D1:697615FE
html-safe-noncee554d3ad0957dc97689a9bced787ee348c690b4de2f2e711a84848146404bfb0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjUyOjMzOEEzQjozNTA0Njk6NDNDNEQxOjY5NzYxNUZFIiwidmlzaXRvcl9pZCI6IjI2Njc1NDM0NDEyOTc1MTE5MzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfe3c75699efd8bb9a58ee03dbe7c9a9dcb77fab16e06137e48ab163a86669830
hovercard-subject-tagpull_request:305991810
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/7669/files
twitter:imagehttps://avatars.githubusercontent.com/u/4989411?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4989411?s=400&v=4
og:image:altPR Checklist The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. There is an issue for the bug/feature this PR is for. ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec6814b4cc7afd45cd6e64525d0cff0e76dd802f315a5b0e55a7abda1d1d070d0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git
octolytics-dimension-user_id7392261
octolytics-dimension-user_loginNativeScript
octolytics-dimension-repository_id31492490
octolytics-dimension-repository_nwoNativeScript/NativeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31492490
octolytics-dimension-repository_network_root_nwoNativeScript/NativeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4ea235bfed58ef16c8a5642b3ac64b74f10c9f52
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/NativeScript/NativeScript/pull/7669/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F7669%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F7669%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=NativeScript%2FNativeScript
Reloadhttps://github.com/NativeScript/NativeScript/pull/7669/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/7669/files
Reloadhttps://github.com/NativeScript/NativeScript/pull/7669/files
NativeScript https://github.com/NativeScript
NativeScripthttps://github.com/NativeScript/NativeScript
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/7669/files
Notifications https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Fork 1.7k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Star 25.4k https://github.com/login?return_to=%2FNativeScript%2FNativeScript
Code https://github.com/NativeScript/NativeScript
Issues 869 https://github.com/NativeScript/NativeScript/issues
Pull requests 58 https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects 0 https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security 0 https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
Code https://github.com/NativeScript/NativeScript
Issues https://github.com/NativeScript/NativeScript/issues
Pull requests https://github.com/NativeScript/NativeScript/pulls
Discussions https://github.com/NativeScript/NativeScript/discussions
Actions https://github.com/NativeScript/NativeScript/actions
Projects https://github.com/NativeScript/NativeScript/projects
Wiki https://github.com/NativeScript/NativeScript/wiki
Security https://github.com/NativeScript/NativeScript/security
Insights https://github.com/NativeScript/NativeScript/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose
VladimirAmiorkovhttps://github.com/VladimirAmiorkov
masterhttps://github.com/NativeScript/NativeScript/tree/master
amiorkov/hmr-modals-fixhttps://github.com/NativeScript/NativeScript/tree/amiorkov/hmr-modals-fix
Conversation 5 https://github.com/NativeScript/NativeScript/pull/7669
Commits 11 https://github.com/NativeScript/NativeScript/pull/7669/commits
Checks 0 https://github.com/NativeScript/NativeScript/pull/7669/checks
Files changed https://github.com/NativeScript/NativeScript/pull/7669/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/7669/files
fix(hmr): close modal views during livesync https://github.com/NativeScript/NativeScript/pull/7669/files#top
Show all changes 11 commits https://github.com/NativeScript/NativeScript/pull/7669/files
ae9ecff fix(hmr): close modal views during livesync #7668 Aug 9, 2019 https://github.com/NativeScript/NativeScript/pull/7669/commits/ae9ecffb253a9e301573287fc3d1e78a9564e1e9
88ea038 chore: raise trace logs before closing modal views on live sync Aug 12, 2019 https://github.com/NativeScript/NativeScript/pull/7669/commits/88ea038ca56799cf0485908bfe26170908e79d7c
0249a7e chore: refactor closing of modal views on live sync Aug 12, 2019 https://github.com/NativeScript/NativeScript/pull/7669/commits/0249a7ed5eb4bf54cee4dd9f6ee023182dd889d7
18e6d67 chore: resolve merge conflict Aug 12, 2019 https://github.com/NativeScript/NativeScript/pull/7669/commits/18e6d67f951e4bacb19e7e121b612517d5b90c03
7387b71 chore: add comment for new method Aug 12, 2019 https://github.com/NativeScript/NativeScript/pull/7669/commits/7387b717646704988ac6cdb0be4e58e9fa48b25e
c7866fc Merge branch 'master' into amiorkov/hmr-modals-fix SvetoslavTsenov Aug 12, 2019 https://github.com/NativeScript/NativeScript/pull/7669/commits/c7866fcc63c7e5f9d3b7689672125fb34af0e197
405bb14 chore: resolve incorrect condition Aug 13, 2019 https://github.com/NativeScript/NativeScript/pull/7669/commits/405bb14494ff3e0ebe2dd92f14703cfaa0d3266a
e5a6e7f chore: remove leftover log Aug 13, 2019 https://github.com/NativeScript/NativeScript/pull/7669/commits/e5a6e7f2afe4059ce050662e44d3589f53fc4708
476a6e9 chore: expose method that gets the root modal views of a view Aug 13, 2019 https://github.com/NativeScript/NativeScript/pull/7669/commits/476a6e944d15234d24158f3a5964c2c9b9f522e3
81b3996 Merge branch 'master' into amiorkov/hmr-modals-fix Aug 13, 2019 https://github.com/NativeScript/NativeScript/pull/7669/commits/81b399678431b83452f11dc627cd29f31b7ae619
9751b35 chore: update unit test to check that app has not restarted Aug 14, 2019 https://github.com/NativeScript/NativeScript/pull/7669/commits/9751b35a27800fbdf37846bfd76f2f65ef551b6b
Clear filters https://github.com/NativeScript/NativeScript/pull/7669/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/7669/files
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/7669/files
livesync-modal-view-page.css https://github.com/NativeScript/NativeScript/pull/7669/files#diff-c735d7c6e2f72876953f446b711bdb03e34660fc36282c7101988547ade8a1f9
livesync-modal-view-page.scss https://github.com/NativeScript/NativeScript/pull/7669/files#diff-061b9355656dea5be6e3077f85c0e70b9fa987bb1fa82dc70f6ec976c6180b54
livesync-modal-view-page.ts https://github.com/NativeScript/NativeScript/pull/7669/files#diff-d921e380dd9d0c17caa74c740427b3c5a9de1421ae664ea7577c132a683e7945
livesync-modal-view-page.xml https://github.com/NativeScript/NativeScript/pull/7669/files#diff-52b9567d506a42f9f6078026ee25d97d0e0ce5cd3dce1ee7669b57ef41e9750f
livesync-tests.ts https://github.com/NativeScript/NativeScript/pull/7669/files#diff-048ab20f3e863324f052e362bba9ceed273d56bc16828b851140492ba8d7866d
view-common.ts https://github.com/NativeScript/NativeScript/pull/7669/files#diff-e07b1b76289f935e05ac85e276f898137958cbf4e7d795bf6364fde17ab8d92c
view.d.ts https://github.com/NativeScript/NativeScript/pull/7669/files#diff-53c4cfb45d44c042076eaf2de18174ac194887d58944829abdb1c464f2c6687f
tests/app/livesync/livesync-modal-view-page.csshttps://github.com/NativeScript/NativeScript/pull/7669/files#diff-c735d7c6e2f72876953f446b711bdb03e34660fc36282c7101988547ade8a1f9
View file https://github.com/NativeScript/NativeScript/blob/9751b35a27800fbdf37846bfd76f2f65ef551b6b/tests/app/livesync/livesync-modal-view-page.css
Open in desktop https://desktop.github.com
tests/app/livesync/livesync-modal-view-page.scsshttps://github.com/NativeScript/NativeScript/pull/7669/files#diff-061b9355656dea5be6e3077f85c0e70b9fa987bb1fa82dc70f6ec976c6180b54
View file https://github.com/NativeScript/NativeScript/blob/9751b35a27800fbdf37846bfd76f2f65ef551b6b/tests/app/livesync/livesync-modal-view-page.scss
Open in desktop https://desktop.github.com
tests/app/livesync/livesync-modal-view-page.tshttps://github.com/NativeScript/NativeScript/pull/7669/files#diff-d921e380dd9d0c17caa74c740427b3c5a9de1421ae664ea7577c132a683e7945
View file https://github.com/NativeScript/NativeScript/blob/9751b35a27800fbdf37846bfd76f2f65ef551b6b/tests/app/livesync/livesync-modal-view-page.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/7669/{{ revealButtonHref }}
tests/app/livesync/livesync-modal-view-page.xmlhttps://github.com/NativeScript/NativeScript/pull/7669/files#diff-52b9567d506a42f9f6078026ee25d97d0e0ce5cd3dce1ee7669b57ef41e9750f
View file https://github.com/NativeScript/NativeScript/blob/9751b35a27800fbdf37846bfd76f2f65ef551b6b/tests/app/livesync/livesync-modal-view-page.xml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/7669/{{ revealButtonHref }}
tests/app/livesync/livesync-tests.tshttps://github.com/NativeScript/NativeScript/pull/7669/files#diff-048ab20f3e863324f052e362bba9ceed273d56bc16828b851140492ba8d7866d
View file https://github.com/NativeScript/NativeScript/blob/9751b35a27800fbdf37846bfd76f2f65ef551b6b/tests/app/livesync/livesync-tests.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/7669/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/7669/files#diff-048ab20f3e863324f052e362bba9ceed273d56bc16828b851140492ba8d7866d
https://github.com/NativeScript/NativeScript/pull/7669/files#diff-048ab20f3e863324f052e362bba9ceed273d56bc16828b851140492ba8d7866d
https://github.com/NativeScript/NativeScript/pull/7669/files#diff-048ab20f3e863324f052e362bba9ceed273d56bc16828b851140492ba8d7866d
https://github.com/NativeScript/NativeScript/pull/7669/files#diff-048ab20f3e863324f052e362bba9ceed273d56bc16828b851140492ba8d7866d
https://github.com/NativeScript/NativeScript/pull/7669/files#diff-048ab20f3e863324f052e362bba9ceed273d56bc16828b851140492ba8d7866d
https://github.com/NativeScript/NativeScript/pull/7669/files#diff-048ab20f3e863324f052e362bba9ceed273d56bc16828b851140492ba8d7866d
tns-core-modules/ui/core/view/view-common.tshttps://github.com/NativeScript/NativeScript/pull/7669/files#diff-e07b1b76289f935e05ac85e276f898137958cbf4e7d795bf6364fde17ab8d92c
View file https://github.com/NativeScript/NativeScript/blob/9751b35a27800fbdf37846bfd76f2f65ef551b6b/tns-core-modules/ui/core/view/view-common.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/7669/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/7669/files#diff-e07b1b76289f935e05ac85e276f898137958cbf4e7d795bf6364fde17ab8d92c
Please reload this pagehttps://github.com/NativeScript/NativeScript/pull/7669/files
https://github.com/NativeScript/NativeScript/pull/7669/files#diff-e07b1b76289f935e05ac85e276f898137958cbf4e7d795bf6364fde17ab8d92c
tns-core-modules/ui/core/view/view.d.tshttps://github.com/NativeScript/NativeScript/pull/7669/files#diff-53c4cfb45d44c042076eaf2de18174ac194887d58944829abdb1c464f2c6687f
View file https://github.com/NativeScript/NativeScript/blob/9751b35a27800fbdf37846bfd76f2f65ef551b6b/tns-core-modules/ui/core/view/view.d.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/NativeScript/NativeScript/pull/7669/{{ revealButtonHref }}
https://github.com/NativeScript/NativeScript/pull/7669/files#diff-53c4cfb45d44c042076eaf2de18174ac194887d58944829abdb1c464f2c6687f
https://github.com/NativeScript/NativeScript/pull/7669/files#diff-53c4cfb45d44c042076eaf2de18174ac194887d58944829abdb1c464f2c6687f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.