| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4d19d9bd-7fed-f982-602f-87156422f46d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AF46:3676A1:2AF1CE9:39AC1A1:6972EC7A |
| html-safe-nonce | ac70f9787f4ed9e6ac80fd0e2a5ba667c736717a72c70702d80fac21e4565724 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjQ2OjM2NzZBMToyQUYxQ0U5OjM5QUMxQTE6Njk3MkVDN0EiLCJ2aXNpdG9yX2lkIjoiOTIwODUzMzU3MDg2MTMyOTUzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c8db754d42e3286524ff594954c9d45af831fbae60d20c6142a267502d79e6c2 |
| hovercard-subject-tag | pull_request:303724208 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/NativeScript/NativeScript/7629/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/19f13e2cfb6e571f2fd46802422b116f623466ad1067382aba98f14ea0920b84/NativeScript/NativeScript/pull/7629 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/19f13e2cfb6e571f2fd46802422b116f623466ad1067382aba98f14ea0920b84/NativeScript/NativeScript/pull/7629 |
| og:image:alt | Make tabContentItem ContentView instead of ViewBase to enable CSS properties propagation. This will enable setting backgroundColor/color and so on to its children views.
Modify Tabs,BottomNavigatio... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ADjenkov |
| hostname | github.com |
| expected-hostname | github.com |
| None | 25ef7e923c492d9047af899b2ba66bfcb0a78059369630f2ce2cf57826ed6a53 |
| turbo-cache-control | no-preview |
| go-import | github.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31492490 |
| octolytics-dimension-repository_nwo | NativeScript/NativeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31492490 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/NativeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c0badd0db61d89a34653af2d762b2eb8c84f9d59 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/NativeScript/NativeScript/pull/7629#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F7629 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F7629 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=NativeScript%2FNativeScript |
| Reload | https://github.com/NativeScript/NativeScript/pull/7629 |
| Reload | https://github.com/NativeScript/NativeScript/pull/7629 |
| Reload | https://github.com/NativeScript/NativeScript/pull/7629 |
|
NativeScript
| https://github.com/NativeScript |
| NativeScript | https://github.com/NativeScript/NativeScript |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7629 |
|
Notifications
| https://github.com/login?return_to=%2FNativeScript%2FNativeScript |
|
Fork
1.7k
| https://github.com/login?return_to=%2FNativeScript%2FNativeScript |
|
Star
25.4k
| https://github.com/login?return_to=%2FNativeScript%2FNativeScript |
|
Code
| https://github.com/NativeScript/NativeScript |
|
Issues
869
| https://github.com/NativeScript/NativeScript/issues |
|
Pull requests
59
| https://github.com/NativeScript/NativeScript/pulls |
|
Discussions
| https://github.com/NativeScript/NativeScript/discussions |
|
Actions
| https://github.com/NativeScript/NativeScript/actions |
|
Projects
0
| https://github.com/NativeScript/NativeScript/projects |
|
Wiki
| https://github.com/NativeScript/NativeScript/wiki |
|
Security
0
| https://github.com/NativeScript/NativeScript/security |
|
Insights
| https://github.com/NativeScript/NativeScript/pulse |
|
Code
| https://github.com/NativeScript/NativeScript |
|
Issues
| https://github.com/NativeScript/NativeScript/issues |
|
Pull requests
| https://github.com/NativeScript/NativeScript/pulls |
|
Discussions
| https://github.com/NativeScript/NativeScript/discussions |
|
Actions
| https://github.com/NativeScript/NativeScript/actions |
|
Projects
| https://github.com/NativeScript/NativeScript/projects |
|
Wiki
| https://github.com/NativeScript/NativeScript/wiki |
|
Security
| https://github.com/NativeScript/NativeScript/security |
|
Insights
| https://github.com/NativeScript/NativeScript/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2FNativeScript%2FNativeScript%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/NativeScript/NativeScript/pull/7629#issue-comment-box |
| MartoYankov | https://github.com/MartoYankov |
| master | https://github.com/NativeScript/NativeScript/tree/master |
| djenkov/tab-content-item-view | https://github.com/NativeScript/NativeScript/tree/djenkov/tab-content-item-view |
|
feat(tab-content-view): change tabContentItem to View
| https://github.com/NativeScript/NativeScript/pull/7629#top |
| MartoYankov | https://github.com/MartoYankov |
| master | https://github.com/NativeScript/NativeScript/tree/master |
| djenkov/tab-content-item-view | https://github.com/NativeScript/NativeScript/tree/djenkov/tab-content-item-view |
|
Conversation
0
| https://github.com/NativeScript/NativeScript/pull/7629 |
|
Commits
9
| https://github.com/NativeScript/NativeScript/pull/7629/commits |
|
Checks
0
| https://github.com/NativeScript/NativeScript/pull/7629/checks |
|
Files changed
| https://github.com/NativeScript/NativeScript/pull/7629/files |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7629 |
| https://github.co/hiddenchars |
| https://github.com/NativeScript/NativeScript/pull/{{ revealButtonHref }} |
|
| https://github.com/ADjenkov |
| ADjenkov | https://github.com/ADjenkov |
| Aug 2, 2019 | https://github.com/NativeScript/NativeScript/pull/7629#issue-476102963 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7629 |
| #7496 | https://github.com/NativeScript/NativeScript/issues/7496 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7629 |
|
| https://github.com/ADjenkov |
| feat(tab-content-view): change tabContentItem to View | https://github.com/NativeScript/NativeScript/pull/7629/commits/a038d52f803b1cc59c5efe0f9f61b4e1998b4418 |
| a038d52 | https://github.com/NativeScript/NativeScript/pull/7629/commits/a038d52f803b1cc59c5efe0f9f61b4e1998b4418 |
| https://github.com/ADjenkov |
| ADjenkov | https://github.com/ADjenkov |
| Aug 2, 2019 | https://github.com/NativeScript/NativeScript/pull/7629#event-2529203476 |
| https://github.com/apps/cla-bot |
| cla-bot | https://github.com/apps/cla-bot |
|
cla: yes
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Aug 2, 2019 | https://github.com/NativeScript/NativeScript/pull/7629#event-2529203593 |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
|
Aug 2, 2019
| https://github.com/NativeScript/NativeScript/pull/7629#pullrequestreview-270116696 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/7629/files/a038d52f803b1cc59c5efe0f9f61b4e1998b4418 |
| SvetoslavTsenov | https://github.com/SvetoslavTsenov |
| August 2, 2019 19:19 | https://github.com/NativeScript/NativeScript/pull/7629#commits-pushed-b588a63 |
|
| https://github.com/SvetoslavTsenov |
| Merge branch 'master' into djenkov/tab-content-item-view | https://github.com/NativeScript/NativeScript/pull/7629/commits/b588a6381cd5377ed672dee290d4eed6dc0a93b9 |
| b588a63 | https://github.com/NativeScript/NativeScript/pull/7629/commits/b588a6381cd5377ed672dee290d4eed6dc0a93b9 |
|
| https://github.com/ADjenkov |
| Merge branch 'master' into djenkov/tab-content-item-view | https://github.com/NativeScript/NativeScript/pull/7629/commits/6d46b1a4f4deeef00627102bdf4f3da2b590024c |
| 6d46b1a | https://github.com/NativeScript/NativeScript/pull/7629/commits/6d46b1a4f4deeef00627102bdf4f3da2b590024c |
|
| https://github.com/ADjenkov |
| feat(tab-content-item): TabContentItem should extend ContentView | https://github.com/NativeScript/NativeScript/pull/7629/commits/2cd39a4ff376f97f4f8d1055ab5089b72161314f |
| 2cd39a4 | https://github.com/NativeScript/NativeScript/pull/7629/commits/2cd39a4ff376f97f4f8d1055ab5089b72161314f |
| https://github.com/ADjenkov |
| ADjenkov | https://github.com/ADjenkov |
| force-pushed | https://github.com/NativeScript/NativeScript/compare/206e1832313f9d838f50088b4f3c7c9958daebb1..2cd39a4ff376f97f4f8d1055ab5089b72161314f |
| 206e183 | https://github.com/NativeScript/NativeScript/commit/206e1832313f9d838f50088b4f3c7c9958daebb1 |
| 2cd39a4 | https://github.com/NativeScript/NativeScript/commit/2cd39a4ff376f97f4f8d1055ab5089b72161314f |
|
Compare
| https://github.com/NativeScript/NativeScript/compare/206e1832313f9d838f50088b4f3c7c9958daebb1..2cd39a4ff376f97f4f8d1055ab5089b72161314f |
| August 7, 2019 11:10 | https://github.com/NativeScript/NativeScript/pull/7629#event-2539689215 |
|
| https://github.com/ADjenkov |
| chore(tests): update tests to use content instead of view | https://github.com/NativeScript/NativeScript/pull/7629/commits/66bbf21a980e99d8656eb6eb421cc0dccca6b158 |
| 66bbf21 | https://github.com/NativeScript/NativeScript/pull/7629/commits/66bbf21a980e99d8656eb6eb421cc0dccca6b158 |
| https://github.com/ADjenkov |
| ADjenkov | https://github.com/ADjenkov |
| force-pushed | https://github.com/NativeScript/NativeScript/compare/25754f9f812024a2ce5b579e9556edb267b98964..66bbf21a980e99d8656eb6eb421cc0dccca6b158 |
| 25754f9 | https://github.com/NativeScript/NativeScript/commit/25754f9f812024a2ce5b579e9556edb267b98964 |
| 66bbf21 | https://github.com/NativeScript/NativeScript/commit/66bbf21a980e99d8656eb6eb421cc0dccca6b158 |
|
Compare
| https://github.com/NativeScript/NativeScript/compare/25754f9f812024a2ce5b579e9556edb267b98964..66bbf21a980e99d8656eb6eb421cc0dccca6b158 |
| August 7, 2019 11:41 | https://github.com/NativeScript/NativeScript/pull/7629#event-2539768166 |
| ADjenkov | https://github.com/ADjenkov |
| August 8, 2019 14:14 | https://github.com/NativeScript/NativeScript/pull/7629#commits-pushed-51b142f |
|
| https://github.com/ADjenkov |
| fix(bottom-navigation-android): remove bottom nav elevation | https://github.com/NativeScript/NativeScript/pull/7629/commits/51b142fb9ed125f8a7bc67b29f01055d325649d4 |
| 51b142f | https://github.com/NativeScript/NativeScript/pull/7629/commits/51b142fb9ed125f8a7bc67b29f01055d325649d4 |
|
| https://github.com/ADjenkov |
| Merge branch 'master' into djenkov/tab-content-item-view | https://github.com/NativeScript/NativeScript/pull/7629/commits/4c943870873e6e0d9611473656bfaa5f8eedaee6 |
| 4c94387 | https://github.com/NativeScript/NativeScript/pull/7629/commits/4c943870873e6e0d9611473656bfaa5f8eedaee6 |
|
| https://github.com/ADjenkov |
| fix(tabs-android): set set elevation depending on tabsPosition property | https://github.com/NativeScript/NativeScript/pull/7629/commits/4a60bfd2bc26a84f4b3f4479868f079d90150388 |
| 4a60bfd | https://github.com/NativeScript/NativeScript/pull/7629/commits/4a60bfd2bc26a84f4b3f4479868f079d90150388 |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
|
Aug 13, 2019
| https://github.com/NativeScript/NativeScript/pull/7629#pullrequestreview-274287477 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/7629/files/4a60bfd2bc26a84f4b3f4479868f079d90150388 |
|
| https://github.com/MartoYankov |
| Merge branch 'master' into djenkov/tab-content-item-view | https://github.com/NativeScript/NativeScript/pull/7629/commits/8e240f8f46044eda6165d50ebe100787985bae2d |
| 8e240f8 | https://github.com/NativeScript/NativeScript/pull/7629/commits/8e240f8f46044eda6165d50ebe100787985bae2d |
| https://github.com/manoldonev |
| manoldonev | https://github.com/manoldonev |
|
Aug 14, 2019
| https://github.com/NativeScript/NativeScript/pull/7629#pullrequestreview-274953020 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/7629/files/8e240f8f46044eda6165d50ebe100787985bae2d |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
| 72ca461 | https://github.com/NativeScript/NativeScript/commit/72ca461f59d8445015ea73193da290012111f3e4 |
| Aug 15, 2019 | https://github.com/NativeScript/NativeScript/pull/7629#event-2558843506 |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
| August 15, 2019 08:08 | https://github.com/NativeScript/NativeScript/pull/7629#event-2558843636 |
| tsonevn | https://github.com/tsonevn |
|
Sep 2, 2019
| https://github.com/NativeScript/NativeScript/pull/7629#ref-commit-1830124 |
|
| https://github.com/ADjenkov |
|
| https://github.com/tsonevn |
| feat(tab-content-view): change tabContentItem to View ( | https://github.com/NativeScript/NativeScript/commit/1830124ffa20979ed18c2a834ebae64e3b4cf9ea |
| #7629 | https://github.com/NativeScript/NativeScript/pull/7629 |
| ) | https://github.com/NativeScript/NativeScript/commit/1830124ffa20979ed18c2a834ebae64e3b4cf9ea |
| 1830124 | https://github.com/NativeScript/NativeScript/commit/1830124ffa20979ed18c2a834ebae64e3b4cf9ea |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F7629 |
|
| https://github.com/manoldonev |
|
manoldonev
| https://github.com/manoldonev |
|
| https://github.com/NativeScript/NativeScript/pull/7629/files/8e240f8f46044eda6165d50ebe100787985bae2d |
|
| https://github.com/MartoYankov |
|
MartoYankov
| https://github.com/MartoYankov |
|
| https://github.com/NativeScript/NativeScript/pull/7629/files/4a60bfd2bc26a84f4b3f4479868f079d90150388 |
|
| https://github.com/ADjenkov |
|
ADjenkov
| https://github.com/ADjenkov |
|
cla: yes
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
[Tabs][BottomNavigation] TabContentItem background color not applied
| https://github.com/NativeScript/NativeScript/issues/7496 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7629 |
|
| https://github.com/ADjenkov |
|
| https://github.com/manoldonev |
|
| https://github.com/MartoYankov |
|
| https://github.com/SvetoslavTsenov |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |