| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5ab7c9b1-57a9-3c31-7f14-24cbe3c4ee75 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8DFC:2009F3:BA325D:F493CA:6A5C26A1 |
| html-safe-nonce | bac015f8a084772e5085dd07d7c5c4d4b8177b1346dc137f19b36d836f9e232f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4REZDOjIwMDlGMzpCQTMyNUQ6RjQ5M0NBOjZBNUMyNkExIiwidmlzaXRvcl9pZCI6IjU0MDc0ODI2NjkxOTM1MDQ0MTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c8337415aed0ff02870ee6db265f2318edebff25d713d2f20040725ae4abd340 |
| hovercard-subject-tag | pull_request:286663201 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/NativeScript/NativeScript/7340/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/add804caca9dae3aa17a2c40c68bf96ea6f58da61a8885bdbcc2da3050625a14/NativeScript/NativeScript/pull/7340 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/add804caca9dae3aa17a2c40c68bf96ea6f58da61a8885bdbcc2da3050625a14/NativeScript/NativeScript/pull/7340 |
| og:image:alt | This is part of the TabView re-design effort detailed here - #6967 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MartoYankov |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-cache |
| go-import | github.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31492490 |
| octolytics-dimension-repository_nwo | NativeScript/NativeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31492490 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/NativeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/NativeScript/NativeScript/pull/7340#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F7340 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F7340 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=NativeScript%2FNativeScript |
| Reload | https://github.com/NativeScript/NativeScript/pull/7340 |
| Reload | https://github.com/NativeScript/NativeScript/pull/7340 |
| Reload | https://github.com/NativeScript/NativeScript/pull/7340 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7340 |
|
NativeScript
| https://github.com/NativeScript |
| NativeScript | https://github.com/NativeScript/NativeScript |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7340 |
|
Notifications
| https://github.com/login?return_to=%2FNativeScript%2FNativeScript |
|
Fork
1.7k
| https://github.com/login?return_to=%2FNativeScript%2FNativeScript |
|
Star
25.6k
| https://github.com/login?return_to=%2FNativeScript%2FNativeScript |
|
Code
| https://github.com/NativeScript/NativeScript |
|
Issues
771
| https://github.com/NativeScript/NativeScript/issues |
|
Pull requests
67
| https://github.com/NativeScript/NativeScript/pulls |
|
Discussions
| https://github.com/NativeScript/NativeScript/discussions |
|
Actions
| https://github.com/NativeScript/NativeScript/actions |
|
Projects
| https://github.com/NativeScript/NativeScript/projects |
|
Wiki
| https://github.com/NativeScript/NativeScript/wiki |
|
Security and quality
0
| https://github.com/NativeScript/NativeScript/security |
|
Insights
| https://github.com/NativeScript/NativeScript/pulse |
|
Code
| https://github.com/NativeScript/NativeScript |
|
Issues
| https://github.com/NativeScript/NativeScript/issues |
|
Pull requests
| https://github.com/NativeScript/NativeScript/pulls |
|
Discussions
| https://github.com/NativeScript/NativeScript/discussions |
|
Actions
| https://github.com/NativeScript/NativeScript/actions |
|
Projects
| https://github.com/NativeScript/NativeScript/projects |
|
Wiki
| https://github.com/NativeScript/NativeScript/wiki |
|
Security and quality
| https://github.com/NativeScript/NativeScript/security |
|
Insights
| https://github.com/NativeScript/NativeScript/pulse |
| MartoYankov | https://github.com/MartoYankov |
| master | https://github.com/NativeScript/NativeScript/tree/master |
| myankov/tabs | https://github.com/NativeScript/NativeScript/tree/myankov/tabs |
| Conversation | https://github.com/NativeScript/NativeScript/pull/7340 |
| Commits20 (20) | https://github.com/NativeScript/NativeScript/pull/7340/commits |
| Checks | https://github.com/NativeScript/NativeScript/pull/7340/checks |
| Files changed | https://github.com/NativeScript/NativeScript/pull/7340/files |
| feat: re-design tab views | https://github.com/NativeScript/NativeScript/pull/7340#top |
| MartoYankov | https://github.com/MartoYankov |
| master | https://github.com/NativeScript/NativeScript/tree/master |
| myankov/tabs | https://github.com/NativeScript/NativeScript/tree/myankov/tabs |
|
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
| Jun 10, 2019 | https://github.com/NativeScript/NativeScript/pull/7340#issue-454153611 |
| #6967 | https://github.com/NativeScript/NativeScript/issues/6967 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7340 |
| MartoYankov | https://github.com/MartoYankov |
| June 10, 2019 14:13 | https://github.com/NativeScript/NativeScript/pull/7340#commits-pushed-2861bb3 |
|
| https://github.com/MartoYankov |
| wip(): add bottom navigation shell classes | https://github.com/NativeScript/NativeScript/pull/7340/commits/2861bb3e2b9b30a9a0349ddfd3478d7bf6ff1761 |
| 2861bb3 | https://github.com/NativeScript/NativeScript/pull/7340/commits/2861bb3e2b9b30a9a0349ddfd3478d7bf6ff1761 |
|
| https://github.com/MartoYankov |
| wip: add bottom navigation markup changes | https://github.com/NativeScript/NativeScript/pull/7340/commits/0995a9df779f4b75473e364826817a7bbdbb5d24 |
| 0995a9d | https://github.com/NativeScript/NativeScript/pull/7340/commits/0995a9df779f4b75473e364826817a7bbdbb5d24 |
|
| https://github.com/MartoYankov |
| wip: add bottomnavigation implementation for android | https://github.com/NativeScript/NativeScript/pull/7340/commits/e86c1c21e764e7e9f208ed94ad1cfcd26019d045 |
| e86c1c2 | https://github.com/NativeScript/NativeScript/pull/7340/commits/e86c1c21e764e7e9f208ed94ad1cfcd26019d045 |
|
| https://github.com/MartoYankov |
| wip: add bottom navigation unit tests | https://github.com/NativeScript/NativeScript/pull/7340/commits/6901bdd3d3b85a5696f0e7bf102ffa3425d5ffad |
| 6901bdd | https://github.com/NativeScript/NativeScript/pull/7340/commits/6901bdd3d3b85a5696f0e7bf102ffa3425d5ffad |
|
| https://github.com/MartoYankov |
| wip: add more unit tests | https://github.com/NativeScript/NativeScript/pull/7340/commits/44faac1680966bf0038aa4a463fab64b6d3daa25 |
| 44faac1 | https://github.com/NativeScript/NativeScript/pull/7340/commits/44faac1680966bf0038aa4a463fab64b6d3daa25 |
|
| https://github.com/MartoYankov |
| wip: add ui tests for bottom nav | https://github.com/NativeScript/NativeScript/pull/7340/commits/dd9e4c39c98dd446b8a525810c65dc21ad9b24b8 |
| dd9e4c3 | https://github.com/NativeScript/NativeScript/pull/7340/commits/dd9e4c39c98dd446b8a525810c65dc21ad9b24b8 |
|
| https://github.com/MartoYankov |
| wip: refactor bottom navigation | https://github.com/NativeScript/NativeScript/pull/7340/commits/565106f91a4f17ea3aa53c611879bccb0d16c25b |
| 565106f | https://github.com/NativeScript/NativeScript/pull/7340/commits/565106f91a4f17ea3aa53c611879bccb0d16c25b |
|
| https://github.com/MartoYankov |
| wip: add basic tabs implementation | https://github.com/NativeScript/NativeScript/pull/7340/commits/98c7c4bbfdea835870bf330d55f69c6308688b5f |
| 98c7c4b | https://github.com/NativeScript/NativeScript/pull/7340/commits/98c7c4bbfdea835870bf330d55f69c6308688b5f |
|
| https://github.com/MartoYankov |
| wip: add ios tabs implementation and tests | https://github.com/NativeScript/NativeScript/pull/7340/commits/e70d90df7e67046a134dd8b81b313ec403a3f987 |
| e70d90d | https://github.com/NativeScript/NativeScript/pull/7340/commits/e70d90df7e67046a134dd8b81b313ec403a3f987 |
|
| https://github.com/MartoYankov |
| wip: add even more tests | https://github.com/NativeScript/NativeScript/pull/7340/commits/fafefe26a8eabe6d44fd1b61bb75bc53526fa66b |
| fafefe2 | https://github.com/NativeScript/NativeScript/pull/7340/commits/fafefe26a8eabe6d44fd1b61bb75bc53526fa66b |
|
| https://github.com/MartoYankov |
| wip: add swipeEnabled property for Tabs | https://github.com/NativeScript/NativeScript/pull/7340/commits/108d2a4920fbba707547a099c2f4a7d81e86916d |
| 108d2a4 | https://github.com/NativeScript/NativeScript/pull/7340/commits/108d2a4920fbba707547a099c2f4a7d81e86916d |
|
| https://github.com/MartoYankov |
| wip: fix some tests | https://github.com/NativeScript/NativeScript/pull/7340/commits/ff9bbae2d5c4cf02c644018dc740330376adf660 |
| ff9bbae | https://github.com/NativeScript/NativeScript/pull/7340/commits/ff9bbae2d5c4cf02c644018dc740330376adf660 |
|
| https://github.com/MartoYankov |
| wip: add offsceenTabLimit property to Tabs | https://github.com/NativeScript/NativeScript/pull/7340/commits/6971416a70f3181bb2364cadea67e2ceae390f7f |
| 6971416 | https://github.com/NativeScript/NativeScript/pull/7340/commits/6971416a70f3181bb2364cadea67e2ceae390f7f |
|
| https://github.com/MartoYankov |
| wip: add tabsPosition property to Tabs | https://github.com/NativeScript/NativeScript/pull/7340/commits/e23fb8cd23a40a1ef1eca95c568ca66b9dfd9f3f |
| e23fb8c | https://github.com/NativeScript/NativeScript/pull/7340/commits/e23fb8cd23a40a1ef1eca95c568ca66b9dfd9f3f |
|
| https://github.com/MartoYankov |
| wip: restructuring the tabs folder | https://github.com/NativeScript/NativeScript/pull/7340/commits/b02db776216be100349b3d428926b21133b73629 |
| b02db77 | https://github.com/NativeScript/NativeScript/pull/7340/commits/b02db776216be100349b3d428926b21133b73629 |
|
| https://github.com/MartoYankov |
| wip: add tabs module to tab navigation | https://github.com/NativeScript/NativeScript/pull/7340/commits/d4e01debf0b98c632ee2ab069362c35e1e5c2a5f |
| d4e01de | https://github.com/NativeScript/NativeScript/pull/7340/commits/d4e01debf0b98c632ee2ab069362c35e1e5c2a5f |
|
| https://github.com/MartoYankov |
| wip: refactor folder structure | https://github.com/NativeScript/NativeScript/pull/7340/commits/c39bbcd5b4ef5a688dc06b6ec6cca87959cc61cb |
| c39bbcd | https://github.com/NativeScript/NativeScript/pull/7340/commits/c39bbcd5b4ef5a688dc06b6ec6cca87959cc61cb |
|
| https://github.com/MartoYankov |
| wip: add androidx support | https://github.com/NativeScript/NativeScript/pull/7340/commits/0f0cbc2dbeb2568d38a1c6bfc1d43a6deb1701bd |
| 0f0cbc2 | https://github.com/NativeScript/NativeScript/pull/7340/commits/0f0cbc2dbeb2568d38a1c6bfc1d43a6deb1701bd |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
| Jun 10, 2019 | https://github.com/NativeScript/NativeScript/pull/7340#event-2400854765 |
| https://github.com/apps/cla-bot |
| cla-bot | https://github.com/apps/cla-bot |
|
cla: yes
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Jun 10, 2019 | https://github.com/NativeScript/NativeScript/pull/7340#event-2400854855 |
| https://github.com/SvetoslavTsenov |
| SvetoslavTsenov | https://github.com/SvetoslavTsenov |
| Jun 10, 2019 | https://github.com/NativeScript/NativeScript/pull/7340#issuecomment-500426750 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7340 |
| MartoYankov | https://github.com/MartoYankov |
| June 12, 2019 15:12 | https://github.com/NativeScript/NativeScript/pull/7340#commits-pushed-1676c08 |
|
| https://github.com/MartoYankov |
| wip: fix unit tests | https://github.com/NativeScript/NativeScript/pull/7340/commits/1676c086212b431e51fc5216dacfa9410b4842ac |
| 1676c08 | https://github.com/NativeScript/NativeScript/pull/7340/commits/1676c086212b431e51fc5216dacfa9410b4842ac |
|
| https://github.com/MartoYankov |
| Merge branch 'master' into myankov/tabs | https://github.com/NativeScript/NativeScript/pull/7340/commits/fc95dd8f93b01d9ca276f78657fd9ce42418a7a3 |
| fc95dd8 | https://github.com/NativeScript/NativeScript/pull/7340/commits/fc95dd8f93b01d9ca276f78657fd9ce42418a7a3 |
| https://github.com/ADjenkov |
| ADjenkov | https://github.com/ADjenkov |
| June 13, 2019 06:22 | https://github.com/NativeScript/NativeScript/pull/7340#event-2409484758 |
| https://github.com/ADjenkov |
| ADjenkov | https://github.com/ADjenkov |
|
Jun 13, 2019
| https://github.com/NativeScript/NativeScript/pull/7340#pullrequestreview-249146306 |
|
View reviewed changes
| https://github.com/NativeScript/NativeScript/pull/7340/files/fc95dd8f93b01d9ca276f78657fd9ce42418a7a3 |
| https://github.com/MartoYankov |
| MartoYankov | https://github.com/MartoYankov |
| 0c2c1cc | https://github.com/NativeScript/NativeScript/commit/0c2c1ccfde0a831fc94026cc3728b5d858683352 |
| Jun 13, 2019 | https://github.com/NativeScript/NativeScript/pull/7340#event-2409705792 |
| renesugar | https://github.com/renesugar |
|
Jun 16, 2019
| https://github.com/NativeScript/NativeScript/pull/7340#ref-commit-be6887e |
|
| https://github.com/renesugar |
| Merge pull request | https://github.com/renesugar/NativeScript/commit/be6887e7b0bb2772fc79a134148e524fe7cb9407 |
| #2 | https://github.com/renesugar/NativeScript/pull/2 |
| from NativeScript/master | https://github.com/renesugar/NativeScript/commit/be6887e7b0bb2772fc79a134148e524fe7cb9407 |
| be6887e | https://github.com/renesugar/NativeScript/commit/be6887e7b0bb2772fc79a134148e524fe7cb9407 |
| NativeScript#7340 | https://github.com/NativeScript/NativeScript/pull/7340 |
| https://github.co/hiddenchars |
| https://github.com/NativeScript/NativeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FNativeScript%2FNativeScript%2Fpull%2F7340 |
|
| https://github.com/ADjenkov |
|
ADjenkov
| https://github.com/ADjenkov |
|
| https://github.com/NativeScript/NativeScript/pull/7340/files/fc95dd8f93b01d9ca276f78657fd9ce42418a7a3 |
|
| https://github.com/MartoYankov |
|
MartoYankov
| https://github.com/MartoYankov |
|
cla: yes
| https://github.com/NativeScript/NativeScript/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Please reload this page | https://github.com/NativeScript/NativeScript/pull/7340 |
|
| https://github.com/MartoYankov |
|
| https://github.com/SvetoslavTsenov |
|
| https://github.com/ADjenkov |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |