Title: fix(android): nested fragment disappears on parent fragment removal by manoldonev · Pull Request #6677 · NativeScript/NativeScript · GitHub
Open Graph Title: fix(android): nested fragment disappears on parent fragment removal by manoldonev · Pull Request #6677 · NativeScript/NativeScript
X Title: fix(android): nested fragment disappears on parent fragment removal by manoldonev · Pull Request #6677 · NativeScript/NativeScript
Description: TODO: Known crash with Flip navigation due to not handling AnimatorSet animator properly. TODO: consider implementing base fragment class in widgets and place the shared code between frame and tab fragment there. TBD: consider do we need a property to enable / disable lollipop transitions (currently implicitly disabled for nested frame scenarios). This property could be useful in other cases as well e.g. this bug #6510 is only present for the "lollipop" Slide transition but if we use our own implementation, it is OK (if user could disable "lollipop" explicitly, it would work). Fixes: #6641 Fixes: #6659 Fixes: #6698 Fixes: #6633 Fixes: #6630 Merge after NativeScript/tns-core-modules-widgets#154 BREAKING CHANGE: [Android] Explode transition cannot be used when navigating in nested frame scenarios. [Android] Custom nested fragments should inherit from org.nativescript.widgets.FragmentBase class instead of android.support.v4.app.Fragment directly to benefit from the applied workaround for https://code.google.com/p/android/issues/detail?id=55228
Open Graph Description: TODO: Known crash with Flip navigation due to not handling AnimatorSet animator properly. TODO: consider implementing base fragment class in widgets and place the shared code between frame and tab ...
X Description: TODO: Known crash with Flip navigation due to not handling AnimatorSet animator properly. TODO: consider implementing base fragment class in widgets and place the shared code between frame and tab ...
Opengraph URL: https://github.com/NativeScript/NativeScript/pull/6677
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:51719029-c172-bd7e-7fb2-cd0865e8c205 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B824:25E083:B5052:10127A:69789CF2 |
| html-safe-nonce | 969555c1ba2bbc0a9a2b09cfe9e9bd88c52e860c1fcc2075c7df22b8e96a7dea |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODI0OjI1RTA4MzpCNTA1MjoxMDEyN0E6Njk3ODlDRjIiLCJ2aXNpdG9yX2lkIjoiNzE1NTEyNjc4MjE3OTgxMTcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 461ddc3986933ac8f3b6aefa8b25f6458d0c2b94d22b63329498be74d5327b50 |
| hovercard-subject-tag | pull_request:236553743 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/NativeScript/NativeScript/pull/6677/files |
| twitter:image | https://avatars.githubusercontent.com/u/2650247?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/2650247?s=400&v=4 |
| og:image:alt | TODO: Known crash with Flip navigation due to not handling AnimatorSet animator properly. TODO: consider implementing base fragment class in widgets and place the shared code between frame and tab ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2981c597c945c1d90ac6fa355ce7929b2f413dfe7872ca5c435ee53a24a1de50 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/NativeScript/NativeScript git https://github.com/NativeScript/NativeScript.git |
| octolytics-dimension-user_id | 7392261 |
| octolytics-dimension-user_login | NativeScript |
| octolytics-dimension-repository_id | 31492490 |
| octolytics-dimension-repository_nwo | NativeScript/NativeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31492490 |
| octolytics-dimension-repository_network_root_nwo | NativeScript/NativeScript |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 14920c7cb7d7c207b5e72684d0e6f23b65b849b3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width